* [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits
@ 2020-03-16 15:56 Dafna Hirschfeld
2020-03-16 16:31 ` Dafna Hirschfeld
0 siblings, 1 reply; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-03-16 15:56 UTC (permalink / raw)
To: linux-media
Cc: dafna.hirschfeld, helen.koike, ezequiel, hverkuil, kernel,
dafna3, mchehab, laurent.pinchart
In the table of the RGB formats, add an explicit '-' signs
to cells that contain undefined bits.
This makes it more clear how many bits and bytes are used
for each format.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Documentation/media/uapi/v4l/pixfmt-rgb.rst | 136 ++++++++++----------
1 file changed, 68 insertions(+), 68 deletions(-)
diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
index 4ce305cc45da..e4adac7f2e4c 100644
--- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
+++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
@@ -128,10 +128,10 @@ next to each other in memory.
- b\ :sub:`1`
- b\ :sub:`0`
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- r\ :sub:`3`
- r\ :sub:`2`
- r\ :sub:`1`
@@ -169,10 +169,10 @@ next to each other in memory.
- b\ :sub:`2`
- b\ :sub:`1`
- b\ :sub:`0`
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- r\ :sub:`3`
- r\ :sub:`2`
@@ -220,10 +220,10 @@ next to each other in memory.
- r\ :sub:`1`
- r\ :sub:`0`
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- b\ :sub:`3`
- b\ :sub:`2`
- b\ :sub:`1`
@@ -261,10 +261,10 @@ next to each other in memory.
- r\ :sub:`2`
- r\ :sub:`1`
- r\ :sub:`0`
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- b\ :sub:`3`
- b\ :sub:`2`
@@ -312,7 +312,7 @@ next to each other in memory.
- b\ :sub:`1`
- b\ :sub:`0`
- -
+ - `-`
- r\ :sub:`4`
- r\ :sub:`3`
- r\ :sub:`2`
@@ -356,7 +356,7 @@ next to each other in memory.
- b\ :sub:`2`
- b\ :sub:`1`
- b\ :sub:`0`
- -
+ - `-`
- r\ :sub:`4`
- r\ :sub:`3`
@@ -404,7 +404,7 @@ next to each other in memory.
- r\ :sub:`1`
- r\ :sub:`0`
- -
+ - `-`
- b\ :sub:`4`
- b\ :sub:`3`
- b\ :sub:`2`
@@ -448,7 +448,7 @@ next to each other in memory.
- r\ :sub:`2`
- r\ :sub:`1`
- r\ :sub:`0`
- -
+ - `-`
- b\ :sub:`4`
- b\ :sub:`3`
@@ -510,7 +510,7 @@ next to each other in memory.
- ``V4L2_PIX_FMT_XRGB555X``
- 'XR15' | (1 << 31)
- -
+ - `-`
- r\ :sub:`4`
- r\ :sub:`3`
- r\ :sub:`2`
@@ -640,21 +640,21 @@ next to each other in memory.
- r\ :sub:`1`
- r\ :sub:`0`
- -
- -
- -
- -
- -
- -
-
- -
- -
- -
- -
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
* .. _V4L2-PIX-FMT-ABGR32:
- ``V4L2_PIX_FMT_ABGR32``
@@ -727,14 +727,14 @@ next to each other in memory.
- r\ :sub:`1`
- r\ :sub:`0`
- -
- -
- -
- -
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
* .. _V4L2-PIX-FMT-BGRA32:
- ``V4L2_PIX_FMT_BGRA32``
@@ -780,14 +780,14 @@ next to each other in memory.
- ``V4L2_PIX_FMT_BGRX32``
- 'RX24'
- -
- -
- -
- -
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- b\ :sub:`7`
- b\ :sub:`6`
@@ -887,14 +887,14 @@ next to each other in memory.
- b\ :sub:`1`
- b\ :sub:`0`
- -
- -
- -
- -
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
* .. _V4L2-PIX-FMT-ARGB32:
- ``V4L2_PIX_FMT_ARGB32``
@@ -940,14 +940,14 @@ next to each other in memory.
- ``V4L2_PIX_FMT_XRGB32``
- 'BX24'
- -
- -
- -
- -
- -
- -
- -
- -
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
+ - `-`
- r\ :sub:`7`
- r\ :sub:`6`
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits
2020-03-16 15:56 [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits Dafna Hirschfeld
@ 2020-03-16 16:31 ` Dafna Hirschfeld
2020-03-16 23:51 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-03-16 16:31 UTC (permalink / raw)
To: linux-media
Cc: helen.koike, ezequiel, hverkuil, kernel, dafna3, mchehab,
laurent.pinchart
hi, adding suggested-by
On 16.03.20 16:56, Dafna Hirschfeld wrote:
> In the table of the RGB formats, add an explicit '-' signs
> to cells that contain undefined bits.
> This makes it more clear how many bits and bytes are used
> for each format.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/media/uapi/v4l/pixfmt-rgb.rst | 136 ++++++++++----------
> 1 file changed, 68 insertions(+), 68 deletions(-)
>
> diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> index 4ce305cc45da..e4adac7f2e4c 100644
> --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> @@ -128,10 +128,10 @@ next to each other in memory.
> - b\ :sub:`1`
> - b\ :sub:`0`
>
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> - r\ :sub:`3`
> - r\ :sub:`2`
> - r\ :sub:`1`
> @@ -169,10 +169,10 @@ next to each other in memory.
> - b\ :sub:`2`
> - b\ :sub:`1`
> - b\ :sub:`0`
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
>
> - r\ :sub:`3`
> - r\ :sub:`2`
> @@ -220,10 +220,10 @@ next to each other in memory.
> - r\ :sub:`1`
> - r\ :sub:`0`
>
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> - b\ :sub:`3`
> - b\ :sub:`2`
> - b\ :sub:`1`
> @@ -261,10 +261,10 @@ next to each other in memory.
> - r\ :sub:`2`
> - r\ :sub:`1`
> - r\ :sub:`0`
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
>
> - b\ :sub:`3`
> - b\ :sub:`2`
> @@ -312,7 +312,7 @@ next to each other in memory.
> - b\ :sub:`1`
> - b\ :sub:`0`
>
> - -
> + - `-`
> - r\ :sub:`4`
> - r\ :sub:`3`
> - r\ :sub:`2`
> @@ -356,7 +356,7 @@ next to each other in memory.
> - b\ :sub:`2`
> - b\ :sub:`1`
> - b\ :sub:`0`
> - -
> + - `-`
>
> - r\ :sub:`4`
> - r\ :sub:`3`
> @@ -404,7 +404,7 @@ next to each other in memory.
> - r\ :sub:`1`
> - r\ :sub:`0`
>
> - -
> + - `-`
> - b\ :sub:`4`
> - b\ :sub:`3`
> - b\ :sub:`2`
> @@ -448,7 +448,7 @@ next to each other in memory.
> - r\ :sub:`2`
> - r\ :sub:`1`
> - r\ :sub:`0`
> - -
> + - `-`
>
> - b\ :sub:`4`
> - b\ :sub:`3`
> @@ -510,7 +510,7 @@ next to each other in memory.
> - ``V4L2_PIX_FMT_XRGB555X``
> - 'XR15' | (1 << 31)
>
> - -
> + - `-`
> - r\ :sub:`4`
> - r\ :sub:`3`
> - r\ :sub:`2`
> @@ -640,21 +640,21 @@ next to each other in memory.
>
> - r\ :sub:`1`
> - r\ :sub:`0`
> - -
> - -
> - -
> - -
> - -
> - -
> -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> +
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> * .. _V4L2-PIX-FMT-ABGR32:
>
> - ``V4L2_PIX_FMT_ABGR32``
> @@ -727,14 +727,14 @@ next to each other in memory.
> - r\ :sub:`1`
> - r\ :sub:`0`
>
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> * .. _V4L2-PIX-FMT-BGRA32:
>
> - ``V4L2_PIX_FMT_BGRA32``
> @@ -780,14 +780,14 @@ next to each other in memory.
> - ``V4L2_PIX_FMT_BGRX32``
> - 'RX24'
>
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
>
> - b\ :sub:`7`
> - b\ :sub:`6`
> @@ -887,14 +887,14 @@ next to each other in memory.
> - b\ :sub:`1`
> - b\ :sub:`0`
>
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> * .. _V4L2-PIX-FMT-ARGB32:
>
> - ``V4L2_PIX_FMT_ARGB32``
> @@ -940,14 +940,14 @@ next to each other in memory.
> - ``V4L2_PIX_FMT_XRGB32``
> - 'BX24'
>
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> - -
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
> + - `-`
>
> - r\ :sub:`7`
> - r\ :sub:`6`
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits
2020-03-16 16:31 ` Dafna Hirschfeld
@ 2020-03-16 23:51 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2020-03-16 23:51 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: linux-media, helen.koike, ezequiel, hverkuil, kernel, dafna3, mchehab
Hi Dafna,
Thank you for the patch.
On Mon, Mar 16, 2020 at 05:31:25PM +0100, Dafna Hirschfeld wrote:
> hi, adding suggested-by
>
> On 16.03.20 16:56, Dafna Hirschfeld wrote:
> > In the table of the RGB formats, add an explicit '-' signs
> > to cells that contain undefined bits.
> > This makes it more clear how many bits and bytes are used
> > for each format.
> >
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Documentation/media/uapi/v4l/pixfmt-rgb.rst | 136 ++++++++++----------
> > 1 file changed, 68 insertions(+), 68 deletions(-)
> >
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > index 4ce305cc45da..e4adac7f2e4c 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst
> > @@ -128,10 +128,10 @@ next to each other in memory.
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> >
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > - r\ :sub:`3`
> > - r\ :sub:`2`
> > - r\ :sub:`1`
> > @@ -169,10 +169,10 @@ next to each other in memory.
> > - b\ :sub:`2`
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> >
> > - r\ :sub:`3`
> > - r\ :sub:`2`
> > @@ -220,10 +220,10 @@ next to each other in memory.
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> >
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > - b\ :sub:`3`
> > - b\ :sub:`2`
> > - b\ :sub:`1`
> > @@ -261,10 +261,10 @@ next to each other in memory.
> > - r\ :sub:`2`
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> >
> > - b\ :sub:`3`
> > - b\ :sub:`2`
> > @@ -312,7 +312,7 @@ next to each other in memory.
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> >
> > - -
> > + - `-`
> > - r\ :sub:`4`
> > - r\ :sub:`3`
> > - r\ :sub:`2`
> > @@ -356,7 +356,7 @@ next to each other in memory.
> > - b\ :sub:`2`
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> > - -
> > + - `-`
> >
> > - r\ :sub:`4`
> > - r\ :sub:`3`
> > @@ -404,7 +404,7 @@ next to each other in memory.
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> >
> > - -
> > + - `-`
> > - b\ :sub:`4`
> > - b\ :sub:`3`
> > - b\ :sub:`2`
> > @@ -448,7 +448,7 @@ next to each other in memory.
> > - r\ :sub:`2`
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> > - -
> > + - `-`
> >
> > - b\ :sub:`4`
> > - b\ :sub:`3`
> > @@ -510,7 +510,7 @@ next to each other in memory.
> > - ``V4L2_PIX_FMT_XRGB555X``
> > - 'XR15' | (1 << 31)
> >
> > - -
> > + - `-`
> > - r\ :sub:`4`
> > - r\ :sub:`3`
> > - r\ :sub:`2`
> > @@ -640,21 +640,21 @@ next to each other in memory.
> >
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > +
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > * .. _V4L2-PIX-FMT-ABGR32:
> >
> > - ``V4L2_PIX_FMT_ABGR32``
> > @@ -727,14 +727,14 @@ next to each other in memory.
> > - r\ :sub:`1`
> > - r\ :sub:`0`
> >
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > * .. _V4L2-PIX-FMT-BGRA32:
> >
> > - ``V4L2_PIX_FMT_BGRA32``
> > @@ -780,14 +780,14 @@ next to each other in memory.
> > - ``V4L2_PIX_FMT_BGRX32``
> > - 'RX24'
> >
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> >
> > - b\ :sub:`7`
> > - b\ :sub:`6`
> > @@ -887,14 +887,14 @@ next to each other in memory.
> > - b\ :sub:`1`
> > - b\ :sub:`0`
> >
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > * .. _V4L2-PIX-FMT-ARGB32:
> >
> > - ``V4L2_PIX_FMT_ARGB32``
> > @@ -940,14 +940,14 @@ next to each other in memory.
> > - ``V4L2_PIX_FMT_XRGB32``
> > - 'BX24'
> >
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > - -
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> > + - `-`
> >
> > - r\ :sub:`7`
> > - r\ :sub:`6`
> >
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-16 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 15:56 [PATCH] media: doc-rst: in the RGB formats table add '-' in undefined bits Dafna Hirschfeld
2020-03-16 16:31 ` Dafna Hirschfeld
2020-03-16 23:51 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).