From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v3 15/22] media: Kconfig: move media controller core select to main Kconfig
Date: Wed, 25 Mar 2020 11:21:29 +0100 [thread overview]
Message-ID: <20200325112129.5579ef45@coco.lan> (raw)
In-Reply-To: <20200325110834.1e204e20@coco.lan>
Em Wed, 25 Mar 2020 11:08:34 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> Em Wed, 25 Mar 2020 12:00:59 +0200
> Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
>
> > Hi Mauro,
> >
> > On Wed, Mar 25, 2020 at 10:49:29AM +0100, Mauro Carvalho Chehab wrote:
> > > Let's place the main API selections at the media/Kconfig file,
> > > as this way we can better organize things.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > ---
> > > drivers/media/Kconfig | 9 +++++++++
> > > drivers/media/mc/Kconfig | 9 ---------
> > > 2 files changed, 9 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > index d6766085c91b..3872e46545e6 100644
> > > --- a/drivers/media/Kconfig
> > > +++ b/drivers/media/Kconfig
> > > @@ -144,6 +144,15 @@ config VIDEO_DEV
> > > depends on MEDIA_SUPPORT
> > > default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_PLATFORM_SUPPORT
> > >
> > > +config MEDIA_CONTROLLER
> > > + bool "Media Controller API"
> > > + depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> > > + help
> > > + Enable the media controller API used to query media devices internal
> > > + topology and configure it dynamically.
> > > +
> > > + This API is mostly used by camera interfaces in embedded platforms.
> > > +
> > > source "drivers/media/v4l2-core/Kconfig"
> > >
> > > #
> > > diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> > > index 3b9795cfcb36..b3579d6c9e32 100644
> > > --- a/drivers/media/mc/Kconfig
> > > +++ b/drivers/media/mc/Kconfig
> > > @@ -3,15 +3,6 @@
> > > # Selectable only for webcam/grabbers, as other drivers don't use it
> > > #
> > >
> > > -config MEDIA_CONTROLLER
> > > - bool "Media Controller API"
> > > - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> > > - help
> > > - Enable the media controller API used to query media devices internal
> > > - topology and configure it dynamically.
> > > -
> > > - This API is mostly used by camera interfaces in embedded platforms.
> > > -
> > > config MEDIA_CONTROLLER_DVB
> > > bool "Enable Media controller for DVB (EXPERIMENTAL)"
> > > depends on MEDIA_CONTROLLER && DVB_CORE
> >
> > This moves the main MC configuration out of the directory but leaves the
> > rest of the MC configuration under the mc directory. All MC related
> > configuration is currently in a single place, which makes sense.
> >
> > I guess you can always have arguments for and against, but my preference is
> > keeping it as-is.
>
> Well, the advantage (after applying the entire series), is that it can now
> present two separate menus:
>
> the first one with the core stuff (MC, V4L and DVB), and a second one
> with the extra features for those three.
>
> Btw, it just occurred to me that perhaps we could map it on a different way,
> using a menu for MC, another one for V4L and a third one for DVB.
What occurred to me is shown at the patch below (applied after this patch
series).
IMHO, it is a way better to present things like that.
Thanks,
Mauro
[PATCH] media: Kconfig: Better organize the per-API options
After this change, the menu is displayed like above.
1) When filtering is not active:
--- Multimedia support
[ ] Filter devices by their types
[*] Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)
Media core support --->
Video4Linux options --->
Media controller options --->
Digital TV options --->
HDMI CEC options --->
Media drivers --->
2) When filtering is active:
--- Multimedia support
[*] Filter devices by their types
[*] Autoselect ancillary drivers (tuners, sensors, i2c, spi, frontends)
Media device types --->
Video4Linux options --->
Media controller options --->
Digital TV options --->
HDMI CEC options --->
Media drivers --->
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 2a69b8024a0f..f942d19cf99b 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -184,10 +184,19 @@ endmenu # Media core support
#
# Extra per-media API core functionality
-menu "Media core additional options"
+menu "Video4Linux options"
source "drivers/media/v4l2-core/Kconfig"
+endmenu
+
+menu "Media controller options"
source "drivers/media/mc/Kconfig"
+endmenu
+
+menu "Digital TV options"
source "drivers/media/dvb-core/Kconfig"
+endmenu
+
+menu "HDMI CEC options"
source "drivers/media/cec/Kconfig"
endmenu
next prev parent reply other threads:[~2020-03-25 10:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:49 [PATCH v3 00/22] Reorganize media Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 01/22] media: dvb-usb: auto-select CYPRESS_FIRMWARE Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 02/22] media: Kconfig: add an option to filter in/out platform drivers Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 03/22] media: Kconfig: not all V4L2 platform drivers are for camera Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 04/22] media: pci: move VIDEO_PCI_SKELETON to a different Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 05/22] media: reorganize the drivers menu options Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 06/22] media: Kconfig: update the MEDIA_SUPPORT help message Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 07/22] media: Kconfig: use a sub-menu to select supported devices Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 08/22] media: split test drivers from platform directory Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 09/22] media: Kconfig: make filtering devices optional Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 10/22] media: Kconfig: move CEC-specific options to cec/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 11/22] media: Kconfig: move comment to siano include Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 12/22] media: Kconfig: move DVB-specific options to dvb-core/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 13/22] media: Kconfig: move V4L2 subdev API to v4l2-core/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 14/22] media: Kconfig: move drivers-specific TTPCI_EEPROM Kconfig var Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 15/22] media: Kconfig: move media controller core select to main Kconfig Mauro Carvalho Chehab
2020-03-25 10:00 ` Sakari Ailus
2020-03-25 10:08 ` Mauro Carvalho Chehab
2020-03-25 10:21 ` Mauro Carvalho Chehab [this message]
2020-03-30 7:46 ` Sakari Ailus
2020-03-25 9:49 ` [PATCH v3 16/22] media: Kconfig: better organize menu items Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 17/22] media: Kconfig: mode firewire comment to firewire/Kconfig Mauro Carvalho Chehab
2020-03-26 12:09 ` Stefan Richter
2020-03-25 9:49 ` [PATCH v3 18/22] media: Kconfig: place all options under a sub-menu Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 19/22] media: Kconfig: move the position of sub-driver autoselection Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 20/22] media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 21/22] media: Kconfig: simplify some dependencies Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 22/22] media: Kconfig: better support hybrid TV devices Mauro Carvalho Chehab
2020-03-25 10:05 ` Mauro Carvalho Chehab
2020-03-25 11:25 ` [PATCH v3.1 " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325112129.5579ef45@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).