From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH v3 17/22] media: Kconfig: mode firewire comment to firewire/Kconfig
Date: Thu, 26 Mar 2020 13:09:57 +0100 [thread overview]
Message-ID: <20200326130957.63299c27@kant> (raw)
In-Reply-To: <94f1d3fc3467bf2335a3e286e2c6055bdf7c37d5.1585129041.git.mchehab+huawei@kernel.org>
On Mar 25 Mauro Carvalho Chehab wrote:
> This comment should only be visible if the DVB_FIREDTV
> config will show.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> drivers/media/Kconfig | 2 --
> drivers/media/firewire/Kconfig | 5 ++++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 4fbebb6bda15..ad9636692183 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -185,8 +185,6 @@ source "drivers/media/mmc/Kconfig"
> endif
>
>
> -comment "FireWire (IEEE 1394) Adapters"
> - depends on DVB_CORE && FIREWIRE
> source "drivers/media/firewire/Kconfig"
>
> comment "Media ancillary drivers (tuners, sensors, i2c, spi, frontends)"
> diff --git a/drivers/media/firewire/Kconfig b/drivers/media/firewire/Kconfig
> index e7837da5905b..0c1f326f581f 100644
> --- a/drivers/media/firewire/Kconfig
> +++ b/drivers/media/firewire/Kconfig
> @@ -1,7 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +if DVB_CORE && FIREWIRE
> +comment "FireWire (IEEE 1394) Adapters"
> +
> config DVB_FIREDTV
> tristate "FireDTV and FloppyDTV"
> - depends on DVB_CORE && FIREWIRE
> help
> Support for DVB receivers from Digital Everywhere
> which are connected via IEEE 1394 (FireWire).
> @@ -18,3 +20,4 @@ config DVB_FIREDTV_INPUT
> def_bool INPUT = y || (INPUT = m && DVB_FIREDTV = m)
>
> endif # DVB_FIREDTV
> +endif # DVB_CORE && FIREWIRE
--
Stefan Richter
-======--=-- --== ==-=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2020-03-26 12:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:49 [PATCH v3 00/22] Reorganize media Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 01/22] media: dvb-usb: auto-select CYPRESS_FIRMWARE Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 02/22] media: Kconfig: add an option to filter in/out platform drivers Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 03/22] media: Kconfig: not all V4L2 platform drivers are for camera Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 04/22] media: pci: move VIDEO_PCI_SKELETON to a different Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 05/22] media: reorganize the drivers menu options Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 06/22] media: Kconfig: update the MEDIA_SUPPORT help message Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 07/22] media: Kconfig: use a sub-menu to select supported devices Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 08/22] media: split test drivers from platform directory Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 09/22] media: Kconfig: make filtering devices optional Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 10/22] media: Kconfig: move CEC-specific options to cec/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 11/22] media: Kconfig: move comment to siano include Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 12/22] media: Kconfig: move DVB-specific options to dvb-core/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 13/22] media: Kconfig: move V4L2 subdev API to v4l2-core/Kconfig Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 14/22] media: Kconfig: move drivers-specific TTPCI_EEPROM Kconfig var Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 15/22] media: Kconfig: move media controller core select to main Kconfig Mauro Carvalho Chehab
2020-03-25 10:00 ` Sakari Ailus
2020-03-25 10:08 ` Mauro Carvalho Chehab
2020-03-25 10:21 ` Mauro Carvalho Chehab
2020-03-30 7:46 ` Sakari Ailus
2020-03-25 9:49 ` [PATCH v3 16/22] media: Kconfig: better organize menu items Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 17/22] media: Kconfig: mode firewire comment to firewire/Kconfig Mauro Carvalho Chehab
2020-03-26 12:09 ` Stefan Richter [this message]
2020-03-25 9:49 ` [PATCH v3 18/22] media: Kconfig: place all options under a sub-menu Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 19/22] media: Kconfig: move the position of sub-driver autoselection Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 20/22] media: Kconfig: on !EMBEDDED && !EXPERT, enable driver filtering Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 21/22] media: Kconfig: simplify some dependencies Mauro Carvalho Chehab
2020-03-25 9:49 ` [PATCH v3 22/22] media: Kconfig: better support hybrid TV devices Mauro Carvalho Chehab
2020-03-25 10:05 ` Mauro Carvalho Chehab
2020-03-25 11:25 ` [PATCH v3.1 " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326130957.63299c27@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).