* [PATCH] media: staging: rkisp1 Kconfig: depends on OF
@ 2020-04-20 16:45 Mauro Carvalho Chehab
2020-04-20 17:13 ` Randy Dunlap
2020-04-21 3:17 ` Ezequiel Garcia
0 siblings, 2 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-20 16:45 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Helen Koike, Greg Kroah-Hartman, devel,
Stephen Rothwell, Randy Dunlap
building it with a random config causes a warning:
WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n]
Selected by [y]:
- VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y])
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/staging/media/rkisp1/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
index 5ecbefa0f5ec..07e4a6e4458e 100644
--- a/drivers/staging/media/rkisp1/Kconfig
+++ b/drivers/staging/media/rkisp1/Kconfig
@@ -2,7 +2,7 @@
config VIDEO_ROCKCHIP_ISP1
tristate "Rockchip Image Signal Processing v1 Unit driver"
- depends on VIDEO_V4L2
+ depends on VIDEO_V4L2 && OF
depends on ARCH_ROCKCHIP || COMPILE_TEST
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
--
2.25.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1 Kconfig: depends on OF
2020-04-20 16:45 [PATCH] media: staging: rkisp1 Kconfig: depends on OF Mauro Carvalho Chehab
@ 2020-04-20 17:13 ` Randy Dunlap
2020-04-21 3:17 ` Ezequiel Garcia
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-04-20 17:13 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List
Cc: Helen Koike, Greg Kroah-Hartman, devel, Stephen Rothwell
On 4/20/20 9:45 AM, Mauro Carvalho Chehab wrote:
> building it with a random config causes a warning:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n]
> Selected by [y]:
> - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y])
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/staging/media/rkisp1/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
> index 5ecbefa0f5ec..07e4a6e4458e 100644
> --- a/drivers/staging/media/rkisp1/Kconfig
> +++ b/drivers/staging/media/rkisp1/Kconfig
> @@ -2,7 +2,7 @@
>
> config VIDEO_ROCKCHIP_ISP1
> tristate "Rockchip Image Signal Processing v1 Unit driver"
> - depends on VIDEO_V4L2
> + depends on VIDEO_V4L2 && OF
> depends on ARCH_ROCKCHIP || COMPILE_TEST
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1 Kconfig: depends on OF
2020-04-20 16:45 [PATCH] media: staging: rkisp1 Kconfig: depends on OF Mauro Carvalho Chehab
2020-04-20 17:13 ` Randy Dunlap
@ 2020-04-21 3:17 ` Ezequiel Garcia
2020-04-21 7:40 ` Mauro Carvalho Chehab
1 sibling, 1 reply; 4+ messages in thread
From: Ezequiel Garcia @ 2020-04-21 3:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Helen Koike, Greg Kroah-Hartman, devel,
Stephen Rothwell, Randy Dunlap
Hi Mauro, Randy,
On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> building it with a random config causes a warning:
>
> WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n]
> Selected by [y]:
> - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y])
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks for the patch. Please note this warning (plus another one),
is already fixed by a couple patches in this series:
https://patchwork.linuxtv.org/project/linux-media/list/?series=2094
Also, Arnd sent a similar fix recently:
https://lkml.org/lkml/2020/4/8/596
The series I posted is acked by Helen and should fix all issues,
so perhaps you can merge it before more people keep finding this :-)
Thanks,
Ezequiel
> ---
> drivers/staging/media/rkisp1/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
> index 5ecbefa0f5ec..07e4a6e4458e 100644
> --- a/drivers/staging/media/rkisp1/Kconfig
> +++ b/drivers/staging/media/rkisp1/Kconfig
> @@ -2,7 +2,7 @@
>
> config VIDEO_ROCKCHIP_ISP1
> tristate "Rockchip Image Signal Processing v1 Unit driver"
> - depends on VIDEO_V4L2
> + depends on VIDEO_V4L2 && OF
> depends on ARCH_ROCKCHIP || COMPILE_TEST
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> --
> 2.25.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1 Kconfig: depends on OF
2020-04-21 3:17 ` Ezequiel Garcia
@ 2020-04-21 7:40 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-21 7:40 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Linux Media Mailing List, Helen Koike, Greg Kroah-Hartman, devel,
Stephen Rothwell, Randy Dunlap
Em Tue, 21 Apr 2020 00:17:08 -0300
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> escreveu:
> Hi Mauro, Randy,
>
> On Mon, 20 Apr 2020 at 13:45, Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> >
> > building it with a random config causes a warning:
> >
> > WARNING: unmet direct dependencies detected for PHY_ROCKCHIP_DPHY_RX0
> > Depends on [n]: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n]
> > Selected by [y]:
> > - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y])
> >
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Thanks for the patch. Please note this warning (plus another one),
> is already fixed by a couple patches in this series:
>
> https://patchwork.linuxtv.org/project/linux-media/list/?series=2094
I actually merged the patches yesterday, in order to have a cleaner
linux-next today.
There were too much Kconfig noise those days.
So, could you please rebase your patches on the top of media upstream?
Thanks,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-21 7:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 16:45 [PATCH] media: staging: rkisp1 Kconfig: depends on OF Mauro Carvalho Chehab
2020-04-20 17:13 ` Randy Dunlap
2020-04-21 3:17 ` Ezequiel Garcia
2020-04-21 7:40 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).