linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tomasz Figa <tfiga@chromium.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: [PATCH v6 02/14] videobuf2: add cache management members
Date: Fri, 15 May 2020 01:01:41 +0900	[thread overview]
Message-ID: <20200514160153.3646-3-sergey.senozhatsky@gmail.com> (raw)
In-Reply-To: <20200514160153.3646-1-sergey.senozhatsky@gmail.com>

From: Sergey Senozhatsky <senozhatsky@chromium.org>

Extend vb2_buffer and vb2_queue structs with cache management
members.

V4L2 UAPI already contains two buffer flags which user-space,
supposedly, can use to control buffer cache sync:

- V4L2_BUF_FLAG_NO_CACHE_INVALIDATE
- V4L2_BUF_FLAG_NO_CACHE_CLEAN

None of these, however, do anything at the moment. This patch
set is intended to change it.

Since user-space cache management hints are supposed to be
implemented on a per-buffer basis we need to extend vb2_buffer
struct with two new members ->need_cache_sync_on_prepare and
->need_cache_sync_on_finish, which will store corresponding
user-space hints.

In order to preserve the existing behaviour, user-space cache
managements flags will be handled only by those drivers that
permit user-space cache hints. That's the purpose of vb2_queue
->allow_cache_hints member. Driver must set ->allow_cache_hints
during queue initialisation to enable cache management hints
mechanism.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 include/media/videobuf2-core.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 9e522bd2acc7..7f39d9fffc8c 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -263,6 +263,10 @@ struct vb2_buffer {
 	 *			after the 'buf_finish' op is called.
 	 * copied_timestamp:	the timestamp of this capture buffer was copied
 	 *			from an output buffer.
+	 * need_cache_sync_on_prepare: when set buffer's ->prepare() function
+	 *			performs cache sync/invalidation.
+	 * need_cache_sync_on_finish: when set buffer's ->finish() function
+	 *			performs cache sync/invalidation.
 	 * queued_entry:	entry on the queued buffers list, which holds
 	 *			all buffers queued from userspace
 	 * done_entry:		entry on the list that stores all buffers ready
@@ -273,6 +277,8 @@ struct vb2_buffer {
 	unsigned int		synced:1;
 	unsigned int		prepared:1;
 	unsigned int		copied_timestamp:1;
+	unsigned int		need_cache_sync_on_prepare:1;
+	unsigned int		need_cache_sync_on_finish:1;
 
 	struct vb2_plane	planes[VB2_MAX_PLANES];
 	struct list_head	queued_entry;
@@ -491,6 +497,9 @@ struct vb2_buf_ops {
  * @uses_requests: requests are used for this queue. Set to 1 the first time
  *		a request is queued. Set to 0 when the queue is canceled.
  *		If this is 1, then you cannot queue buffers directly.
+ * @allow_cache_hints: when set user-space can pass cache management hints in
+ *		order to skip cache flush/invalidation on ->prepare() or/and
+ *		->finish().
  * @lock:	pointer to a mutex that protects the &struct vb2_queue. The
  *		driver can set this to a mutex to let the v4l2 core serialize
  *		the queuing ioctls. If the driver wants to handle locking
@@ -567,6 +576,7 @@ struct vb2_queue {
 	unsigned int			requires_requests:1;
 	unsigned int			uses_qbuf:1;
 	unsigned int			uses_requests:1;
+	unsigned int			allow_cache_hints:1;
 
 	struct mutex			*lock;
 	void				*owner;
-- 
2.26.2


  parent reply	other threads:[~2020-05-14 16:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 16:01 [PATCH v6 00/14] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 01/14] videobuf2: use explicit unsigned int in vb2_queue Sergey Senozhatsky
2020-05-14 16:01 ` Sergey Senozhatsky [this message]
2020-05-14 16:01 ` [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags Sergey Senozhatsky
2020-06-02  9:51   ` Hans Verkuil
2020-06-02 10:18     ` Sergey Senozhatsky
2020-06-02 10:27       ` Hans Verkuil
2020-06-02 12:10         ` Sergey Senozhatsky
2020-06-02 12:21           ` Hans Verkuil
2020-06-02 12:22     ` Tomasz Figa
2020-06-02 12:24       ` Hans Verkuil
2020-06-04  4:36         ` Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 04/14] videobuf2: add V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 05/14] videobuf2: add queue memory consistency parameter Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 06/14] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 07/14] videobuf2: factor out planes prepare/finish functions Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 08/14] videobuf2: do not sync caches when we are allowed not to Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 09/14] videobuf2: check ->synced flag in prepare() and finish() Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 10/14] videobuf2: add begin/end cpu_access callbacks to dma-contig Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 11/14] videobuf2: add begin/end cpu_access callbacks to dma-sg Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 12/14] videobuf2: don't test db_attach in dma-contig prepare and finish Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 13/14] videobuf2: remove redundant if-statement Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 14/14] media: vivid: add cache_hints module param Sergey Senozhatsky
2020-05-18 15:18 ` [PATCH v6 00/14] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Hans Verkuil
2020-05-19  8:06   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514160153.3646-3-sergey.senozhatsky@gmail.com \
    --to=sergey.senozhatsky@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).