From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags
Date: Tue, 2 Jun 2020 21:10:49 +0900 [thread overview]
Message-ID: <20200602121049.GB617@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <9ec2618b-0cce-b00e-08cf-b579d9aa1d5d@xs4all.nl>
On (20/06/02 12:27), Hans Verkuil wrote:
[..]
> > Sorry, Hans, do you suggest to have something like this:
> >
> > if (q->memory == VB2_MEMORY_DMABUF) {
> > vb->need_cache_sync_on_finish = 0;
> > vb->need_cache_sync_on_prepare = 0;
> > b->flags &= ~V4L2_BUF_FLAG_NO_CACHE_INVALIDATE;
> > b->flags &= ~V4L2_BUF_FLAG_NO_CACHE_CLEAN;
> > return;
> > }
> >
> > I didn't clear the ->flags there because we clear the vb flush/sync
> > flags: ->need_cache_sync_on_finish/prepare are zeros for DMABUF memory
> > type. Which is equivalent to passing V4L2_BUF_FLAG_NO_CACHE_INVALIDATE
> > V4L2_BUF_FLAG_NO_CACHE_CLEAN. IOW we would clearing both "vb's do cache
> > sync" and request's "do not cache sync".
>
> Ah, yes. In that case the v4l-utils patch is likely wrong.
> Can you take a look at that patch?
Hans, are we talking about "v4l2-utils: test cache_hints for MMAP queues"
patch? I can take a look, yes.
-ss
next prev parent reply other threads:[~2020-06-02 12:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 16:01 [PATCH v6 00/14] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 01/14] videobuf2: use explicit unsigned int in vb2_queue Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 02/14] videobuf2: add cache management members Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags Sergey Senozhatsky
2020-06-02 9:51 ` Hans Verkuil
2020-06-02 10:18 ` Sergey Senozhatsky
2020-06-02 10:27 ` Hans Verkuil
2020-06-02 12:10 ` Sergey Senozhatsky [this message]
2020-06-02 12:21 ` Hans Verkuil
2020-06-02 12:22 ` Tomasz Figa
2020-06-02 12:24 ` Hans Verkuil
2020-06-04 4:36 ` Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 04/14] videobuf2: add V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 05/14] videobuf2: add queue memory consistency parameter Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 06/14] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 07/14] videobuf2: factor out planes prepare/finish functions Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 08/14] videobuf2: do not sync caches when we are allowed not to Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 09/14] videobuf2: check ->synced flag in prepare() and finish() Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 10/14] videobuf2: add begin/end cpu_access callbacks to dma-contig Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 11/14] videobuf2: add begin/end cpu_access callbacks to dma-sg Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 12/14] videobuf2: don't test db_attach in dma-contig prepare and finish Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 13/14] videobuf2: remove redundant if-statement Sergey Senozhatsky
2020-05-14 16:01 ` [PATCH v6 14/14] media: vivid: add cache_hints module param Sergey Senozhatsky
2020-05-18 15:18 ` [PATCH v6 00/14] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Hans Verkuil
2020-05-19 8:06 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602121049.GB617@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).