* [PATCH] media: tvp5150: Add missed media_entity_cleanup()
@ 2020-06-06 14:39 Chuhong Yuan
2020-06-08 7:46 ` Marco Felsch
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2020-06-06 14:39 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Hans Verkuil, Marco Felsch, linux-media,
linux-kernel, Chuhong Yuan
This driver does not call media_entity_cleanup() in the error handler
of tvp5150_registered() and tvp5150_remove(), while it has called
media_entity_pads_init() at first.
Add the missed calls to fix it.
Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/i2c/tvp5150.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index eb39cf5ea089..9df575238952 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1664,8 +1664,10 @@ static int tvp5150_registered(struct v4l2_subdev *sd)
return 0;
err:
- for (i = 0; i < decoder->connectors_num; i++)
+ for (i = 0; i < decoder->connectors_num; i++) {
media_device_unregister_entity(&decoder->connectors[i].ent);
+ media_entity_cleanup(&decoder->connectors[i].ent);
+ }
return ret;
#endif
@@ -2248,8 +2250,10 @@ static int tvp5150_remove(struct i2c_client *c)
for (i = 0; i < decoder->connectors_num; i++)
v4l2_fwnode_connector_free(&decoder->connectors[i].base);
- for (i = 0; i < decoder->connectors_num; i++)
+ for (i = 0; i < decoder->connectors_num; i++) {
media_device_unregister_entity(&decoder->connectors[i].ent);
+ media_entity_cleanup(&decoder->connectors[i].ent);
+ }
v4l2_async_unregister_subdev(sd);
v4l2_ctrl_handler_free(&decoder->hdl);
pm_runtime_disable(&c->dev);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: tvp5150: Add missed media_entity_cleanup()
2020-06-06 14:39 [PATCH] media: tvp5150: Add missed media_entity_cleanup() Chuhong Yuan
@ 2020-06-08 7:46 ` Marco Felsch
0 siblings, 0 replies; 2+ messages in thread
From: Marco Felsch @ 2020-06-08 7:46 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel
Hi,
thanks for covering that. Appart of the fact that this function does
nothing:
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
On 20-06-06 22:39, Chuhong Yuan wrote:
> This driver does not call media_entity_cleanup() in the error handler
> of tvp5150_registered() and tvp5150_remove(), while it has called
> media_entity_pads_init() at first.
> Add the missed calls to fix it.
>
> Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/media/i2c/tvp5150.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index eb39cf5ea089..9df575238952 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1664,8 +1664,10 @@ static int tvp5150_registered(struct v4l2_subdev *sd)
> return 0;
>
> err:
> - for (i = 0; i < decoder->connectors_num; i++)
> + for (i = 0; i < decoder->connectors_num; i++) {
> media_device_unregister_entity(&decoder->connectors[i].ent);
> + media_entity_cleanup(&decoder->connectors[i].ent);
> + }
> return ret;
> #endif
>
> @@ -2248,8 +2250,10 @@ static int tvp5150_remove(struct i2c_client *c)
>
> for (i = 0; i < decoder->connectors_num; i++)
> v4l2_fwnode_connector_free(&decoder->connectors[i].base);
> - for (i = 0; i < decoder->connectors_num; i++)
> + for (i = 0; i < decoder->connectors_num; i++) {
> media_device_unregister_entity(&decoder->connectors[i].ent);
> + media_entity_cleanup(&decoder->connectors[i].ent);
> + }
> v4l2_async_unregister_subdev(sd);
> v4l2_ctrl_handler_free(&decoder->hdl);
> pm_runtime_disable(&c->dev);
> --
> 2.26.2
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-08 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-06 14:39 [PATCH] media: tvp5150: Add missed media_entity_cleanup() Chuhong Yuan
2020-06-08 7:46 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).