linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] [media] saa7164: use dev_pm_ops structure for power management
@ 2020-06-22 12:09 Vaibhav Gupta
  0 siblings, 0 replies; only message in thread
From: Vaibhav Gupta @ 2020-06-22 12:09 UTC (permalink / raw)
  To: Bjorn Helgaas, Bjorn Helgaas, bjorn, Mauro Carvalho Chehab,
	Vaibhav Gupta
  Cc: Vaibhav Gupta, linux-kernel-mentees, skhan, linux-media, linux-kernel

The .suspend() and .resume() callbacks are not defined for this driver.
Still, their power managemgement stucture can be easily upgraded to
gemeric, without affecting its normal behaviour.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/media/pci/saa7164/saa7164-core.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c
index 126d085be9a7..dba537c11797 100644
--- a/drivers/media/pci/saa7164/saa7164-core.c
+++ b/drivers/media/pci/saa7164/saa7164-core.c
@@ -1534,14 +1534,18 @@ static const struct pci_device_id saa7164_pci_tbl[] = {
 };
 MODULE_DEVICE_TABLE(pci, saa7164_pci_tbl);
 
+#define saa7164_suspend NULL
+#define saa7164_resume NULL
+
+static SIMPLE_DEV_PM_OPS(saa7164_pm_ops, saa7164_suspend, saa7164_resume);
+
 static struct pci_driver saa7164_pci_driver = {
 	.name     = "saa7164",
 	.id_table = saa7164_pci_tbl,
 	.probe    = saa7164_initdev,
 	.remove   = saa7164_finidev,
 	/* TODO */
-	.suspend  = NULL,
-	.resume   = NULL,
+	.driver.pm = &saa7164_pm_ops,
 };
 
 static int __init saa7164_init(void)
-- 
2.27.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-22 12:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 12:09 [PATCH v1] [media] saa7164: use dev_pm_ops structure for power management Vaibhav Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).