Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	libcamera-devel@lists.libcamera.org
Subject: Re: [PATCH] imx219: selection compliance fixes
Date: Tue, 14 Jul 2020 14:31:46 +0200
Message-ID: <20200714123146.5xhmslath7vqqfds@uno.localdomain> (raw)
In-Reply-To: <b580ac9d-5ae4-29ce-c81a-a1f98b1d953b@xs4all.nl>

Hi Hans,

On Thu, Jul 02, 2020 at 03:50:04PM +0200, Hans Verkuil wrote:
> The top/left crop coordinates were 0, 0 instead of 8, 8 in the
> supported_modes array. This was a mismatch with the default values,
> so this is corrected. Found with v4l2-compliance.
>
> Also add V4L2_SEL_TGT_CROP_BOUNDS support: CROP_DEFAULT and CROP_BOUNDS
> always go together. Found with v4l2-compliance.

I actually introduced this with
e6d4ef7d58aa ("media: i2c: imx219: Implement get_selection")

>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
>  drivers/media/i2c/imx219.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index 0a546b8e466c..935e2a258ce5 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -473,8 +473,8 @@ static const struct imx219_mode supported_modes[] = {
>  		.width = 3280,
>  		.height = 2464,
>  		.crop = {
> -			.left = 0,
> -			.top = 0,
> +			.left = 8,
> +			.top = 8,

Mmmm, why this change ?
This values are used to report V4L2_SEL_TGT_CROP rectangle, which
according to the documentation is defined as
"Crop rectangle. Defines the cropped area."
(not a much extensive description :)

Clearly this is a faulty definition, and I know from experience how
hard is proving to define pixel array properties and in which extent
the documentation has to go:
https://lists.libcamera.org/pipermail/libcamera-devel/2020-June/009115.html

My understanding is that target should report the current crop
rectangle, defined from the rectangle retrieved with the
V4L2_SEL_TGT_CROP_DEFAULT target, which, according documentation
reports the:
"Suggested cropping rectangle that covers the “whole picture”.
This includes only active pixels and excludes other non-active pixels such
as black pixels"

The TGT_CROP_DEFAULT then reports the active pixel array portion, and
needs to be defined in respect to the TGT_NATIVE_SIZE, which reports
the dimensions of the whole pixel matrix, including non-active pixels,
optical blanks active and non-active pixels.

The TGT_CROP rectangle is hence defined from the CROP_DEFAULT one, and
if the 'whole active area' is selected, its top-left corner is placed
in position (0, 0) (what's the point of defining it in respect to an
area which cannot be read anyway ?)

Unless TGT_CROP should be defined in respect to the NATIVE_SIZE
rectangle too, but that's not specified anywhere.

Anyway, those selection targets badly apply to image sensors, are
ill-defined as the definition of active pixels, optical blank (active
and non-active) pixels is not provided anywhere, and it's not specified
anywhere what is the reference area for each of those rectangles, so I
might very well got them wrongly.

>  			.width = 3280,
>  			.height = 2464
>  		},
> @@ -489,8 +489,8 @@ static const struct imx219_mode supported_modes[] = {
>  		.width = 1920,
>  		.height = 1080,
>  		.crop = {
> -			.left = 680,
> -			.top = 692,
> +			.left = 8 + 680,
> +			.top = 8 + 692,
>  			.width = 1920,
>  			.height = 1080
>  		},
> @@ -505,8 +505,8 @@ static const struct imx219_mode supported_modes[] = {
>  		.width = 1640,
>  		.height = 1232,
>  		.crop = {
> -			.left = 0,
> -			.top = 0,
> +			.left = 8,
> +			.top = 8,
>  			.width = 3280,
>  			.height = 2464
>  		},
> @@ -521,8 +521,8 @@ static const struct imx219_mode supported_modes[] = {
>  		.width = 640,
>  		.height = 480,
>  		.crop = {
> -			.left = 1000,
> -			.top = 752,
> +			.left = 8 + 1000,
> +			.top = 8 + 752,
>  			.width = 1280,
>  			.height = 960
>  		},
> @@ -1014,6 +1014,7 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
>  		return 0;
>
>  	case V4L2_SEL_TGT_CROP_DEFAULT:
> +	case V4L2_SEL_TGT_CROP_BOUNDS:

Still not getting what is the purpose of two targets if the "always
have to go together" :)

>  		sel->r.top = IMX219_PIXEL_ARRAY_TOP;
>  		sel->r.left = IMX219_PIXEL_ARRAY_LEFT;
>  		sel->r.width = IMX219_PIXEL_ARRAY_WIDTH;
> --
> 2.27.0
>

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 13:50 Hans Verkuil
2020-07-14 12:31 ` Jacopo Mondi [this message]
2020-07-14 23:49   ` Laurent Pinchart
2020-07-15  7:19     ` Jacopo Mondi
2020-07-16  9:48       ` Hans Verkuil
2020-07-16 12:59         ` Laurent Pinchart
2020-07-16 13:53           ` Hans Verkuil
2020-07-16 23:20             ` Laurent Pinchart
2020-07-17  6:34               ` Jacopo Mondi
2020-08-01 11:19 ` Jacopo Mondi
2020-08-01 15:13   ` Laurent Pinchart
2020-08-03  8:33     ` Jacopo Mondi
2020-08-03  9:07     ` Hans Verkuil
2020-08-03  8:37   ` Hans Verkuil
2020-08-03  9:58   ` [libcamera-devel] " Dave Stevenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714123146.5xhmslath7vqqfds@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=libcamera-devel@lists.libcamera.org \
    --cc=linux-media@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=skomatineni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git