linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/3] dt-bidings: media: ov5647 bindings + small fix
@ 2020-07-15 12:48 Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 1/3] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-07-15 12:48 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, dongchun.zhu, linux-renesas-soc,
	laurent.pinchart, roman.kovalivskyi

A small update to v2:
- Add Laurent's tags
- Remove 'endpoint' from the list of required port properties, in the
  newly introduced ov5647 bindings, and while updating the existing ov8865
  ones
- Make Dave and me co-maintainers for ov5647 as the two email addresses we tried
  to contact Luis with both failed.

Thanks
  j

Jacopo Mondi (3):
  dt-bindings: media: ov5647: Convert to json-schema
  dt-bindings: media: i2c: Document 'remote-endpoint'
  media: MAINTAINERS: ov5647: Add myself as maintainer

 .../devicetree/bindings/media/i2c/imx219.yaml |  5 ++
 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 79 +++++++++++++++++++
 .../devicetree/bindings/media/i2c/ov8856.yaml |  7 +-
 MAINTAINERS                                   |  3 +-
 5 files changed, 90 insertions(+), 39 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

--
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 1/3] dt-bindings: media: ov5647: Convert to json-schema
  2020-07-15 12:48 [PATCH v3 0/3] dt-bidings: media: ov5647 bindings + small fix Jacopo Mondi
@ 2020-07-15 12:48 ` Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 2/3] dt-bindings: media: i2c: Document 'remote-endpoint' Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 3/3] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
  2 siblings, 0 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-07-15 12:48 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, dongchun.zhu, linux-renesas-soc,
	laurent.pinchart, roman.kovalivskyi, Rob Herring, Jacopo Mondi

Convert the ov5647 image sensor bindings to DT schema and add
the file entry to MAINTAINERS.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 79 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 3 files changed, 80 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
deleted file mode 100644
index 22e44945b661..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/ov5647.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Omnivision OV5647 raw image sensor
----------------------------------
-
-OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
-and CCI (I2C compatible) control bus.
-
-Required properties:
-
-- compatible		: "ovti,ov5647".
-- reg			: I2C slave address of the sensor.
-- clocks		: Reference to the xclk clock.
-
-The common video interfaces bindings (see video-interfaces.txt) should be
-used to specify link to the image data receiver. The OV5647 device
-node should contain one 'port' child node with an 'endpoint' subnode.
-
-Endpoint node mandatory properties:
-
-- remote-endpoint: A phandle to the bus receiver's endpoint node.
-
-Example:
-
-	i2c@2000 {
-		...
-		ov: camera@36 {
-			compatible = "ovti,ov5647";
-			reg = <0x36>;
-			clocks = <&camera_clk>;
-			port {
-				camera_1: endpoint {
-					remote-endpoint = <&csi1_ep1>;
-				};
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
new file mode 100644
index 000000000000..179743ea9446
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Omnivision OV5647 raw image sensor
+
+maintainers:
+  - Dave Stevenson <dave.stevenson@raspberrypi.com>
+
+description: |-
+  OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
+  and CCI (I2C compatible) control bus.
+
+properties:
+  compatible:
+    const: ovti,ov5647
+
+  reg:
+    description: I2C device address
+    maxItems: 1
+
+  clocks:
+    description: Reference to the xclk clock
+    maxItems: 1
+
+  port:
+    type: object
+    description: |-
+      Should contain one endpoint sub-node used to model connection to the
+      video receiver according to the specification defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt
+
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
+        required:
+          - remote-endpoint
+
+        additionalProperties: false
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ov5647: camera@36 {
+            compatible = "ovti,ov5647";
+            reg = <0x36>;
+            clocks = <&camera_clk>;
+
+            port {
+                camera_out: endpoint {
+                    remote-endpoint = <&csi1_ep1>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 2730af1265ea..1742fa1a88cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12612,6 +12612,7 @@ L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov5647.c
+F:	Documentation/devicetree/bindings/media/i2c/ov5647.yaml
 
 OMNIVISION OV5670 SENSOR DRIVER
 M:	Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'
  2020-07-15 12:48 [PATCH v3 0/3] dt-bidings: media: ov5647 bindings + small fix Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 1/3] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
@ 2020-07-15 12:48 ` Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 3/3] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
  2 siblings, 0 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-07-15 12:48 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, dongchun.zhu, linux-renesas-soc,
	laurent.pinchart, roman.kovalivskyi, Rob Herring, Jacopo Mondi

Document the 'remote-endpoint' property and add it to the list of required
endpoint properties in imx219 and ov8856 dt-schema binding files.

While at it, remove 'endpoint' from the list of required properties in
the ov8856 bindings file, as it is allowed to specify port nodes without
a connected endpoint.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
 Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 7 ++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
index dfc4d29a4f04..0251e15fe0a7 100644
--- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
@@ -71,8 +71,13 @@ properties:
             description:
               Allowed data bus frequencies.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
         required:
           - link-frequencies
+          - remote-endpoint
 
 required:
   - compatible
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
index 1956b2a32bf4..8d662f9dac5f 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
@@ -84,12 +84,13 @@ properties:
               Allowed data bus frequencies. 360000000, 180000000 Hz or both
               are supported by the driver.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
 
         required:
           - link-frequencies
-
-    required:
-      - endpoint
+          - remote-endpoint
 
 required:
   - compatible
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 3/3] media: MAINTAINERS: ov5647: Replace maintainer
  2020-07-15 12:48 [PATCH v3 0/3] dt-bidings: media: ov5647 bindings + small fix Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 1/3] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
  2020-07-15 12:48 ` [PATCH v3 2/3] dt-bindings: media: i2c: Document 'remote-endpoint' Jacopo Mondi
@ 2020-07-15 12:48 ` Jacopo Mondi
  2 siblings, 0 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-07-15 12:48 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, dongchun.zhu, linux-renesas-soc,
	laurent.pinchart, roman.kovalivskyi

Since the current maintainer email address bounces back, replace
the entry and make myself and Dave Stevenson maintainers of the driver.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1742fa1a88cd..c74d25c58e1a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12607,7 +12607,8 @@ T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov5640.c
 
 OMNIVISION OV5647 SENSOR DRIVER
-M:	Luis Oliveira <lolivei@synopsys.com>
+M:	Jacopo Mondi <jacopo@jmondi.org>
+M:	Dave Stevenson <dave.stevenson@raspberrypi.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-15 12:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 12:48 [PATCH v3 0/3] dt-bidings: media: ov5647 bindings + small fix Jacopo Mondi
2020-07-15 12:48 ` [PATCH v3 1/3] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
2020-07-15 12:48 ` [PATCH v3 2/3] dt-bindings: media: i2c: Document 'remote-endpoint' Jacopo Mondi
2020-07-15 12:48 ` [PATCH v3 3/3] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).