* [PATCH] meye: fix missing pm_mchip_mode field
@ 2020-07-21 21:32 Hans Verkuil
2020-07-22 6:08 ` Vaibhav Gupta
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2020-07-21 21:32 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Vaibhav Gupta
After patch 9c4a8489ab7c ("media: meye: use generic power management")
the pm_mchip_mode field should now always be present, even if CONFIG_PM
is not set.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 9c4a8489ab7c ("media: meye: use generic power management")
---
diff --git a/drivers/media/pci/meye/meye.h b/drivers/media/pci/meye/meye.h
index c957d9b55f89..5fa6552cf93d 100644
--- a/drivers/media/pci/meye/meye.h
+++ b/drivers/media/pci/meye/meye.h
@@ -305,9 +305,7 @@ struct meye {
u16 colour;
struct meye_params params; /* additional parameters */
unsigned long in_use; /* set to 1 if the device is in use */
-#ifdef CONFIG_PM
u8 pm_mchip_mode; /* old mchip mode */
-#endif
};
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] meye: fix missing pm_mchip_mode field
2020-07-21 21:32 [PATCH] meye: fix missing pm_mchip_mode field Hans Verkuil
@ 2020-07-22 6:08 ` Vaibhav Gupta
0 siblings, 0 replies; 2+ messages in thread
From: Vaibhav Gupta @ 2020-07-22 6:08 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
On Tue, Jul 21, 2020 at 11:32:29PM +0200, Hans Verkuil wrote:
> After patch 9c4a8489ab7c ("media: meye: use generic power management")
> the pm_mchip_mode field should now always be present, even if CONFIG_PM
> is not set.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 9c4a8489ab7c ("media: meye: use generic power management")
> ---
> diff --git a/drivers/media/pci/meye/meye.h b/drivers/media/pci/meye/meye.h
> index c957d9b55f89..5fa6552cf93d 100644
> --- a/drivers/media/pci/meye/meye.h
> +++ b/drivers/media/pci/meye/meye.h
> @@ -305,9 +305,7 @@ struct meye {
> u16 colour;
> struct meye_params params; /* additional parameters */
> unsigned long in_use; /* set to 1 if the device is in use */
> -#ifdef CONFIG_PM
> u8 pm_mchip_mode; /* old mchip mode */
> -#endif
> };
>
> #endif
Thank you so much for the fix.
--Vaibhav Gupta
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 21:32 [PATCH] meye: fix missing pm_mchip_mode field Hans Verkuil
2020-07-22 6:08 ` Vaibhav Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).