* [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool
@ 2020-08-07 8:35 Daniel W. S. Almeida
2020-08-11 12:57 ` Benoit Parrot
0 siblings, 1 reply; 3+ messages in thread
From: Daniel W. S. Almeida @ 2020-08-07 8:35 UTC (permalink / raw)
To: Benoit Parrot
Cc: skhan, Daniel W. S. Almeida, Mauro Carvalho Chehab, linux-media,
linux-kernel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Fix the following coccinelle report:
drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to bool
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
drivers/media/platform/ti-vpe/vpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
index 2e5148ae7a0f..de600ffffbbc 100644
--- a/drivers/media/platform/ti-vpe/vpdma.c
+++ b/drivers/media/platform/ti-vpe/vpdma.c
@@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
spin_lock_irqsave(&vpdma->lock, flags);
for (i = 0; i < VPDMA_MAX_NUM_LIST &&
- vpdma->hwlist_used[i] == true; i++)
+ vpdma->hwlist_used[i]; i++)
;
if (i < VPDMA_MAX_NUM_LIST) {
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool
2020-08-07 8:35 [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool Daniel W. S. Almeida
@ 2020-08-11 12:57 ` Benoit Parrot
2020-08-11 18:34 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Benoit Parrot @ 2020-08-11 12:57 UTC (permalink / raw)
To: Daniel W. S. Almeida
Cc: skhan, Mauro Carvalho Chehab, linux-media, linux-kernel
Daniel W. S. Almeida <dwlsalmeida@gmail.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
> Fix the following coccinelle report:
>
> drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
> Comparison to bool
>
> Found using - Coccinelle (http://coccinelle.lip6.fr)
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
> ---
> drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..de600ffffbbc 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
>
> spin_lock_irqsave(&vpdma->lock, flags);
> for (i = 0; i < VPDMA_MAX_NUM_LIST &&
> - vpdma->hwlist_used[i] == true; i++)
> + vpdma->hwlist_used[i]; i++)
> ;
>
> if (i < VPDMA_MAX_NUM_LIST) {
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool
2020-08-11 12:57 ` Benoit Parrot
@ 2020-08-11 18:34 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-08-11 18:34 UTC (permalink / raw)
To: Benoit Parrot, Daniel W. S. Almeida
Cc: skhan, Mauro Carvalho Chehab, linux-media, linux-kernel
On Tue, 2020-08-11 at 07:57 -0500, Benoit Parrot wrote:
> Daniel W. S. Almeida <dwlsalmeida@gmail.com> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
> > From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
> >
> > Fix the following coccinelle report:
> >
> > drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
> > Comparison to bool
> >
> > Found using - Coccinelle (http://coccinelle.lip6.fr)
[]
> > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
[]
> > @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
> >
> > spin_lock_irqsave(&vpdma->lock, flags);
> > for (i = 0; i < VPDMA_MAX_NUM_LIST &&
> > - vpdma->hwlist_used[i] == true; i++)
> > + vpdma->hwlist_used[i]; i++)
> > ;
A more typical way to write this loop is
not testing i < VPDMA_MAX_NUM_LIST multiple
times like the below:
---
drivers/media/platform/ti-vpe/vpdma.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
index 2e5148ae7a0f..5893917ce50d 100644
--- a/drivers/media/platform/ti-vpe/vpdma.c
+++ b/drivers/media/platform/ti-vpe/vpdma.c
@@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
unsigned long flags;
spin_lock_irqsave(&vpdma->lock, flags);
- for (i = 0; i < VPDMA_MAX_NUM_LIST &&
- vpdma->hwlist_used[i] == true; i++)
- ;
-
- if (i < VPDMA_MAX_NUM_LIST) {
+ for (i = 0; i < VPDMA_MAX_NUM_LIST; i++) {
+ if (vpdma->hwlist_used[i])
+ continue;
list_num = i;
vpdma->hwlist_used[i] = true;
vpdma->hwlist_priv[i] = priv;
+ break;
}
spin_unlock_irqrestore(&vpdma->lock, flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-11 18:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 8:35 [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool Daniel W. S. Almeida
2020-08-11 12:57 ` Benoit Parrot
2020-08-11 18:34 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).