* [PATCH 02/20] media: exynos4-is: media-dev.c: use PTR_ERR_OR_ZERO
@ 2020-08-07 8:35 Daniel W. S. Almeida
0 siblings, 0 replies; only message in thread
From: Daniel W. S. Almeida @ 2020-08-07 8:35 UTC (permalink / raw)
To: Kyungmin Park, Sylwester Nawrocki, Kukjin Kim, Krzysztof Kozlowski
Cc: skhan, Daniel W. S. Almeida, Mauro Carvalho Chehab, linux-media,
linux-arm-kernel, linux-samsung-soc, linux-kernel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Fixes the following coccinelle report:
drivers/media/platform/exynos4-is/media-dev.c:1273:1-3:
WARNING: PTR_ERR_OR_ZERO can be used
By using PTR_ERR_OR_ZERO in place of the existing logic.
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
drivers/media/platform/exynos4-is/media-dev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index 16dd660137a8..9346b08931e2 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -1270,10 +1270,8 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd)
pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl,
PINCTRL_STATE_IDLE);
- if (IS_ERR(pctl->state_idle))
- return PTR_ERR(pctl->state_idle);
- return 0;
+ return PTR_ERR_OR_ZERO(pctl->state_idle);
}
static int cam_clk_prepare(struct clk_hw *hw)
--
2.28.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-07 8:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 8:35 [PATCH 02/20] media: exynos4-is: media-dev.c: use PTR_ERR_OR_ZERO Daniel W. S. Almeida
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).