From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Cengiz Can <cengiz@kernel.wtf>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] staging: atomisp: move null check to earlier point
Date: Fri, 7 Aug 2020 12:53:20 +0300 [thread overview]
Message-ID: <20200807095320.GI1793@kadam> (raw)
In-Reply-To: <20200806221537.GA703560@bjorn-Precision-5520>
Beyond that, though, I feel like the rules are stupid because I've seen
more than a couple commit messages which were contorted to avoid
imperative. My own standard for commit messages is that 1) Is the
problem explained, especially what it looks like to user space? 2) Is
it clear what the solution is? 3) Does the patch itself raise any
questions that I can't figure out and which aren't explained in the
commit message. And I figure I'm not a domain expert but if I can
understand the commit message probably anyone can.
We've got people who speak English as a second language and then start
imposing pointless rules on top? It's crazy. I've had to ask someone
recently to redo a commit message and it seemed very obvious they were
focused on nonsense about imperative and avoiding saying "this patch"
to the extent that I literally could not figure out what they were
saying. When I read the patch, of course, I could see what they were
doing but from the commit message it was impossible.
regards,
dan carpenter
prev parent reply other threads:[~2020-08-07 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 13:56 [PATCH] staging: atomisp: move null check to earlier point Cengiz Can
2020-07-29 15:13 ` Andy Shevchenko
2020-07-30 8:45 ` Dan Carpenter
2020-07-30 8:59 ` Cengiz Can
2020-07-30 22:17 ` [PATCH v2] " Cengiz Can
2020-07-31 8:38 ` Andy Shevchenko
2020-08-01 21:51 ` [PATCH v3] " Cengiz Can
2020-08-01 21:55 ` [PATCHi v4] " Cengiz Can
2020-08-01 21:58 ` [PATCH v5] " Cengiz Can
2020-08-01 22:01 ` [PATCH v6] " Cengiz Can
2020-08-06 18:34 ` Cengiz Can
2020-08-06 18:39 ` Greg KH
2020-08-06 20:38 ` Cengiz Can
2020-08-06 22:15 ` [PATCH] " Bjorn Helgaas
2020-08-07 9:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807095320.GI1793@kadam \
--to=dan.carpenter@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=cengiz@kernel.wtf \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).