From: Kaaira Gupta <email@example.com> To: Kieran Bingham <firstname.lastname@example.org> Cc: Helen Koike <email@example.com>, Shuah Khan <firstname.lastname@example.org>, Mauro Carvalho Chehab <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v3 0/9] media: vimc: Multiple stream support in vimc Date: Sat, 12 Sep 2020 16:19:22 +0530 [thread overview] Message-ID: <20200912104922.GG5022@kaaira-HP-Pavilion-Notebook> (raw) In-Reply-To: <firstname.lastname@example.org> On Wed, Sep 02, 2020 at 11:51:59AM +0100, Kieran Bingham wrote: > Hi Kaaira, > > Thank you for this series. > > I have tested it, and indeed it works well, which is great work. > I know this has been hard to debug some of the code paths! Thanks for testing and helping! :D > > There are a few bits that are hard for me to understand, with the graph > walking/initialisation - so I think either some better comments or > refactoring might help there - and Dafna has suggested that there might > be a useful helper which will assist too. That needs to be checked > though, as I think your 'streamer' needs to have full visibility of the > whole pipeline, rather than just a single stream. > > I wonder if it would help to rename it to make that clearer, as > 'vimc_stream' sounds like it deals with only a single stream - but now > it deals with multiple - so the naming is a bit confusing. Hm, I too think that the name is confusing and doesn't show the correct context..is vimc_streamer_referance a better name? What name do you suggest? Thanks, Kaaira > > -- > Kieran > > On 19/08/2020 19:04, Kaaira Gupta wrote: > > This series adds supoort for two (or more) capture devices to be > > connected to the same sensors and run simultaneously. > > > > Changes since v2: > > - This series introduces new patches, namely patch 1, 2, 4, 5, > > 7, and 9 to shift multiple captures to operate at a single > > thread. > > > > Kaaira Gupta (7): > > media: vimc: Move get_source_entity to vimc-common > > media: vimc: Add get_frame callback > > media: vimc: Separate starting stream from pipeline initialisation > > media: vimc: Separate closing of stream and thread > > media: vimc: Dynamically allocate stream struct > > media: vimc: Join pipeline if one already exists > > media: vimc: Run multiple captures on same thread > > > > Niklas Söderlund (2): > > media: vimc: Add usage count to subdevices > > media: vimc: Serialize vimc_streamer_s_stream() > > > > .../media/test-drivers/vimc/vimc-capture.c | 42 +++- > > drivers/media/test-drivers/vimc/vimc-common.c | 14 ++ > > drivers/media/test-drivers/vimc/vimc-common.h | 21 +- > > .../media/test-drivers/vimc/vimc-debayer.c | 26 ++- > > drivers/media/test-drivers/vimc/vimc-scaler.c | 25 +- > > drivers/media/test-drivers/vimc/vimc-sensor.c | 17 +- > > .../media/test-drivers/vimc/vimc-streamer.c | 213 ++++++++++++------ > > .../media/test-drivers/vimc/vimc-streamer.h | 2 + > > 8 files changed, 271 insertions(+), 89 deletions(-) > > > > -- > Regards > -- > Kieran
prev parent reply other threads:[~2020-09-12 10:49 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-19 18:04 Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 1/9] media: vimc: Move get_source_entity to vimc-common Kaaira Gupta 2020-08-20 15:32 ` Kieran Bingham 2020-08-19 18:04 ` [PATCH v3 2/9] media: vimc: Add get_frame callback Kaaira Gupta 2020-08-20 15:36 ` Kieran Bingham 2020-09-12 10:01 ` Kaaira Gupta 2020-10-02 11:08 ` Dafna Hirschfeld 2020-08-19 18:04 ` [PATCH v3 3/9] media: vimc: Add usage count to subdevices Kaaira Gupta 2020-10-02 11:13 ` Dafna Hirschfeld 2020-08-19 18:04 ` [PATCH v3 4/9] media: vimc: Separate starting stream from pipeline initialisation Kaaira Gupta 2020-08-21 15:11 ` Dafna Hirschfeld 2020-08-21 21:01 ` Kaaira Gupta 2020-08-28 20:37 ` Dafna Hirschfeld 2020-09-02 9:56 ` Kieran Bingham 2020-09-12 10:21 ` Kaaira Gupta 2020-09-12 10:16 ` Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 5/9] media: vimc: Separate closing of stream and thread Kaaira Gupta 2020-09-02 10:13 ` Kieran Bingham 2020-09-12 10:28 ` Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 6/9] media: vimc: Serialize vimc_streamer_s_stream() Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 7/9] media: vimc: Dynamically allocate stream struct Kaaira Gupta 2020-09-02 10:29 ` Kieran Bingham 2020-09-12 10:39 ` Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 8/9] media: vimc: Join pipeline if one already exists Kaaira Gupta 2020-09-02 10:40 ` Kieran Bingham 2020-08-19 18:04 ` [PATCH v3 9/9] media: vimc: Run multiple captures on same thread Kaaira Gupta 2020-09-02 10:46 ` Kieran Bingham 2020-09-12 10:45 ` Kaaira Gupta 2020-09-02 10:51 ` [PATCH v3 0/9] media: vimc: Multiple stream support in vimc Kieran Bingham 2020-09-12 10:49 ` Kaaira Gupta [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200912104922.GG5022@kaaira-HP-Pavilion-Notebook \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3 0/9] media: vimc: Multiple stream support in vimc' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).