From: Sakari Ailus <sakari.ailus@iki.fi>
To: Dan Scally <djrscally@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com,
kieran.bingham@ideasonboard.com, jorhand@linux.microsoft.com,
kitakar@gmail.com
Subject: Re: [PATCH v2] software_node: Add support for fwnode_graph*() family of functions
Date: Fri, 18 Sep 2020 09:22:38 +0300 [thread overview]
Message-ID: <20200918062237.GP834@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <7b81d743-736d-62d1-7072-d08759a0d5d7@gmail.com>
Hi Dan,
On Wed, Sep 16, 2020 at 02:22:10PM +0100, Dan Scally wrote:
> Hi Sakari - thanks for the comments
>
> On 16/09/2020 10:17, Sakari Ailus wrote:
> > Moi Daniel and Heikki,
> >
> > On Wed, Sep 16, 2020 at 12:28:27AM +0100, Daniel Scally wrote:
> >> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >>
> >> This implements the remaining .graph_* callbacks in the
> >> fwnode operations vector for the software nodes. That makes
> >> the fwnode_graph*() functions available in the drivers also
> >> when software nodes are used.
> >>
> >> The implementation tries to mimic the "OF graph" as much as
> >> possible, but there is no support for the "reg" device
> >> property. The ports will need to have the index in their
> >> name which starts with "port" (for example "port0", "port1",
> >> ...) and endpoints will use the index of the software node
> >> that is given to them during creation. The port nodes can
> >> also be grouped under a specially named "ports" subnode,
> >> just like in DT, if necessary.
> >>
> >> The remote-endpoints are reference properties under the
> >> endpoint nodes that are named "remote-endpoint".
> >>
> >> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >> Co-developed-by: Daniel Scally <djrscally@gmail.com>
> >> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> >> ---
> >> changes in v2:
> >> - added software_node_device_is_available
> >> - altered software_node_get_next_child to get references
> >> - altered software_node_get_next_endpoint to release references
> >> to ports and avoid passing invalid combinations of swnodes to
> >> software_node_get_next_child
> >> - altered swnode_graph_find_next_port to release port rather than
> >> old
> >>
> >> drivers/base/swnode.c | 129 +++++++++++++++++++++++++++++++++++++++++-
> >> 1 file changed, 127 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> >> index 010828fc785b..d69034b807e3 100644
> >> --- a/drivers/base/swnode.c
> >> +++ b/drivers/base/swnode.c
> >> @@ -363,6 +363,11 @@ static void software_node_put(struct fwnode_handle *fwnode)
> >> kobject_put(&swnode->kobj);
> >> }
> >>
> >> +static bool software_node_device_is_available(const struct fwnode_handle *fwnode)
> >> +{
> >> + return is_software_node(fwnode);
> > This basically tells whether the device is there. Are there software node
> > based devices, i.e. do you need this?
> >
> > If you do really need this, then I guess this could just return true for
> > now as if you somehow get here, the node is a software node anyway.
>
> I do think its better to include it; I'm targeting using this with
> ipu3-cio2; the cio2_parse_firmware() call there doesn't pass
> FWNODE_GRAPH_DEVICE_DISABLED to fwnode_graph_get_endpoint_by_id() so
I wonder if this has something to do with replacing the device's fwnode
in the cio2-bridge patch.
It's the device that needs to be enabled, and it's not a software node.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2020-09-18 6:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 23:28 [PATCH v2] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-09-16 9:17 ` Sakari Ailus
2020-09-16 13:22 ` Dan Scally
2020-09-16 14:32 ` Andy Shevchenko
2020-09-16 15:06 ` Kieran Bingham
2020-09-16 16:10 ` Andy Shevchenko
2020-09-18 6:22 ` Sakari Ailus [this message]
2020-09-18 6:49 ` Dan Scally
2020-09-18 7:34 ` Sakari Ailus
2020-09-18 7:46 ` Dan Scally
2020-09-18 7:57 ` Sakari Ailus
[not found] ` <20200918085709.GA1630537@kuha.fi.intel.com>
2020-09-18 9:10 ` Dan Scally
2020-09-18 9:15 ` Sakari Ailus
2020-09-18 9:22 ` Dan Scally
2020-09-18 12:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918062237.GP834@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).