linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Deepak R Varma <mh12gx2825@gmail.com>
To: outreachy-kernel@googlegroups.com,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use
Date: Mon, 26 Oct 2020 09:32:00 +0530	[thread overview]
Message-ID: <20201026040200.GB5074@my--box> (raw)
In-Reply-To: <6a22de0a51e06b7cb43d4a55850f3a0213532e42.1602869338.git.mh12gx2825@gmail.com>

On Fri, Oct 16, 2020 at 11:16:06PM +0530, Deepak R Varma wrote:

Hello All,
Request for review / ack of this patch.

Thank you.
Deepak.

> Use of variable vc_num is unnecessary here as it is used only once.
> Instead, the value can directly be used in place of the variable.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
>    - None.
> Changes since v3:
>    - None.
> Changes since v2:
>    - Implement feedback from Vaishali to simplify patch log message.
> Changes since v1:
>    - None.
> 
>  drivers/staging/media/imx/imx-media-csi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 9320e3974d86..db77fef07654 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  	priv->upstream_ep = upstream_ep;
>  	is_csi2 = !is_parallel_bus(&upstream_ep);
>  	if (is_csi2) {
> -		int vc_num = 0;
>  		/*
>  		 * NOTE! It seems the virtual channels from the mipi csi-2
>  		 * receiver are used only for routing by the video mux's,
> @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  		 * enters the CSI's however, they are treated internally
>  		 * in the IPU as virtual channel 0.
>  		 */
> -		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> +		ipu_csi_set_mipi_datatype(priv->csi, 0,
>  					  &priv->format_mbus[CSI_SINK_PAD]);
>  	}
>  
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2020-10-26  4:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
2020-10-16 17:43 ` Steve Longerbeam
2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
2020-10-16 17:46   ` Steve Longerbeam
2020-10-26  4:02   ` Deepak R Varma [this message]
2020-10-26  4:00 ` [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
2020-10-26  5:56   ` Greg Kroah-Hartman
2020-10-26 18:03     ` Deepak R Varma
2020-10-27  9:43     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026040200.GB5074@my--box \
    --to=mh12gx2825@gmail.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=p.zabel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).