* [PATCH] adv748x: Only set i2c addresses once during probe
@ 2020-11-22 16:30 Niklas Söderlund
2020-11-25 12:07 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2020-11-22 16:30 UTC (permalink / raw)
To: linux-media; +Cc: linux-renesas-soc, Niklas Söderlund
During probe the i2c slave addresses are set two times in a row, once in
adv748x_initialise_clients() and once directly after in adv748x_reset().
Remove the call to adv748x_set_slave_addresses() in
adv748x_initialise_clients() as it's only called during probe while
adv748x_reset() is called during probe and normal operation.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
index ae8b7ebf3830aa1c..00966fe104881a14 100644
--- a/drivers/media/i2c/adv748x/adv748x-core.c
+++ b/drivers/media/i2c/adv748x/adv748x-core.c
@@ -198,7 +198,7 @@ static int adv748x_initialise_clients(struct adv748x_state *state)
return ret;
}
- return adv748x_set_slave_addresses(state);
+ return 0;
}
/**
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] adv748x: Only set i2c addresses once during probe
2020-11-22 16:30 [PATCH] adv748x: Only set i2c addresses once during probe Niklas Söderlund
@ 2020-11-25 12:07 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2020-11-25 12:07 UTC (permalink / raw)
To: Niklas Söderlund, linux-media; +Cc: linux-renesas-soc
Hi Niklas,
On 22/11/2020 16:30, Niklas Söderlund wrote:
> During probe the i2c slave addresses are set two times in a row, once in
> adv748x_initialise_clients() and once directly after in adv748x_reset().
> Remove the call to adv748x_set_slave_addresses() in
> adv748x_initialise_clients() as it's only called during probe while
> adv748x_reset() is called during probe and normal operation.
Yes, and the call to reset will completely reset the first setting in
the first place - so it's quite redundant.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index ae8b7ebf3830aa1c..00966fe104881a14 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -198,7 +198,7 @@ static int adv748x_initialise_clients(struct adv748x_state *state)
> return ret;
> }
>
> - return adv748x_set_slave_addresses(state);
> + return 0;
> }
>
> /**
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-25 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 16:30 [PATCH] adv748x: Only set i2c addresses once during probe Niklas Söderlund
2020-11-25 12:07 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).