linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
@ 2021-01-15 18:15 Lee Jones
  2021-01-15 18:15 ` [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Ben Skeggs, Christian König, Daniel Vetter,
	Dave Airlie, David Airlie, dri-devel, Eddie Dong, Eric Anholt,
	Faith, Gareth Hughes, intel-gfx, intel-gvt-dev, Jackie Li,
	Jani Nikula, Jan Safrata, Jesse Barnes, jim liu, Joonas Lahtinen,
	Keith Packard, Kevin Tian, linaro-mm-sig, linux-media,
	Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing, nouveau,
	Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark, Rodrigo Vivi,
	Roland Scheidegger, Sumit Semwal, Thomas Zimmermann, Tina Zhang,
	VMware Graphics, Zack Rusin, Zhenyu Wang, Zhi Wang, Zhiyuan Lv

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Lee Jones (29):
  drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural
  drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation
    problems
  drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member
  drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and
    remove others
  drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'
  drm/gma500/mmu: Actually return an error if one occurs
  drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff'
    param
  drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function
    param descriptions
  drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
  drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member
    'manager'
  drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses
  drm/gma500/psb_irq: Demote kernel-doc abuse
  drm/drm_dp_helper: Fix spelling issue and add missing description for
    'enable_frl_ready_hpd'
  drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in
    'cdv_intel_crt_detect_hotplug()'s header
  drm/gma500/cdv_intel_display: Demote kernel-doc abuse in
    'cdv_intel_panel_fitter_pipe()'s header
  drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks
    and fix another
  drm/gma500/cdv_intel_dp: Demote one unworthy header fix another
  drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp'
  drm/gma500/oaktrail_lvds: Demote one documentation header fix another
  drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers
  drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting
    abuses
  drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting
    abuses
  drm/drm_agpsupport: Strip out obviously wrong descriptions and demote
    to standard headers
  drm/i915/gvt/handlers: Remove kernel-doc formatting from
    non-kernel-doc header
  drm/nouveau/nouveau_ioc32: File headers are not good candidates for
    kernel-doc
  drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void
    function
  drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from
    'nouveau_bios_init()'
  drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment
    block
  drm/vmwgfx/ttm_object: Reorder header to immediately precede its
    struct

 drivers/gpu/drm/drm_agpsupport.c             | 46 +++++---------------
 drivers/gpu/drm/drm_dp_helper.c              |  3 +-
 drivers/gpu/drm/gma500/cdv_intel_crt.c       |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_display.c   |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_dp.c        |  4 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c      |  7 +--
 drivers/gpu/drm/gma500/mdfld_dsi_output.c    |  4 +-
 drivers/gpu/drm/gma500/mdfld_intel_display.c |  6 +--
 drivers/gpu/drm/gma500/mmu.c                 |  2 +-
 drivers/gpu/drm/gma500/oaktrail_crtc.c       |  6 +--
 drivers/gpu/drm/gma500/oaktrail_lvds.c       |  3 +-
 drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c   |  8 ++--
 drivers/gpu/drm/gma500/psb_intel_sdvo.c      |  6 +--
 drivers/gpu/drm/gma500/psb_irq.c             |  3 +-
 drivers/gpu/drm/i915/gvt/handlers.c          |  2 +-
 drivers/gpu/drm/nouveau/nouveau_bios.c       |  2 -
 drivers/gpu/drm/nouveau/nouveau_ioc32.c      |  4 +-
 drivers/gpu/drm/nouveau/nouveau_svm.c        |  5 +--
 drivers/gpu/drm/vmwgfx/ttm_object.c          | 25 ++++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c      |  9 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c         |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c       |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c      |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_so.c           |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_thp.c          |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c   |  5 ++-
 27 files changed, 74 insertions(+), 90 deletions(-)

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eddie Dong <eddie.dong@intel.com>
Cc: Eric Anholt <eric@anholt.net>
Cc: Faith <faith@valinux.com>
Cc: Gareth Hughes <gareth@valinux.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: Jackie Li <yaodong.li@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jan Safrata <jan.nikitenko@gmail.com>
Cc: Jesse Barnes <jesse.barnes@intel.com>
Cc: jim liu <jim.liu@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Keith Packard <keithp@keithp.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-media@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Min He <min.he@intel.com>
Cc: Niu Bing <bing.niu@intel.com>
Cc: nouveau@lists.freedesktop.org
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Pei Zhang <pei.zhang@intel.com>
Cc: Ping Gao <ping.a.gao@intel.com>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Tina Zhang <tina.zhang@intel.com>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
@ 2021-01-15 18:15 ` Lee Jones
  2021-01-15 18:16 ` [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  2 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, VMware Graphics, Roland Scheidegger, Zack Rusin,
	David Airlie, Daniel Vetter, Sumit Semwal, Christian König,
	Dave Airlie, Rob Clark, dri-devel, linux-media, linaro-mm-sig

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union!
 drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device'
 drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'ops' not described in 'ttm_object_device'
 drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dmabuf_release' not described in 'ttm_object_device'
 drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dma_buf_size' not described in 'ttm_object_device'
 drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'idr' not described in 'ttm_object_device'
 drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'rcu_head' not described in 'ttm_ref_object'
 drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'tfile' not described in 'ttm_ref_object'
 drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Function parameter or member 'dmabuf' not described in 'get_dma_buf_unless_doomed'
 drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Excess function parameter 'dma_buf' description in 'get_dma_buf_unless_doomed'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/vmwgfx/ttm_object.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/ttm_object.c b/drivers/gpu/drm/vmwgfx/ttm_object.c
index 0fe869d0fad12..b3fdc630497cb 100644
--- a/drivers/gpu/drm/vmwgfx/ttm_object.c
+++ b/drivers/gpu/drm/vmwgfx/ttm_object.c
@@ -73,7 +73,7 @@ struct ttm_object_file {
 	struct kref refcount;
 };
 
-/**
+/*
  * struct ttm_object_device
  *
  * @object_lock: lock that protects the object_hash hash table.
@@ -96,7 +96,7 @@ struct ttm_object_device {
 	struct idr idr;
 };
 
-/**
+/*
  * struct ttm_ref_object
  *
  * @hash: Hash entry for the per-file object reference hash.
@@ -568,7 +568,7 @@ void ttm_object_device_release(struct ttm_object_device **p_tdev)
 /**
  * get_dma_buf_unless_doomed - get a dma_buf reference if possible.
  *
- * @dma_buf: Non-refcounted pointer to a struct dma-buf.
+ * @dmabuf: Non-refcounted pointer to a struct dma-buf.
  *
  * Obtain a file reference from a lookup structure that doesn't refcount
  * the file, but synchronizes with its release method to make sure it has
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
  2021-01-15 18:15 ` [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
@ 2021-01-15 18:16 ` Lee Jones
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  2 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-01-15 18:16 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, VMware Graphics, Roland Scheidegger, Zack Rusin,
	David Airlie, Daniel Vetter, Sumit Semwal, Christian König,
	Dave Airlie, Rob Clark, dri-devel, linux-media, linaro-mm-sig

Also add missing description for 'refcount'

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union!

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/vmwgfx/ttm_object.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/ttm_object.c b/drivers/gpu/drm/vmwgfx/ttm_object.c
index b3fdc630497cb..112394dd0ab6a 100644
--- a/drivers/gpu/drm/vmwgfx/ttm_object.c
+++ b/drivers/gpu/drm/vmwgfx/ttm_object.c
@@ -42,6 +42,14 @@
  */
 
 
+#define pr_fmt(fmt) "[TTM] " fmt
+
+#include <linux/list.h>
+#include <linux/spinlock.h>
+#include <linux/slab.h>
+#include <linux/atomic.h>
+#include "ttm_object.h"
+
 /**
  * struct ttm_object_file
  *
@@ -55,16 +63,9 @@
  *
  * @ref_hash: Hash tables of ref objects, one per ttm_ref_type,
  * for fast lookup of ref objects given a base object.
+ *
+ * @refcount: reference/usage count
  */
-
-#define pr_fmt(fmt) "[TTM] " fmt
-
-#include <linux/list.h>
-#include <linux/spinlock.h>
-#include <linux/slab.h>
-#include <linux/atomic.h>
-#include "ttm_object.h"
-
 struct ttm_object_file {
 	struct ttm_object_device *tdev;
 	spinlock_t lock;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
  2021-01-15 18:15 ` [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
  2021-01-15 18:16 ` [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones
@ 2021-01-15 18:27 ` Zack Rusin
  2021-01-18  9:49   ` Daniel Vetter
  2021-01-18 14:54   ` Daniel Vetter
  2 siblings, 2 replies; 11+ messages in thread
From: Zack Rusin @ 2021-01-15 18:27 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-kernel, Ben Skeggs, Christian König, Daniel Vetter,
	Dave Airlie, David Airlie, DRI Development, Eddie Dong,
	Eric Anholt, Faith, Gareth Hughes, intel-gfx, intel-gvt-dev,
	Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes, jim liu,
	Joonas Lahtinen, Keith Packard, Kevin Tian, linaro-mm-sig,
	linux-media, Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing,
	nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark,
	Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv


> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> 
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Thanks! For all the vmwgfx bits:
Reviewed-by: Zack Rusin <zackr@vmware.com>

z

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
@ 2021-01-18  9:49   ` Daniel Vetter
  2021-01-18 14:54   ` Daniel Vetter
  1 sibling, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-18  9:49 UTC (permalink / raw)
  To: Zack Rusin
  Cc: Lee Jones, linux-kernel, Ben Skeggs, Christian König,
	Daniel Vetter, Dave Airlie, David Airlie, DRI Development,
	Eddie Dong, Eric Anholt, Faith, Gareth Hughes, intel-gfx,
	intel-gvt-dev, Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes,
	jim liu, Joonas Lahtinen, Keith Packard, Kevin Tian,
	linaro-mm-sig, linux-media, Maarten Lankhorst, Maxime Ripard,
	Min He, Niu Bing, nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao,
	Rob Clark, Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> 
> > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> 
> Thanks! For all the vmwgfx bits:
> Reviewed-by: Zack Rusin <zackr@vmware.com>

Can you pls push them to drm-misc-next? I'm planning to go pull in all the
other patches later today that belong into drm-misc-next, but some patch
monkey help would be really great :-)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  2021-01-18  9:49   ` Daniel Vetter
@ 2021-01-18 14:54   ` Daniel Vetter
  2021-01-18 15:09     ` Lee Jones
  1 sibling, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2021-01-18 14:54 UTC (permalink / raw)
  To: Zack Rusin
  Cc: Lee Jones, linux-kernel, Ben Skeggs, Christian König,
	Daniel Vetter, Dave Airlie, David Airlie, DRI Development,
	Eddie Dong, Eric Anholt, Faith, Gareth Hughes, intel-gfx,
	intel-gvt-dev, Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes,
	jim liu, Joonas Lahtinen, Keith Packard, Kevin Tian,
	linaro-mm-sig, linux-media, Maarten Lankhorst, Maxime Ripard,
	Min He, Niu Bing, nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao,
	Rob Clark, Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> 
> > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> 
> Thanks! For all the vmwgfx bits:
> Reviewed-by: Zack Rusin <zackr@vmware.com>

Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
(those generally go through other trees, pls holler if they're stuck).

Note that we have some build issue on some of the configs sfr uses, so drm
trees are still stuck on old versions in linux-next. Hopefully should get
resolved soon, the bugfix is in some subtree I've heard.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-18 14:54   ` Daniel Vetter
@ 2021-01-18 15:09     ` Lee Jones
  2021-01-18 17:21       ` Daniel Vetter
  0 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-01-18 15:09 UTC (permalink / raw)
  To: Zack Rusin, linux-kernel, Ben Skeggs, Christian König,
	Dave Airlie, David Airlie, DRI Development, Eddie Dong,
	Eric Anholt, Faith, Gareth Hughes, intel-gfx, intel-gvt-dev,
	Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes, jim liu,
	Joonas Lahtinen, Keith Packard, Kevin Tian, linaro-mm-sig,
	linux-media, Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing,
	nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark,
	Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > 
> > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > 
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > > 
> > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > 
> > Thanks! For all the vmwgfx bits:
> > Reviewed-by: Zack Rusin <zackr@vmware.com>
> 
> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> (those generally go through other trees, pls holler if they're stuck).

Thanks Daniel, you're a superstar!

So Zack will take the vmwgfx parts?  Despite providing a R-b?

> Note that we have some build issue on some of the configs sfr uses, so drm
> trees are still stuck on old versions in linux-next. Hopefully should get
> resolved soon, the bugfix is in some subtree I've heard.

No worries.  Thanks for letting me know.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-18 15:09     ` Lee Jones
@ 2021-01-18 17:21       ` Daniel Vetter
  2021-01-19  8:29         ` Lee Jones
  0 siblings, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2021-01-18 17:21 UTC (permalink / raw)
  To: Lee Jones
  Cc: Zack Rusin, linux-kernel, Ben Skeggs, Christian König,
	Dave Airlie, David Airlie, DRI Development, Eddie Dong,
	Eric Anholt, Faith, Gareth Hughes, intel-gfx, intel-gvt-dev,
	Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes, jim liu,
	Joonas Lahtinen, Keith Packard, Kevin Tian, linaro-mm-sig,
	linux-media, Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing,
	nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark,
	Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> 
> > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > 
> > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > 
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > > 
> > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > 
> > > Thanks! For all the vmwgfx bits:
> > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > 
> > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > (those generally go through other trees, pls holler if they're stuck).
> 
> Thanks Daniel, you're a superstar!
> 
> So Zack will take the vmwgfx parts?  Despite providing a R-b?

I only merge stuff that's defacto abandoned already. Everything else I try
to offload to whomever actually cares :-)
-Daniel

> 
> > Note that we have some build issue on some of the configs sfr uses, so drm
> > trees are still stuck on old versions in linux-next. Hopefully should get
> > resolved soon, the bugfix is in some subtree I've heard.
> 
> No worries.  Thanks for letting me know.
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-18 17:21       ` Daniel Vetter
@ 2021-01-19  8:29         ` Lee Jones
  2021-01-19 19:27           ` Zack Rusin
  0 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-01-19  8:29 UTC (permalink / raw)
  To: Zack Rusin, linux-kernel, Ben Skeggs, Christian König,
	Dave Airlie, David Airlie, DRI Development, Eddie Dong,
	Eric Anholt, Faith, Gareth Hughes, intel-gfx, intel-gvt-dev,
	Jackie Li, Jani Nikula, Jan Safrata, Jesse Barnes, jim liu,
	Joonas Lahtinen, Keith Packard, Kevin Tian, linaro-mm-sig,
	linux-media, Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing,
	nouveau, Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark,
	Rodrigo Vivi, Roland Scheidegger, Sumit Semwal,
	Thomas Zimmermann, Tina Zhang, Linux-graphics-maintainer,
	Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> > > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > > 
> > > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > > 
> > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > niggly little warnings.
> > > > > 
> > > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > > 
> > > > Thanks! For all the vmwgfx bits:
> > > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > > 
> > > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > > (those generally go through other trees, pls holler if they're stuck).
> > 
> > Thanks Daniel, you're a superstar!
> > 
> > So Zack will take the vmwgfx parts?  Despite providing a R-b?
> 
> I only merge stuff that's defacto abandoned already. Everything else I try
> to offload to whomever actually cares :-)

Understood.  Thanks for the explanation.

Hopefully Zack actually cares. :D

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-19  8:29         ` Lee Jones
@ 2021-01-19 19:27           ` Zack Rusin
  2021-01-20  8:05             ` Lee Jones
  0 siblings, 1 reply; 11+ messages in thread
From: Zack Rusin @ 2021-01-19 19:27 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-kernel, Ben Skeggs, Christian König, Dave Airlie,
	David Airlie, DRI Development, Eddie Dong, Eric Anholt, Faith,
	Gareth Hughes, intel-gfx, intel-gvt-dev, Jackie Li, Jani Nikula,
	Jan Safrata, Jesse Barnes, jim liu, Joonas Lahtinen,
	Keith Packard, Kevin Tian, linaro-mm-sig, linux-media,
	Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing, nouveau,
	Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark, Rodrigo Vivi,
	Roland Scheidegger, Sumit Semwal, Thomas Zimmermann, Tina Zhang,
	Linux-graphics-maintainer, Zhenyu Wang, Zhi Wang, Zhiyuan Lv



> On Jan 19, 2021, at 03:29, Lee Jones <lee.jones@linaro.org> wrote:
> 
> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> 
>> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
>>> On Mon, 18 Jan 2021, Daniel Vetter wrote:
>>> 
>>>> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
>>>>> 
>>>>>> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
>>>>>> 
>>>>>> This set is part of a larger effort attempting to clean-up W=1
>>>>>> kernel builds, which are currently overwhelmingly riddled with
>>>>>> niggly little warnings.
>>>>>> 
>>>>>> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
>>>>> 
>>>>> Thanks! For all the vmwgfx bits:
>>>>> Reviewed-by: Zack Rusin <zackr@vmware.com>
>>>> 
>>>> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
>>>> (those generally go through other trees, pls holler if they're stuck).
>>> 
>>> Thanks Daniel, you're a superstar!
>>> 
>>> So Zack will take the vmwgfx parts?  Despite providing a R-b?
>> 
>> I only merge stuff that's defacto abandoned already. Everything else I try
>> to offload to whomever actually cares :-)
> 
> Understood.  Thanks for the explanation.
> 
> Hopefully Zack actually cares. :D

hah, I do. I just pushed all of the changes to drm-misc-next. Let me know if I missed anything. Thanks!

z



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-19 19:27           ` Zack Rusin
@ 2021-01-20  8:05             ` Lee Jones
  0 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-01-20  8:05 UTC (permalink / raw)
  To: Zack Rusin
  Cc: linux-kernel, Ben Skeggs, Christian König, Dave Airlie,
	David Airlie, DRI Development, Eddie Dong, Eric Anholt, Faith,
	Gareth Hughes, intel-gfx, intel-gvt-dev, Jackie Li, Jani Nikula,
	Jan Safrata, Jesse Barnes, jim liu, Joonas Lahtinen,
	Keith Packard, Kevin Tian, linaro-mm-sig, linux-media,
	Maarten Lankhorst, Maxime Ripard, Min He, Niu Bing, nouveau,
	Patrik Jakobsson, Pei Zhang, Ping Gao, Rob Clark, Rodrigo Vivi,
	Roland Scheidegger, Sumit Semwal, Thomas Zimmermann, Tina Zhang,
	Linux-graphics-maintainer, Zhenyu Wang, Zhi Wang, Zhiyuan Lv

On Tue, 19 Jan 2021, Zack Rusin wrote:

> 
> 
> > On Jan 19, 2021, at 03:29, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> >> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> >>> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> >>> 
> >>>> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> >>>>> 
> >>>>>> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> >>>>>> 
> >>>>>> This set is part of a larger effort attempting to clean-up W=1
> >>>>>> kernel builds, which are currently overwhelmingly riddled with
> >>>>>> niggly little warnings.
> >>>>>> 
> >>>>>> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> >>>>> 
> >>>>> Thanks! For all the vmwgfx bits:
> >>>>> Reviewed-by: Zack Rusin <zackr@vmware.com>
> >>>> 
> >>>> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> >>>> (those generally go through other trees, pls holler if they're stuck).
> >>> 
> >>> Thanks Daniel, you're a superstar!
> >>> 
> >>> So Zack will take the vmwgfx parts?  Despite providing a R-b?
> >> 
> >> I only merge stuff that's defacto abandoned already. Everything else I try
> >> to offload to whomever actually cares :-)
> > 
> > Understood.  Thanks for the explanation.
> > 
> > Hopefully Zack actually cares. :D
> 
> hah, I do. I just pushed all of the changes to drm-misc-next. Let me
> know if I missed anything. Thanks!

Perfect.  Thank you Zack.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-01-20  8:09 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
2021-01-15 18:15 ` [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
2021-01-15 18:16 ` [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones
2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
2021-01-18  9:49   ` Daniel Vetter
2021-01-18 14:54   ` Daniel Vetter
2021-01-18 15:09     ` Lee Jones
2021-01-18 17:21       ` Daniel Vetter
2021-01-19  8:29         ` Lee Jones
2021-01-19 19:27           ` Zack Rusin
2021-01-20  8:05             ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).