* [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device()
@ 2021-01-23 3:44 Stephen Boyd
2021-01-23 3:44 ` [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data() Stephen Boyd
2021-01-26 18:21 ` [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-01-23 3:44 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, devicetree, Alexandre Torgue, Arnd Bergmann,
David S. Miller, Frank Rowand, Geert Uytterhoeven,
Greg Kroah-Hartman, Grygorii Strashko, Guenter Roeck,
Jacopo Mondi, Jean Delvare, Jiri Slaby, linux-hwmon, linux-media,
linux-omap, linux-renesas-soc, linux-serial, linux-usb,
Mauro Carvalho Chehab, Maxime Coquelin, Richard Leitner,
Rob Herring
(This is a continuation of this series[1] per Rob's request. I've picked
up the acks, etc. with b4 and compile tested the patches along with an
arm64 allmodconfig build. Presumably Rob will pick these up directly.)
of_match_device() uses of_match_ptr() to make the match table argument
NULL via the pre-processor when CONFIG_OF=n. This makes life harder for
compilers who think that match tables are never used and warn about
unused variables when CONFIG_OF=n. This series changes various callers
to use of_device_get_match_data() instead, which doesn't have this
problem, and removes the of_match_ptr() usage from of_match_device() so
that the compiler can stop complaining about unused variables. It will
do dead code elimination instead and remove the match table if it isn't
actually used.
[1] https://lore.kernel.org/r/20191004214334.149976-1-swboyd@chromium.org
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jacopo Mondi <jacopo@jmondi.org>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: <linux-hwmon@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
Cc: <linux-media@vger.kernel.org>
Cc: <linux-omap@vger.kernel.org>
Cc: <linux-renesas-soc@vger.kernel.org>
Cc: <linux-serial@vger.kernel.org>
Cc: <linux-usb@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Richard Leitner <richard.leitner@skidata.com>
Cc: Rob Herring <robh+dt@kernel.org>
Stephen Boyd (6):
media: renesas-ceu: Use of_device_get_match_data()
drivers: net: davinci_mdio: Use of_device_get_match_data()
serial: stm32: Use of_device_get_match_data()
usb: usb251xb: Use of_device_get_match_data()
hwmon: (lm70) Avoid undefined reference to match table
of/device: Don't NULLify match table in of_match_device() with
CONFIG_OF=n
drivers/hwmon/lm70.c | 2 +-
drivers/media/platform/renesas-ceu.c | 2 +-
drivers/net/ethernet/ti/davinci_mdio.c | 12 ++---
drivers/tty/serial/stm32-usart.c | 71 ++++++++++++--------------
drivers/tty/serial/stm32-usart.h | 2 +-
drivers/usb/misc/usb251xb.c | 12 ++---
include/linux/of_device.h | 4 +-
7 files changed, 47 insertions(+), 58 deletions(-)
base-commit: 19c329f6808995b142b3966301f217c831e7cf31
--
https://chromeos.dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data()
2021-01-23 3:44 [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Stephen Boyd
@ 2021-01-23 3:44 ` Stephen Boyd
2021-01-25 8:30 ` Geert Uytterhoeven
2021-01-26 18:21 ` [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2021-01-23 3:44 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, devicetree, Mauro Carvalho Chehab, Jacopo Mondi,
Arnd Bergmann, Geert Uytterhoeven, Jacopo Mondi,
Mauro Carvalho Chehab, Rob Herring, Frank Rowand, linux-media,
linux-renesas-soc
This driver can use the replacement API instead of calling
of_match_device() and then dereferencing the pointer that is returned.
This nicely avoids referencing the match table when it is undefined with
configurations where CONFIG_OF=n.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo@jmondi.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: <linux-media@vger.kernel.org>
Cc: <linux-renesas-soc@vger.kernel.org>
---
Please ack so Rob can apply.
drivers/media/platform/renesas-ceu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
index 4a633ad0e8fa..352e7c84d5ba 100644
--- a/drivers/media/platform/renesas-ceu.c
+++ b/drivers/media/platform/renesas-ceu.c
@@ -1679,7 +1679,7 @@ static int ceu_probe(struct platform_device *pdev)
v4l2_async_notifier_init(&ceudev->notifier);
if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
- ceu_data = of_match_device(ceu_of_match, dev)->data;
+ ceu_data = of_device_get_match_data(dev);
num_subdevs = ceu_parse_dt(ceudev);
} else if (dev->platform_data) {
/* Assume SH4 if booting with platform data. */
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data()
2021-01-23 3:44 ` [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data() Stephen Boyd
@ 2021-01-25 8:30 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-01-25 8:30 UTC (permalink / raw)
To: Stephen Boyd
Cc: Rob Herring, Linux Kernel Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Mauro Carvalho Chehab, Jacopo Mondi, Arnd Bergmann, Jacopo Mondi,
Mauro Carvalho Chehab, Rob Herring, Frank Rowand,
Linux Media Mailing List, Linux-Renesas
On Sat, Jan 23, 2021 at 4:44 AM Stephen Boyd <swboyd@chromium.org> wrote:
> This driver can use the replacement API instead of calling
> of_match_device() and then dereferencing the pointer that is returned.
> This nicely avoids referencing the match table when it is undefined with
> configurations where CONFIG_OF=n.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device()
2021-01-23 3:44 [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Stephen Boyd
2021-01-23 3:44 ` [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data() Stephen Boyd
@ 2021-01-26 18:21 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-01-26 18:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, devicetree, Alexandre Torgue, Arnd Bergmann,
David S. Miller, Frank Rowand, Geert Uytterhoeven,
Greg Kroah-Hartman, Grygorii Strashko, Guenter Roeck,
Jacopo Mondi, Jean Delvare, Jiri Slaby, Linux HWMON List,
Linux Media Mailing List, linux-omap,
open list:MEDIA DRIVERS FOR RENESAS - FCP,
open list:SERIAL DRIVERS, Linux USB List, Mauro Carvalho Chehab,
Maxime Coquelin, Richard Leitner
On Fri, Jan 22, 2021 at 9:44 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> (This is a continuation of this series[1] per Rob's request. I've picked
> up the acks, etc. with b4 and compile tested the patches along with an
> arm64 allmodconfig build. Presumably Rob will pick these up directly.)
>
> of_match_device() uses of_match_ptr() to make the match table argument
> NULL via the pre-processor when CONFIG_OF=n. This makes life harder for
> compilers who think that match tables are never used and warn about
> unused variables when CONFIG_OF=n. This series changes various callers
> to use of_device_get_match_data() instead, which doesn't have this
> problem, and removes the of_match_ptr() usage from of_match_device() so
> that the compiler can stop complaining about unused variables. It will
> do dead code elimination instead and remove the match table if it isn't
> actually used.
>
> [1] https://lore.kernel.org/r/20191004214334.149976-1-swboyd@chromium.org
>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jacopo Mondi <jacopo@jmondi.org>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: <linux-hwmon@vger.kernel.org>
> Cc: <linux-kernel@vger.kernel.org>,
> Cc: <linux-media@vger.kernel.org>
> Cc: <linux-omap@vger.kernel.org>
> Cc: <linux-renesas-soc@vger.kernel.org>
> Cc: <linux-serial@vger.kernel.org>
> Cc: <linux-usb@vger.kernel.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Richard Leitner <richard.leitner@skidata.com>
> Cc: Rob Herring <robh+dt@kernel.org>
>
> Stephen Boyd (6):
> media: renesas-ceu: Use of_device_get_match_data()
> drivers: net: davinci_mdio: Use of_device_get_match_data()
> serial: stm32: Use of_device_get_match_data()
> usb: usb251xb: Use of_device_get_match_data()
> hwmon: (lm70) Avoid undefined reference to match table
> of/device: Don't NULLify match table in of_match_device() with
> CONFIG_OF=n
>
> drivers/hwmon/lm70.c | 2 +-
> drivers/media/platform/renesas-ceu.c | 2 +-
> drivers/net/ethernet/ti/davinci_mdio.c | 12 ++---
> drivers/tty/serial/stm32-usart.c | 71 ++++++++++++--------------
> drivers/tty/serial/stm32-usart.h | 2 +-
> drivers/usb/misc/usb251xb.c | 12 ++---
> include/linux/of_device.h | 4 +-
> 7 files changed, 47 insertions(+), 58 deletions(-)
Series applied.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 22:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-23 3:44 [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Stephen Boyd
2021-01-23 3:44 ` [PATCH v2 1/6] media: renesas-ceu: Use of_device_get_match_data() Stephen Boyd
2021-01-25 8:30 ` Geert Uytterhoeven
2021-01-26 18:21 ` [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device() Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).