* [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1
@ 2021-04-29 12:45 Geert Uytterhoeven
2021-05-01 10:21 ` Niklas Söderlund
2021-05-03 20:02 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-04-29 12:45 UTC (permalink / raw)
To: Niklas Söderlund, Mauro Carvalho Chehab, Rob Herring, Jacopo Mondi
Cc: linux-media, linux-renesas-soc, devicetree, Geert Uytterhoeven
The "resets" property is not present on R-Car Gen1 SoCs.
Supporting it would require migrating from renesas,cpg-clocks to
renesas,cpg-mssr.
Fixes: 905fc6b1bfb4a631 ("dt-bindings: rcar-vin: Convert bindings to json-schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Note that VIN is not yet enabled in r8a777[89].dtsi.
---
.../bindings/media/renesas,vin.yaml | 46 ++++++++++++-------
1 file changed, 29 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
index 79c936b313ea91ae..19fccc2fd8ece120 100644
--- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
@@ -194,23 +194,35 @@ required:
- interrupts
- clocks
- power-domains
- - resets
-
-if:
- properties:
- compatible:
- contains:
- enum:
- - renesas,vin-r8a7778
- - renesas,vin-r8a7779
- - renesas,rcar-gen2-vin
-then:
- required:
- - port
-else:
- required:
- - renesas,id
- - ports
+
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,vin-r8a7778
+ - renesas,vin-r8a7779
+ then:
+ required:
+ - resets
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,vin-r8a7778
+ - renesas,vin-r8a7779
+ - renesas,rcar-gen2-vin
+ then:
+ required:
+ - port
+ else:
+ required:
+ - renesas,id
+ - ports
additionalProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1
2021-04-29 12:45 [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1 Geert Uytterhoeven
@ 2021-05-01 10:21 ` Niklas Söderlund
2021-05-03 20:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2021-05-01 10:21 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Rob Herring, Jacopo Mondi, linux-media,
linux-renesas-soc, devicetree
Hi Geert,
On 2021-04-29 14:45:52 +0200, Geert Uytterhoeven wrote:
> The "resets" property is not present on R-Car Gen1 SoCs.
> Supporting it would require migrating from renesas,cpg-clocks to
> renesas,cpg-mssr.
>
> Fixes: 905fc6b1bfb4a631 ("dt-bindings: rcar-vin: Convert bindings to json-schema")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Note that VIN is not yet enabled in r8a777[89].dtsi.
> ---
> .../bindings/media/renesas,vin.yaml | 46 ++++++++++++-------
> 1 file changed, 29 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> index 79c936b313ea91ae..19fccc2fd8ece120 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> @@ -194,23 +194,35 @@ required:
> - interrupts
> - clocks
> - power-domains
> - - resets
> -
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,vin-r8a7778
> - - renesas,vin-r8a7779
> - - renesas,rcar-gen2-vin
> -then:
> - required:
> - - port
> -else:
> - required:
> - - renesas,id
> - - ports
> +
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,vin-r8a7778
> + - renesas,vin-r8a7779
> + then:
> + required:
> + - resets
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,vin-r8a7778
> + - renesas,vin-r8a7779
> + - renesas,rcar-gen2-vin
> + then:
> + required:
> + - port
> + else:
> + required:
> + - renesas,id
> + - ports
>
> additionalProperties: false
>
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1
2021-04-29 12:45 [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1 Geert Uytterhoeven
2021-05-01 10:21 ` Niklas Söderlund
@ 2021-05-03 20:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-03 20:02 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, Mauro Carvalho Chehab, Rob Herring,
linux-renesas-soc, Jacopo Mondi, linux-media,
Niklas Söderlund
On Thu, 29 Apr 2021 14:45:52 +0200, Geert Uytterhoeven wrote:
> The "resets" property is not present on R-Car Gen1 SoCs.
> Supporting it would require migrating from renesas,cpg-clocks to
> renesas,cpg-mssr.
>
> Fixes: 905fc6b1bfb4a631 ("dt-bindings: rcar-vin: Convert bindings to json-schema")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Note that VIN is not yet enabled in r8a777[89].dtsi.
> ---
> .../bindings/media/renesas,vin.yaml | 46 ++++++++++++-------
> 1 file changed, 29 insertions(+), 17 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-03 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 12:45 [PATCH] dt-bindings: media: renesas,vin: Make resets optional on R-Car Gen1 Geert Uytterhoeven
2021-05-01 10:21 ` Niklas Söderlund
2021-05-03 20:02 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).