* [PATCH] media: mxl692: make a const array static, makes object smaller
@ 2021-05-05 19:06 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-05-05 19:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sean Young, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array fw_hdr on the stack but instead it
static. Makes the object code smaller by 5 bytes:
Before:
text data bss dec hex filename
31948 12072 64 44084 ac34 drivers/media/dvb-frontends/mxl692.o
After:
text data bss dec hex filename
31879 12136 64 44079 ac2f drivers/media/dvb-frontends/mxl692.o
(gcc version 10.3.0)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/dvb-frontends/mxl692.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/mxl692.c b/drivers/media/dvb-frontends/mxl692.c
index 83030643aba7..a246db683cdf 100644
--- a/drivers/media/dvb-frontends/mxl692.c
+++ b/drivers/media/dvb-frontends/mxl692.c
@@ -224,7 +224,9 @@ static int mxl692_validate_fw_header(struct mxl692_dev *dev,
u32 ix, temp;
__be32 *local_buf = NULL;
u8 temp_cksum = 0;
- const u8 fw_hdr[] = { 0x4D, 0x31, 0x10, 0x02, 0x40, 0x00, 0x00, 0x80 };
+ static const u8 fw_hdr[] = {
+ 0x4D, 0x31, 0x10, 0x02, 0x40, 0x00, 0x00, 0x80
+ };
if (memcmp(buffer, fw_hdr, 8) != 0) {
status = -EINVAL;
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-05 19:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 19:06 [PATCH] media: mxl692: make a const array static, makes object smaller Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).