Re: [PATCH v4 6/8] phy: HiSilicon: add driver for Kirin 970 PCIe PHY

Re: [PATCH v4 6/8] phy: HiSilicon: add driver for Kirin 970 PCIe PHY

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2800 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on robh/for-next linus/master v5.14-rc1 next-20210712]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20210713-054716
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c1d16aeb1efc7e49da9c7222fc98efcc07ddb5c3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20210713-054716
        git checkout c1d16aeb1efc7e49da9c7222fc98efcc07ddb5c3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/phy/hisilicon/phy-hi3670-pcie.c:178:6: warning: no previous prototype for 'hi3670_pcie_get_eyeparam' [-Wmissing-prototypes]
     178 | void hi3670_pcie_get_eyeparam(struct hi3670_pcie_phy *phy)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/hi3670_pcie_get_eyeparam +178 drivers/phy/hisilicon/phy-hi3670-pcie.c

   177	
 > 178	void hi3670_pcie_get_eyeparam(struct hi3670_pcie_phy *phy)
   179	{
   180		struct device *dev = phy->dev;
   181		struct device_node *np;
   182		int ret, i;
   183	
   184		np = dev->of_node;
   185	
   186		ret = of_property_read_u32_array(np, "hisilicon,eye-diagram-param",
   187						 phy->eye_param, NUM_EYEPARAM);
   188		if (!ret)
   189			return;
   190	
   191		/* There's no optional eye_param property. Set array to default */
   192		for (i = 0; i < NUM_EYEPARAM; i++)
   193			phy->eye_param[i] = EYEPARAM_NOCFG;
   194	}
   195	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55109 bytes --]