linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static
@ 2021-08-11  7:15 Eizan Miyamoto
  2021-08-16  4:26 ` houlong wei
  0 siblings, 1 reply; 3+ messages in thread
From: Eizan Miyamoto @ 2021-08-11  7:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: enric.balletbo, dafna.hirschfeld, Eizan Miyamoto, Andrew-CT Chen,
	Houlong Wei, Matthias Brugger, Mauro Carvalho Chehab,
	Minghsiu Tsai, linux-arm-kernel, linux-media, linux-mediatek

This function isn't and doesn't need to be used outside of
mtk_mdp_comp.c

This patch depends on and is a follow-up to
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929

Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
---

 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
 drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 9527649de98e..2cf8f1864f8c 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -234,7 +234,7 @@ static const struct component_ops mtk_mdp_component_ops = {
 	.unbind = mtk_mdp_comp_unbind,
 };
 
-int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
+static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
 {
 	struct device_node *larb_node;
 	struct platform_device *larb_pdev;
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
index e3d6aef52869..aa6442cc8c1d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
@@ -21,8 +21,6 @@ struct mtk_mdp_comp {
 	struct device		*larb_dev;
 };
 
-int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev);
-
 int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
 int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
 
-- 
2.32.0.605.g8dce9f2422-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static
  2021-08-11  7:15 [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static Eizan Miyamoto
@ 2021-08-16  4:26 ` houlong wei
  2022-04-27  8:05   ` Hans Verkuil
  0 siblings, 1 reply; 3+ messages in thread
From: houlong wei @ 2021-08-16  4:26 UTC (permalink / raw)
  To: Eizan Miyamoto, linux-kernel
  Cc: enric.balletbo, dafna.hirschfeld,
	Andrew-CT Chen (陳智迪),
	Matthias Brugger, Mauro Carvalho Chehab,
	Minghsiu Tsai (蔡明修),
	linux-arm-kernel, linux-media, linux-mediatek, houlong.wei

On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
> This function isn't and doesn't need to be used outside of
> mtk_mdp_comp.c
> 
> This patch depends on and is a follow-up to
> 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
> 
> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---

Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>

>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 9527649de98e..2cf8f1864f8c 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -234,7 +234,7 @@ static const struct component_ops
> mtk_mdp_component_ops = {
>  	.unbind = mtk_mdp_comp_unbind,
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
> device *dev)
>  {
>  	struct device_node *larb_node;
>  	struct platform_device *larb_pdev;
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index e3d6aef52869..aa6442cc8c1d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
>  	struct device		*larb_dev;
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
> *dev);
> -
>  int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
>  int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>  
> -- 
> 2.32.0.605.g8dce9f2422-goog
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static
  2021-08-16  4:26 ` houlong wei
@ 2022-04-27  8:05   ` Hans Verkuil
  0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2022-04-27  8:05 UTC (permalink / raw)
  To: houlong wei, Eizan Miyamoto, linux-kernel
  Cc: enric.balletbo, dafna.hirschfeld,
	Andrew-CT Chen (陳智迪),
	Matthias Brugger, Mauro Carvalho Chehab,
	Minghsiu Tsai (蔡明修),
	linux-arm-kernel, linux-media, linux-mediatek

Hi all,

Since the patch series this depends on hasn't been accepted (and using
the components framework is highly controversial in the media subsystem
anyway), I'm marking this (just as the patch series itself) as
'Changes Requested' in the media patchwork. If you want to continue
with this, then this patch should be folded into a v8.

Regards,

	Hans

On 16/08/2021 06:26, houlong wei wrote:
> On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
>> This function isn't and doesn't need to be used outside of
>> mtk_mdp_comp.c
>>
>> This patch depends on and is a follow-up to
>>
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
>>
>> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
>> ---
> 
> Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
> 
>>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
>>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
>>  2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> index 9527649de98e..2cf8f1864f8c 100644
>> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
>> @@ -234,7 +234,7 @@ static const struct component_ops
>> mtk_mdp_component_ops = {
>>  	.unbind = mtk_mdp_comp_unbind,
>>  };
>>  
>> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
>> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
>> device *dev)
>>  {
>>  	struct device_node *larb_node;
>>  	struct platform_device *larb_pdev;
>> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> index e3d6aef52869..aa6442cc8c1d 100644
>> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
>> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
>>  	struct device		*larb_dev;
>>  };
>>  
>> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
>> *dev);
>> -
>>  int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
>>  int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>>  
>> -- 
>> 2.32.0.605.g8dce9f2422-goog
>>


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-27  8:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11  7:15 [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static Eizan Miyamoto
2021-08-16  4:26 ` houlong wei
2022-04-27  8:05   ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).