* [PATCH v1] media: imx-jpeg: fix a bug of accessing array out of bounds
@ 2022-02-07 6:28 Ming Qian
0 siblings, 0 replies; only message in thread
From: Ming Qian @ 2022-02-07 6:28 UTC (permalink / raw)
To: mchehab, shawnguo, s.hauer, mirela.rabulea
Cc: hverkuil-cisco, kernel, festevam, linux-imx, linux-media,
linux-kernel, devicetree, linux-arm-kernel
When error occurs in parsing jpeg, the slot isn't acquired yet, it may
be the default value MXC_MAX_SLOTS.
If the driver access the slot using the incorrect slot number, it will
access array out of bounds.
The result is the driver will change num_domains, which follows
slot_data in struct mxc_jpeg_dev.
Then the driver won't detach the pm domain at rmmod, which will lead to
kernel panic when trying to insmod again.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
drivers/media/platform/imx-jpeg/mxc-jpeg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
index 7c0366f5f801..86d37d14cfe2 100644
--- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
@@ -948,7 +948,6 @@ static void mxc_jpeg_device_run(void *priv)
jpeg_src_buf = vb2_to_mxc_buf(&src_buf->vb2_buf);
if (jpeg_src_buf->jpeg_parse_error) {
- jpeg->slot_data[ctx->slot].used = false;
v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
--
2.33.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-07 6:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 6:28 [PATCH v1] media: imx-jpeg: fix a bug of accessing array out of bounds Ming Qian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).