linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* False 'uninitialized symbol' messages in latest smatch
@ 2022-03-11 13:22 Hans Verkuil
  2022-03-11 20:30 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2022-03-11 13:22 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: linux-media

Hi Dan,

With the latest smatch I get a lot of 'uninitialized symbol' errors that
all appear to be related to the use of the min/max/abs macros.

It's clearly seen here:

include/media/v4l2-rect.h:127 v4l2_rect_intersect() error: uninitialized symbol 'bottom'.
include/media/v4l2-rect.h:128 v4l2_rect_intersect() error: uninitialized symbol 'right'.

drivers/media/usb/uvc/uvc_v4l2.c:445 uvc_v4l2_set_streamparm() error: uninitialized symbol 'maxd'.
drivers/media/usb/uvc/uvc_v4l2.c:457 uvc_v4l2_set_streamparm() error: uninitialized symbol 'd'.

The logs of my daily media build from last night are here:

https://hverkuil.home.xs4all.nl/logs/Friday.log

Too many of these appear to be incorrect errors.

Can you take a look?

Regards,

	Hans

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: False 'uninitialized symbol' messages in latest smatch
  2022-03-11 13:22 False 'uninitialized symbol' messages in latest smatch Hans Verkuil
@ 2022-03-11 20:30 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-03-11 20:30 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

On Fri, Mar 11, 2022 at 02:22:53PM +0100, Hans Verkuil wrote:
> Hi Dan,
> 
> With the latest smatch I get a lot of 'uninitialized symbol' errors that
> all appear to be related to the use of the min/max/abs macros.
> 
> It's clearly seen here:
> 
> include/media/v4l2-rect.h:127 v4l2_rect_intersect() error: uninitialized symbol 'bottom'.
> include/media/v4l2-rect.h:128 v4l2_rect_intersect() error: uninitialized symbol 'right'.
> 
> drivers/media/usb/uvc/uvc_v4l2.c:445 uvc_v4l2_set_streamparm() error: uninitialized symbol 'maxd'.
> drivers/media/usb/uvc/uvc_v4l2.c:457 uvc_v4l2_set_streamparm() error: uninitialized symbol 'd'.
> 
> The logs of my daily media build from last night are here:
> 
> https://hverkuil.home.xs4all.nl/logs/Friday.log 
> 
> Too many of these appear to be incorrect errors.

Sorry, about that!  I've pushed a fix for it now.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-11 20:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 13:22 False 'uninitialized symbol' messages in latest smatch Hans Verkuil
2022-03-11 20:30 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).