* [PATCH 0/2] FIx compile-testing of Venus
@ 2022-07-13 11:03 Stanimir Varbanov
2022-07-13 11:03 ` [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms Stanimir Varbanov
2022-07-13 11:03 ` [PATCH 2/2] soc: qcom: smem: Fix compile-testing on dependent drivers Stanimir Varbanov
0 siblings, 2 replies; 4+ messages in thread
From: Stanimir Varbanov @ 2022-07-13 11:03 UTC (permalink / raw)
To: linux-media, linux-arm-msm, linux-kernel
Cc: Bjorn Andersson, Mauro Carvalho Chehab, Hans Verkuil, Stanimir Varbanov
Hello,
Here are two patches to fix COMPILE_TEST testing of Venus
driver on x86.
The first one is fixing Venus compilation. The second patch is
fixing unmet dependencies seen on QCOM smem driver when
dependent driver (like Venus) is enabled.
Comments are welcome!
regards,
Stan
Stanimir Varbanov (2):
venus: kconfig: Fix compile-testing on x86 platforms
soc: qcom: smem: Fix compile-testing on dependent drivers
drivers/media/platform/qcom/venus/Kconfig | 4 +++-
drivers/soc/qcom/Kconfig | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms
2022-07-13 11:03 [PATCH 0/2] FIx compile-testing of Venus Stanimir Varbanov
@ 2022-07-13 11:03 ` Stanimir Varbanov
2022-10-20 0:51 ` Bjorn Andersson
2022-07-13 11:03 ` [PATCH 2/2] soc: qcom: smem: Fix compile-testing on dependent drivers Stanimir Varbanov
1 sibling, 1 reply; 4+ messages in thread
From: Stanimir Varbanov @ 2022-07-13 11:03 UTC (permalink / raw)
To: linux-media, linux-arm-msm, linux-kernel
Cc: Bjorn Andersson, Mauro Carvalho Chehab, Hans Verkuil, Stanimir Varbanov
Fix Venus driver COMPILE_TEST compilation on x86 platform by
adding a dependacy on V4L_PLATFORM_DRIVERS and select QCOM_SMEM
instead of depending on it.
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
drivers/media/platform/qcom/venus/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig
index bfd50e8f3421..95814b175c3e 100644
--- a/drivers/media/platform/qcom/venus/Kconfig
+++ b/drivers/media/platform/qcom/venus/Kconfig
@@ -1,12 +1,14 @@
config VIDEO_QCOM_VENUS
tristate "Qualcomm Venus V4L2 encoder/decoder driver"
+ depends on V4L_PLATFORM_DRIVERS
depends on V4L_MEM2MEM_DRIVERS
- depends on VIDEO_DEV && QCOM_SMEM
+ depends on VIDEO_DEV
depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST
select QCOM_MDT_LOADER if ARCH_QCOM
select QCOM_SCM
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
+ select QCOM_SMEM
help
This is a V4L2 driver for Qualcomm Venus video accelerator
hardware. It accelerates encoding and decoding operations
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] soc: qcom: smem: Fix compile-testing on dependent drivers
2022-07-13 11:03 [PATCH 0/2] FIx compile-testing of Venus Stanimir Varbanov
2022-07-13 11:03 ` [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms Stanimir Varbanov
@ 2022-07-13 11:03 ` Stanimir Varbanov
1 sibling, 0 replies; 4+ messages in thread
From: Stanimir Varbanov @ 2022-07-13 11:03 UTC (permalink / raw)
To: linux-media, linux-arm-msm, linux-kernel
Cc: Bjorn Andersson, Mauro Carvalho Chehab, Hans Verkuil, Stanimir Varbanov
Fix following unmet dependencies seen when compile-testing
Venus driver:
WARNING: unmet direct dependencies detected for QCOM_SMEM
Depends on [n]: (ARCH_QCOM || COMPILE_TEST [=y]) && HWSPINLOCK [=n]
Selected by [m]:
- VIDEO_QCOM_VENUS [=m] && MEDIA_SUPPORT [=m] &&
MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] &&
V4L_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=y] &&
VIDEO_DEV [=m] && (ARCH_QCOM && IOMMU_DMA [=y] || COMPILE_TEST [=y])
by select HWSPINLOCK instead of depend on it.
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
drivers/soc/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index e718b8735444..68f29452e5fa 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -139,7 +139,7 @@ config QCOM_RPMPD
config QCOM_SMEM
tristate "Qualcomm Shared Memory Manager (SMEM)"
depends on ARCH_QCOM || COMPILE_TEST
- depends on HWSPINLOCK
+ select HWSPINLOCK
help
Say y here to enable support for the Qualcomm Shared Memory Manager.
The driver provides an interface to items in a heap shared among all
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms
2022-07-13 11:03 ` [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms Stanimir Varbanov
@ 2022-10-20 0:51 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-10-20 0:51 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: linux-media, linux-arm-msm, linux-kernel, Bjorn Andersson,
Mauro Carvalho Chehab, Hans Verkuil
On Wed, Jul 13, 2022 at 02:03:50PM +0300, Stanimir Varbanov wrote:
> Fix Venus driver COMPILE_TEST compilation on x86 platform by
> adding a dependacy on V4L_PLATFORM_DRIVERS and select QCOM_SMEM
> instead of depending on it.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> drivers/media/platform/qcom/venus/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig
> index bfd50e8f3421..95814b175c3e 100644
> --- a/drivers/media/platform/qcom/venus/Kconfig
> +++ b/drivers/media/platform/qcom/venus/Kconfig
> @@ -1,12 +1,14 @@
> config VIDEO_QCOM_VENUS
> tristate "Qualcomm Venus V4L2 encoder/decoder driver"
> + depends on V4L_PLATFORM_DRIVERS
> depends on V4L_MEM2MEM_DRIVERS
> - depends on VIDEO_DEV && QCOM_SMEM
> + depends on VIDEO_DEV
> depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST
> select QCOM_MDT_LOADER if ARCH_QCOM
> select QCOM_SCM
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> + select QCOM_SMEM
QCOM_SMEM is user selectable, and it's a fairly broadly used API. So I
would prefer that we introduce stub functions in linux/soc/qcom/smem.h.
Regards,
Bjorn
> help
> This is a V4L2 driver for Qualcomm Venus video accelerator
> hardware. It accelerates encoding and decoding operations
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-20 0:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 11:03 [PATCH 0/2] FIx compile-testing of Venus Stanimir Varbanov
2022-07-13 11:03 ` [PATCH 1/2] venus: kconfig: Fix compile-testing on x86 platforms Stanimir Varbanov
2022-10-20 0:51 ` Bjorn Andersson
2022-07-13 11:03 ` [PATCH 2/2] soc: qcom: smem: Fix compile-testing on dependent drivers Stanimir Varbanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).