* [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER
@ 2022-08-12 22:00 Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 2/6] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni, kernel test robot
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
It also selects PHY_SUN6I_MIPI_DPHY, which depends on RESET_CONTROLLER.
Fixes: af54b4f4c17f ("media: sunxi: Add support for the A31 MIPI CSI-2 controller")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
index eb982466abd3..781aedbe1e30 100644
--- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
+++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
@@ -3,7 +3,7 @@ config VIDEO_SUN6I_MIPI_CSI2
tristate "Allwinner A31 MIPI CSI-2 Controller Driver"
depends on V4L_PLATFORM_DRIVERS && VIDEO_DEV
depends on ARCH_SUNXI || COMPILE_TEST
- depends on PM && COMMON_CLK
+ depends on PM && COMMON_CLK && RESET_CONTROLLER
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/6] media: sun8i-a83t-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
@ 2022-08-12 22:00 ` Paul Kocialkowski
2022-08-14 6:46 ` Jernej Škrabec
2022-08-12 22:00 ` [PATCH 3/6] media: sun6i-csi: " Paul Kocialkowski
` (4 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
index 789d58ee12ea..47a8c0fb7eb9 100644
--- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
+++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
@@ -3,7 +3,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
tristate "Allwinner A83T MIPI CSI-2 Controller and D-PHY Driver"
depends on V4L_PLATFORM_DRIVERS && VIDEO_DEV
depends on ARCH_SUNXI || COMPILE_TEST
- depends on PM && COMMON_CLK
+ depends on PM && COMMON_CLK && RESET_CONTROLLER
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/6] media: sun6i-csi: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 2/6] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski
@ 2022-08-12 22:00 ` Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 4/6] media: sun4i-csi: " Paul Kocialkowski
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/platform/sunxi/sun6i-csi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun6i-csi/Kconfig b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
index 0345901617d4..e5b6991ce7f0 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/Kconfig
+++ b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
@@ -2,7 +2,7 @@
config VIDEO_SUN6I_CSI
tristate "Allwinner V3s Camera Sensor Interface driver"
depends on V4L_PLATFORM_DRIVERS
- depends on VIDEO_DEV && COMMON_CLK && HAS_DMA
+ depends on VIDEO_DEV && COMMON_CLK && RESET_CONTROLLER && HAS_DMA
depends on ARCH_SUNXI || COMPILE_TEST
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/6] media: sun4i-csi: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 2/6] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 3/6] media: sun6i-csi: " Paul Kocialkowski
@ 2022-08-12 22:00 ` Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 5/6] media: sun8i-di: " Paul Kocialkowski
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/platform/sunxi/sun4i-csi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun4i-csi/Kconfig b/drivers/media/platform/sunxi/sun4i-csi/Kconfig
index 7960e6836f41..60610c04d6a7 100644
--- a/drivers/media/platform/sunxi/sun4i-csi/Kconfig
+++ b/drivers/media/platform/sunxi/sun4i-csi/Kconfig
@@ -3,7 +3,7 @@
config VIDEO_SUN4I_CSI
tristate "Allwinner A10 CMOS Sensor Interface Support"
depends on V4L_PLATFORM_DRIVERS
- depends on VIDEO_DEV && COMMON_CLK && HAS_DMA
+ depends on VIDEO_DEV && COMMON_CLK && RESET_CONTROLLER && HAS_DMA
depends on ARCH_SUNXI || COMPILE_TEST
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/6] media: sun8i-di: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
` (2 preceding siblings ...)
2022-08-12 22:00 ` [PATCH 4/6] media: sun4i-csi: " Paul Kocialkowski
@ 2022-08-12 22:00 ` Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 6/6] media: sun8i-rotate: " Paul Kocialkowski
2022-08-14 6:42 ` [PATCH 1/6] media: sun6i-mipi-csi2: " Jernej Škrabec
5 siblings, 0 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/platform/sunxi/sun8i-di/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun8i-di/Kconfig b/drivers/media/platform/sunxi/sun8i-di/Kconfig
index ff71e06ee2df..f688396913b7 100644
--- a/drivers/media/platform/sunxi/sun8i-di/Kconfig
+++ b/drivers/media/platform/sunxi/sun8i-di/Kconfig
@@ -4,7 +4,7 @@ config VIDEO_SUN8I_DEINTERLACE
depends on V4L_MEM2MEM_DRIVERS
depends on VIDEO_DEV
depends on ARCH_SUNXI || COMPILE_TEST
- depends on COMMON_CLK && OF
+ depends on COMMON_CLK && RESET_CONTROLLER && OF
depends on PM
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 6/6] media: sun8i-rotate: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
` (3 preceding siblings ...)
2022-08-12 22:00 ` [PATCH 5/6] media: sun8i-di: " Paul Kocialkowski
@ 2022-08-12 22:00 ` Paul Kocialkowski
2022-08-14 6:42 ` [PATCH 1/6] media: sun6i-mipi-csi2: " Jernej Škrabec
5 siblings, 0 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-12 22:00 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
The driver relies on the reset controller API to work, so add
RESET_CONTROLLER as one of its Kconfig dependencies.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/platform/sunxi/sun8i-rotate/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun8i-rotate/Kconfig b/drivers/media/platform/sunxi/sun8i-rotate/Kconfig
index cfba29072d75..ee2c1f248c64 100644
--- a/drivers/media/platform/sunxi/sun8i-rotate/Kconfig
+++ b/drivers/media/platform/sunxi/sun8i-rotate/Kconfig
@@ -5,7 +5,7 @@ config VIDEO_SUN8I_ROTATE
depends on V4L_MEM2MEM_DRIVERS
depends on VIDEO_DEV
depends on ARCH_SUNXI || COMPILE_TEST
- depends on COMMON_CLK && OF
+ depends on COMMON_CLK && RESET_CONTROLLER && OF
depends on PM
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
` (4 preceding siblings ...)
2022-08-12 22:00 ` [PATCH 6/6] media: sun8i-rotate: " Paul Kocialkowski
@ 2022-08-14 6:42 ` Jernej Škrabec
5 siblings, 0 replies; 9+ messages in thread
From: Jernej Škrabec @ 2022-08-14 6:42 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel,
Paul Kocialkowski
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni, kernel test robot
Dne sobota, 13. avgust 2022 ob 00:00:40 CEST je Paul Kocialkowski napisal(a):
> The driver relies on the reset controller API to work, so add
> RESET_CONTROLLER as one of its Kconfig dependencies.
>
> It also selects PHY_SUN6I_MIPI_DPHY, which depends on RESET_CONTROLLER.
>
> Fixes: af54b4f4c17f ("media: sunxi: Add support for the A31 MIPI CSI-2
> controller") Signed-off-by: Paul Kocialkowski
> <paul.kocialkowski@bootlin.com>
> Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/6] media: sun8i-a83t-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-12 22:00 ` [PATCH 2/6] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski
@ 2022-08-14 6:46 ` Jernej Škrabec
2022-08-22 13:47 ` Paul Kocialkowski
0 siblings, 1 reply; 9+ messages in thread
From: Jernej Škrabec @ 2022-08-14 6:46 UTC (permalink / raw)
To: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel,
Paul Kocialkowski
Cc: Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Samuel Holland, Paul Kocialkowski, Hans Verkuil,
Thomas Petazzoni
Dne sobota, 13. avgust 2022 ob 00:00:41 CEST je Paul Kocialkowski napisal(a):
> The driver relies on the reset controller API to work, so add
> RESET_CONTROLLER as one of its Kconfig dependencies.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Please add fixes tag here and in the rest of the series.
Best regards,
Jernej
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/6] media: sun8i-a83t-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER
2022-08-14 6:46 ` Jernej Škrabec
@ 2022-08-22 13:47 ` Paul Kocialkowski
0 siblings, 0 replies; 9+ messages in thread
From: Paul Kocialkowski @ 2022-08-22 13:47 UTC (permalink / raw)
To: Jernej Škrabec
Cc: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel,
Maxime Ripard, Mauro Carvalho Chehab, Chen-Yu Tsai,
Samuel Holland, Hans Verkuil, Thomas Petazzoni
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
Hi Jernej,
On Sun 14 Aug 22, 08:46, Jernej Škrabec wrote:
> Dne sobota, 13. avgust 2022 ob 00:00:41 CEST je Paul Kocialkowski napisal(a):
> > The driver relies on the reset controller API to work, so add
> > RESET_CONTROLLER as one of its Kconfig dependencies.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>
> Please add fixes tag here and in the rest of the series.
Okay I wasn't sure it was worth it since there is no build-time requirement
and no Kconfig select/depend issue here.
But I guess it doesn't hurt, so will do.
Thanks,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-22 13:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 22:00 [PATCH 1/6] media: sun6i-mipi-csi2: Add a Kconfig dependency on RESET_CONTROLLER Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 2/6] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski
2022-08-14 6:46 ` Jernej Škrabec
2022-08-22 13:47 ` Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 3/6] media: sun6i-csi: " Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 4/6] media: sun4i-csi: " Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 5/6] media: sun8i-di: " Paul Kocialkowski
2022-08-12 22:00 ` [PATCH 6/6] media: sun8i-rotate: " Paul Kocialkowski
2022-08-14 6:42 ` [PATCH 1/6] media: sun6i-mipi-csi2: " Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).