* [PATCH -next] media: stm32: dcmi: Remove redundant dev_err call
@ 2022-09-23 10:07 Shang XiaoJing
2022-09-26 7:33 ` Hugues FRUCHET
0 siblings, 1 reply; 2+ messages in thread
From: Shang XiaoJing @ 2022-09-23 10:07 UTC (permalink / raw)
To: hugues.fruchet, mchehab, mcoquelin.stm32, alexandre.torgue,
linux-media, linux-stm32, linux-arm-kernel
Cc: shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
drivers/media/platform/st/stm32/stm32-dcmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
index 2ca95ab2b0fe..70e1b6af0448 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
@@ -1997,10 +1997,8 @@ static int dcmi_probe(struct platform_device *pdev)
}
dcmi->regs = devm_ioremap_resource(&pdev->dev, dcmi->res);
- if (IS_ERR(dcmi->regs)) {
- dev_err(&pdev->dev, "Could not map registers\n");
+ if (IS_ERR(dcmi->regs))
return PTR_ERR(dcmi->regs);
- }
mclk = devm_clk_get(&pdev->dev, "mclk");
if (IS_ERR(mclk)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: stm32: dcmi: Remove redundant dev_err call
2022-09-23 10:07 [PATCH -next] media: stm32: dcmi: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-26 7:33 ` Hugues FRUCHET
0 siblings, 0 replies; 2+ messages in thread
From: Hugues FRUCHET @ 2022-09-26 7:33 UTC (permalink / raw)
To: Shang XiaoJing, mchehab, mcoquelin.stm32, alexandre.torgue,
linux-media, linux-stm32, linux-arm-kernel
Hi Shang,
Thanks for the patch:
Acked-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
BR,
Hugues.
On 9/23/22 12:07, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
> drivers/media/platform/st/stm32/stm32-dcmi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 2ca95ab2b0fe..70e1b6af0448 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -1997,10 +1997,8 @@ static int dcmi_probe(struct platform_device *pdev)
> }
>
> dcmi->regs = devm_ioremap_resource(&pdev->dev, dcmi->res);
> - if (IS_ERR(dcmi->regs)) {
> - dev_err(&pdev->dev, "Could not map registers\n");
> + if (IS_ERR(dcmi->regs))
> return PTR_ERR(dcmi->regs);
> - }
>
> mclk = devm_clk_get(&pdev->dev, "mclk");
> if (IS_ERR(mclk)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 10:07 [PATCH -next] media: stm32: dcmi: Remove redundant dev_err call Shang XiaoJing
2022-09-26 7:33 ` Hugues FRUCHET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).