[PATCH 0/2] media: Fix p_s32 and p_s64 pointer types

[PATCH 0/2] media: Fix p_s32 and p_s64 pointer types

[Daniel Lundberg Pedersen]

Unless I'm misunderstanding something then there is no reason to have
p_s32 and p_s64 in struct v4l2_ext_control be of type __u32* instead of
__s32* and __s64* respectively.

So this series fixes that and updates the documentation.

Daniel Lundberg Pedersen (2):
  media: videodev2.h: Fix p_s32 and p_s64 pointer types
  media: docs: vidioc-g-ext-ctrls.rst: Update p_s32 and p_s64 types

 Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4 ++--
 include/uapi/linux/videodev2.h                               | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

--
2.38.4

[PATCH 1/2] media: videodev2.h: Fix p_s32 and p_s64 pointer types

[Daniel Lundberg Pedersen]

Use the intended pointer types for p_s32 and p_64 in the union of the
struct v4l2_ext_control.

Fixes: e77eb66342c7 ("videodev2.h: add p_s32 and p_s64 pointers")
Signed-off-by: Daniel Lundberg Pedersen <dlp@qtec.com>
---
 include/uapi/linux/videodev2.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index aee75eb9e686..9e7cf1d36945 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -1807,8 +1807,8 @@ struct v4l2_ext_control {
 		__u8 __user *p_u8;
 		__u16 __user *p_u16;
 		__u32 __user *p_u32;
-		__u32 __user *p_s32;
-		__u32 __user *p_s64;
+		__s32 __user *p_s32;
+		__s64 __user *p_s64;
 		struct v4l2_area __user *p_area;
 		struct v4l2_ctrl_h264_sps __user *p_h264_sps;
 		struct v4l2_ctrl_h264_pps *p_h264_pps;
-- 
2.38.4

[PATCH 2/2] media: docs: vidioc-g-ext-ctrls.rst: Update p_s32 and p_s64 types

[Daniel Lundberg Pedersen]

The pointer types of p_s32 and p_s64 in v4l2_ext_control has been
updated, match the change in documentation.
---
 Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
index 5292d5e1a91f..6d85ec6a19b4 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
@@ -185,12 +185,12 @@ still cause this situation.
       - ``p_u32``
       - A pointer to a matrix control of unsigned 32-bit values. Valid if
 	this control is of type ``V4L2_CTRL_TYPE_U32``.
-    * - __u32 *
+    * - __s32 *
       - ``p_s32``
       - A pointer to a matrix control of signed 32-bit values. Valid if
         this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and
         ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set.
-    * - __u32 *
+    * - __s64 *
       - ``p_s64``
       - A pointer to a matrix control of signed 64-bit values. Valid if
         this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and
-- 
2.38.4

Re: [PATCH 2/2] media: docs: vidioc-g-ext-ctrls.rst: Update p_s32 and p_s64 types

[Daniel Lundberg Pedersen]

Forgot Signed-off-by.

Signed-off-by: Daniel Lundberg Pedersen <dlp@qtec.com>

On 01/05/2023 16:57, Daniel Lundberg Pedersen wrote:
> The pointer types of p_s32 and p_s64 in v4l2_ext_control has been
> updated, match the change in documentation.
> ---
>  Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> index 5292d5e1a91f..6d85ec6a19b4 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> @@ -185,12 +185,12 @@ still cause this situation.
>        - ``p_u32``
>        - A pointer to a matrix control of unsigned 32-bit values. Valid if
>  	this control is of type ``V4L2_CTRL_TYPE_U32``.
> -    * - __u32 *
> +    * - __s32 *
>        - ``p_s32``
>        - A pointer to a matrix control of signed 32-bit values. Valid if
>          this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and
>          ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set.
> -    * - __u32 *
> +    * - __s64 *
>        - ``p_s64``
>        - A pointer to a matrix control of signed 64-bit values. Valid if
>          this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and