linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
	Philipp Zabel <p.zabel@pengutronix.de>,
	hverkuil@xs4all.nl, Francesco Dolcini <francesco@dolcini.it>,
	aishwarya.kothari@toradex.com, Robert Foss <rfoss@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Hyun Kwon <hyun.kwon@xilinx.com>,
	bingbu.cao@intel.com, niklas.soderlund@ragnatech.se,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Maxime Ripard <mripard@kernel.org>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Dafna Hirschfeld <dafna@fastmail.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Yong Deng <yong.deng@magewell.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	Benoit Parrot <bparrot@ti.com>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Marco Felsch <m.felsch@pengutronix.de>
Subject: [RESEND PATCH v3 29/32] media: davinci: Init async notifier after registering V4L2 device
Date: Thu, 25 May 2023 12:16:12 +0300	[thread overview]
Message-ID: <20230525091615.2324824-30-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20230525091615.2324824-1-sakari.ailus@linux.intel.com>

Initialise the V4L2 async notifier after registering the V4L2 device, just
before parsing DT for async sub-devices. This way struct device is
available to the notifier right from the beginning which makes it possible
to use it for debug prints.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 .../media/platform/ti/davinci/vpif_capture.c    | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
index a63c9e51dac41..9b97e26be0892 100644
--- a/drivers/media/platform/ti/davinci/vpif_capture.c
+++ b/drivers/media/platform/ti/davinci/vpif_capture.c
@@ -1608,18 +1608,12 @@ static __init int vpif_probe(struct platform_device *pdev)
 	int res_idx = 0;
 	int i, err;
 
-	pdev->dev.platform_data = vpif_capture_get_pdata(pdev);
-	if (!pdev->dev.platform_data) {
-		dev_warn(&pdev->dev, "Missing platform data.  Giving up.\n");
-		return -EINVAL;
-	}
-
 	vpif_dev = &pdev->dev;
 
 	err = initialize_vpif();
 	if (err) {
 		v4l2_err(vpif_dev->driver, "Error initializing vpif\n");
-		goto cleanup;
+		return err;
 	}
 
 	err = v4l2_device_register(vpif_dev, &vpif_obj.v4l2_dev);
@@ -1655,6 +1649,12 @@ static __init int vpif_probe(struct platform_device *pdev)
 		goto vpif_unregister;
 	}
 
+	pdev->dev.platform_data = vpif_capture_get_pdata(pdev);
+	if (!pdev->dev.platform_data) {
+		dev_warn(&pdev->dev, "Missing platform data.  Giving up.\n");
+		goto probe_subdev_out;
+	}
+
 	if (!vpif_obj.config->asd_sizes[0]) {
 		int i2c_id = vpif_obj.config->i2c_adapter_id;
 
@@ -1695,14 +1695,13 @@ static __init int vpif_probe(struct platform_device *pdev)
 	return 0;
 
 probe_subdev_out:
+	v4l2_async_nf_cleanup(&vpif_obj.notifier);
 	/* free sub devices memory */
 	kfree(vpif_obj.sd);
 vpif_unregister:
 	v4l2_device_unregister(&vpif_obj.v4l2_dev);
 vpif_free:
 	free_vpif_objs();
-cleanup:
-	v4l2_async_nf_cleanup(&vpif_obj.notifier);
 
 	return err;
 }
-- 
2.30.2


  parent reply	other threads:[~2023-05-25  9:17 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  9:15 [RESEND PATCH v3 00/32] Separate links and async sub-devices Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 01/32] media: v4l: async: Drop v4l2_async_nf_parse_fwnode_endpoints() Sakari Ailus
2023-05-30  2:13   ` Laurent Pinchart
2023-05-25  9:15 ` [RESEND PATCH v3 02/32] media: Documentation: v4l: Document missing async subdev function Sakari Ailus
2023-05-30  2:14   ` Laurent Pinchart
2023-06-13 13:43     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 03/32] media: xilinx-vipp: Clean up bound async notifier callback Sakari Ailus
2023-05-30  2:20   ` Laurent Pinchart
2023-05-30  2:21   ` Laurent Pinchart
2023-05-25  9:15 ` [RESEND PATCH v3 04/32] media: omap3isp: Don't check for the sub-device's notifier Sakari Ailus
2023-05-30  2:23   ` Laurent Pinchart
2023-06-13 13:19     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 05/32] media: v4l: async: Add some debug prints Sakari Ailus
2023-05-30  2:34   ` Laurent Pinchart
2023-05-25  9:15 ` [RESEND PATCH v3 06/32] media: v4l: async: Clean up testing for duplicate async subdevs Sakari Ailus
2023-05-30  2:42   ` Laurent Pinchart
2023-06-13 13:57     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 07/32] media: v4l: async: Drop unneeded list entry initialisation Sakari Ailus
2023-05-30  2:46   ` Laurent Pinchart
2023-06-13 14:00     ` Sakari Ailus
2023-06-13 14:08       ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 08/32] media: v4l: async: Don't check whether asd is NULL in validity check Sakari Ailus
2023-05-30  2:48   ` Laurent Pinchart
2023-05-25  9:15 ` [RESEND PATCH v3 09/32] media: v4l: async: Make V4L2 async match information a struct Sakari Ailus
2023-05-30  2:52   ` Laurent Pinchart
2023-06-13 14:35     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 10/32] media: v4l: async: Rename V4L2_ASYNC_MATCH_ macros, add TYPE_ Sakari Ailus
2023-05-30  2:55   ` Laurent Pinchart
2023-05-25  9:15 ` [RESEND PATCH v3 11/32] media: v4l: async: Only pass match information for async subdev validation Sakari Ailus
2023-05-30  3:02   ` Laurent Pinchart
2023-06-13 14:37     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 12/32] media: v4l: async: Clean up list heads and entries Sakari Ailus
2023-05-30  3:09   ` Laurent Pinchart
2023-05-30  5:40     ` Laurent Pinchart
2023-06-13 14:58       ` Sakari Ailus
2023-06-13 14:51     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 13/32] media: v4l: async: Simplify async sub-device fwnode matching Sakari Ailus
2023-05-30  5:08   ` Laurent Pinchart
2023-06-13 15:10     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 14/32] media: v4l: async: Rename v4l2_async_subdev as v4l2_async_connection Sakari Ailus
2023-05-30  5:50   ` Laurent Pinchart
2023-06-13 16:39     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 15/32] media: v4l: async: Clean up error handling in v4l2_async_match_notify Sakari Ailus
2023-05-30  5:52   ` Laurent Pinchart
2023-06-13 16:55     ` Sakari Ailus
2023-05-25  9:15 ` [RESEND PATCH v3 16/32] media: v4l: async: Drop duplicate handling when adding connections Sakari Ailus
2023-05-30  6:01   ` Laurent Pinchart
2023-06-13 16:58     ` Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 17/32] media: v4l: async: Rework internal lists Sakari Ailus
2023-05-30  6:11   ` Laurent Pinchart
2023-06-22 12:02     ` Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 18/32] media: v4l: async: Obtain async connection based on sub-device Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 19/32] media: v4l: async: Allow multiple connections between entities Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 20/32] media: v4l: async: Try more connections Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 21/32] media: v4l: async: Support fwnode endpoint list matching for subdevs Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 22/32] media: adv748x: Return to endpoint matching Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 23/32] media: pxa_camera: Fix probe error handling Sakari Ailus
2023-05-30  4:51   ` Laurent Pinchart
2023-06-21 15:43     ` Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 24/32] media: pxa_camera: Register V4L2 device early Sakari Ailus
2023-05-30  4:54   ` Laurent Pinchart
2023-05-30  4:56     ` Laurent Pinchart
2023-06-13 15:08       ` Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 25/32] media: marvell: cafe: Register V4L2 device earlier Sakari Ailus
2023-05-30  5:00   ` Laurent Pinchart
2023-06-20  9:43     ` Sakari Ailus
2023-06-20 16:50       ` Laurent Pinchart
2023-05-25  9:16 ` [RESEND PATCH v3 26/32] media: am437x-vpfe: Register V4L2 device early Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 27/32] media: omap3isp: Initialise V4L2 async notifier later Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 28/32] media: xilinx-vipp: Init async notifier after registering V4L2 device Sakari Ailus
2023-05-25  9:16 ` Sakari Ailus [this message]
2023-05-25  9:16 ` [RESEND PATCH v3 30/32] media: qcom: Initialise V4L2 async notifier later Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 31/32] media: v4l: async: Set v4l2_device in async notifier init Sakari Ailus
2023-05-30  6:22   ` Laurent Pinchart
2023-06-14 12:43     ` Sakari Ailus
2023-05-25  9:16 ` [RESEND PATCH v3 32/32] media: Documentation: v4l: Document sub-device notifiers Sakari Ailus
2023-05-30  6:18   ` Laurent Pinchart
2023-06-20 10:14     ` Sakari Ailus
2023-05-30 12:13   ` Aishwarya Kothari
2023-05-25  9:22 ` [RESEND PATCH v3 00/32] Separate links and async sub-devices Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525091615.2324824-30-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=aishwarya.kothari@toradex.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=bingbu.cao@intel.com \
    --cc=bparrot@ti.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=dafna@fastmail.com \
    --cc=eugen.hristev@collabora.com \
    --cc=festevam@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=hugues.fruchet@foss.st.com \
    --cc=hverkuil@xs4all.nl \
    --cc=hyun.kwon@xilinx.com \
    --cc=jonathanh@nvidia.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mripard@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=rfoss@kernel.org \
    --cc=rmfrfs@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=skomatineni@nvidia.com \
    --cc=slongerbeam@gmail.com \
    --cc=sylvain.petinot@foss.st.com \
    --cc=thierry.reding@gmail.com \
    --cc=todor.too@gmail.com \
    --cc=yong.deng@magewell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).