From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
hverkuil@xs4all.nl, Francesco Dolcini <francesco@dolcini.it>,
aishwarya.kothari@toradex.com, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
bingbu.cao@intel.com, niklas.soderlund@ragnatech.se,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Eugen Hristev <eugen.hristev@collabora.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Maxime Ripard <mripard@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Dafna Hirschfeld <dafna@fastmail.com>,
Hugues Fruchet <hugues.fruchet@foss.st.com>,
Yong Deng <yong.deng@magewell.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Benoit Parrot <bparrot@ti.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Marco Felsch <m.felsch@pengutronix.de>
Subject: Re: [RESEND PATCH v3 06/32] media: v4l: async: Clean up testing for duplicate async subdevs
Date: Tue, 30 May 2023 05:42:29 +0300 [thread overview]
Message-ID: <20230530024229.GG21633@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230525091615.2324824-7-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Thu, May 25, 2023 at 12:15:49PM +0300, Sakari Ailus wrote:
> There's a need to verify that a single async sub-device isn't being added
> multiple times, this would be an error. This takes place at the time of
> adding the async sub-device to the notifier's list as well as when the
> notifier is added to the global notifier's list.
>
> Use the pointer to the sub-device for testing this instead of an index to
> an array that is long gone. (There was an array of async sub-devices in
> the notifier before it was converted to a linked list by commit
> 66beb323e4a0 ("media: v4l2: async: Remove notifier subdevs array").
Unbalanced opening and closing parentheses.
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/v4l2-core/v4l2-async.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index c5781124337af..320fe5cbaaf41 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -520,21 +520,19 @@ __v4l2_async_nf_has_async_subdev(struct v4l2_async_notifier *notifier,
>
> /*
> * Find out whether an async sub-device was set up already or
> - * whether it exists in a given notifier before @this_index.
> - * If @this_index < 0, search the notifier's entire @asd_list.
> + * whether it exists in a given notifier.
Please document what the skip_self parameter does. The parameter name
doesn't match the 'break' in the test below, I was expecting a
'continue'. If my expectation is wrong documentation should help, if
it's correct, then you can fix the code :-)
> */
> static bool
> v4l2_async_nf_has_async_subdev(struct v4l2_async_notifier *notifier,
> - struct v4l2_async_subdev *asd, int this_index)
> + struct v4l2_async_subdev *asd, bool skip_self)
> {
> struct v4l2_async_subdev *asd_y;
> - int j = 0;
>
> lockdep_assert_held(&list_lock);
>
> /* Check that an asd is not being added more than once. */
> list_for_each_entry(asd_y, ¬ifier->asd_list, asd_list) {
> - if (this_index >= 0 && j++ >= this_index)
> + if (skip_self && asd == asd_y)
> break;
> if (asd_equal(asd, asd_y))
> return true;
> @@ -550,7 +548,7 @@ v4l2_async_nf_has_async_subdev(struct v4l2_async_notifier *notifier,
>
> static int v4l2_async_nf_asd_valid(struct v4l2_async_notifier *notifier,
> struct v4l2_async_subdev *asd,
> - int this_index)
> + bool skip_self)
> {
> struct device *dev = notifier_dev(notifier);
>
> @@ -560,7 +558,7 @@ static int v4l2_async_nf_asd_valid(struct v4l2_async_notifier *notifier,
> switch (asd->match_type) {
> case V4L2_ASYNC_MATCH_I2C:
> case V4L2_ASYNC_MATCH_FWNODE:
> - if (v4l2_async_nf_has_async_subdev(notifier, asd, this_index)) {
> + if (v4l2_async_nf_has_async_subdev(notifier, asd, skip_self)) {
> dev_dbg(dev, "v4l2-async: subdev descriptor already listed in a notifier\n");
> return -EEXIST;
> }
> @@ -583,7 +581,7 @@ EXPORT_SYMBOL(v4l2_async_nf_init);
> static int __v4l2_async_nf_register(struct v4l2_async_notifier *notifier)
> {
> struct v4l2_async_subdev *asd;
> - int ret, i = 0;
> + int ret;
>
> INIT_LIST_HEAD(¬ifier->waiting);
> INIT_LIST_HEAD(¬ifier->done);
> @@ -591,7 +589,7 @@ static int __v4l2_async_nf_register(struct v4l2_async_notifier *notifier)
> mutex_lock(&list_lock);
>
> list_for_each_entry(asd, ¬ifier->asd_list, asd_list) {
> - ret = v4l2_async_nf_asd_valid(notifier, asd, i++);
> + ret = v4l2_async_nf_asd_valid(notifier, asd, true);
> if (ret)
> goto err_unlock;
>
> @@ -725,7 +723,7 @@ static int __v4l2_async_nf_add_subdev(struct v4l2_async_notifier *notifier,
>
> mutex_lock(&list_lock);
>
> - ret = v4l2_async_nf_asd_valid(notifier, asd, -1);
> + ret = v4l2_async_nf_asd_valid(notifier, asd, false);
> if (ret)
> goto unlock;
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-05-30 2:42 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:15 [RESEND PATCH v3 00/32] Separate links and async sub-devices Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 01/32] media: v4l: async: Drop v4l2_async_nf_parse_fwnode_endpoints() Sakari Ailus
2023-05-30 2:13 ` Laurent Pinchart
2023-05-25 9:15 ` [RESEND PATCH v3 02/32] media: Documentation: v4l: Document missing async subdev function Sakari Ailus
2023-05-30 2:14 ` Laurent Pinchart
2023-06-13 13:43 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 03/32] media: xilinx-vipp: Clean up bound async notifier callback Sakari Ailus
2023-05-30 2:20 ` Laurent Pinchart
2023-05-30 2:21 ` Laurent Pinchart
2023-05-25 9:15 ` [RESEND PATCH v3 04/32] media: omap3isp: Don't check for the sub-device's notifier Sakari Ailus
2023-05-30 2:23 ` Laurent Pinchart
2023-06-13 13:19 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 05/32] media: v4l: async: Add some debug prints Sakari Ailus
2023-05-30 2:34 ` Laurent Pinchart
2023-05-25 9:15 ` [RESEND PATCH v3 06/32] media: v4l: async: Clean up testing for duplicate async subdevs Sakari Ailus
2023-05-30 2:42 ` Laurent Pinchart [this message]
2023-06-13 13:57 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 07/32] media: v4l: async: Drop unneeded list entry initialisation Sakari Ailus
2023-05-30 2:46 ` Laurent Pinchart
2023-06-13 14:00 ` Sakari Ailus
2023-06-13 14:08 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 08/32] media: v4l: async: Don't check whether asd is NULL in validity check Sakari Ailus
2023-05-30 2:48 ` Laurent Pinchart
2023-05-25 9:15 ` [RESEND PATCH v3 09/32] media: v4l: async: Make V4L2 async match information a struct Sakari Ailus
2023-05-30 2:52 ` Laurent Pinchart
2023-06-13 14:35 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 10/32] media: v4l: async: Rename V4L2_ASYNC_MATCH_ macros, add TYPE_ Sakari Ailus
2023-05-30 2:55 ` Laurent Pinchart
2023-05-25 9:15 ` [RESEND PATCH v3 11/32] media: v4l: async: Only pass match information for async subdev validation Sakari Ailus
2023-05-30 3:02 ` Laurent Pinchart
2023-06-13 14:37 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 12/32] media: v4l: async: Clean up list heads and entries Sakari Ailus
2023-05-30 3:09 ` Laurent Pinchart
2023-05-30 5:40 ` Laurent Pinchart
2023-06-13 14:58 ` Sakari Ailus
2023-06-13 14:51 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 13/32] media: v4l: async: Simplify async sub-device fwnode matching Sakari Ailus
2023-05-30 5:08 ` Laurent Pinchart
2023-06-13 15:10 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 14/32] media: v4l: async: Rename v4l2_async_subdev as v4l2_async_connection Sakari Ailus
2023-05-30 5:50 ` Laurent Pinchart
2023-06-13 16:39 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 15/32] media: v4l: async: Clean up error handling in v4l2_async_match_notify Sakari Ailus
2023-05-30 5:52 ` Laurent Pinchart
2023-06-13 16:55 ` Sakari Ailus
2023-05-25 9:15 ` [RESEND PATCH v3 16/32] media: v4l: async: Drop duplicate handling when adding connections Sakari Ailus
2023-05-30 6:01 ` Laurent Pinchart
2023-06-13 16:58 ` Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 17/32] media: v4l: async: Rework internal lists Sakari Ailus
2023-05-30 6:11 ` Laurent Pinchart
2023-06-22 12:02 ` Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 18/32] media: v4l: async: Obtain async connection based on sub-device Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 19/32] media: v4l: async: Allow multiple connections between entities Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 20/32] media: v4l: async: Try more connections Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 21/32] media: v4l: async: Support fwnode endpoint list matching for subdevs Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 22/32] media: adv748x: Return to endpoint matching Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 23/32] media: pxa_camera: Fix probe error handling Sakari Ailus
2023-05-30 4:51 ` Laurent Pinchart
2023-06-21 15:43 ` Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 24/32] media: pxa_camera: Register V4L2 device early Sakari Ailus
2023-05-30 4:54 ` Laurent Pinchart
2023-05-30 4:56 ` Laurent Pinchart
2023-06-13 15:08 ` Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 25/32] media: marvell: cafe: Register V4L2 device earlier Sakari Ailus
2023-05-30 5:00 ` Laurent Pinchart
2023-06-20 9:43 ` Sakari Ailus
2023-06-20 16:50 ` Laurent Pinchart
2023-05-25 9:16 ` [RESEND PATCH v3 26/32] media: am437x-vpfe: Register V4L2 device early Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 27/32] media: omap3isp: Initialise V4L2 async notifier later Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 28/32] media: xilinx-vipp: Init async notifier after registering V4L2 device Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 29/32] media: davinci: " Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 30/32] media: qcom: Initialise V4L2 async notifier later Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 31/32] media: v4l: async: Set v4l2_device in async notifier init Sakari Ailus
2023-05-30 6:22 ` Laurent Pinchart
2023-06-14 12:43 ` Sakari Ailus
2023-05-25 9:16 ` [RESEND PATCH v3 32/32] media: Documentation: v4l: Document sub-device notifiers Sakari Ailus
2023-05-30 6:18 ` Laurent Pinchart
2023-06-20 10:14 ` Sakari Ailus
2023-05-30 12:13 ` Aishwarya Kothari
2023-05-25 9:22 ` [RESEND PATCH v3 00/32] Separate links and async sub-devices Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530024229.GG21633@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=aishwarya.kothari@toradex.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=bingbu.cao@intel.com \
--cc=bparrot@ti.com \
--cc=bryan.odonoghue@linaro.org \
--cc=dafna@fastmail.com \
--cc=eugen.hristev@collabora.com \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=hugues.fruchet@foss.st.com \
--cc=hverkuil@xs4all.nl \
--cc=hyun.kwon@xilinx.com \
--cc=jonathanh@nvidia.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=prabhakar.csengg@gmail.com \
--cc=rfoss@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=skomatineni@nvidia.com \
--cc=slongerbeam@gmail.com \
--cc=sylvain.petinot@foss.st.com \
--cc=thierry.reding@gmail.com \
--cc=todor.too@gmail.com \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).