* [PATCH] media: rkisp1: Promote link validation error to dev_err
@ 2023-07-19 14:55 Martijn Braam
2023-09-22 15:18 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Martijn Braam @ 2023-07-19 14:55 UTC (permalink / raw)
Cc: Martijn Braam, Dafna Hirschfeld, Mauro Carvalho Chehab,
Heiko Stuebner, linux-media, linux-rockchip, linux-arm-kernel,
linux-kernel
Show an error when the pipeline cannot start due to an invalid link
instead of hiding it behind the debugging system.
Signed-off-by: Martijn Braam <martijn@brixit.nl>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
index 8f3cba319762..9361b9086f6b 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
@@ -1340,7 +1340,7 @@ static int rkisp1_capture_link_validate(struct media_link *link)
if (sd_fmt.format.height != cap->pix.fmt.height ||
sd_fmt.format.width != cap->pix.fmt.width ||
sd_fmt.format.code != fmt->mbus) {
- dev_dbg(cap->rkisp1->dev,
+ dev_err(cap->rkisp1->dev,
"link '%s':%u -> '%s':%u not valid: 0x%04x/%ux%u != 0x%04x/%ux%u\n",
link->source->entity->name, link->source->index,
link->sink->entity->name, link->sink->index,
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rkisp1: Promote link validation error to dev_err
2023-07-19 14:55 [PATCH] media: rkisp1: Promote link validation error to dev_err Martijn Braam
@ 2023-09-22 15:18 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2023-09-22 15:18 UTC (permalink / raw)
To: Martijn Braam
Cc: Dafna Hirschfeld, Mauro Carvalho Chehab, Heiko Stuebner,
linux-media, linux-rockchip, linux-arm-kernel, linux-kernel
Hi Martijn,
Thank you for the patch.
On Wed, Jul 19, 2023 at 04:55:33PM +0200, Martijn Braam wrote:
> Show an error when the pipeline cannot start due to an invalid link
> instead of hiding it behind the debugging system.
While this can help debugging issues in applications, allowing
unpriviledged applications to control messages being printed to the
kernel log is frowned upon, is it could flood the log. This is why these
messages use dev_dbg() and not dev_err().
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> index 8f3cba319762..9361b9086f6b 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> @@ -1340,7 +1340,7 @@ static int rkisp1_capture_link_validate(struct media_link *link)
> if (sd_fmt.format.height != cap->pix.fmt.height ||
> sd_fmt.format.width != cap->pix.fmt.width ||
> sd_fmt.format.code != fmt->mbus) {
> - dev_dbg(cap->rkisp1->dev,
> + dev_err(cap->rkisp1->dev,
> "link '%s':%u -> '%s':%u not valid: 0x%04x/%ux%u != 0x%04x/%ux%u\n",
> link->source->entity->name, link->source->index,
> link->sink->entity->name, link->sink->index,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-22 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 14:55 [PATCH] media: rkisp1: Promote link validation error to dev_err Martijn Braam
2023-09-22 15:18 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).