linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder
@ 2023-08-16 15:22 Devarsh Thakkar
  2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-16 15:22 UTC (permalink / raw)
  To: mchehab, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp, devarsht

This adds support for V4L2 M2M based driver for E5010 JPEG Encoder
which is a stateful JPEG encoder from Imagination technologies
and is present in TI AM62A SoC.

v4l2-compliance test :
Link: https://gist.github.com/devarsht/17348fc509fe375a630a798196edbb73

E5010 JPEG Encoder Manual tests :

Performance:
Link: https://gist.github.com/devarsht/ef5aba211aae45166681b8b4418d4e65

Functionality:
Link: https://gist.github.com/devarsht/bfef1e3ead8e858b09cbf418aea753e8

Compression Quality:
Link: https://gist.github.com/devarsht/345df9bf7157b4ca094293760e257451

Multi Instance:
Link: https://gist.github.com/devarsht/4b4d734eeb9e0e616837c0836ddbc769

Devarsh Thakkar (4):
  dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder
    driver
  media: imagination: Add E5010 JPEG Encoder driver
  arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder
  arm64: defconfig: Enable E5010 JPEG Encoder

 .../bindings/media/img,e5010-jpeg-enc.yaml    |   81 +
 MAINTAINERS                                   |    7 +
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     |   11 +
 arch/arm64/boot/dts/ti/k3-am62a.dtsi          |    2 +
 arch/arm64/configs/defconfig                  |  117 +-
 drivers/media/platform/Kconfig                |    1 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/imagination/Kconfig    |   12 +
 drivers/media/platform/imagination/Makefile   |    3 +
 .../platform/imagination/e5010-core-regs.h    |  585 ++++++
 .../platform/imagination/e5010-jpeg-enc-hw.c  |  320 ++++
 .../platform/imagination/e5010-jpeg-enc-hw.h  |   42 +
 .../platform/imagination/e5010-jpeg-enc.c     | 1678 +++++++++++++++++
 .../platform/imagination/e5010-jpeg-enc.h     |  169 ++
 .../platform/imagination/e5010-mmu-regs.h     |  311 +++
 15 files changed, 3265 insertions(+), 75 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
 create mode 100644 drivers/media/platform/imagination/Kconfig
 create mode 100644 drivers/media/platform/imagination/Makefile
 create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
 create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h

---
Changelog:
V1->V2: 
No change (sending dt-binding and driver together)

V2->V3:
- Add DONOTMERGE patches for dts and defconfig
- Update driver with below changes :
  - Correct license headers
  - Use more generic name core instead of jasper for base registers
  - Add Comment for forward declarations
  - Simplify quantization table calculations
  - Use v4l2_apply_frmsize_constraints for updating framesize and remove unrequired functions
  - Place TODO at top of file and in commit message too
  - Use dev_err_probe helper in probe function
  - Fix return value checking for failure scenarios in probe function
  - Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
  - Fix unexpected indentation
  - Correct commit message
- Update dt-bindings with below changes :
  - Add vendor specific compatible 
  - Fix commit title and message
  - Update reg names
  - Update clocks to 1
  - Fix dts example with proper naming
-- 
2.34.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
  2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
@ 2023-08-16 15:22 ` Devarsh Thakkar
  2023-08-19 14:00   ` Krzysztof Kozlowski
  2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-16 15:22 UTC (permalink / raw)
  To: mchehab, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp, devarsht

Add dt-bindings for Imagination E5010 JPEG Encoder driver which is
implemented as stateful V4L2 M2M driver.

Co-developed-by: David Huang <d-huang@ti.com>
Signed-off-by: David Huang <d-huang@ti.com>
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
V2: No change
V3: 
- Add vendor specific compatible 
- Fix commit title and message
- Update reg names
- Update clocks to 1
- Fix dts example with proper naming

 .../bindings/media/img,e5010-jpeg-enc.yaml    | 81 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 86 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml

diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
new file mode 100644
index 000000000000..d105a71ee2ea
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Imagination E5010 JPEG Encoder
+
+maintainers:
+  - Devarsh Thakkar <devarsht@ti.com>
+
+description: |
+  The E5010 is a JPEG encoder from Imagination Technologies implemented on
+  TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422
+  inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to
+  8Kx8K resolution.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: ti,e5010-jpeg-enc
+          - const: img,e5010-jpeg-enc
+      - const: img,e5010-jpeg-enc
+
+  reg:
+    items:
+      - description: The E5010 core register region
+      - description: The E5010 mmu register region
+
+  reg-names:
+    items:
+      - const: core
+      - const: mmu
+
+  power-domains:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: core_clk
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/soc/ti,sci_pm_domain.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    soc {
+      #address-cells = <2>;
+      #size-cells = <2>;
+      jpeg-encoder@fd20000 {
+          compatible = "img,e5010-jpeg-enc";
+          reg = <0x00 0xfd20000 0x00 0x100>,
+                <0x00 0xfd20200 0x00 0x200>;
+          reg-names = "core", "mmu";
+          clocks = <&k3_clks 201 0>;
+          clock-names = "core_clk";
+          power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>;
+          interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+      };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index d8700b009e22..9425ecf45df6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10206,6 +10206,11 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml
 F:	drivers/auxdisplay/img-ascii-lcd.c
 
+IMGTEC JPEG ENCODER DRIVER
+M:	Devarsh Thakkar <devarsht@ti.com>
+S:	Supported
+F:	Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
+
 IMGTEC IR DECODER DRIVER
 S:	Orphan
 F:	drivers/media/rc/img-ir/
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3 2/4] media: imagination: Add E5010 JPEG Encoder driver
  2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
  2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
@ 2023-08-16 15:22 ` Devarsh Thakkar
  2023-08-22 10:27   ` Andrzej Pietrasiewicz
  2023-09-06 12:38   ` Hans Verkuil
  2023-08-16 15:22 ` [DONOTMERGE PATCH v3 3/4] arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder Devarsh Thakkar
  2023-08-16 15:22 ` [DONOTMERGE PATCH v3 4/4] arm64: defconfig: Enable " Devarsh Thakkar
  3 siblings, 2 replies; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-16 15:22 UTC (permalink / raw)
  To: mchehab, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp, devarsht

This adds support for stateful V4L2 M2M based driver
for Imagination E5010 JPEG Encoder [1] which supports baseline
encoding with two different quantization tables and compression
ratio as demanded.

Support for both contiguous and non-contiguous YUV420 and YUV422
semiplanar formats is added along with alignment restrictions
as required by the hardware.

System and runtime PM hooks are added in the driver along with v4l2
crop and selection API support.

Minimum resolution supported is 64x64 and
Maximum resolution supported is 8192x8192.

All v4l2-compliance tests are passing [2] :
v4l2-compliance -s -f -a  -d /dev/video0 -e /dev/video1

Total for e5010 device /dev/video0: 70, Succeeded: 70, Failed: 0,
Warnings: 0
NOTE: video1 here is VIVID test pattern generator

Also tests [3] were run manually to verify below driver features:
 - Runtime Power Management
 - Multi-instance JPEG Encoding
 - DMABUF import, export support
 - NV12, NV21, NV16, NV61 video format support
 - Compression quality S_CTRL

Existing V4L2 M2M based JPEG drivers namely s5p-jpeg,
imx-jpeg and rcar_jpu were referred while making this.

TODO:
Add MMU and memory tiling support

[1]:  AM62A TRM (Section 7.6 is for JPEG Encoder)
Link: https://www.ti.com/lit/pdf/spruj16

[2]: v4l2-compliance test :
Link: https://gist.github.com/devarsht/17348fc509fe375a630a798196edbb73

[3]: E5010 JPEG Encoder Manual tests :

Performance:
Link: https://gist.github.com/devarsht/ef5aba211aae45166681b8b4418d4e65

Functionality:
Link: https://gist.github.com/devarsht/bfef1e3ead8e858b09cbf418aea753e8

Compression Quality:
Link: https://gist.github.com/devarsht/345df9bf7157b4ca094293760e257451

Multi Instance:
Link: https://gist.github.com/devarsht/4b4d734eeb9e0e616837c0836ddbc769

Co-developed-by: David Huang <d-huang@ti.com>
Signed-off-by: David Huang <d-huang@ti.com>
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
V2:
No change

V3:
- Correct license headers
- Use more generic name core instead of jasper for base registers
- Add Comment for forward declarations
- Simplify quantization table calculations
- Use v4l2_apply_frmsize_constraints for updating framesize and remove unrequired functions
- Place TODO at top of file and in commit message too
- Use dev_err_probe helper in probe function
- Fix return value checking for failure scenarios in probe function
- Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
- Fix unexpected indentation
- Correct commit message
- Remove dependency on ARCH_K3 as driver is not specific to that

 MAINTAINERS                                   |    2 +
 drivers/media/platform/Kconfig                |    1 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/imagination/Kconfig    |   12 +
 drivers/media/platform/imagination/Makefile   |    3 +
 .../platform/imagination/e5010-core-regs.h    |  585 ++++++
 .../platform/imagination/e5010-jpeg-enc-hw.c  |  320 ++++
 .../platform/imagination/e5010-jpeg-enc-hw.h  |   42 +
 .../platform/imagination/e5010-jpeg-enc.c     | 1678 +++++++++++++++++
 .../platform/imagination/e5010-jpeg-enc.h     |  169 ++
 .../platform/imagination/e5010-mmu-regs.h     |  311 +++
 11 files changed, 3124 insertions(+)
 create mode 100644 drivers/media/platform/imagination/Kconfig
 create mode 100644 drivers/media/platform/imagination/Makefile
 create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
 create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
 create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 9425ecf45df6..725a280a521b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10208,8 +10208,10 @@ F:	drivers/auxdisplay/img-ascii-lcd.c
 
 IMGTEC JPEG ENCODER DRIVER
 M:	Devarsh Thakkar <devarsht@ti.com>
+L:	linux-media@vger.kernel.org
 S:	Supported
 F:	Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
+F:	drivers/media/platform/imagination/e5010*
 
 IMGTEC IR DECODER DRIVER
 S:	Orphan
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index ee579916f874..72b4bedd47fb 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -69,6 +69,7 @@ source "drivers/media/platform/aspeed/Kconfig"
 source "drivers/media/platform/atmel/Kconfig"
 source "drivers/media/platform/cadence/Kconfig"
 source "drivers/media/platform/chips-media/Kconfig"
+source "drivers/media/platform/imagination/Kconfig"
 source "drivers/media/platform/intel/Kconfig"
 source "drivers/media/platform/marvell/Kconfig"
 source "drivers/media/platform/mediatek/Kconfig"
diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
index 5453bb868e67..96db57cc9412 100644
--- a/drivers/media/platform/Makefile
+++ b/drivers/media/platform/Makefile
@@ -12,6 +12,7 @@ obj-y += aspeed/
 obj-y += atmel/
 obj-y += cadence/
 obj-y += chips-media/
+obj-y += imagination/
 obj-y += intel/
 obj-y += marvell/
 obj-y += mediatek/
diff --git a/drivers/media/platform/imagination/Kconfig b/drivers/media/platform/imagination/Kconfig
new file mode 100644
index 000000000000..d8d79266ad5d
--- /dev/null
+++ b/drivers/media/platform/imagination/Kconfig
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0
+config VIDEO_E5010_JPEG_ENC
+	tristate "Imagination E5010 JPEG Encoder Driver"
+	depends on VIDEO_DEV
+	select VIDEOBUF2_DMA_CONTIG
+	select VIDEOBUF2_VMALLOC
+	select V4L2_MEM2MEM_DEV
+	help
+	  This is a video4linux2 M2M driver for Imagination E5010 JPEG encoder,
+	  which supports JPEG and MJPEG baseline encoding of YUV422 and YUV420
+	  semiplanar video formats, with resolution ranging from 64x64 to 8K x 8K
+	  pixels. The module will be named as e5010_jpeg_enc.
diff --git a/drivers/media/platform/imagination/Makefile b/drivers/media/platform/imagination/Makefile
new file mode 100644
index 000000000000..d45b85b88575
--- /dev/null
+++ b/drivers/media/platform/imagination/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+e5010_jpeg_enc-objs := e5010-jpeg-enc-hw.o e5010-jpeg-enc.o
+obj-$(CONFIG_VIDEO_E5010_JPEG_ENC) += e5010_jpeg_enc.o
diff --git a/drivers/media/platform/imagination/e5010-core-regs.h b/drivers/media/platform/imagination/e5010-core-regs.h
new file mode 100644
index 000000000000..aaec498fe83f
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-core-regs.h
@@ -0,0 +1,585 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#ifndef _E5010_CORE_REGS_H
+#define _E5010_CORE_REGS_H
+
+#define JASPER_CORE_ID_OFFSET				(0x0000)
+#define JASPER_CORE_ID_CR_GROUP_ID_MASK			(0xFF000000)
+#define JASPER_CORE_ID_CR_GROUP_ID_SHIFT		(24)
+#define JASPER_CORE_ID_CR_CORE_ID_MASK			(0x00FF0000)
+#define JASPER_CORE_ID_CR_CORE_ID_SHIFT			(16)
+#define JASPER_CORE_ID_CR_UNIQUE_NUM_MASK		(0x0000FFF8)
+#define JASPER_CORE_ID_CR_UNIQUE_NUM_SHIFT		(3)
+#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_MASK		(0x00000007)
+#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_SHIFT		(0)
+
+#define JASPER_CORE_REV_OFFSET				(0x0004)
+#define JASPER_CORE_REV_CR_JASPER_DESIGNER_MASK		(0xFF000000)
+#define JASPER_CORE_REV_CR_JASPER_DESIGNER_SHIFT	(24)
+#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_MASK	(0x00FF0000)
+#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_SHIFT	(16)
+#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_MASK	(0x0000FF00)
+#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_SHIFT	(8)
+#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_MASK	(0x000000FF)
+#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_SHIFT	(0)
+
+#define JASPER_INTERRUPT_MASK_OFFSET					(0x0008)
+#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK	(0x00000002)
+#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT	(1)
+#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK		(0x00000001)
+#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT		(0)
+
+#define JASPER_INTERRUPT_STATUS_OFFSET					(0x000C)
+#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK	(0x00000002)
+#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_SHIFT	(1)
+#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK		(0x00000001)
+#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_SHIFT		(0)
+
+#define JASPER_INTERRUPT_CLEAR_OFFSET					(0x0010)
+#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK		(0x00000002)
+#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT		(1)
+#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK		(0x00000001)
+#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT		(0)
+
+#define JASPER_CLK_CONTROL_OFFSET				(0x0014)
+#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK	(0x00000002)
+#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT	(1)
+#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK	(0x00000001)
+#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT	(0)
+
+#define JASPER_CLK_STATUS_OFFSET			(0x0018)
+#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_MASK	(0x00000001)
+#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_SHIFT	(0)
+
+#define JASPER_RESET_OFFSET			(0x001C)
+#define JASPER_RESET_CR_SYS_RESET_MASK		(0x00000002)
+#define JASPER_RESET_CR_SYS_RESET_SHIFT		(1)
+#define JASPER_RESET_CR_CORE_RESET_MASK		(0x00000001)
+#define JASPER_RESET_CR_CORE_RESET_SHIFT	(0)
+
+#define JASPER_CORE_CTRL_OFFSET				(0x0020)
+#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK	(0x00000001)
+#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT	(0)
+
+#define JASPER_STATUS_OFFSET				(0x0024)
+#define JASPER_STATUS_CR_FLUSH_MODE_MASK		(0x00000002)
+#define JASPER_STATUS_CR_FLUSH_MODE_SHIFT		(1)
+#define JASPER_STATUS_CR_JASPER_BUSY_MASK		(0x00000001)
+#define JASPER_STATUS_CR_JASPER_BUSY_SHIFT		(0)
+
+#define JASPER_CRC_CLEAR_OFFSET					(0x0028)
+#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_MASK		(0x00000001)
+#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_SHIFT		(0)
+#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_MASK			(0x00000002)
+#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_SHIFT			(1)
+#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_MASK			(0x00000004)
+#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_SHIFT			(2)
+#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_MASK		(0x00000008)
+#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_SHIFT		(3)
+#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_MASK	(0x00000010)
+#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_SHIFT	(4)
+#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_MASK	(0x00000020)
+#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_SHIFT	(5)
+
+#define JASPER_INPUT_CTRL0_OFFSET			(0x002C)
+#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK	(0x01000000)
+#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT	(24)
+#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK	(0x00030000)
+#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT	(16)
+#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK		(0x00000004)
+#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT	(2)
+
+#define JASPER_INPUT_CTRL1_OFFSET			(0x0030)
+#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK	(0x1FC00000)
+#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT	(22)
+#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK	(0x00001FC0)
+#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT	(6)
+
+#define JASPER_MMU_CTRL_OFFSET				(0x0034)
+#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_MASK	(0x00000002)
+#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_SHIFT	(1)
+#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_MASK	(0x00000001)
+#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_SHIFT	(0)
+
+#define JASPER_IMAGE_SIZE_OFFSET				(0x0038)
+#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK		(0x1FFF0000)
+#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT		(16)
+#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK		(0x00001FFF)
+#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT	(0)
+
+#define INPUT_LUMA_BASE_OFFSET				(0x003C)
+#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK		(0xFFFFFFC0)
+#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_SHIFT	(6)
+
+#define INPUT_CHROMA_BASE_OFFSET			(0x0040)
+#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK	(0xFFFFFFC0)
+#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_SHIFT	(6)
+
+#define JASPER_OUTPUT_BASE_OFFSET		(0x0044)
+#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK	(0xFFFFFFFF)
+#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT	(0)
+
+#define JASPER_OUTPUT_SIZE_OFFSET			(0x0048)
+#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_MASK		(0xFFFFFFFF)
+#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_SHIFT		(0)
+#define JASPER_OUTPUT_MAX_SIZE_OFFSET			(0x004C)
+#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK	(0xFFFFFFFF)
+#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET					(0x0050)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_SHIFT	(16)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_SHIFT	(0)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_OFFSET					(0x0054)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_SHIFT	(16)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_SHIFT	(0)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_OFFSET					(0x0058)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_SHIFT	(16)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_SHIFT	(0)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_OFFSET					(0x005C)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_SHIFT	(16)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_SHIFT	(0)
+#define JASPER_LUMA_QUANTIZATION_TABLE4_OFFSET					(0x0060)
+#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE5_OFFSET					(0x0064)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_SHIFT	(16)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE6_OFFSET					(0x0068)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_SHIFT	(8)
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE7_OFFSET					(0x006C)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE8_OFFSET					(0x0070)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_SHIFT	(24)
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE9_OFFSET					(0x0074)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE10_OFFSET					(0x0078)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE11_OFFSET					(0x007C)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE12_OFFSET					(0x0080)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE13_OFFSET					(0x0084)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE14_OFFSET					(0x0088)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_SHIFT	(0)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE15_OFFSET					(0x008C)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_MASK	(0xFF000000)
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_SHIFT	(24)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_MASK	(0x00FF0000)
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_SHIFT	(16)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_MASK	(0x0000FF00)
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_SHIFT	(8)
+
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_MASK	(0x000000FF)
+#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET				(0x0090)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_OFFSET					(0x0094)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_OFFSET					(0x0098)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_OFFSET					(0x009C)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_OFFSET					(0x00A0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_OFFSET					(0x00A4)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_OFFSET					(0x00A8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_OFFSET					(0x00AC)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_OFFSET					(0x00B0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_OFFSET					(0x00B4)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_SHIFT		(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_SHIFT		(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_SHIFT		(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_SHIFT		(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_OFFSET					(0x00B8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_OFFSET					(0x00BC)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_OFFSET					(0x00C0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_OFFSET					(0x00C4)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_OFFSET					(0x00C8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_SHIFT	(0)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_OFFSET					(0x00CC)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_MASK		(0xFF000000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_SHIFT	(24)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_MASK		(0x00FF0000)
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_SHIFT	(16)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_MASK		(0x0000FF00)
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_SHIFT	(8)
+
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_MASK		(0x000000FF)
+#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_SHIFT	(0)
+
+#define JASPER_CRC_CTRL_OFFSET				(0x00D0)
+#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK		(0x00000001)
+#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT		(0)
+
+#define JASPER_FRONT_END_CRC_OFFSET				(0x00D4)
+#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_MASK	(0xFFFFFFFF)
+#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_SHIFT	(0)
+
+#define JASPER_DCT_CRC_OFFSET				(0x00D8)
+#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_MASK	(0xFFFFFFFF)
+#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_SHIFT	(0)
+
+#define JASPER_ZZ_CRC_OFFSET				(0x00DC)
+#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_MASK		(0xFFFFFFFF)
+#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_SHIFT	(0)
+
+#define JASPER_QUANT_CRC_OFFSET				(0x00E0)
+#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_MASK	(0xFFFFFFFF)
+#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_SHIFT	(0)
+
+#define JASPER_ENTROPY_ENCODER_CRC_OFFSET				(0x00E4)
+#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_MASK	(0xFFFFFFFF)
+#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_SHIFT	(0)
+
+#define JASPER_PACKING_BUFFER_DATA_CRC_OFFSET						(0x00E8)
+#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_MASK		(0xFFFFFFFF)
+#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_SHIFT		(0)
+
+#define JASPER_PACKING_BUFFER_ADDR_CRC_OFFSET						(0x00EC)
+#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_MASK		(0xFFFFFFFF)
+#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_SHIFT		(0)
+
+#define JASPER_CORE_BYTE_SIZE	(0x00F0)
+
+#endif
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
new file mode 100644
index 000000000000..237339789407
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
@@ -0,0 +1,320 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#include <linux/io.h>
+#include <linux/iopoll.h>
+#include <linux/dev_printk.h>
+#include "e5010-jpeg-enc-hw.h"
+
+static void write_reg_field(void __iomem *base, unsigned int offset, u32 mask,
+			    unsigned int shift, u32 value)
+{
+	u32 reg;
+
+	value <<= shift;
+	if (mask != 0xffffffff) {
+		reg = readl(base + offset);
+		value = (value & mask) | (reg & ~mask);
+	}
+	writel(value, (base + offset));
+}
+
+static int write_reg_field_not_busy(void __iomem *jasper_base, void __iomem *wr_base,
+				    unsigned int offset, u32 mask, unsigned int shift,
+				    u32 value)
+{
+	int ret;
+	u32 val;
+
+	ret = readl_poll_timeout_atomic(jasper_base + JASPER_STATUS_OFFSET, val,
+					(val & JASPER_STATUS_CR_JASPER_BUSY_MASK) == 0,
+					2000, 50000);
+	if (ret)
+		return ret;
+
+	write_reg_field(wr_base, offset, mask, shift, value);
+
+	return 0;
+}
+
+void e5010_reset(struct device *dev, void __iomem *core_base, void __iomem *mmu_base)
+{
+	int ret = 0;
+	u32 val;
+
+	write_reg_field(core_base, JASPER_RESET_OFFSET,
+			JASPER_RESET_CR_CORE_RESET_MASK,
+			JASPER_RESET_CR_CORE_RESET_SHIFT, 1);
+
+	write_reg_field(mmu_base, MMU_MMU_CONTROL1_OFFSET,
+			MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK,
+			MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT, 1);
+
+	ret = readl_poll_timeout_atomic(mmu_base + MMU_MMU_CONTROL1_OFFSET, val,
+					(val & MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK) == 0,
+					2000, 50000);
+	if (ret)
+		dev_warn(dev, "MMU soft reset timed out, forcing system soft reset\n");
+
+	write_reg_field(core_base, JASPER_RESET_OFFSET,
+			JASPER_RESET_CR_SYS_RESET_MASK,
+			JASPER_RESET_CR_SYS_RESET_SHIFT, 1);
+}
+
+void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable)
+{
+	/* Bypass MMU */
+	write_reg_field(mmu_base,
+			MMU_MMU_ADDRESS_CONTROL_OFFSET,
+			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK,
+			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT,
+			enable);
+}
+
+int e5010_hw_enable_output_address_error_irq(void __iomem *core_base, u32 enable)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INTERRUPT_MASK_OFFSET,
+				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK,
+				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT,
+				       enable);
+	return ret;
+}
+
+bool e5010_hw_pic_done_irq(void __iomem *core_base)
+{
+	u32 reg;
+	bool pic_done;
+
+	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
+	pic_done = (reg & JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK) ? true : false;
+
+	return pic_done;
+}
+
+bool e5010_hw_output_address_irq(void __iomem *core_base)
+{
+	u32 reg;
+	bool output_address_error;
+
+	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
+	output_address_error = (reg & JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK) ?
+				true : false;
+
+	return output_address_error;
+}
+
+int e5010_hw_enable_picture_done_irq(void __iomem *core_base, u32 enable)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INTERRUPT_MASK_OFFSET,
+				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK,
+				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT,
+				       enable);
+	return ret;
+}
+
+int e5010_hw_enable_auto_clock_gating(void __iomem *core_base, u32 enable)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_CLK_CONTROL_OFFSET,
+				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK,
+				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT,
+				       enable);
+	return ret;
+}
+
+int e5010_hw_enable_manual_clock_gating(void __iomem *core_base, u32 enable)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_CLK_CONTROL_OFFSET,
+				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK,
+				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT, 0);
+	return ret;
+}
+
+int e5010_hw_enable_crc_check(void __iomem *core_base, u32 enable)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_CRC_CTRL_OFFSET,
+				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK,
+				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT, enable);
+	return ret;
+}
+
+int e5010_hw_set_input_source_to_memory(void __iomem *core_base, u32 set)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INPUT_CTRL0_OFFSET,
+				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK,
+				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT, set);
+	return ret;
+}
+
+int e5010_hw_set_input_luma_addr(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       INPUT_LUMA_BASE_OFFSET,
+				       INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK, 0, val);
+	return ret;
+}
+
+int e5010_hw_set_input_chroma_addr(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       INPUT_CHROMA_BASE_OFFSET,
+				       INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK, 0, val);
+	return ret;
+}
+
+int e5010_hw_set_output_base_addr(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_OUTPUT_BASE_OFFSET,
+				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK,
+				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT, val);
+	return ret;
+}
+
+int e5010_hw_set_horizontal_size(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_IMAGE_SIZE_OFFSET,
+				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK,
+				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT,
+				       val);
+	return ret;
+}
+
+int e5010_hw_set_vertical_size(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_IMAGE_SIZE_OFFSET,
+				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK,
+				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT,
+				       val);
+	return ret;
+}
+
+int e5010_hw_set_luma_stride(void __iomem *core_base, u32 bytesperline)
+{
+	int ret;
+	u32 val = bytesperline / 64;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INPUT_CTRL1_OFFSET,
+				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK,
+				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT,
+				       val);
+	return ret;
+}
+
+int e5010_hw_set_chroma_stride(void __iomem *core_base, u32 bytesperline)
+{
+	int ret;
+	u32 val = bytesperline / 64;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INPUT_CTRL1_OFFSET,
+				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK,
+				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT,
+				       val);
+	return ret;
+}
+
+int e5010_hw_set_input_subsampling(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INPUT_CTRL0_OFFSET,
+				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK,
+				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT,
+				       val);
+	return ret;
+}
+
+int e5010_hw_set_chroma_order(void __iomem *core_base, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base,
+				       JASPER_INPUT_CTRL0_OFFSET,
+				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK,
+				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT,
+				       val);
+	return ret;
+}
+
+void e5010_hw_set_output_max_size(void __iomem *core_base, u32 val)
+{
+	write_reg_field(core_base, JASPER_OUTPUT_MAX_SIZE_OFFSET,
+			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK,
+			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT,
+			val);
+}
+
+int e5010_hw_set_qpvalue(void __iomem *core_base, u32 offset, u32 val)
+{
+	int ret;
+
+	ret = write_reg_field_not_busy(core_base, core_base, offset, 0xffffffff, 0, val);
+	return ret;
+}
+
+void e5010_hw_clear_output_error(void __iomem *core_base, u32 clear)
+{
+	/* Make sure interrupts are clear */
+	write_reg_field(core_base, JASPER_INTERRUPT_CLEAR_OFFSET,
+			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK,
+			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT, clear);
+}
+
+void e5010_hw_clear_picture_done(void __iomem *core_base, u32 clear)
+{
+	write_reg_field(core_base,
+			JASPER_INTERRUPT_CLEAR_OFFSET,
+			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK,
+			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT, clear);
+}
+
+int e5010_hw_get_output_size(void __iomem *core_base)
+{
+	return readl(core_base + JASPER_OUTPUT_SIZE_OFFSET);
+}
+
+void e5010_hw_encode_start(void __iomem *core_base, u32 start)
+{
+	write_reg_field(core_base, JASPER_CORE_CTRL_OFFSET,
+			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK,
+			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT, start);
+}
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
new file mode 100644
index 000000000000..781d353c3226
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
@@ -0,0 +1,42 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#ifndef _E5010_JPEG_ENC_HW_H
+#define _E5010_JPEG_ENC_HW_H
+
+#include "e5010-core-regs.h"
+#include "e5010-mmu-regs.h"
+
+int e5010_hw_enable_output_address_error_irq(void __iomem *core_offset, u32 enable);
+int e5010_hw_enable_picture_done_irq(void __iomem *core_offset, u32 enable);
+int e5010_hw_enable_auto_clock_gating(void __iomem *core_offset, u32 enable);
+int e5010_hw_enable_manual_clock_gating(void __iomem *core_offset, u32 enable);
+int e5010_hw_enable_crc_check(void __iomem *core_offset, u32 enable);
+int e5010_hw_set_input_source_to_memory(void __iomem *core_offset, u32 set);
+int e5010_hw_set_input_luma_addr(void __iomem *core_offset, u32 val);
+int e5010_hw_set_input_chroma_addr(void __iomem *core_offset, u32 val);
+int e5010_hw_set_output_base_addr(void __iomem *core_offset, u32 val);
+int e5010_hw_get_output_size(void __iomem *core_offset);
+int e5010_hw_set_horizontal_size(void __iomem *core_offset, u32 val);
+int e5010_hw_set_vertical_size(void __iomem *core_offset, u32 val);
+int e5010_hw_set_luma_stride(void __iomem *core_offset, u32 bytesperline);
+int e5010_hw_set_chroma_stride(void __iomem *core_offset, u32 bytesperline);
+int e5010_hw_set_input_subsampling(void __iomem *core_offset, u32 val);
+int e5010_hw_set_chroma_order(void __iomem *core_offset, u32 val);
+int e5010_hw_set_qpvalue(void __iomem *core_offset, u32 offset, u32 value);
+void e5010_reset(struct device *dev, void __iomem *core_offset, void __iomem *mmu_offset);
+void e5010_hw_set_output_max_size(void __iomem *core_offset, u32 val);
+void e5010_hw_clear_picture_done(void __iomem *core_offset, u32 clear);
+void e5010_hw_encode_start(void __iomem *core_offset, u32 start);
+void e5010_hw_clear_output_error(void __iomem *core_offset, u32 clear);
+void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable);
+bool e5010_hw_pic_done_irq(void __iomem *core_base);
+bool e5010_hw_output_address_irq(void __iomem *core_base);
+#endif
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
new file mode 100644
index 000000000000..bf40ba9014e1
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
@@ -0,0 +1,1678 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * TODO: Add MMU and memory tiling support
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/ioctl.h>
+#include <linux/dma-mapping.h>
+#include <linux/err.h>
+#include <linux/pm_runtime.h>
+#include <linux/interrupt.h>
+#include <linux/clk.h>
+#include <media/v4l2-common.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-event.h>
+#include <media/v4l2-ioctl.h>
+#include <media/v4l2-mem2mem.h>
+#include <media/videobuf2-v4l2.h>
+#include <media/videobuf2-dma-contig.h>
+#include "e5010-jpeg-enc.h"
+#include "e5010-jpeg-enc-hw.h"
+
+/* forward declarations */
+static const struct of_device_id e5010_of_match[];
+
+static const struct v4l2_file_operations e5010_fops;
+
+static const struct v4l2_ioctl_ops e5010_ioctl_ops;
+
+static const struct vb2_ops e5010_video_ops;
+
+static const struct v4l2_m2m_ops e5010_m2m_ops;
+
+static struct e5010_fmt e5010_formats[] = {
+	{
+		.fourcc = V4L2_PIX_FMT_NV12,
+		.num_planes = 1,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
+		.chroma_order = CHROMA_ORDER_CB_CR,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV12M,
+		.num_planes = 2,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
+		.chroma_order = CHROMA_ORDER_CB_CR,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV21,
+		.num_planes = 1,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
+		.chroma_order = CHROMA_ORDER_CR_CB,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV21M,
+		.num_planes = 2,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
+		.chroma_order = CHROMA_ORDER_CR_CB,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV16,
+		.num_planes = 1,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
+		.chroma_order = CHROMA_ORDER_CB_CR,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV16M,
+		.num_planes = 2,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
+		.chroma_order = CHROMA_ORDER_CB_CR,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV61,
+		.num_planes = 1,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
+		.chroma_order = CHROMA_ORDER_CR_CB,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_NV61M,
+		.num_planes = 2,
+		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
+		.chroma_order = CHROMA_ORDER_CR_CB,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+	{
+		.fourcc = V4L2_PIX_FMT_JPEG,
+		.num_planes = 1,
+		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
+		.subsampling = 0,
+		.chroma_order = 0,
+		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 16,
+			     MIN_DIMENSION, MAX_DIMENSION, 8 },
+	},
+};
+
+/* Luma and chroma qp table to acheive 50% compression quality
+ * This is as per example in Annex K.1 of IS0/IEC 10918-1:1994(E)
+ */
+static const u8 luma[64] = {
+	16, 11, 10, 16, 24, 40, 51, 61,
+	12, 12, 14, 19, 26, 58, 60, 55,
+	14, 13, 16, 24, 40, 57, 69, 56,
+	14, 17, 22, 29, 51, 87, 80, 62,
+	18, 22, 37, 56, 68, 109, 103, 77,
+	24, 35, 55, 64, 81, 104, 113, 92,
+	49, 64, 78, 87, 103, 121, 120, 101,
+	72, 92, 95, 98, 112, 100, 103, 99
+};
+
+static const u8 chroma[64] = {
+	17, 18, 24, 47, 99, 99, 99, 99,
+	18, 21, 26, 66, 99, 99, 99, 99,
+	24, 26, 56, 99, 99, 99, 99, 99,
+	47, 66, 99, 99, 99, 99, 99, 99,
+	99, 99, 99, 99, 99, 99, 99, 99,
+	99, 99, 99, 99, 99, 99, 99, 99,
+	99, 99, 99, 99, 99, 99, 99, 99,
+	99, 99, 99, 99, 99, 99, 99, 99
+};
+
+/* Zigzag scan pattern */
+static const u8 zigzag[64] = {
+	0,   1,  8, 16,  9,  2,  3, 10,
+	17, 24, 32, 25, 18, 11,  4,  5,
+	12, 19, 26, 33, 40, 48, 41, 34,
+	27, 20, 13,  6,  7, 14, 21, 28,
+	35, 42, 49, 56, 57, 50, 43, 36,
+	29, 22, 15, 23, 30, 37, 44, 51,
+	58, 59, 52, 45, 38, 31, 39, 46,
+	53, 60, 61, 54, 47, 55, 62, 63
+};
+
+/*
+ * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
+ * stream or an abbreviated format table specification data stream.
+ * Specifies the huffman table used for encoding the luminance DC coefficient differences.
+ * The table represents Table K.3 of IS0/IEC 10918-1:1994(E)
+ */
+static const u8 marker_luma_dc[] = {
+	0x00, 0x00, 0x01, 0x05, 0x01, 0x01, 0x01, 0x01, 0x01,
+	0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
+};
+
+/*
+ * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
+ * stream or an abbreviated format table specification data stream.
+ * Specifies the huffman table used for encoding the luminance AC coefficients.
+ * The table represents Table K.5 of IS0/IEC 10918-1:1994(E)
+ */
+static const u8 marker_luma_ac[] = {
+	0x10, 0x00, 0x02, 0x01, 0x03, 0x03, 0x02, 0x04, 0x03,
+	0x05, 0x05, 0x04, 0x04, 0x00, 0x00, 0x01, 0x7D,
+	0x01, 0x02, 0x03, 0x00, 0x04, 0x11, 0x05, 0x12, 0x21, 0x31, 0x41, 0x06, 0x13, 0x51, 0x61,
+	0x07, 0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xA1, 0x08, 0x23, 0x42, 0xB1, 0xC1, 0x15, 0x52,
+	0xD1, 0xF0, 0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0A, 0x16, 0x17, 0x18, 0x19, 0x1A, 0x25,
+	0x26, 0x27, 0x28, 0x29, 0x2A, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44, 0x45,
+	0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63, 0x64,
+	0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A, 0x83,
+	0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99,
+	0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4, 0xB5, 0xB6,
+	0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA, 0xD2, 0xD3,
+	0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE1, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7, 0xE8,
+	0xE9, 0xEA, 0xF1, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
+};
+
+/*
+ * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
+ * stream or an abbreviated format table specification data stream.
+ * Specifies the huffman table used for encoding the chrominance DC coefficient differences.
+ * The table represents Table K.4 of IS0/IEC 10918-1:1994(E)
+ */
+static const u8 marker_chroma_dc[] = {
+	0x01, 0x00, 0x03, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
+	0x01, 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00,
+	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
+};
+
+/*
+ * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
+ * stream or an abbreviated format table specification data stream.
+ * Specifies the huffman table used for encoding the chrominance AC coefficients.
+ * The table represents Table K.6 of IS0/IEC 10918-1:1994(E)
+ */
+static const u8 marker_chroma_ac[] = {
+	0x11, 0x00, 0x02, 0x01, 0x02, 0x04, 0x04, 0x03, 0x04,
+	0x07, 0x05, 0x04, 0x04, 0x00, 0x01, 0x02, 0x77,
+	0x00, 0x01, 0x02, 0x03, 0x11, 0x04, 0x05, 0x21, 0x31, 0x06, 0x12, 0x41, 0x51, 0x07, 0x61,
+	0x71, 0x13, 0x22, 0x32, 0x81, 0x08, 0x14, 0x42, 0x91, 0xA1, 0xB1, 0xC1, 0x09, 0x23, 0x33,
+	0x52, 0xF0, 0x15, 0x62, 0x72, 0xD1, 0x0A, 0x16, 0x24, 0x34, 0xE1, 0x25, 0xF1, 0x17, 0x18,
+	0x19, 0x1A, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44,
+	0x45, 0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63,
+	0x64, 0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A,
+	0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97,
+	0x98, 0x99, 0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4,
+	0xB5, 0xB6, 0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA,
+	0xD2, 0xD3, 0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7,
+	0xE8, 0xE9, 0xEA, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
+};
+
+static unsigned int debug;
+module_param(debug, uint, 0644);
+MODULE_PARM_DESC(debug, "debug level");
+
+#define dprintk(dev, lvl, fmt, arg...) \
+	v4l2_dbg(lvl, debug, &(dev)->v4l2_dev, "%s: " fmt, __func__, ## arg)
+
+static const struct v4l2_event e5010_eos_event = {
+	.type = V4L2_EVENT_EOS
+};
+
+static const char *type_name(enum v4l2_buf_type type)
+{
+	switch (type) {
+	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
+		return "Output";
+	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
+		return "Capture";
+	default:
+		return "Invalid";
+	}
+}
+
+static struct e5010_q_data *get_queue(struct e5010_context *ctx, enum v4l2_buf_type type)
+{
+	switch (type) {
+	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
+		return &ctx->out_queue;
+	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
+		return &ctx->cap_queue;
+	default:
+		return ERR_PTR(-EINVAL);
+	}
+
+	return ERR_PTR(-EINVAL);
+}
+
+static void calculate_qp_tables(struct e5010_context *ctx)
+{
+	long long luminosity, contrast;
+	int quality, i;
+
+	quality = 50 - ctx->quality;
+
+	luminosity = LUMINOSITY * quality / 50;
+	contrast = CONTRAST * quality / 50;
+
+	if (quality > 0) {
+		luminosity *= INCREASE;
+		contrast *= INCREASE;
+	}
+
+	for (i = 0; i < 64; i++) {
+		long long delta = chroma[i] * contrast + luminosity;
+		int val = (int)(chroma[i] + delta);
+
+		clamp(val, 1, 255);
+		ctx->chroma_qp[i] = quality == -50 ? 1 : val;
+
+		delta = luma[i] * contrast + luminosity;
+		val = (int)(luma[i] + delta);
+		clamp(val, 1, 255);
+		ctx->luma_qp[i] = quality == -50 ? 1 : val;
+	}
+
+	ctx->update_qp = true;
+}
+
+static int update_qp_tables(struct e5010_context *ctx)
+{
+	struct e5010_dev *e5010 = ctx->e5010;
+	int i, ret = 0;
+	u32 lvalue, cvalue;
+
+	lvalue = 0;
+	cvalue = 0;
+
+	for (i = 0; i < QP_TABLE_SIZE; i++) {
+		lvalue |= ctx->luma_qp[i] << (8 * (i % 4));
+		cvalue |= ctx->chroma_qp[i] << (8 * (i % 4));
+		if (i % 4 == 3) {
+			ret |= e5010_hw_set_qpvalue(e5010->core_base,
+							JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET
+							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
+							lvalue);
+			ret |= e5010_hw_set_qpvalue(e5010->core_base,
+							JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET
+							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
+							cvalue);
+			lvalue = 0;
+			cvalue = 0;
+		}
+	}
+
+	return ret;
+}
+
+static int e5010_set_input_subsampling(void __iomem *core_base, int subsampling)
+{
+	switch (subsampling) {
+	case V4L2_JPEG_CHROMA_SUBSAMPLING_420:
+		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_420);
+	case V4L2_JPEG_CHROMA_SUBSAMPLING_422:
+		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_422);
+	default:
+		return -EINVAL;
+	};
+}
+
+static int e5010_querycap(struct file *file, void *priv, struct v4l2_capability *cap)
+{
+	strscpy(cap->driver, E5010_MODULE_NAME, sizeof(cap->driver));
+	strscpy(cap->card, E5010_MODULE_NAME, sizeof(cap->card));
+	snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", E5010_MODULE_NAME);
+	cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING;
+	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
+
+	return 0;
+}
+
+static struct e5010_fmt *find_format(struct v4l2_format *f)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
+		if (e5010_formats[i].fourcc == f->fmt.pix_mp.pixelformat &&
+		    e5010_formats[i].type == f->type)
+			return &e5010_formats[i];
+	}
+
+	return NULL;
+}
+
+static int e5010_enum_fmt(struct file *file, void *priv, struct v4l2_fmtdesc *f)
+{
+	int i, index = 0;
+	struct e5010_fmt *fmt = NULL;
+	struct e5010_context *ctx = file->private_data;
+
+	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "ENUMFMT with Invalid type: %d\n", f->type);
+		return -EINVAL;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
+		if (e5010_formats[i].type == f->type) {
+			if (index == f->index) {
+				fmt = &e5010_formats[i];
+				break;
+			}
+			index++;
+		}
+	}
+
+	if (!fmt)
+		return -EINVAL;
+
+	f->pixelformat = fmt->fourcc;
+	return 0;
+}
+
+static int e5010_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
+{
+	struct e5010_context *ctx = file->private_data;
+	struct e5010_q_data *queue;
+	int i;
+	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
+	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
+
+	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
+		return -EINVAL;
+	}
+
+	queue = get_queue(ctx, f->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	pix_mp->flags = 0;
+	pix_mp->field = V4L2_FIELD_NONE;
+	pix_mp->pixelformat = queue->fmt->fourcc;
+	pix_mp->width = queue->width_adjusted;
+	pix_mp->height = queue->height_adjusted;
+	pix_mp->num_planes = queue->fmt->num_planes;
+
+	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
+		if (!pix_mp->colorspace)
+			pix_mp->colorspace = V4L2_COLORSPACE_SRGB;
+
+		for (i = 0; i < queue->fmt->num_planes; i++) {
+			plane_fmt[i].sizeimage = queue->sizeimage[i];
+			plane_fmt[i].bytesperline = queue->bytesperline[i];
+		}
+
+	} else {
+		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
+		plane_fmt[0].bytesperline = 0;
+		plane_fmt[0].sizeimage = queue->sizeimage[0];
+	}
+	pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+	pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
+	pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
+
+	return 0;
+}
+
+static int e5010_jpeg_try_fmt(struct v4l2_format *f, struct e5010_context *ctx)
+{
+	struct e5010_fmt *fmt;
+	struct e5010_q_data *queue;
+	int i;
+	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
+	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
+
+	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
+		return -EINVAL;
+	}
+
+	fmt = find_format(f);
+	if (!fmt) {
+		if (V4L2_TYPE_IS_OUTPUT(f->type))
+			pix_mp->pixelformat = V4L2_PIX_FMT_NV12;
+		else
+			pix_mp->pixelformat = V4L2_PIX_FMT_JPEG;
+		fmt = find_format(f);
+		if (!fmt)
+			return -EINVAL;
+	}
+
+	queue = get_queue(ctx, f->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	queue->fmt = fmt;
+	queue->width = pix_mp->width;
+	queue->height = pix_mp->height;
+
+	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
+		if (!pix_mp->colorspace)
+			pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
+		if (!pix_mp->ycbcr_enc)
+			pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+		if (!pix_mp->quantization)
+			pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
+		if (!pix_mp->xfer_func)
+			pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
+
+		v4l2_apply_frmsize_constraints(&pix_mp->width,
+					       &pix_mp->height,
+					       &fmt->frmsize);
+
+		v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
+				    pix_mp->width, pix_mp->height);
+
+		for (i = 0; i < fmt->num_planes; i++) {
+			queue->bytesperline[i] = plane_fmt[i].bytesperline;
+			queue->sizeimage[i] = plane_fmt[i].sizeimage;
+		}
+	} else {
+		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
+		pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+		pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
+		pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
+		memset(plane_fmt[0].reserved, 0, sizeof(plane_fmt[0].reserved));
+		v4l2_apply_frmsize_constraints(&pix_mp->width,
+					       &pix_mp->height,
+					       &fmt->frmsize);
+		queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
+		queue->sizeimage[0] += HEADER_SIZE;
+		queue->sizeimage[1] = 0;
+		queue->bytesperline[0] = 0;
+		queue->bytesperline[1] = 0;
+		plane_fmt[0].sizeimage = queue->sizeimage[0];
+		plane_fmt[0].bytesperline = 0;
+	}
+	pix_mp->flags = 0;
+	pix_mp->field = V4L2_FIELD_NONE;
+	pix_mp->pixelformat = fmt->fourcc;
+	queue->width_adjusted = pix_mp->width;
+	queue->height_adjusted = pix_mp->height;
+	pix_mp->num_planes = fmt->num_planes;
+	memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
+
+	dprintk(ctx->e5010, 2,
+		"ctx: 0x%p: format type %s:, wxh: %dx%d (plane0 : %d bytes, plane1 : %d bytes),fmt: %c%c%c%c\n",
+		ctx, type_name(f->type), queue->width_adjusted, queue->height_adjusted,
+		queue->sizeimage[0], queue->sizeimage[1],
+		(queue->fmt->fourcc & 0xff),
+		(queue->fmt->fourcc >>  8) & 0xff,
+		(queue->fmt->fourcc >> 16) & 0xff,
+		(queue->fmt->fourcc >> 24) & 0xff);
+
+	return 0;
+}
+
+static int e5010_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
+{
+	struct e5010_context *ctx = file->private_data;
+
+	return e5010_jpeg_try_fmt(f, ctx);
+}
+
+static int e5010_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
+{
+	struct e5010_context *ctx = file->private_data;
+	struct vb2_queue *vq;
+
+	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
+	if (!vq)
+		return -EINVAL;
+
+	if (vb2_is_busy(vq)) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "queue busy\n");
+		return -EBUSY;
+	}
+
+	return e5010_jpeg_try_fmt(f, ctx);
+}
+
+static int e5010_enum_framesizes(struct file *file, void *priv, struct v4l2_frmsizeenum *fsize)
+{
+	struct v4l2_format f;
+	struct e5010_fmt *fmt;
+
+	if (fsize->index != 0)
+		return -EINVAL;
+
+	f.fmt.pix_mp.pixelformat = fsize->pixel_format;
+	if (f.fmt.pix_mp.pixelformat ==  V4L2_PIX_FMT_JPEG)
+		f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
+	else
+		f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
+
+	fmt = find_format(&f);
+	if (!fmt)
+		return -EINVAL;
+
+	fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
+	fsize->stepwise = fmt->frmsize;
+	fsize->reserved[0] = 0;
+	fsize->reserved[1] = 0;
+
+	return 0;
+}
+
+static int e5010_g_selection(struct file *file, void *fh, struct v4l2_selection *s)
+{
+	struct e5010_context *ctx = file->private_data;
+	struct e5010_q_data *queue;
+
+	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
+		return -EINVAL;
+
+	queue = get_queue(ctx, s->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	switch (s->target) {
+	case V4L2_SEL_TGT_CROP_DEFAULT:
+	case V4L2_SEL_TGT_CROP_BOUNDS:
+		s->r.left = 0;
+		s->r.top = 0;
+		s->r.width = queue->width;
+		s->r.height = queue->height;
+		break;
+	case V4L2_SEL_TGT_CROP:
+		s->r = queue->crop;
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int e5010_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
+{
+	struct e5010_context *ctx = file->private_data;
+	struct e5010_q_data *queue;
+
+	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
+		return -EINVAL;
+
+	queue = get_queue(ctx, s->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	queue->crop.left = 0;
+	queue->crop.top = 0;
+	queue->crop.width = s->r.width;
+	queue->crop.height = s->r.height;
+
+	return 0;
+}
+
+static int e5010_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subscription *sub)
+{
+	switch (sub->type) {
+	case V4L2_EVENT_EOS:
+		return v4l2_event_subscribe(fh, sub, 0, NULL);
+	case V4L2_EVENT_CTRL:
+		return v4l2_ctrl_subscribe_event(fh, sub);
+	default:
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
+{
+	struct e5010_context *ctx = priv;
+	struct e5010_dev *e5010 = ctx->e5010;
+	int ret = 0;
+
+	/* src_vq */
+	memset(src_vq, 0, sizeof(*src_vq));
+	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
+	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
+	src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	src_vq->drv_priv = ctx;
+	src_vq->buf_struct_size = sizeof(struct e5010_buffer);
+	src_vq->ops = &e5010_video_ops;
+	src_vq->mem_ops = &vb2_dma_contig_memops;
+	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
+	src_vq->lock = &e5010->mutex;
+	src_vq->dev = e5010->v4l2_dev.dev;
+
+	ret = vb2_queue_init(src_vq);
+	if (ret)
+		return ret;
+
+	/* dst_vq */
+	memset(dst_vq, 0, sizeof(*dst_vq));
+	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
+	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
+	dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
+	dst_vq->drv_priv = ctx;
+	dst_vq->buf_struct_size = sizeof(struct e5010_buffer);
+	dst_vq->ops = &e5010_video_ops;
+	dst_vq->mem_ops = &vb2_dma_contig_memops;
+	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
+	dst_vq->lock = &e5010->mutex;
+	dst_vq->dev = e5010->v4l2_dev.dev;
+
+	ret = vb2_queue_init(dst_vq);
+	if (ret) {
+		vb2_queue_release(src_vq);
+		return ret;
+	}
+
+	return 0;
+}
+
+static int e5010_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+	struct e5010_context *ctx =
+		container_of(ctrl->handler, struct e5010_context, ctrl_handler);
+
+	switch (ctrl->id) {
+	case V4L2_CID_JPEG_COMPRESSION_QUALITY:
+		ctx->quality = ctrl->val;
+		calculate_qp_tables(ctx);
+		break;
+	default:
+		v4l2_err(&ctx->e5010->v4l2_dev, "Invalid control, id = %d, val = %d\n",
+			 ctrl->id, ctrl->val);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static const struct v4l2_ctrl_ops e5010_ctrl_ops = {
+	.s_ctrl = e5010_s_ctrl,
+};
+
+static void e5010_encode_ctrls(struct e5010_context *ctx)
+{
+	v4l2_ctrl_new_std(&ctx->ctrl_handler, &e5010_ctrl_ops,
+			  V4L2_CID_JPEG_COMPRESSION_QUALITY, 1, 100, 1, 75);
+}
+
+static int e5010_ctrls_setup(struct e5010_context *ctx)
+{
+	int err;
+
+	v4l2_ctrl_handler_init(&ctx->ctrl_handler, 1);
+
+	e5010_encode_ctrls(ctx);
+
+	if (ctx->ctrl_handler.error) {
+		err = ctx->ctrl_handler.error;
+		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
+
+		return err;
+	}
+
+	err = v4l2_ctrl_handler_setup(&ctx->ctrl_handler);
+	if (err)
+		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
+
+	return err;
+}
+
+static void e5010_jpeg_set_default_params(struct e5010_context *ctx)
+{
+	struct e5010_q_data *queue;
+	struct v4l2_format f;
+	struct e5010_fmt *fmt;
+	struct v4l2_pix_format_mplane *pix_mp = &f.fmt.pix_mp;
+	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
+	int i = 0;
+
+	f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
+	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12;
+	fmt = find_format(&f);
+	queue = &ctx->out_queue;
+	queue->fmt = fmt;
+	queue->width = DEFAULT_WIDTH;
+	queue->height = DEFAULT_HEIGHT;
+	v4l2_apply_frmsize_constraints(&pix_mp->width,
+				       &pix_mp->height,
+				       &fmt->frmsize);
+	v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
+			    pix_mp->width, pix_mp->height);
+	for (i = 0; i < fmt->num_planes; i++) {
+		queue->bytesperline[i] = plane_fmt[i].bytesperline;
+		queue->sizeimage[i] = plane_fmt[i].sizeimage;
+	}
+	queue->width_adjusted = pix_mp->width;
+	queue->height_adjusted = pix_mp->height;
+	queue->format_set = false;
+	queue->streaming = false;
+
+	f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
+	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_JPEG;
+	fmt = find_format(&f);
+	queue = &ctx->cap_queue;
+	queue->fmt = fmt;
+	queue->width = DEFAULT_WIDTH;
+	queue->height = DEFAULT_HEIGHT;
+	v4l2_apply_frmsize_constraints(&pix_mp->width,
+				       &pix_mp->height,
+				       &fmt->frmsize);
+	queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
+	queue->sizeimage[0] += HEADER_SIZE;
+	queue->sizeimage[1] = 0;
+	queue->bytesperline[0] = 0;
+	queue->bytesperline[1] = 0;
+	queue->format_set = false;
+	queue->streaming = false;
+	queue->width_adjusted = pix_mp->width;
+	queue->height_adjusted = pix_mp->height;
+}
+
+static int e5010_open(struct file *file)
+{
+	struct e5010_dev *e5010 = video_drvdata(file);
+	struct video_device *vdev = video_devdata(file);
+	struct e5010_context *ctx;
+	int ret = 0;
+
+	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return -ENOMEM;
+
+	if (mutex_lock_interruptible(&e5010->mutex)) {
+		ret = -ERESTARTSYS;
+		goto free;
+	}
+
+	v4l2_fh_init(&ctx->fh, vdev);
+	file->private_data = ctx;
+	v4l2_fh_add(&ctx->fh);
+
+	ctx->e5010 = e5010;
+	ctx->fh.m2m_ctx = v4l2_m2m_ctx_init(e5010->m2m_dev, ctx, queue_init);
+	if (IS_ERR(ctx->fh.m2m_ctx)) {
+		v4l2_err(&e5010->v4l2_dev, "failed to init m2m ctx\n");
+		ret = PTR_ERR(ctx->fh.m2m_ctx);
+		goto exit;
+	}
+
+	ret = e5010_ctrls_setup(ctx);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to setup e5010 jpeg controls\n");
+		goto err_ctrls_setup;
+	}
+	ctx->fh.ctrl_handler = &ctx->ctrl_handler;
+
+	e5010_jpeg_set_default_params(ctx);
+
+	dprintk(e5010, 1, "Created instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
+
+	mutex_unlock(&e5010->mutex);
+	return 0;
+
+err_ctrls_setup:
+	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
+exit:
+	v4l2_fh_del(&ctx->fh);
+	v4l2_fh_exit(&ctx->fh);
+	mutex_unlock(&e5010->mutex);
+free:
+	kfree(ctx);
+	return ret;
+}
+
+static int e5010_release(struct file *file)
+{
+	struct e5010_dev *e5010 = video_drvdata(file);
+	struct e5010_context *ctx = file->private_data;
+
+	dprintk(e5010, 1, "Releasing instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
+	mutex_lock(&e5010->mutex);
+	v4l2_ctrl_handler_free(&ctx->ctrl_handler);
+	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
+	v4l2_fh_del(&ctx->fh);
+	v4l2_fh_exit(&ctx->fh);
+	kfree(ctx);
+	mutex_unlock(&e5010->mutex);
+
+	return 0;
+}
+
+static struct video_device e5010_videodev = {
+	.name = E5010_MODULE_NAME,
+	.fops = &e5010_fops,
+	.ioctl_ops = &e5010_ioctl_ops,
+	.minor = -1,
+	.release = video_device_release_empty,
+	.vfl_dir = VFL_DIR_M2M,
+	.device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING,
+};
+
+static void header_write(struct e5010_context *ctx, u8 *addr, unsigned int *offset,
+			 unsigned int no_bytes, unsigned long bits)
+{
+	u8 *w_addr = addr + *offset;
+	int i;
+
+	if ((*offset + no_bytes) > HEADER_SIZE) {
+		v4l2_warn(&ctx->e5010->v4l2_dev, "%s: %s: %d: Problem writing header. %d > HEADER_SIZE %d\n",
+			  __FILE__, __func__, __LINE__, *offset + no_bytes, HEADER_SIZE);
+		return;
+	}
+
+	for (i = no_bytes - 1; i >= 0; i--)
+		*(w_addr++) = ((u8 *)&bits)[i];
+
+	*offset += no_bytes;
+}
+
+static void encode_marker_segment(struct e5010_context *ctx, void *addr, unsigned int *offset)
+{
+	u8 *buffer = (u8 *)addr;
+	int i;
+
+	header_write(ctx, buffer, offset, 2, START_OF_IMAGE);
+	header_write(ctx, buffer, offset, 2, DQT_MARKER);
+	header_write(ctx, buffer, offset, 3, LQPQ << 4);
+	for (i = 0; i < PELS_IN_BLOCK; i++)
+		header_write(ctx, buffer, offset, 1, ctx->luma_qp[zigzag[i]]);
+
+	header_write(ctx, buffer, offset, 2, DQT_MARKER);
+	header_write(ctx, buffer, offset, 3, (LQPQ << 4) | 1);
+	for (i = 0; i < PELS_IN_BLOCK; i++)
+		header_write(ctx, buffer, offset, 1, ctx->chroma_qp[zigzag[i]]);
+
+	/* Huffman tables */
+	header_write(ctx, buffer, offset, 2, DHT_MARKER);
+	header_write(ctx, buffer, offset, 2, LH_DC);
+	for (i = 0 ; i < (LH_DC - 2); i++)
+		header_write(ctx, buffer, offset, 1, marker_luma_dc[i]);
+
+	header_write(ctx, buffer, offset, 2, DHT_MARKER);
+	header_write(ctx, buffer, offset, 2, LH_AC);
+	for (i = 0 ; i < (LH_AC - 2); i++)
+		header_write(ctx, buffer, offset, 1, marker_luma_ac[i]);
+
+	header_write(ctx, buffer, offset, 2, DHT_MARKER);
+	header_write(ctx, buffer, offset, 2, LH_DC);
+	for (i = 0 ; i < (LH_DC - 2); i++)
+		header_write(ctx, buffer, offset, 1, marker_chroma_dc[i]);
+
+	header_write(ctx, buffer, offset, 2, DHT_MARKER);
+	header_write(ctx, buffer, offset, 2, LH_AC);
+	for (i = 0 ; i < (LH_AC - 2); i++)
+		header_write(ctx, buffer, offset, 1, marker_chroma_ac[i]);
+}
+
+static void encode_frame_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
+{
+	u8 *buffer = (u8 *)addr;
+
+	header_write(ctx, buffer, offset, 2, SOF_BASELINE_DCT);
+	header_write(ctx, buffer, offset, 2, 8 + (3 * UC_NUM_COMP));
+	header_write(ctx, buffer, offset, 1, PRECISION);
+	header_write(ctx, buffer, offset, 2, ctx->out_queue.height);
+	header_write(ctx, buffer, offset, 2, ctx->out_queue.width);
+	header_write(ctx, buffer, offset, 1, UC_NUM_COMP);
+
+	/* Luma details */
+	header_write(ctx, buffer, offset, 1, 1);
+	if (ctx->out_queue.fmt->subsampling == V4L2_JPEG_CHROMA_SUBSAMPLING_422)
+		header_write(ctx, buffer, offset, 1,
+			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_422));
+	else
+		header_write(ctx, buffer, offset, 1,
+			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_420));
+	header_write(ctx, buffer, offset, 1, 0);
+	/* Chroma details */
+	header_write(ctx, buffer, offset, 1, 2);
+	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
+	header_write(ctx, buffer, offset, 1, 1);
+	header_write(ctx, buffer, offset, 1, 3);
+	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
+	header_write(ctx, buffer, offset, 1, 1);
+
+	header_write(ctx, buffer, offset, 1, 0xFF);
+}
+
+static void jpg_encode_sos_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
+{
+	u8 *buffer = (u8 *)addr;
+	int i;
+
+	header_write(ctx, buffer, offset, 2, START_OF_SCAN);
+	header_write(ctx, buffer, offset, 2, 6 + (COMPONENTS_IN_SCAN << 1));
+	header_write(ctx, buffer, offset, 1, COMPONENTS_IN_SCAN);
+
+	for (i = 0; i < COMPONENTS_IN_SCAN; i++) {
+		header_write(ctx, buffer, offset, 1, i + 1);
+		if (i == 0)
+			header_write(ctx, buffer, offset, 1, 0);
+		else
+			header_write(ctx, buffer, offset, 1, 17);
+	}
+
+	header_write(ctx, buffer, offset, 1, 0);
+	header_write(ctx, buffer, offset, 1, 63);
+	header_write(ctx, buffer, offset, 1, 0);
+}
+
+static void write_header(struct e5010_context *ctx, void *addr)
+{
+	unsigned int offset = 0;
+
+	encode_marker_segment(ctx, addr, &offset);
+	encode_frame_header(ctx, addr, &offset);
+	jpg_encode_sos_header(ctx, addr, &offset);
+}
+
+static irqreturn_t e5010_irq(int irq, void *data)
+{
+	struct e5010_dev *e5010 = data;
+	struct e5010_context *ctx;
+	int output_size;
+	struct vb2_v4l2_buffer *src_buf, *dst_buf;
+	bool pic_done, out_addr_err;
+
+	spin_lock(&e5010->hw_lock);
+	pic_done = e5010_hw_pic_done_irq(e5010->core_base);
+	out_addr_err = e5010_hw_output_address_irq(e5010->core_base);
+
+	if (!pic_done && !out_addr_err) {
+		spin_unlock(&e5010->hw_lock);
+		return IRQ_NONE;
+	}
+
+	ctx = v4l2_m2m_get_curr_priv(e5010->m2m_dev);
+	if (WARN_ON(!ctx))
+		goto job_unlock;
+
+	dst_buf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
+	src_buf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+	if (!dst_buf || !src_buf) {
+		v4l2_err(&e5010->v4l2_dev, "ctx: 0x%p No source or destination buffer\n", ctx);
+		goto job_unlock;
+	}
+
+	if (out_addr_err) {
+		e5010_hw_clear_output_error(e5010->core_base, 1);
+		v4l2_warn(&e5010->v4l2_dev,
+			  "ctx: 0x%p Output bitstream size exceeded max size\n", ctx);
+		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
+		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, dst_buf->planes[0].length);
+		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR);
+		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
+			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
+			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
+			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
+			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
+		}
+	}
+
+	if (pic_done) {
+		e5010_hw_clear_picture_done(e5010->core_base, 1);
+		dprintk(e5010, 3, "ctx: 0x%p Got output bitstream of size %d bytes\n",
+			ctx, readl(e5010->core_base + JASPER_OUTPUT_SIZE_OFFSET));
+
+		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
+			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
+			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
+			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
+			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
+		}
+		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE);
+		output_size = e5010_hw_get_output_size(e5010->core_base);
+		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, output_size + HEADER_SIZE);
+		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE);
+		dprintk(e5010, 3,
+			"ctx: 0x%p frame done for dst_buf->sequence: %d src_buf->sequence: %d\n",
+			ctx, dst_buf->sequence, src_buf->sequence);
+	}
+
+	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
+	dprintk(e5010, 3, "ctx: 0x%p Finish job\n", ctx);
+
+job_unlock:
+	spin_unlock(&e5010->hw_lock);
+	return IRQ_HANDLED;
+}
+
+static int e5010_init_device(struct e5010_dev *e5010)
+{
+	int ret = 0;
+
+	/*TODO: Set MMU in bypass mode until support for the same is added in driver*/
+	e5010_hw_bypass_mmu(e5010->mmu_base, 1);
+
+	if (e5010_hw_enable_auto_clock_gating(e5010->core_base, 1))
+		v4l2_warn(&e5010->v4l2_dev, "failed to enable auto clock gating\n");
+
+	if (e5010_hw_enable_manual_clock_gating(e5010->core_base, 0))
+		v4l2_warn(&e5010->v4l2_dev, "failed to disable manual clock gating\n");
+
+	if (e5010_hw_enable_crc_check(e5010->core_base, 0))
+		v4l2_warn(&e5010->v4l2_dev, "failed to disable CRC check\n");
+
+	if (e5010_hw_enable_output_address_error_irq(e5010->core_base, 1))
+		v4l2_err(&e5010->v4l2_dev, "failed to enable Output Address Error interrupts\n");
+
+	ret = e5010_hw_set_input_source_to_memory(e5010->core_base, 1);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input source to memory\n");
+		return ret;
+	}
+
+	ret = e5010_hw_enable_picture_done_irq(e5010->core_base, 1);
+	if (ret)
+		v4l2_err(&e5010->v4l2_dev, "failed to enable Picture Done interrupts\n");
+
+	return ret;
+}
+
+static int e5010_probe(struct platform_device *pdev)
+{
+	struct e5010_dev *e5010;
+	int irq, ret = 0;
+
+	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+	if (ret)
+		return dev_err_probe(e5010->dev, ret, "32-bit consistent DMA enable failed\n");
+
+	e5010 = devm_kzalloc(&pdev->dev, sizeof(*e5010), GFP_KERNEL);
+	if (!e5010)
+		return -ENOMEM;
+
+	platform_set_drvdata(pdev, e5010);
+
+	e5010->dev = &pdev->dev;
+
+	mutex_init(&e5010->mutex);
+	spin_lock_init(&e5010->hw_lock);
+
+	e5010->vdev = &e5010_videodev;
+	e5010->vdev->v4l2_dev = &e5010->v4l2_dev;
+	e5010->vdev->lock = &e5010->mutex;
+	e5010->vdev->queue = NULL;
+	e5010->vdev->prio = NULL;
+	e5010->vdev->dev_parent = NULL;
+	e5010->vdev->minor = -1;
+
+	ret = v4l2_device_register(&pdev->dev, &e5010->v4l2_dev);
+	if (ret)
+		return dev_err_probe(e5010->dev, ret, "failed to register v4l2 device\n");
+
+	e5010->m2m_dev = v4l2_m2m_init(&e5010_m2m_ops);
+	if (IS_ERR(e5010->m2m_dev)) {
+		ret = PTR_ERR(e5010->m2m_dev);
+		e5010->m2m_dev = NULL;
+		dev_err_probe(e5010->dev, ret, "failed to init mem2mem device\n");
+		goto fail_after_v4l2_register;
+	}
+
+	video_set_drvdata(e5010->vdev, e5010);
+
+	ret = video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0);
+	if (ret) {
+		dev_err_probe(e5010->dev, ret, "failed to register video device\n");
+		goto fail_after_v4l2_register;
+	}
+
+	v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n",
+		  e5010->vdev->num);
+
+	e5010->core_base = devm_platform_ioremap_resource_byname(pdev, "core");
+	if (IS_ERR(e5010->core_base)) {
+		ret = PTR_ERR(e5010->core_base);
+		dev_err_probe(e5010->dev, ret, "Missing 'core' resources area\n");
+		goto fail_after_video_register_device;
+	}
+
+	e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu");
+	if (IS_ERR(e5010->mmu_base)) {
+		ret = PTR_ERR(e5010->mmu_base);
+		dev_err_probe(e5010->dev, ret, "Missing 'mmu' resources area\n");
+		goto fail_after_video_register_device;
+	}
+
+	e5010->last_context_run = NULL;
+
+	irq = platform_get_irq(pdev, 0);
+	ret = devm_request_irq(e5010->dev, irq, e5010_irq, 0,
+			       E5010_MODULE_NAME, e5010);
+	if (ret) {
+		dev_err_probe(e5010->dev, ret, "failed to register IRQ %d\n", irq);
+		goto fail_after_video_register_device;
+	}
+
+	e5010->clk = devm_clk_get(&pdev->dev, "core_clk");
+	if (IS_ERR(e5010->clk)) {
+		ret = PTR_ERR(e5010->clk);
+		dev_err_probe(e5010->dev, ret, "failed to get clock\n");
+		goto fail_after_video_register_device;
+	}
+
+	pm_runtime_enable(e5010->dev);
+
+	return 0;
+
+fail_after_video_register_device:
+	v4l2_m2m_release(e5010->m2m_dev);
+fail_after_v4l2_register:
+	v4l2_device_unregister(&e5010->v4l2_dev);
+	return ret;
+}
+
+static int e5010_remove(struct platform_device *pdev)
+{
+	struct e5010_dev *e5010 = platform_get_drvdata(pdev);
+
+	pm_runtime_disable(e5010->dev);
+	video_unregister_device(e5010->vdev);
+	v4l2_m2m_release(e5010->m2m_dev);
+	v4l2_device_unregister(&e5010->v4l2_dev);
+
+	return 0;
+}
+
+static int e5010_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsigned int *nplanes,
+			     unsigned int sizes[], struct device *alloc_devs[])
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(vq);
+	struct e5010_q_data *queue;
+	int i;
+
+	if (!V4L2_TYPE_IS_MULTIPLANAR(vq->type)) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "queue setup with Invalid type: %d\n", vq->type);
+		return -EINVAL;
+	}
+
+	queue = get_queue(ctx, vq->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	if (*nplanes) {
+		if (*nplanes != queue->fmt->num_planes)
+			return -EINVAL;
+		for (i = 0; i < *nplanes; i++) {
+			if (sizes[i] < queue->sizeimage[i])
+				return -EINVAL;
+		}
+		return 0;
+	}
+
+	*nbuffers = max_t(unsigned int, *nbuffers, 1);
+	*nplanes = queue->fmt->num_planes;
+	for (i = 0; i < *nplanes; i++)
+		sizes[i] = queue->sizeimage[i];
+
+	dprintk(ctx->e5010, 2,
+		"ctx: 0x%p, type %s, buffer(s): %d, planes %d, plane1: bytes %d plane2: %d bytes\n",
+		ctx, type_name(vq->type), *nbuffers, *nplanes, sizes[0], sizes[1]);
+
+	return 0;
+}
+
+static void e5010_buf_finish(struct vb2_buffer *vb)
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
+	void *d_addr;
+
+	if (vb->state != VB2_BUF_STATE_DONE || V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
+		return;
+
+	d_addr = vb2_plane_vaddr(vb, 0);
+	write_header(ctx, d_addr);
+}
+
+static int e5010_buf_out_validate(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
+	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
+
+	if (vbuf->field != V4L2_FIELD_NONE)
+		dprintk(ctx->e5010, 1, "ctx: 0x%p, field isn't supported\n", ctx);
+
+	vbuf->field = V4L2_FIELD_NONE;
+
+	return 0;
+}
+
+static int e5010_buf_prepare(struct vb2_buffer *vb)
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
+	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
+	struct e5010_q_data *queue;
+	int i;
+
+	vbuf->field = V4L2_FIELD_NONE;
+
+	queue = get_queue(ctx, vb->vb2_queue->type);
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+
+	for (i = 0; i < queue->fmt->num_planes; i++) {
+		if (vb2_plane_size(vb, i) < (unsigned long)queue->sizeimage[i]) {
+			v4l2_err(&ctx->e5010->v4l2_dev, "plane %d too small (%lu < %lu)", i,
+				 vb2_plane_size(vb, i), (unsigned long)queue->sizeimage[i]);
+
+			return -EINVAL;
+		}
+	}
+
+	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type)) {
+		vb2_set_plane_payload(vb, 0, 0);
+		vb2_set_plane_payload(vb, 1, 0);
+	}
+
+	return 0;
+}
+
+static void e5010_buf_queue(struct vb2_buffer *vb)
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
+	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
+
+	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type) &&
+	    vb2_is_streaming(vb->vb2_queue) &&
+	    v4l2_m2m_dst_buf_is_last(ctx->fh.m2m_ctx)) {
+		struct e5010_q_data *queue = get_queue(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
+
+		if (IS_ERR(queue))
+			return;
+
+		vbuf->sequence = queue->sequence++;
+		v4l2_m2m_last_buffer_done(ctx->fh.m2m_ctx, vbuf);
+		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
+		return;
+	}
+
+	v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
+}
+
+static int e5010_encoder_cmd(struct file *file, void *priv,
+			     struct v4l2_encoder_cmd *cmd)
+{
+	struct e5010_context *ctx = file->private_data;
+	int ret;
+	struct vb2_queue *cap_vq;
+
+	cap_vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
+
+	ret = v4l2_m2m_ioctl_try_encoder_cmd(file, &ctx->fh, cmd);
+	if (ret < 0)
+		return ret;
+
+	if (!vb2_is_streaming(v4l2_m2m_get_src_vq(ctx->fh.m2m_ctx)) ||
+	    !vb2_is_streaming(v4l2_m2m_get_dst_vq(ctx->fh.m2m_ctx)))
+		return 0;
+
+	ret = v4l2_m2m_ioctl_encoder_cmd(file, &ctx->fh, cmd);
+	if (ret < 0)
+		return ret;
+
+	if (cmd->cmd == V4L2_ENC_CMD_STOP &&
+	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
+		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
+
+	if (cmd->cmd == V4L2_ENC_CMD_START &&
+	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
+		vb2_clear_last_buffer_dequeued(cap_vq);
+
+	return 0;
+}
+
+static int e5010_start_streaming(struct vb2_queue *q, unsigned int count)
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(q);
+	int ret;
+
+	struct e5010_q_data *queue = get_queue(ctx, q->type);
+
+	if (IS_ERR(queue))
+		return PTR_ERR(queue);
+	queue->streaming = true;
+	v4l2_m2m_update_start_streaming_state(ctx->fh.m2m_ctx, q);
+	queue->sequence = 0;
+
+	ret = pm_runtime_resume_and_get(ctx->e5010->dev);
+	if (ret < 0) {
+		v4l2_err(&ctx->e5010->v4l2_dev, "failed to power up jpeg\n");
+		return ret;
+	}
+
+	ret = e5010_init_device(ctx->e5010);
+	if (ret)
+		v4l2_err(&ctx->e5010->v4l2_dev, "failed to Enable e5010 device\n");
+
+	return ret;
+}
+
+static void e5010_stop_streaming(struct vb2_queue *q)
+{
+	struct e5010_context *ctx = vb2_get_drv_priv(q);
+	struct vb2_v4l2_buffer *vbuf;
+	struct e5010_q_data *queue;
+
+	queue = get_queue(ctx, q->type);
+	if (IS_ERR(queue))
+		return;
+
+	queue->streaming = false;
+
+	if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
+		while ((vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx))) {
+			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
+				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
+			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
+		}
+	} else {
+		while ((vbuf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx))) {
+			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
+				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
+			vb2_set_plane_payload(&vbuf->vb2_buf, 0, 0);
+			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
+		}
+	}
+
+	if (V4L2_TYPE_IS_OUTPUT(q->type))
+		v4l2_m2m_update_stop_streaming_state(ctx->fh.m2m_ctx, q);
+
+	if (V4L2_TYPE_IS_OUTPUT(q->type) &&
+	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx)) {
+		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
+	}
+
+	pm_runtime_put_sync(ctx->e5010->dev);
+}
+
+static void e5010_device_run(void *priv)
+{
+	struct e5010_context *ctx = priv;
+	struct e5010_dev *e5010 = ctx->e5010;
+	struct vb2_v4l2_buffer *s_vb, *d_vb;
+	u32 reg = 0;
+	int ret = 0;
+	unsigned long flags;
+	int num_planes = ctx->out_queue.fmt->num_planes;
+
+	spin_lock_irqsave(&e5010->hw_lock, flags);
+	s_vb = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
+	WARN_ON(!s_vb);
+	d_vb = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx);
+	WARN_ON(!d_vb);
+	if (!s_vb || !d_vb)
+		goto no_ready_buf_err;
+
+	s_vb->sequence = ctx->out_queue.sequence++;
+	d_vb->sequence = ctx->cap_queue.sequence++;
+
+	v4l2_m2m_buf_copy_metadata(s_vb, d_vb, false);
+
+	if (ctx != e5010->last_context_run || ctx->update_qp) {
+		dprintk(e5010, 1, "ctx updated: 0x%p -> 0x%p, updating qp tables\n",
+			e5010->last_context_run, ctx);
+		ret = update_qp_tables(ctx);
+	}
+
+	if (ret) {
+		ctx->update_qp = true;
+		v4l2_err(&e5010->v4l2_dev, "failed to update QP tables\n");
+		goto device_busy_err;
+	} else {
+		e5010->last_context_run = ctx;
+		ctx->update_qp = false;
+	}
+
+	/* Set I/O Buffer addresses */
+	reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0);
+	ret = e5010_hw_set_input_luma_addr(e5010->core_base, reg);
+	if (ret || !reg) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input luma address\n");
+		goto device_busy_err;
+	}
+
+	if (num_planes == 1)
+		reg += (ctx->out_queue.bytesperline[0]) * (ctx->out_queue.height);
+	else
+		reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 1);
+
+	dprintk(e5010, 3,
+		"ctx: 0x%p, luma_addr: 0x%x, chroma_addr: 0x%x, out_addr: 0x%x\n",
+		ctx, (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0), reg,
+		(u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0));
+
+	dprintk(e5010, 3,
+		"ctx: 0x%p, buf indices: src_index: %d, dst_index: %d\n",
+		ctx, s_vb->vb2_buf.index, d_vb->vb2_buf.index);
+
+	ret = e5010_hw_set_input_chroma_addr(e5010->core_base, reg);
+	if (ret || !reg) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input chroma address\n");
+		goto device_busy_err;
+	}
+
+	reg = (u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0);
+	reg += HEADER_SIZE;
+	ret = e5010_hw_set_output_base_addr(e5010->core_base, reg);
+	if (ret || !reg) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set output size\n");
+		goto device_busy_err;
+	}
+
+	/* Set input settings */
+	ret = e5010_hw_set_horizontal_size(e5010->core_base, ctx->out_queue.width - 1);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
+		goto device_busy_err;
+	}
+
+	ret = e5010_hw_set_vertical_size(e5010->core_base, ctx->out_queue.height - 1);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
+		goto device_busy_err;
+	}
+
+	ret = e5010_hw_set_luma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set luma stride\n");
+		goto device_busy_err;
+	}
+
+	ret = e5010_hw_set_chroma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set chroma stride\n");
+		goto device_busy_err;
+	}
+
+	ret = e5010_set_input_subsampling(e5010->core_base, ctx->out_queue.fmt->subsampling);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set input subsampling\n");
+		goto device_busy_err;
+	}
+
+	ret = e5010_hw_set_chroma_order(e5010->core_base, ctx->out_queue.fmt->chroma_order);
+	if (ret) {
+		v4l2_err(&e5010->v4l2_dev, "failed to set chroma order\n");
+		goto device_busy_err;
+	}
+
+	e5010_hw_set_output_max_size(e5010->core_base, d_vb->planes[0].length);
+	e5010_hw_encode_start(e5010->core_base, 1);
+
+	spin_unlock_irqrestore(&e5010->hw_lock, flags);
+
+	return;
+
+device_busy_err:
+	e5010_reset(e5010->dev, e5010->core_base, e5010->mmu_base);
+
+no_ready_buf_err:
+	if (s_vb) {
+		v4l2_m2m_src_buf_remove_by_buf(ctx->fh.m2m_ctx, s_vb);
+		v4l2_m2m_buf_done(s_vb, VB2_BUF_STATE_ERROR);
+	}
+
+	if (d_vb) {
+		v4l2_m2m_dst_buf_remove_by_buf(ctx->fh.m2m_ctx, d_vb);
+		/* Payload set to 1 since 0 payload can trigger EOS */
+		vb2_set_plane_payload(&d_vb->vb2_buf, 0, 1);
+		v4l2_m2m_buf_done(d_vb, VB2_BUF_STATE_ERROR);
+	}
+	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
+	spin_unlock_irqrestore(&e5010->hw_lock, flags);
+}
+
+#ifdef CONFIG_PM
+static int e5010_runtime_resume(struct device *dev)
+{
+	struct e5010_dev *e5010 = dev_get_drvdata(dev);
+	int ret;
+
+	ret = clk_prepare_enable(e5010->clk);
+	if (ret < 0) {
+		v4l2_err(&e5010->v4l2_dev, "failed to enable clock\n");
+		return ret;
+	}
+
+	return 0;
+}
+
+static int e5010_runtime_suspend(struct device *dev)
+{
+	struct e5010_dev *e5010 = dev_get_drvdata(dev);
+
+	clk_disable_unprepare(e5010->clk);
+
+	return 0;
+}
+#endif
+
+#ifdef CONFIG_PM_SLEEP
+static int e5010_suspend(struct device *dev)
+{
+	struct e5010_dev *e5010 = dev_get_drvdata(dev);
+
+	v4l2_m2m_suspend(e5010->m2m_dev);
+
+	return pm_runtime_force_suspend(dev);
+}
+
+static int e5010_resume(struct device *dev)
+{
+	struct e5010_dev *e5010 = dev_get_drvdata(dev);
+	int ret;
+
+	ret = pm_runtime_force_resume(dev);
+	if (ret < 0)
+		return ret;
+
+	v4l2_m2m_resume(e5010->m2m_dev);
+
+	return ret;
+}
+#endif
+
+static const struct dev_pm_ops	e5010_pm_ops = {
+	SET_RUNTIME_PM_OPS(e5010_runtime_suspend,
+			   e5010_runtime_resume, NULL)
+	SET_SYSTEM_SLEEP_PM_OPS(e5010_suspend, e5010_resume)
+};
+
+static const struct v4l2_ioctl_ops e5010_ioctl_ops = {
+	.vidioc_querycap = e5010_querycap,
+
+	.vidioc_enum_fmt_vid_cap = e5010_enum_fmt,
+	.vidioc_g_fmt_vid_cap_mplane = e5010_g_fmt,
+	.vidioc_try_fmt_vid_cap_mplane = e5010_try_fmt,
+	.vidioc_s_fmt_vid_cap_mplane = e5010_s_fmt,
+
+	.vidioc_enum_fmt_vid_out = e5010_enum_fmt,
+	.vidioc_g_fmt_vid_out_mplane = e5010_g_fmt,
+	.vidioc_try_fmt_vid_out_mplane = e5010_try_fmt,
+	.vidioc_s_fmt_vid_out_mplane = e5010_s_fmt,
+
+	.vidioc_g_selection = e5010_g_selection,
+	.vidioc_s_selection = e5010_s_selection,
+
+	.vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
+	.vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
+	.vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
+	.vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
+	.vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
+	.vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
+	.vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
+
+	.vidioc_streamon = v4l2_m2m_ioctl_streamon,
+	.vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
+	.vidioc_log_status = v4l2_ctrl_log_status,
+
+	.vidioc_subscribe_event = e5010_subscribe_event,
+	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
+	.vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
+	.vidioc_encoder_cmd = e5010_encoder_cmd,
+
+	.vidioc_enum_framesizes = e5010_enum_framesizes,
+};
+
+static const struct vb2_ops e5010_video_ops = {
+	.queue_setup = e5010_queue_setup,
+	.buf_queue = e5010_buf_queue,
+	.buf_finish = e5010_buf_finish,
+	.buf_prepare = e5010_buf_prepare,
+	.buf_out_validate = e5010_buf_out_validate,
+	.wait_prepare = vb2_ops_wait_prepare,
+	.wait_finish = vb2_ops_wait_finish,
+	.start_streaming = e5010_start_streaming,
+	.stop_streaming = e5010_stop_streaming,
+};
+
+static const struct v4l2_file_operations e5010_fops = {
+	.owner = THIS_MODULE,
+	.open = e5010_open,
+	.release = e5010_release,
+	.poll = v4l2_m2m_fop_poll,
+	.unlocked_ioctl = video_ioctl2,
+	.mmap = v4l2_m2m_fop_mmap,
+};
+
+static const struct v4l2_m2m_ops e5010_m2m_ops = {
+	.device_run = e5010_device_run,
+};
+
+static const struct of_device_id e5010_of_match[] = {
+	{.compatible = "img,e5010-jpeg-enc"},   { /* end */},
+};
+MODULE_DEVICE_TABLE(of, e5010_of_match);
+
+static struct platform_driver e5010_driver = {
+	.probe = e5010_probe,
+	.remove = e5010_remove,
+	.driver = {
+		.name = E5010_MODULE_NAME,
+		.of_match_table = e5010_of_match,
+		.pm = &e5010_pm_ops,
+	},
+};
+module_platform_driver(e5010_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Imagination E5010 JPEG encoder driver");
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.h b/drivers/media/platform/imagination/e5010-jpeg-enc.h
new file mode 100644
index 000000000000..3a47b0327101
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc.h
@@ -0,0 +1,169 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-fh.h>
+
+#ifndef _E5010_JPEG_ENC_H
+#define _E5010_JPEG_ENC_H
+
+#define MAX_PLANES			2
+#define HEADER_SIZE			0x025E
+#define MIN_DIMENSION			64
+#define MAX_DIMENSION			8192
+#define DEFAULT_WIDTH			640
+#define DEFAULT_HEIGHT			480
+#define E5010_MODULE_NAME		"e5010"
+#define JPEG_MAX_BYTES_PER_PIXEL	2
+
+/* JPEG marker definitions */
+#define START_OF_IMAGE			0xFFD8
+#define SOF_BASELINE_DCT		0xFFC0
+#define END_OF_IMAGE			0xFFD9
+#define START_OF_SCAN			0xFFDA
+
+/* Definitions for the huffman table specification in the Marker segment */
+#define DHT_MARKER			0xFFC4
+#define LH_DC				0x001F
+#define LH_AC				0x00B5
+
+/* Definitions for the quantization table specification in the Marker segment */
+#define DQT_MARKER			0xFFDB
+#define ACMAX				0x03FF
+#define DCMAX				0x07FF
+
+/* Length and precision of the quantization table parameters */
+#define LQPQ				0x00430
+#define QMAX				255
+
+/* Misc JPEG header definitions */
+#define UC_NUM_COMP			3
+#define PRECISION			8
+#define HORZ_SAMPLING_FACTOR		(2 << 4)
+#define VERT_SAMPLING_FACTOR_422	1
+#define VERT_SAMPLING_FACTOR_420	2
+#define COMPONENTS_IN_SCAN		3
+#define PELS_IN_BLOCK			64
+
+/* Used for Qp table generation */
+#define LUMINOSITY			10
+#define CONTRAST			1
+#define INCREASE			2
+#define QP_TABLE_SIZE			(8 * 8)
+#define QP_TABLE_FIELD_OFFSET		0x04
+
+/*
+ * vb2 queue structure
+ * contains queue data information
+ *
+ * @fmt: format info
+ * @width: frame width
+ * @height: frame height
+ * @bytesperline: bytes per line in memory
+ * @size_image: image size in memory
+ */
+struct e5010_q_data {
+	struct e5010_fmt	*fmt;
+	u32			width;
+	u32			height;
+	u32			width_adjusted;
+	u32			height_adjusted;
+	u32			sizeimage[MAX_PLANES];
+	u32			bytesperline[MAX_PLANES];
+	bool			format_set;
+	bool			streaming;
+	u32			sequence;
+	struct v4l2_rect	crop;
+};
+
+/*
+ * Driver device structure
+ * Holds all memory handles and global parameters
+ * Shared by all instances
+ */
+struct e5010_dev {
+	struct device *dev;
+	struct v4l2_device	v4l2_dev;
+	struct v4l2_m2m_dev	*m2m_dev;
+	struct video_device	*vdev;
+	void __iomem		*core_base;
+	void __iomem		*mmu_base;
+	struct clk		*clk;
+	struct e5010_context	*last_context_run;
+	/* Protect access to device data */
+	struct mutex		mutex;
+	/* Protect access to hardware*/
+	spinlock_t		hw_lock;
+};
+
+/*
+ * Driver context structure
+ * One of these exists for every m2m context
+ * Holds context specific data
+ */
+struct e5010_context {
+	struct v4l2_fh			fh;
+	struct e5010_dev		*e5010;
+	struct e5010_q_data		out_queue;
+	struct e5010_q_data		cap_queue;
+	int				quality;
+	bool				update_qp;
+	struct v4l2_ctrl_handler	ctrl_handler;
+	u8				luma_qp[QP_TABLE_SIZE];
+	u8				chroma_qp[QP_TABLE_SIZE];
+};
+
+/*
+ * Buffer structure
+ * Contains info for all buffers
+ */
+struct e5010_buffer {
+	struct v4l2_m2m_buffer buffer;
+};
+
+enum {
+	CHROMA_ORDER_CB_CR = 0, //UV ordering
+	CHROMA_ORDER_CR_CB = 1, //VU ordering
+};
+
+enum {
+	SUBSAMPLING_420 = 1,
+	SUBSAMPLING_422 = 2,
+};
+
+/*
+ * e5010 format structure
+ * contains format information
+ */
+struct e5010_fmt {
+	u32					fourcc;
+	unsigned int				num_planes;
+	unsigned int				type;
+	u32					subsampling;
+	u32					chroma_order;
+	const struct v4l2_frmsize_stepwise	frmsize;
+};
+
+/*
+ * struct e5010_ctrl - contains info for each supported v4l2 control
+ */
+struct e5010_ctrl {
+	unsigned int		cid;
+	enum v4l2_ctrl_type	type;
+	unsigned char		name[32];
+	int			minimum;
+	int			maximum;
+	int			step;
+	int			default_value;
+	unsigned char		compound;
+};
+
+#endif
diff --git a/drivers/media/platform/imagination/e5010-mmu-regs.h b/drivers/media/platform/imagination/e5010-mmu-regs.h
new file mode 100644
index 000000000000..bfba06956cf2
--- /dev/null
+++ b/drivers/media/platform/imagination/e5010-mmu-regs.h
@@ -0,0 +1,311 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Imagination E5010 JPEG Encoder driver.
+ *
+ * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
+ *
+ * Author: David Huang <d-huang@ti.com>
+ * Author: Devarsh Thakkar <devarsht@ti.com>
+ */
+
+#ifndef _E5010_MMU_REGS_H
+#define _E5010_MMU_REGS_H
+
+#define MMU_MMU_DIR_BASE_ADDR_OFFSET					(0x0020)
+#define MMU_MMU_DIR_BASE_ADDR_STRIDE					(4)
+#define MMU_MMU_DIR_BASE_ADDR_NO_ENTRIES				(4)
+
+#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_MASK			(0xFFFFFFFF)
+#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_SHIFT			(0)
+
+#define MMU_MMU_TILE_CFG_OFFSET						(0x0040)
+#define MMU_MMU_TILE_CFG_STRIDE						(4)
+#define MMU_MMU_TILE_CFG_NO_ENTRIES					(4)
+
+#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_MASK			(0x00000010)
+#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_SHIFT			(4)
+
+#define MMU_MMU_TILE_CFG_TILE_ENABLE_MASK				(0x00000008)
+#define MMU_MMU_TILE_CFG_TILE_ENABLE_SHIFT				(3)
+
+#define MMU_MMU_TILE_CFG_TILE_STRIDE_MASK				(0x00000007)
+#define MMU_MMU_TILE_CFG_TILE_STRIDE_SHIFT				(0)
+
+#define MMU_MMU_TILE_MIN_ADDR_OFFSET					(0x0050)
+#define MMU_MMU_TILE_MIN_ADDR_STRIDE					(4)
+#define MMU_MMU_TILE_MIN_ADDR_NO_ENTRIES				(4)
+
+#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_MASK			(0xFFFFFFFF)
+#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_SHIFT			(0)
+
+#define MMU_MMU_TILE_MAX_ADDR_OFFSET					(0x0060)
+#define MMU_MMU_TILE_MAX_ADDR_STRIDE					(4)
+#define MMU_MMU_TILE_MAX_ADDR_NO_ENTRIES				(4)
+
+#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_MASK			(0xFFFFFFFF)
+#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_SHIFT			(0)
+
+#define MMU_MMU_CONTROL0_OFFSET						(0x0000)
+
+#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_MASK				(0x00000001)
+#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_SHIFT			(0)
+
+#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_MASK				(0x00000100)
+#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_SHIFT				(8)
+
+#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_MASK			(0x00000200)
+#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_SHIFT		(9)
+
+#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_MASK			(0x00001000)
+#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_SHIFT			(12)
+
+#define MMU_MMU_CONTROL1_OFFSET						(0x0008)
+
+#define MMU_MMU_CONTROL1_MMU_FLUSH_MASK					(0x00000008)
+#define MMU_MMU_CONTROL1_MMU_FLUSH_SHIFT				(3)
+#define MMU_MMU_CONTROL1_MMU_FLUSH_NO_REPS				(4)
+#define MMU_MMU_CONTROL1_MMU_FLUSH_SIZE					(1)
+
+#define MMU_MMU_CONTROL1_MMU_INVALDC_MASK				(0x00000800)
+#define MMU_MMU_CONTROL1_MMU_INVALDC_SHIFT				(11)
+#define MMU_MMU_CONTROL1_MMU_INVALDC_NO_REPS				(4)
+#define MMU_MMU_CONTROL1_MMU_INVALDC_SIZE				(1)
+
+#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_MASK				(0x00010000)
+#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_SHIFT				(16)
+
+#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_MASK			(0x00100000)
+#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_SHIFT			(20)
+
+#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_MASK				(0x01000000)
+#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_SHIFT				(24)
+
+#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_MASK				(0x02000000)
+#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_SHIFT				(25)
+
+#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK				(0x10000000)
+#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT				(28)
+
+#define MMU_MMU_BANK_INDEX_OFFSET					(0x0010)
+
+#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_MASK				(0xC0000000)
+#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SHIFT				(30)
+#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_NO_REPS			(16)
+#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SIZE				(2)
+
+#define MMU_REQUEST_PRIORITY_ENABLE_OFFSET				(0x0018)
+
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_MASK		(0x00008000)
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SHIFT		(15)
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_NO_REPS		(16)
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SIZE		(1)
+
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_MASK	(0x00010000)
+#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_SHIFT	(16)
+
+#define MMU_REQUEST_LIMITED_THROUGHPUT_OFFSET				(0x001C)
+
+#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_MASK		(0x000003FF)
+#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_SHIFT		(0)
+
+#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_MASK			(0x0FFF0000)
+#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_SHIFT		(16)
+
+#define MMU_MMU_ADDRESS_CONTROL_OFFSET					(0x0070)
+#define MMU_MMU_ADDRESS_CONTROL_TRUSTED					(IMG_TRUE)
+
+#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK				(0x00000001)
+#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT			(0)
+
+#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_MASK		(0x00000010)
+#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_SHIFT		(4)
+
+#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_MASK		(0x00FF0000)
+#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_SHIFT		(16)
+
+#define MMU_MMU_CONFIG0_OFFSET						(0x0080)
+
+#define MMU_MMU_CONFIG0_NUM_REQUESTORS_MASK				(0x0000000F)
+#define MMU_MMU_CONFIG0_NUM_REQUESTORS_SHIFT				(0)
+
+#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_MASK			(0x000000F0)
+#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_SHIFT			(4)
+
+#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_MASK			(0x00000700)
+#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_SHIFT			(8)
+
+#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_MASK			(0x00001000)
+#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_SHIFT			(12)
+
+#define MMU_MMU_CONFIG0_MMU_SUPPORTED_MASK				(0x00002000)
+#define MMU_MMU_CONFIG0_MMU_SUPPORTED_SHIFT				(13)
+
+#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_MASK			(0x001F0000)
+#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_SHIFT			(16)
+
+#define MMU_MMU_CONFIG0_NO_READ_REORDER_MASK				(0x00200000)
+#define MMU_MMU_CONFIG0_NO_READ_REORDER_SHIFT				(21)
+
+#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_MASK				(0xFFC00000)
+#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_SHIFT				(22)
+
+#define MMU_MMU_CONFIG1_OFFSET						(0x0084)
+
+#define MMU_MMU_CONFIG1_PAGE_SIZE_MASK					(0x0000000F)
+#define MMU_MMU_CONFIG1_PAGE_SIZE_SHIFT					(0)
+
+#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_MASK				(0x0000FF00)
+#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_SHIFT			(8)
+
+#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_MASK				(0x001F0000)
+#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_SHIFT				(16)
+
+#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_MASK			(0x01000000)
+#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_SHIFT			(24)
+
+#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_MASK			(0x02000000)
+#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_SHIFT			(25)
+
+#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_MASK			(0x04000000)
+#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_SHIFT			(26)
+
+#define MMU_MMU_STATUS0_OFFSET						(0x0088)
+
+#define MMU_MMU_STATUS0_MMU_PF_N_RW_MASK				(0x00000001)
+#define MMU_MMU_STATUS0_MMU_PF_N_RW_SHIFT				(0)
+
+#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_MASK				(0xFFFFF000)
+#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_SHIFT				(12)
+
+#define MMU_MMU_STATUS1_OFFSET						(0x008C)
+
+#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_MASK				(0x0000FFFF)
+#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_SHIFT			(0)
+
+#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_MASK				(0x000F0000)
+#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_SHIFT				(16)
+
+#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_MASK				(0x03000000)
+#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_SHIFT				(24)
+
+#define MMU_MMU_STATUS1_MMU_FAULT_RNW_MASK				(0x10000000)
+#define MMU_MMU_STATUS1_MMU_FAULT_RNW_SHIFT				(28)
+
+#define MMU_MMU_MEM_REQ_OFFSET						(0x0090)
+
+#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_MASK				(0x000003FF)
+#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_SHIFT				(0)
+
+#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_MASK				(0x00001000)
+#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_SHIFT				(12)
+
+#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_MASK				(0x00002000)
+#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_SHIFT				(13)
+
+#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_MASK			(0x00004000)
+#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_SHIFT			(14)
+
+#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_MASK				(0x80000000)
+#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SHIFT			(31)
+#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_NO_REPS			(16)
+#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SIZE				(1)
+
+#define MMU_MMU_FAULT_SELECT_OFFSET					(0x00A0)
+
+#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_MASK			(0x0000000F)
+#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_SHIFT			(0)
+
+#define MMU_PROTOCOL_FAULT_OFFSET					(0x00A8)
+
+#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_MASK			(0x00000001)
+#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_SHIFT			(0)
+
+#define MMU_PROTOCOL_FAULT_FAULT_WRITE_MASK				(0x00000010)
+#define MMU_PROTOCOL_FAULT_FAULT_WRITE_SHIFT				(4)
+
+#define MMU_PROTOCOL_FAULT_FAULT_READ_MASK				(0x00000020)
+#define MMU_PROTOCOL_FAULT_FAULT_READ_SHIFT				(5)
+
+#define MMU_TOTAL_READ_REQ_OFFSET					(0x0100)
+
+#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_MASK				(0xFFFFFFFF)
+#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_SHIFT				(0)
+
+#define MMU_TOTAL_WRITE_REQ_OFFSET					(0x0104)
+
+#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_MASK			(0xFFFFFFFF)
+#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_SHIFT			(0)
+
+#define MMU_READS_LESS_64_REQ_OFFSET					(0x0108)
+
+#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_MASK			(0xFFFFFFFF)
+#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_SHIFT			(0)
+
+#define MMU_WRITES_LESS_64_REQ_OFFSET					(0x010C)
+
+#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_MASK			(0xFFFFFFFF)
+#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_SHIFT			(0)
+
+#define MMU_EXT_CMD_STALL_OFFSET					(0x0120)
+
+#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_MASK				(0xFFFFFFFF)
+#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_SHIFT				(0)
+
+#define MMU_WRITE_REQ_STALL_OFFSET					(0x0124)
+
+#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_MASK			(0xFFFFFFFF)
+#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_SHIFT			(0)
+
+#define MMU_MMU_MISS_STALL_OFFSET					(0x0128)
+
+#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_MASK				(0xFFFFFFFF)
+#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_SHIFT				(0)
+
+#define MMU_ADDRESS_STALL_OFFSET					(0x012C)
+
+#define MMU_ADDRESS_STALL_ADDRESS_STALL_MASK				(0xFFFFFFFF)
+#define MMU_ADDRESS_STALL_ADDRESS_STALL_SHIFT				(0)
+
+#define MMU_TAG_STALL_OFFSET						(0x0130)
+
+#define MMU_TAG_STALL_TAG_STALL_MASK					(0xFFFFFFFF)
+#define MMU_TAG_STALL_TAG_STALL_SHIFT					(0)
+
+#define MMU_PEAK_READ_OUTSTANDING_OFFSET				(0x0140)
+
+#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_MASK		(0x000003FF)
+#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_SHIFT		(0)
+
+#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_MASK		(0xFFFF0000)
+#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_SHIFT		(16)
+
+#define MMU_AVERAGE_READ_LATENCY_OFFSET					(0x0144)
+
+#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_MASK		(0xFFFFFFFF)
+#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_SHIFT		(0)
+
+#define MMU_STATISTICS_CONTROL_OFFSET					(0x0160)
+
+#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_MASK		(0x00000001)
+#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_SHIFT		(0)
+
+#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_MASK			(0x00000002)
+#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_SHIFT			(1)
+
+#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_MASK			(0x00000004)
+#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_SHIFT			(2)
+
+#define MMU_MMU_VERSION_OFFSET						(0x01D0)
+
+#define MMU_MMU_VERSION_MMU_MAJOR_REV_MASK				(0x00FF0000)
+#define MMU_MMU_VERSION_MMU_MAJOR_REV_SHIFT				(16)
+
+#define MMU_MMU_VERSION_MMU_MINOR_REV_MASK				(0x0000FF00)
+#define MMU_MMU_VERSION_MMU_MINOR_REV_SHIFT				(8)
+
+#define MMU_MMU_VERSION_MMU_MAINT_REV_MASK				(0x000000FF)
+#define MMU_MMU_VERSION_MMU_MAINT_REV_SHIFT				(0)
+
+#define MMU_BYTE_SIZE							(0x01D4)
+
+#endif
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [DONOTMERGE PATCH v3 3/4] arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder
  2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
  2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
  2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
@ 2023-08-16 15:22 ` Devarsh Thakkar
  2023-08-16 15:22 ` [DONOTMERGE PATCH v3 4/4] arm64: defconfig: Enable " Devarsh Thakkar
  3 siblings, 0 replies; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-16 15:22 UTC (permalink / raw)
  To: mchehab, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp, devarsht

This adds node for E5010 JPEG Encoder node which is a stateful
JPEG Encoder supporting baseline encoding for semiplanar YUV420
and YUV422 video formats to JPEG with resolutions supported
from 64x64 up to 8kx8k resolution.

E5010 JPEG Encoder IP is present main domain, so this
also adds address range for core and mmu regions of E5010 IP
in cbass_main node.

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
V2: No change
V3: No change

 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 11 +++++++++++
 arch/arm64/boot/dts/ti/k3-am62a.dtsi      |  2 ++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index 3198af08fb9f..0dd5c9e280eb 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -816,4 +816,15 @@ ecap2: pwm@23120000 {
 		clock-names = "fck";
 		status = "disabled";
 	};
+
+	e5010: jpeg-encoder@fd20000 {
+		compatible = "ti,e5010-jpeg-enc", "img,e5010-jpeg-enc";
+		reg = <0x00 0xfd20000 0x00 0x100>,
+		      <0x00 0xfd20200 0x00 0x200>;
+		reg-names = "core", "mmu";
+		clocks = <&k3_clks 201 0>;
+		clock-names = "core_clk";
+		power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>;
+		interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+	};
 };
diff --git a/arch/arm64/boot/dts/ti/k3-am62a.dtsi b/arch/arm64/boot/dts/ti/k3-am62a.dtsi
index 61a210ecd5ff..2dcd41cddf33 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a.dtsi
@@ -61,6 +61,8 @@ cbass_main: bus@f0000 {
 			 <0x00 0x08000000 0x00 0x08000000 0x00 0x00200000>, /* Main CPSW */
 			 <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01d20000>, /* Second peripheral window */
 			 <0x00 0x0fd00000 0x00 0x0fd00000 0x00 0x00020000>, /* GPU */
+			 <0x00 0x0fd20000 0x00 0x0fd20000 0x00 0x00000100>, /* JPEGENC0_CORE */
+			 <0x00 0x0fd20200 0x00 0x0fd20200 0x00 0x00000200>, /* JPEGENC0_CORE_MMU */
 			 <0x00 0x20000000 0x00 0x20000000 0x00 0x0a008000>, /* Third peripheral window */
 			 <0x00 0x30040000 0x00 0x30040000 0x00 0x00080000>, /* PRUSS-M */
 			 <0x00 0x30101000 0x00 0x30101000 0x00 0x00010100>, /* CSI window */
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [DONOTMERGE PATCH v3 4/4] arm64: defconfig: Enable E5010 JPEG Encoder
  2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
                   ` (2 preceding siblings ...)
  2023-08-16 15:22 ` [DONOTMERGE PATCH v3 3/4] arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder Devarsh Thakkar
@ 2023-08-16 15:22 ` Devarsh Thakkar
  3 siblings, 0 replies; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-16 15:22 UTC (permalink / raw)
  To: mchehab, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp, devarsht

Enable Imagination E5010 JPEG Encoder which supports baseline
encoding with two different quantization tables and compression
ratio as demanded.

The E5010 JPEG Encoder is currently present in TI's AM62A
SoC.

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
V2: No change
V3: No change

 arch/arm64/configs/defconfig | 117 +++++++++++++----------------------
 1 file changed, 42 insertions(+), 75 deletions(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5315789f4868..0477729cfda7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -30,6 +30,8 @@ CONFIG_SCHED_AUTOGROUP=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_KALLSYMS_ALL=y
 CONFIG_PROFILING=y
+CONFIG_KEXEC_FILE=y
+CONFIG_CRASH_DUMP=y
 CONFIG_ARCH_ACTIONS=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_ARCH_ALPINE=y
@@ -77,9 +79,6 @@ CONFIG_ARM64_VA_BITS_48=y
 CONFIG_SCHED_MC=y
 CONFIG_SCHED_SMT=y
 CONFIG_NUMA=y
-CONFIG_KEXEC=y
-CONFIG_KEXEC_FILE=y
-CONFIG_CRASH_DUMP=y
 CONFIG_XEN=y
 CONFIG_COMPAT=y
 CONFIG_RANDOMIZE_BASE=y
@@ -119,7 +118,6 @@ CONFIG_KVM=y
 CONFIG_JUMP_LABEL=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
-CONFIG_IOSCHED_BFQ=y
 # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
 # CONFIG_COMPAT_BRK is not set
 CONFIG_MEMORY_HOTPLUG=y
@@ -129,8 +127,6 @@ CONFIG_MEMORY_FAILURE=y
 CONFIG_TRANSPARENT_HUGEPAGE=y
 CONFIG_NET=y
 CONFIG_PACKET=y
-CONFIG_UNIX=y
-CONFIG_INET=y
 CONFIG_IP_MULTICAST=y
 CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
@@ -180,8 +176,6 @@ CONFIG_NET_ACT_GATE=m
 CONFIG_QRTR_SMD=m
 CONFIG_QRTR_TUN=m
 CONFIG_CAN=m
-CONFIG_CAN_M_CAN=m
-CONFIG_CAN_M_CAN_PLATFORM=m
 CONFIG_BT=m
 CONFIG_BT_HIDP=m
 # CONFIG_BT_LE is not set
@@ -215,27 +209,27 @@ CONFIG_PCI_PASID=y
 CONFIG_HOTPLUG_PCI=y
 CONFIG_HOTPLUG_PCI_ACPI=y
 CONFIG_PCI_AARDVARK=y
-CONFIG_PCI_TEGRA=y
-CONFIG_PCIE_RCAR_HOST=y
-CONFIG_PCIE_RCAR_EP=y
-CONFIG_PCI_HOST_GENERIC=y
-CONFIG_PCI_XGENE=y
 CONFIG_PCIE_ALTERA=y
 CONFIG_PCIE_ALTERA_MSI=y
+CONFIG_PCIE_BRCMSTB=m
 CONFIG_PCI_HOST_THUNDER_PEM=y
 CONFIG_PCI_HOST_THUNDER_ECAM=y
-CONFIG_PCIE_ROCKCHIP_HOST=m
+CONFIG_PCI_HOST_GENERIC=y
 CONFIG_PCIE_MEDIATEK_GEN3=m
-CONFIG_PCIE_BRCMSTB=m
+CONFIG_PCI_TEGRA=y
+CONFIG_PCIE_RCAR_HOST=y
+CONFIG_PCIE_RCAR_EP=y
+CONFIG_PCIE_ROCKCHIP_HOST=m
+CONFIG_PCI_XGENE=y
 CONFIG_PCI_IMX6_HOST=y
 CONFIG_PCI_LAYERSCAPE=y
 CONFIG_PCI_HISI=y
-CONFIG_PCIE_QCOM=y
-CONFIG_PCIE_ARMADA_8K=y
-CONFIG_PCIE_ROCKCHIP_DW_HOST=y
 CONFIG_PCIE_KIRIN=y
 CONFIG_PCIE_HISI_STB=y
+CONFIG_PCIE_ARMADA_8K=y
 CONFIG_PCIE_TEGRA194_HOST=m
+CONFIG_PCIE_QCOM=y
+CONFIG_PCIE_ROCKCHIP_DW_HOST=y
 CONFIG_PCIE_VISCONTI_HOST=y
 CONFIG_PCIE_LAYERSCAPE_GEN4=y
 CONFIG_PCI_ENDPOINT=y
@@ -247,7 +241,6 @@ CONFIG_FW_LOADER_USER_HELPER=y
 CONFIG_HISILICON_LPC=y
 CONFIG_TEGRA_ACONNECT=m
 CONFIG_MHI_BUS_PCI_GENERIC=m
-CONFIG_ARM_SCMI_PROTOCOL=y
 CONFIG_ARM_SCPI_PROTOCOL=y
 CONFIG_RASPBERRYPI_FIRMWARE=y
 CONFIG_INTEL_STRATIX10_SERVICE=y
@@ -276,15 +269,12 @@ CONFIG_MTD_NAND_FSL_IFC=y
 CONFIG_MTD_NAND_QCOM=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=m
-CONFIG_UBIFS_FS=m
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_VIRTIO_BLK=y
 CONFIG_BLK_DEV_NVME=m
 CONFIG_QCOM_COINCELL=m
 CONFIG_QCOM_FASTRPC=m
-CONFIG_BATTERY_QCOM_BATTMGR=m
-CONFIG_UCSI_PMIC_GLINK=m
 CONFIG_SRAM=y
 CONFIG_PCI_ENDPOINT_TEST=m
 CONFIG_EEPROM_AT24=m
@@ -308,7 +298,6 @@ CONFIG_AHCI_XGENE=y
 CONFIG_AHCI_QORIQ=y
 CONFIG_SATA_SIL24=y
 CONFIG_SATA_RCAR=y
-CONFIG_PATA_PLATFORM=y
 CONFIG_PATA_OF_PLATFORM=y
 CONFIG_MD=y
 CONFIG_BLK_DEV_MD=m
@@ -384,6 +373,8 @@ CONFIG_DP83869_PHY=m
 CONFIG_DP83TD510_PHY=y
 CONFIG_VITESSE_PHY=y
 CONFIG_CAN_FLEXCAN=m
+CONFIG_CAN_M_CAN=m
+CONFIG_CAN_M_CAN_PLATFORM=m
 CONFIG_CAN_RCAR=m
 CONFIG_CAN_RCAR_CANFD=m
 CONFIG_CAN_MCP251XFD=m
@@ -573,9 +564,9 @@ CONFIG_PINCTRL_IMX8DXL=y
 CONFIG_PINCTRL_IMX8ULP=y
 CONFIG_PINCTRL_IMX93=y
 CONFIG_PINCTRL_MSM=y
-CONFIG_PINCTRL_IPQ8074=y
 CONFIG_PINCTRL_IPQ5018=y
 CONFIG_PINCTRL_IPQ5332=y
+CONFIG_PINCTRL_IPQ8074=y
 CONFIG_PINCTRL_IPQ6018=y
 CONFIG_PINCTRL_IPQ9574=y
 CONFIG_PINCTRL_MSM8916=y
@@ -587,12 +578,10 @@ CONFIG_PINCTRL_MSM8998=y
 CONFIG_PINCTRL_QCM2290=y
 CONFIG_PINCTRL_QCS404=y
 CONFIG_PINCTRL_QDF2XXX=y
-CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
 CONFIG_PINCTRL_QDU1000=y
 CONFIG_PINCTRL_SA8775P=y
 CONFIG_PINCTRL_SC7180=y
 CONFIG_PINCTRL_SC7280=y
-CONFIG_PINCTRL_SC7280_LPASS_LPI=m
 CONFIG_PINCTRL_SC8180X=y
 CONFIG_PINCTRL_SC8280XP=y
 CONFIG_PINCTRL_SDM660=y
@@ -604,14 +593,16 @@ CONFIG_PINCTRL_SM6350=y
 CONFIG_PINCTRL_SM6375=y
 CONFIG_PINCTRL_SM8150=y
 CONFIG_PINCTRL_SM8250=y
-CONFIG_PINCTRL_SM8250_LPASS_LPI=m
 CONFIG_PINCTRL_SM8350=y
 CONFIG_PINCTRL_SM8450=y
+CONFIG_PINCTRL_SM8550=y
+CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
+CONFIG_PINCTRL_LPASS_LPI=m
+CONFIG_PINCTRL_SC7280_LPASS_LPI=m
+CONFIG_PINCTRL_SM8250_LPASS_LPI=m
 CONFIG_PINCTRL_SM8450_LPASS_LPI=m
 CONFIG_PINCTRL_SC8280XP_LPASS_LPI=m
-CONFIG_PINCTRL_SM8550=y
 CONFIG_PINCTRL_SM8550_LPASS_LPI=m
-CONFIG_PINCTRL_LPASS_LPI=m
 CONFIG_GPIO_ALTERA=m
 CONFIG_GPIO_DAVINCI=y
 CONFIG_GPIO_DWAPB=y
@@ -620,6 +611,7 @@ CONFIG_GPIO_MPC8XXX=y
 CONFIG_GPIO_MXC=y
 CONFIG_GPIO_PL061=y
 CONFIG_GPIO_RCAR=y
+CONFIG_GPIO_SYSCON=y
 CONFIG_GPIO_UNIPHIER=y
 CONFIG_GPIO_VISCONTI=y
 CONFIG_GPIO_WCD934X=m
@@ -631,13 +623,13 @@ CONFIG_GPIO_PCA953X_IRQ=y
 CONFIG_GPIO_BD9571MWV=m
 CONFIG_GPIO_MAX77620=y
 CONFIG_GPIO_SL28CPLD=m
-CONFIG_GPIO_SYSCON=y
 CONFIG_POWER_RESET_MSM=y
 CONFIG_POWER_RESET_QCOM_PON=m
 CONFIG_POWER_RESET_XGENE=y
 CONFIG_POWER_RESET_SYSCON=y
 CONFIG_SYSCON_REBOOT_MODE=y
 CONFIG_NVMEM_REBOOT_MODE=m
+CONFIG_BATTERY_QCOM_BATTMGR=m
 CONFIG_BATTERY_SBS=m
 CONFIG_BATTERY_BQ27XXX=y
 CONFIG_BATTERY_MAX17042=m
@@ -662,8 +654,8 @@ CONFIG_DEVFREQ_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_IMX_SC_THERMAL=m
 CONFIG_IMX8MM_THERMAL=m
-CONFIG_QORIQ_THERMAL=m
 CONFIG_K3_THERMAL=m
+CONFIG_QORIQ_THERMAL=m
 CONFIG_SUN8I_THERMAL=y
 CONFIG_ROCKCHIP_THERMAL=m
 CONFIG_RCAR_THERMAL=y
@@ -688,6 +680,7 @@ CONFIG_ARM_SP805_WATCHDOG=y
 CONFIG_ARM_SBSA_WATCHDOG=y
 CONFIG_S3C2410_WATCHDOG=y
 CONFIG_DW_WATCHDOG=y
+CONFIG_K3_RTI_WATCHDOG=m
 CONFIG_SUNXI_WATCHDOG=m
 CONFIG_NPCM7XX_WATCHDOG=y
 CONFIG_IMX2_WDT=y
@@ -703,7 +696,6 @@ CONFIG_UNIPHIER_WATCHDOG=y
 CONFIG_PM8916_WATCHDOG=m
 CONFIG_BCM2835_WDT=y
 CONFIG_BCM7038_WDT=m
-CONFIG_K3_RTI_WATCHDOG=m
 CONFIG_MFD_ALTERA_SYSMGR=y
 CONFIG_MFD_BD9571MWV=y
 CONFIG_MFD_AXP20X_I2C=y
@@ -720,8 +712,8 @@ CONFIG_MFD_RK8XX_SPI=y
 CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_SL28CPLD=y
 CONFIG_RZ_MTU3=y
-CONFIG_MFD_TPS65219=y
 CONFIG_MFD_TI_AM335X_TSCADC=m
+CONFIG_MFD_TPS65219=y
 CONFIG_MFD_ROHM_BD718XX=y
 CONFIG_MFD_WCD934X=m
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
@@ -773,6 +765,7 @@ CONFIG_USB_VIDEO_CLASS=m
 CONFIG_V4L_PLATFORM_DRIVERS=y
 CONFIG_SDR_PLATFORM_DRIVERS=y
 CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_E5010_JPEG_ENC=m
 CONFIG_VIDEO_MEDIATEK_JPEG=m
 CONFIG_VIDEO_MEDIATEK_VCODEC=m
 CONFIG_VIDEO_IMX7_CSI=m
@@ -822,12 +815,8 @@ CONFIG_ROCKCHIP_INNO_HDMI=y
 CONFIG_ROCKCHIP_LVDS=y
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_RCAR_DW_HDMI=m
-CONFIG_DRM_RCAR_MIPI_DSI=m
 CONFIG_DRM_RZG2L_MIPI_DSI=m
 CONFIG_DRM_SUN4I=m
-CONFIG_DRM_SUN6I_DSI=m
-CONFIG_DRM_SUN8I_DW_HDMI=m
-CONFIG_DRM_SUN8I_MIXER=m
 CONFIG_DRM_MSM=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=m
@@ -867,15 +856,15 @@ CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MEDIATEK=m
 CONFIG_DRM_MEDIATEK_HDMI=m
 CONFIG_DRM_MXSFB=m
-CONFIG_DRM_MESON=m
 CONFIG_DRM_IMX_LCDIF=m
+CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
 CONFIG_DRM_LIMA=m
 CONFIG_DRM_PANFROST=m
 CONFIG_DRM_TIDSS=m
 CONFIG_FB=y
-CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_EFI=y
+CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_PWM=m
 CONFIG_BACKLIGHT_LP855X=m
 CONFIG_LOGO=y
@@ -937,7 +926,7 @@ CONFIG_SND_SOC_TEGRA210_AMX=m
 CONFIG_SND_SOC_TEGRA210_ADX=m
 CONFIG_SND_SOC_TEGRA210_MIXER=m
 CONFIG_SND_SOC_TEGRA_AUDIO_GRAPH_CARD=m
-CONFIG_SND_SOC_DAVINCI_MCASP=m
+CONFIG_SND_SOC_J721E_EVM=m
 CONFIG_SND_SOC_AK4613=m
 CONFIG_SND_SOC_DA7213=m
 CONFIG_SND_SOC_ES7134=m
@@ -946,10 +935,8 @@ CONFIG_SND_SOC_ES8316=m
 CONFIG_SND_SOC_GTM601=m
 CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
 CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
-CONFIG_SND_SOC_PCM3168A_I2C=m
 CONFIG_SND_SOC_RK817=m
 CONFIG_SND_SOC_RT5640=m
-CONFIG_SND_SOC_J721E_EVM=m
 CONFIG_SND_SOC_RT5659=m
 CONFIG_SND_SOC_SIMPLE_AMPLIFIER=m
 CONFIG_SND_SOC_SIMPLE_MUX=m
@@ -968,8 +955,6 @@ CONFIG_SND_SOC_WSA881X=m
 CONFIG_SND_SOC_NAU8822=m
 CONFIG_SND_SOC_LPASS_WSA_MACRO=m
 CONFIG_SND_SOC_LPASS_VA_MACRO=m
-CONFIG_SND_SOC_LPASS_RX_MACRO=m
-CONFIG_SND_SOC_LPASS_TX_MACRO=m
 CONFIG_SND_SIMPLE_CARD=m
 CONFIG_SND_AUDIO_GRAPH_CARD=m
 CONFIG_SND_AUDIO_GRAPH_CARD2=m
@@ -1034,11 +1019,12 @@ CONFIG_TYPEC=m
 CONFIG_TYPEC_TCPM=m
 CONFIG_TYPEC_TCPCI=m
 CONFIG_TYPEC_FUSB302=m
+CONFIG_TYPEC_UCSI=m
+CONFIG_UCSI_CCG=m
+CONFIG_UCSI_PMIC_GLINK=m
 CONFIG_TYPEC_TPS6598X=m
 CONFIG_TYPEC_HD3SS3220=m
-CONFIG_TYPEC_UCSI=m
 CONFIG_TYPEC_MUX_FSA4480=m
-CONFIG_UCSI_CCG=m
 CONFIG_TYPEC_MUX_GPIO_SBU=m
 CONFIG_MMC=y
 CONFIG_MMC_BLOCK_MINORS=32
@@ -1167,7 +1153,6 @@ CONFIG_CROS_EC_RPMSG=m
 CONFIG_CROS_EC_SPI=y
 CONFIG_CROS_EC_CHARDEV=m
 CONFIG_COMMON_CLK_RK808=y
-CONFIG_COMMON_CLK_SCMI=y
 CONFIG_COMMON_CLK_SCPI=y
 CONFIG_COMMON_CLK_CS2000_CP=y
 CONFIG_COMMON_CLK_FSL_SAI=y
@@ -1175,7 +1160,6 @@ CONFIG_COMMON_CLK_S2MPS11=y
 CONFIG_COMMON_CLK_PWM=y
 CONFIG_COMMON_CLK_RS9_PCIE=y
 CONFIG_COMMON_CLK_VC5=y
-CONFIG_COMMON_CLK_NPCM8XX=y
 CONFIG_COMMON_CLK_BD718XX=m
 CONFIG_CLK_RASPBERRYPI=m
 CONFIG_CLK_IMX8MM=y
@@ -1186,18 +1170,6 @@ CONFIG_CLK_IMX8QXP=y
 CONFIG_CLK_IMX8ULP=y
 CONFIG_CLK_IMX93=y
 CONFIG_TI_SCI_CLK=y
-CONFIG_COMMON_CLK_MT8192_AUDSYS=y
-CONFIG_COMMON_CLK_MT8192_CAMSYS=y
-CONFIG_COMMON_CLK_MT8192_IMGSYS=y
-CONFIG_COMMON_CLK_MT8192_IMP_IIC_WRAP=y
-CONFIG_COMMON_CLK_MT8192_IPESYS=y
-CONFIG_COMMON_CLK_MT8192_MDPSYS=y
-CONFIG_COMMON_CLK_MT8192_MFGCFG=y
-CONFIG_COMMON_CLK_MT8192_MMSYS=y
-CONFIG_COMMON_CLK_MT8192_MSDC=y
-CONFIG_COMMON_CLK_MT8192_SCP_ADSP=y
-CONFIG_COMMON_CLK_MT8192_VDECSYS=y
-CONFIG_COMMON_CLK_MT8192_VENCSYS=y
 CONFIG_COMMON_CLK_QCOM=y
 CONFIG_QCOM_A53PLL=y
 CONFIG_QCOM_CLK_APCS_MSM8916=y
@@ -1205,24 +1177,23 @@ CONFIG_QCOM_CLK_APCC_MSM8996=y
 CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_APSS_6018=y
-CONFIG_IPQ_GCC_5332=y
-CONFIG_IPQ_APSS_5018=y
 CONFIG_IPQ_GCC_5018=y
+CONFIG_IPQ_GCC_5332=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y
 CONFIG_MSM_GCC_8916=y
+CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_GCC_8994=y
 CONFIG_MSM_GCC_8996=y
-CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_MMCC_8996=m
-CONFIG_MSM_MMCC_8998=m
 CONFIG_MSM_GCC_8998=y
+CONFIG_MSM_MMCC_8998=m
 CONFIG_QCM_GCC_2290=y
 CONFIG_QCM_DISPCC_2290=m
 CONFIG_QCS_GCC_404=y
-CONFIG_SA_GCC_8775P=y
 CONFIG_SC_DISPCC_8280XP=m
+CONFIG_SA_GCC_8775P=y
 CONFIG_SA_GPUCC_8775P=m
 CONFIG_SC_GCC_7180=y
 CONFIG_SC_GCC_7280=y
@@ -1244,10 +1215,10 @@ CONFIG_SM_GCC_6115=y
 CONFIG_SM_GCC_8350=y
 CONFIG_SM_GCC_8450=y
 CONFIG_SM_GCC_8550=y
-CONFIG_SM_TCSRCC_8550=y
 CONFIG_SM_GPUCC_6115=m
 CONFIG_SM_GPUCC_8150=y
 CONFIG_SM_GPUCC_8250=y
+CONFIG_SM_TCSRCC_8550=y
 CONFIG_SM_VIDEOCC_8250=y
 CONFIG_QCOM_HFPLL=y
 CONFIG_CLK_GFM_LPASS_SM8250=m
@@ -1258,7 +1229,6 @@ CONFIG_TEGRA186_TIMER=y
 CONFIG_RENESAS_OSTM=y
 CONFIG_ARM_MHU=y
 CONFIG_IMX_MBOX=y
-CONFIG_OMAP2PLUS_MBOX=m
 CONFIG_PLATFORM_MHU=y
 CONFIG_BCM2835_MBOX=y
 CONFIG_QCOM_APCS_IPC=y
@@ -1271,14 +1241,14 @@ CONFIG_MTK_IOMMU=y
 CONFIG_QCOM_IOMMU=y
 CONFIG_REMOTEPROC=y
 CONFIG_IMX_REMOTEPROC=y
-CONFIG_TI_K3_R5_REMOTEPROC=m
-CONFIG_TI_K3_DSP_REMOTEPROC=m
 CONFIG_MTK_SCP=m
 CONFIG_QCOM_Q6V5_ADSP=m
 CONFIG_QCOM_Q6V5_MSS=m
 CONFIG_QCOM_Q6V5_PAS=m
 CONFIG_QCOM_SYSMON=m
 CONFIG_QCOM_WCNSS_PIL=m
+CONFIG_TI_K3_DSP_REMOTEPROC=m
+CONFIG_TI_K3_R5_REMOTEPROC=m
 CONFIG_RPMSG_CHAR=m
 CONFIG_RPMSG_CTRL=m
 CONFIG_RPMSG_QCOM_GLINK_RPM=y
@@ -1412,11 +1382,11 @@ CONFIG_PHY_HISI_INNO_USB2=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
 CONFIG_PHY_MTK_TPHY=y
 CONFIG_PHY_QCOM_EDP=m
-CONFIG_PHY_QCOM_EUSB2_REPEATER=m
 CONFIG_PHY_QCOM_PCIE2=m
 CONFIG_PHY_QCOM_QMP=m
 CONFIG_PHY_QCOM_QUSB2=m
 CONFIG_PHY_QCOM_SNPS_EUSB2=m
+CONFIG_PHY_QCOM_EUSB2_REPEATER=m
 CONFIG_PHY_QCOM_USB_HS=m
 CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=m
 CONFIG_PHY_QCOM_USB_HS_28NM=m
@@ -1443,7 +1413,6 @@ CONFIG_PHY_J721E_WIZ=m
 CONFIG_ARM_CCI_PMU=m
 CONFIG_ARM_CCN=m
 CONFIG_ARM_CMN=m
-CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU=m
 CONFIG_ARM_SMMU_V3_PMU=m
 CONFIG_ARM_DSU_PMU=m
 CONFIG_FSL_IMX8_DDR_PMU=m
@@ -1452,6 +1421,7 @@ CONFIG_QCOM_L3_PMU=y
 CONFIG_ARM_SPE_PMU=m
 CONFIG_ARM_DMC620_PMU=m
 CONFIG_HISI_PMU=y
+CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU=m
 CONFIG_NVMEM_LAYOUT_SL28_VPD=m
 CONFIG_NVMEM_IMX_OCOTP=y
 CONFIG_NVMEM_IMX_OCOTP_ELE=m
@@ -1478,10 +1448,8 @@ CONFIG_TEE=y
 CONFIG_OPTEE=y
 CONFIG_MUX_GPIO=m
 CONFIG_MUX_MMIO=y
-CONFIG_SLIMBUS=m
 CONFIG_SLIM_QCOM_CTRL=m
 CONFIG_SLIM_QCOM_NGD_CTRL=m
-CONFIG_INTERCONNECT=y
 CONFIG_INTERCONNECT_IMX=y
 CONFIG_INTERCONNECT_IMX8MM=m
 CONFIG_INTERCONNECT_IMX8MN=m
@@ -1524,8 +1492,8 @@ CONFIG_OVERLAY_FS=m
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS_POSIX_ACL=y
 CONFIG_HUGETLBFS=y
-CONFIG_CONFIGFS_FS=y
 CONFIG_EFIVAR_FS=y
+CONFIG_UBIFS_FS=m
 CONFIG_SQUASHFS=y
 CONFIG_NFS_FS=y
 CONFIG_NFS_V4=y
@@ -1573,7 +1541,6 @@ CONFIG_DEBUG_INFO_REDUCED=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set
-# CONFIG_DEBUG_PREEMPT is not set
 # CONFIG_FTRACE is not set
 CONFIG_CORESIGHT=m
 CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
  2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
@ 2023-08-19 14:00   ` Krzysztof Kozlowski
  2023-08-20 16:46     ` Devarsh Thakkar
  0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-19 14:00 UTC (permalink / raw)
  To: Devarsh Thakkar, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

On 16/08/2023 17:22, Devarsh Thakkar wrote:
> Add dt-bindings for Imagination E5010 JPEG Encoder driver which is
> implemented as stateful V4L2 M2M driver.
> 
> Co-developed-by: David Huang <d-huang@ti.com>
> Signed-off-by: David Huang <d-huang@ti.com>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> V2: No change
> V3: 
> - Add vendor specific compatible 
> - Fix commit title and message
> - Update reg names
> - Update clocks to 1
> - Fix dts example with proper naming

I do not see improvements in the subject.

> 
>  .../bindings/media/img,e5010-jpeg-enc.yaml    | 81 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 86 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> new file mode 100644
> index 000000000000..d105a71ee2ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination E5010 JPEG Encoder
> +
> +maintainers:
> +  - Devarsh Thakkar <devarsht@ti.com>
> +
> +description: |
> +  The E5010 is a JPEG encoder from Imagination Technologies implemented on
> +  TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422
> +  inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to
> +  8Kx8K resolution.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: ti,e5010-jpeg-enc

TI did not make e5010. Use SoC-based compatible.

> +          - const: img,e5010-jpeg-enc
> +      - const: img,e5010-jpeg-enc

img,e5010-jpeg-enc cannot be compatible with img,e5010-jpeg-enc. It does
not make sense. I guess I did not expect you are going to use what you
wrote in v1 directly... I thought it is just about syntax.

> +
> +  reg:
> +    items:
> +      - description: The E5010 core register region
> +      - description: The E5010 mmu register region
> +
> +  reg-names:
> +    items:
> +      - const: core
> +      - const: mmu
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: core_clk

Drop _clk or even drop clock-names. It brings little benefit for
one-entry list.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
  2023-08-19 14:00   ` Krzysztof Kozlowski
@ 2023-08-20 16:46     ` Devarsh Thakkar
  2023-08-20 20:25       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-20 16:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

Hi Krzysztof,

Thanks for the review.

On 19/08/23 19:30, Krzysztof Kozlowski wrote:
> On 16/08/2023 17:22, Devarsh Thakkar wrote:
>> Add dt-bindings for Imagination E5010 JPEG Encoder driver which is
>> implemented as stateful V4L2 M2M driver.
>>
>> Co-developed-by: David Huang <d-huang@ti.com>
>> Signed-off-by: David Huang <d-huang@ti.com>
>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
>> ---
>> V2: No change
>> V3:
>> - Add vendor specific compatible
>> - Fix commit title and message
>> - Update reg names
>> - Update clocks to 1
>> - Fix dts example with proper naming
> 
> I do not see improvements in the subject.
> 

Sorry, Will correct in v4.

>>
>>   .../bindings/media/img,e5010-jpeg-enc.yaml    | 81 +++++++++++++++++++
>>   MAINTAINERS                                   |  5 ++
>>   2 files changed, 86 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>> new file mode 100644
>> index 000000000000..d105a71ee2ea
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>> @@ -0,0 +1,81 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Imagination E5010 JPEG Encoder
>> +
>> +maintainers:
>> +  - Devarsh Thakkar <devarsht@ti.com>
>> +
>> +description: |
>> +  The E5010 is a JPEG encoder from Imagination Technologies implemented on
>> +  TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422
>> +  inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to
>> +  8Kx8K resolution.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - items:
>> +          - const: ti,e5010-jpeg-enc
> 
> TI did not make e5010. Use SoC-based compatible.
> 
>> +          - const: img,e5010-jpeg-enc
>> +      - const: img,e5010-jpeg-enc
> 
> img,e5010-jpeg-enc cannot be compatible with img,e5010-jpeg-enc. It does
> not make sense. I guess I did not expect you are going to use what you
> wrote in v1 directly... I thought it is just about syntax.
> 

Sorry but I did not understand this fully, the possible compatibles are:

1) "ti,am62a-jpeg-enc", "img,e5010-jpeg-enc"
or
2)  "img,e5010-jpeg-enc"

anything else will not comply during dtbs_check as shown below :

For e.g. If I use below compatible :
"img,e5010-jpeg-enc", "img,e5010-jpeg-enc"

and run dtbs_check, it throw below error  :

make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml 
ti/k3-am62a7-sk.dtb
   LINT    Documentation/devicetree/bindings
   CHKDT   Documentation/devicetree/bindings/processed-schema.json
   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
   DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
/home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: 
jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must 
be fixed:
         ['img,e5010-jpeg-enc', 'img,e5010-jpeg-enc'] is too long
         'ti,am62a-jpeg-enc' was expected
         From schema: 
/home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml


Similarly, if I use below compatible :

"ti,am62a-jpeg-enc",
It throw below error :

make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml 
ti/k3-am62a7-sk.dtb
   DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
/home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: 
jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must 
be fixed:
         ['ti,am62a-jpeg-enc'] is too short
         'img,e5010-jpeg-enc' was expected
         From schema: 
/home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml


But If I use either 1) or 2) it does not throw any error.
Please let me know if I missed to understand your point.

>> +
>> +  reg:
>> +    items:
>> +      - description: The E5010 core register region
>> +      - description: The E5010 mmu register region
>> +
>> +  reg-names:
>> +    items:
>> +      - const: core
>> +      - const: mmu
>> +
>> +  power-domains:
>> +    maxItems: 1
>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    items:
>> +      - const: core_clk
> 
> Drop _clk or even drop clock-names. It brings little benefit for
> one-entry list.
> 

Agreed, will drop clock-names altogether.

Regards
Devarsh

> 
> Best regards,
> Krzysztof
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
  2023-08-20 16:46     ` Devarsh Thakkar
@ 2023-08-20 20:25       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-20 20:25 UTC (permalink / raw)
  To: Devarsh Thakkar, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

On 20/08/2023 18:46, Devarsh Thakkar wrote:
>>> +properties:
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - const: ti,e5010-jpeg-enc
>>
>> TI did not make e5010. Use SoC-based compatible.
>>
>>> +          - const: img,e5010-jpeg-enc
>>> +      - const: img,e5010-jpeg-enc
>>
>> img,e5010-jpeg-enc cannot be compatible with img,e5010-jpeg-enc. It does
>> not make sense. I guess I did not expect you are going to use what you
>> wrote in v1 directly... I thought it is just about syntax.
>>
> 
> Sorry but I did not understand this fully, the possible compatibles are:
> 
> 1) "ti,am62a-jpeg-enc", "img,e5010-jpeg-enc"
> or
> 2)  "img,e5010-jpeg-enc"
> 
> anything else will not comply during dtbs_check as shown below :

Ah, you are right, ENOTENOUGHCOFFEE or some other issue on my side.

> 
> For e.g. If I use below compatible :
> "img,e5010-jpeg-enc", "img,e5010-jpeg-enc"
> 
> and run dtbs_check, it throw below error  :
> 
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml 
> ti/k3-am62a7-sk.dtb
>    LINT    Documentation/devicetree/bindings
>    CHKDT   Documentation/devicetree/bindings/processed-schema.json
>    SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>    DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: 
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must 
> be fixed:
>          ['img,e5010-jpeg-enc', 'img,e5010-jpeg-enc'] is too long
>          'ti,am62a-jpeg-enc' was expected
>          From schema: 
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> 
> 
> Similarly, if I use below compatible :
> 
> "ti,am62a-jpeg-enc",
> It throw below error :
> 
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml 
> ti/k3-am62a7-sk.dtb
>    DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: 
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must 
> be fixed:
>          ['ti,am62a-jpeg-enc'] is too short
>          'img,e5010-jpeg-enc' was expected
>          From schema: 
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> 
> 
> But If I use either 1) or 2) it does not throw any error.
> Please let me know if I missed to understand your point.

Yes, you are right, sorry for that.

However it still should be "ti,am62a-jpeg-enc", not ti,e5010...


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/4] media: imagination: Add E5010 JPEG Encoder driver
  2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
@ 2023-08-22 10:27   ` Andrzej Pietrasiewicz
  2023-08-31 13:24     ` Devarsh Thakkar
  2023-09-06 12:38   ` Hans Verkuil
  1 sibling, 1 reply; 11+ messages in thread
From: Andrzej Pietrasiewicz @ 2023-08-22 10:27 UTC (permalink / raw)
  To: Devarsh Thakkar, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

Hi Devarsh,

W dniu 16.08.2023 o 17:22, Devarsh Thakkar pisze:
> This adds support for stateful V4L2 M2M based driver
> for Imagination E5010 JPEG Encoder [1] which supports baseline
> encoding with two different quantization tables and compression
> ratio as demanded.
> 
> Support for both contiguous and non-contiguous YUV420 and YUV422
> semiplanar formats is added along with alignment restrictions
> as required by the hardware.
> 
> System and runtime PM hooks are added in the driver along with v4l2
> crop and selection API support.
> 
> Minimum resolution supported is 64x64 and
> Maximum resolution supported is 8192x8192.
> 
> All v4l2-compliance tests are passing [2] :
> v4l2-compliance -s -f -a  -d /dev/video0 -e /dev/video1
> 
> Total for e5010 device /dev/video0: 70, Succeeded: 70, Failed: 0,
> Warnings: 0
> NOTE: video1 here is VIVID test pattern generator
> 
> Also tests [3] were run manually to verify below driver features:
>   - Runtime Power Management
>   - Multi-instance JPEG Encoding
>   - DMABUF import, export support
>   - NV12, NV21, NV16, NV61 video format support
>   - Compression quality S_CTRL
> 
> Existing V4L2 M2M based JPEG drivers namely s5p-jpeg,
> imx-jpeg and rcar_jpu were referred while making this.
> 
> TODO:
> Add MMU and memory tiling support
> 
> [1]:  AM62A TRM (Section 7.6 is for JPEG Encoder)
> Link: https://www.ti.com/lit/pdf/spruj16
> 
> [2]: v4l2-compliance test :
> Link: https://gist.github.com/devarsht/17348fc509fe375a630a798196edbb73
> 
> [3]: E5010 JPEG Encoder Manual tests :
> 
> Performance:
> Link: https://gist.github.com/devarsht/ef5aba211aae45166681b8b4418d4e65
> 
> Functionality:
> Link: https://gist.github.com/devarsht/bfef1e3ead8e858b09cbf418aea753e8
> 
> Compression Quality:
> Link: https://gist.github.com/devarsht/345df9bf7157b4ca094293760e257451
> 
> Multi Instance:
> Link: https://gist.github.com/devarsht/4b4d734eeb9e0e616837c0836ddbc769
> 
> Co-developed-by: David Huang <d-huang@ti.com>
> Signed-off-by: David Huang <d-huang@ti.com>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> V2:
> No change
> 
> V3:
> - Correct license headers
> - Use more generic name core instead of jasper for base registers
> - Add Comment for forward declarations
> - Simplify quantization table calculations
> - Use v4l2_apply_frmsize_constraints for updating framesize and remove unrequired functions
> - Place TODO at top of file and in commit message too
> - Use dev_err_probe helper in probe function
> - Fix return value checking for failure scenarios in probe function
> - Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
> - Fix unexpected indentation
> - Correct commit message
> - Remove dependency on ARCH_K3 as driver is not specific to that
> 
>   MAINTAINERS                                   |    2 +
>   drivers/media/platform/Kconfig                |    1 +
>   drivers/media/platform/Makefile               |    1 +
>   drivers/media/platform/imagination/Kconfig    |   12 +
>   drivers/media/platform/imagination/Makefile   |    3 +
>   .../platform/imagination/e5010-core-regs.h    |  585 ++++++
>   .../platform/imagination/e5010-jpeg-enc-hw.c  |  320 ++++
>   .../platform/imagination/e5010-jpeg-enc-hw.h  |   42 +
>   .../platform/imagination/e5010-jpeg-enc.c     | 1678 +++++++++++++++++
>   .../platform/imagination/e5010-jpeg-enc.h     |  169 ++
>   .../platform/imagination/e5010-mmu-regs.h     |  311 +++
>   11 files changed, 3124 insertions(+)
>   create mode 100644 drivers/media/platform/imagination/Kconfig
>   create mode 100644 drivers/media/platform/imagination/Makefile
>   create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
>   create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9425ecf45df6..725a280a521b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10208,8 +10208,10 @@ F:	drivers/auxdisplay/img-ascii-lcd.c
>   
>   IMGTEC JPEG ENCODER DRIVER
>   M:	Devarsh Thakkar <devarsht@ti.com>
> +L:	linux-media@vger.kernel.org
>   S:	Supported
>   F:	Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> +F:	drivers/media/platform/imagination/e5010*
>   
>   IMGTEC IR DECODER DRIVER
>   S:	Orphan
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index ee579916f874..72b4bedd47fb 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -69,6 +69,7 @@ source "drivers/media/platform/aspeed/Kconfig"
>   source "drivers/media/platform/atmel/Kconfig"
>   source "drivers/media/platform/cadence/Kconfig"
>   source "drivers/media/platform/chips-media/Kconfig"
> +source "drivers/media/platform/imagination/Kconfig"
>   source "drivers/media/platform/intel/Kconfig"
>   source "drivers/media/platform/marvell/Kconfig"
>   source "drivers/media/platform/mediatek/Kconfig"
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index 5453bb868e67..96db57cc9412 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -12,6 +12,7 @@ obj-y += aspeed/
>   obj-y += atmel/
>   obj-y += cadence/
>   obj-y += chips-media/
> +obj-y += imagination/
>   obj-y += intel/
>   obj-y += marvell/
>   obj-y += mediatek/
> diff --git a/drivers/media/platform/imagination/Kconfig b/drivers/media/platform/imagination/Kconfig
> new file mode 100644
> index 000000000000..d8d79266ad5d
> --- /dev/null
> +++ b/drivers/media/platform/imagination/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config VIDEO_E5010_JPEG_ENC
> +	tristate "Imagination E5010 JPEG Encoder Driver"
> +	depends on VIDEO_DEV
> +	select VIDEOBUF2_DMA_CONTIG
> +	select VIDEOBUF2_VMALLOC
> +	select V4L2_MEM2MEM_DEV
> +	help
> +	  This is a video4linux2 M2M driver for Imagination E5010 JPEG encoder,
> +	  which supports JPEG and MJPEG baseline encoding of YUV422 and YUV420
> +	  semiplanar video formats, with resolution ranging from 64x64 to 8K x 8K
> +	  pixels. The module will be named as e5010_jpeg_enc.
> diff --git a/drivers/media/platform/imagination/Makefile b/drivers/media/platform/imagination/Makefile
> new file mode 100644
> index 000000000000..d45b85b88575
> --- /dev/null
> +++ b/drivers/media/platform/imagination/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +e5010_jpeg_enc-objs := e5010-jpeg-enc-hw.o e5010-jpeg-enc.o
> +obj-$(CONFIG_VIDEO_E5010_JPEG_ENC) += e5010_jpeg_enc.o
> diff --git a/drivers/media/platform/imagination/e5010-core-regs.h b/drivers/media/platform/imagination/e5010-core-regs.h
> new file mode 100644
> index 000000000000..aaec498fe83f
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-core-regs.h
> @@ -0,0 +1,585 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_CORE_REGS_H
> +#define _E5010_CORE_REGS_H
> +
> +#define JASPER_CORE_ID_OFFSET				(0x0000)
> +#define JASPER_CORE_ID_CR_GROUP_ID_MASK			(0xFF000000)
> +#define JASPER_CORE_ID_CR_GROUP_ID_SHIFT		(24)
> +#define JASPER_CORE_ID_CR_CORE_ID_MASK			(0x00FF0000)
> +#define JASPER_CORE_ID_CR_CORE_ID_SHIFT			(16)
> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_MASK		(0x0000FFF8)
> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_SHIFT		(3)
> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_MASK		(0x00000007)
> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_SHIFT		(0)
> +
> +#define JASPER_CORE_REV_OFFSET				(0x0004)
> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_MASK		(0xFF000000)
> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_SHIFT	(24)
> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_MASK	(0x00FF0000)
> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_SHIFT	(16)
> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_MASK	(0x0000FF00)
> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_SHIFT	(8)
> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_MASK	(0x000000FF)
> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_SHIFT	(0)
> +
> +#define JASPER_INTERRUPT_MASK_OFFSET					(0x0008)
> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK	(0x00000002)
> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT	(1)
> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT		(0)
> +
> +#define JASPER_INTERRUPT_STATUS_OFFSET					(0x000C)
> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK	(0x00000002)
> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_SHIFT	(1)
> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_SHIFT		(0)
> +
> +#define JASPER_INTERRUPT_CLEAR_OFFSET					(0x0010)
> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK		(0x00000002)
> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT		(1)
> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT		(0)
> +
> +#define JASPER_CLK_CONTROL_OFFSET				(0x0014)
> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK	(0x00000002)
> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT	(1)
> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK	(0x00000001)
> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT	(0)
> +
> +#define JASPER_CLK_STATUS_OFFSET			(0x0018)
> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_MASK	(0x00000001)
> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_SHIFT	(0)
> +
> +#define JASPER_RESET_OFFSET			(0x001C)
> +#define JASPER_RESET_CR_SYS_RESET_MASK		(0x00000002)
> +#define JASPER_RESET_CR_SYS_RESET_SHIFT		(1)
> +#define JASPER_RESET_CR_CORE_RESET_MASK		(0x00000001)
> +#define JASPER_RESET_CR_CORE_RESET_SHIFT	(0)
> +
> +#define JASPER_CORE_CTRL_OFFSET				(0x0020)
> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK	(0x00000001)
> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT	(0)
> +
> +#define JASPER_STATUS_OFFSET				(0x0024)
> +#define JASPER_STATUS_CR_FLUSH_MODE_MASK		(0x00000002)
> +#define JASPER_STATUS_CR_FLUSH_MODE_SHIFT		(1)
> +#define JASPER_STATUS_CR_JASPER_BUSY_MASK		(0x00000001)
> +#define JASPER_STATUS_CR_JASPER_BUSY_SHIFT		(0)
> +
> +#define JASPER_CRC_CLEAR_OFFSET					(0x0028)
> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_MASK		(0x00000001)
> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_SHIFT		(0)
> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_MASK			(0x00000002)
> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_SHIFT			(1)
> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_MASK			(0x00000004)
> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_SHIFT			(2)
> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_MASK		(0x00000008)
> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_SHIFT		(3)
> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_MASK	(0x00000010)
> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_SHIFT	(4)
> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_MASK	(0x00000020)
> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_SHIFT	(5)
> +
> +#define JASPER_INPUT_CTRL0_OFFSET			(0x002C)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK	(0x01000000)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT	(24)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK	(0x00030000)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT	(16)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK		(0x00000004)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT	(2)
> +
> +#define JASPER_INPUT_CTRL1_OFFSET			(0x0030)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK	(0x1FC00000)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT	(22)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK	(0x00001FC0)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT	(6)
> +
> +#define JASPER_MMU_CTRL_OFFSET				(0x0034)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_MASK	(0x00000002)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_SHIFT	(1)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_MASK	(0x00000001)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_SHIFT	(0)
> +
> +#define JASPER_IMAGE_SIZE_OFFSET				(0x0038)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK		(0x1FFF0000)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT		(16)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK		(0x00001FFF)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT	(0)
> +
> +#define INPUT_LUMA_BASE_OFFSET				(0x003C)
> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK		(0xFFFFFFC0)
> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_SHIFT	(6)
> +
> +#define INPUT_CHROMA_BASE_OFFSET			(0x0040)
> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK	(0xFFFFFFC0)
> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_SHIFT	(6)
> +
> +#define JASPER_OUTPUT_BASE_OFFSET		(0x0044)
> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK	(0xFFFFFFFF)
> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT	(0)
> +
> +#define JASPER_OUTPUT_SIZE_OFFSET			(0x0048)
> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_MASK		(0xFFFFFFFF)
> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_SHIFT		(0)
> +#define JASPER_OUTPUT_MAX_SIZE_OFFSET			(0x004C)
> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK	(0xFFFFFFFF)
> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET					(0x0050)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_OFFSET					(0x0054)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_OFFSET					(0x0058)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_OFFSET					(0x005C)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_OFFSET					(0x0060)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_OFFSET					(0x0064)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_OFFSET					(0x0068)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_OFFSET					(0x006C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_OFFSET					(0x0070)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_OFFSET					(0x0074)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_OFFSET					(0x0078)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_OFFSET					(0x007C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_OFFSET					(0x0080)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_OFFSET					(0x0084)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_OFFSET					(0x0088)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_OFFSET					(0x008C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET				(0x0090)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_OFFSET					(0x0094)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_OFFSET					(0x0098)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_OFFSET					(0x009C)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_OFFSET					(0x00A0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_OFFSET					(0x00A4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_OFFSET					(0x00A8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_OFFSET					(0x00AC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_OFFSET					(0x00B0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_OFFSET					(0x00B4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_OFFSET					(0x00B8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_OFFSET					(0x00BC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_OFFSET					(0x00C0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_OFFSET					(0x00C4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_OFFSET					(0x00C8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_OFFSET					(0x00CC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_SHIFT	(0)
> +
> +#define JASPER_CRC_CTRL_OFFSET				(0x00D0)
> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK		(0x00000001)
> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT		(0)
> +
> +#define JASPER_FRONT_END_CRC_OFFSET				(0x00D4)
> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_DCT_CRC_OFFSET				(0x00D8)
> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_ZZ_CRC_OFFSET				(0x00DC)
> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_MASK		(0xFFFFFFFF)
> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_QUANT_CRC_OFFSET				(0x00E0)
> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_ENTROPY_ENCODER_CRC_OFFSET				(0x00E4)
> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_PACKING_BUFFER_DATA_CRC_OFFSET						(0x00E8)
> +#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_MASK		(0xFFFFFFFF)
> +#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_SHIFT		(0)
> +
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_OFFSET						(0x00EC)
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_MASK		(0xFFFFFFFF)
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_SHIFT		(0)
> +
> +#define JASPER_CORE_BYTE_SIZE	(0x00F0)
> +
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
> new file mode 100644
> index 000000000000..237339789407
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
> @@ -0,0 +1,320 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <linux/io.h>
> +#include <linux/iopoll.h>
> +#include <linux/dev_printk.h>
> +#include "e5010-jpeg-enc-hw.h"
> +
> +static void write_reg_field(void __iomem *base, unsigned int offset, u32 mask,
> +			    unsigned int shift, u32 value)
> +{
> +	u32 reg;
> +
> +	value <<= shift;
> +	if (mask != 0xffffffff) {
> +		reg = readl(base + offset);
> +		value = (value & mask) | (reg & ~mask);
> +	}
> +	writel(value, (base + offset));
> +}
> +
> +static int write_reg_field_not_busy(void __iomem *jasper_base, void __iomem *wr_base,
> +				    unsigned int offset, u32 mask, unsigned int shift,
> +				    u32 value)
> +{
> +	int ret;
> +	u32 val;
> +
> +	ret = readl_poll_timeout_atomic(jasper_base + JASPER_STATUS_OFFSET, val,
> +					(val & JASPER_STATUS_CR_JASPER_BUSY_MASK) == 0,
> +					2000, 50000);
> +	if (ret)
> +		return ret;
> +
> +	write_reg_field(wr_base, offset, mask, shift, value);
> +
> +	return 0;
> +}
> +
> +void e5010_reset(struct device *dev, void __iomem *core_base, void __iomem *mmu_base)
> +{
> +	int ret = 0;
> +	u32 val;
> +
> +	write_reg_field(core_base, JASPER_RESET_OFFSET,
> +			JASPER_RESET_CR_CORE_RESET_MASK,
> +			JASPER_RESET_CR_CORE_RESET_SHIFT, 1);
> +
> +	write_reg_field(mmu_base, MMU_MMU_CONTROL1_OFFSET,
> +			MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK,
> +			MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT, 1);
> +
> +	ret = readl_poll_timeout_atomic(mmu_base + MMU_MMU_CONTROL1_OFFSET, val,
> +					(val & MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK) == 0,
> +					2000, 50000);
> +	if (ret)
> +		dev_warn(dev, "MMU soft reset timed out, forcing system soft reset\n");
> +
> +	write_reg_field(core_base, JASPER_RESET_OFFSET,
> +			JASPER_RESET_CR_SYS_RESET_MASK,
> +			JASPER_RESET_CR_SYS_RESET_SHIFT, 1);
> +}
> +
> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable)
> +{
> +	/* Bypass MMU */
> +	write_reg_field(mmu_base,
> +			MMU_MMU_ADDRESS_CONTROL_OFFSET,
> +			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK,
> +			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT,
> +			enable);
> +}
> +
> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INTERRUPT_MASK_OFFSET,
> +				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK,
> +				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT,
> +				       enable);
> +	return ret;
> +}
> +
> +bool e5010_hw_pic_done_irq(void __iomem *core_base)
> +{
> +	u32 reg;
> +	bool pic_done;
> +
> +	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
> +	pic_done = (reg & JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK) ? true : false;
> +
> +	return pic_done;
> +}
> +
> +bool e5010_hw_output_address_irq(void __iomem *core_base)
> +{
> +	u32 reg;
> +	bool output_address_error;
> +
> +	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
> +	output_address_error = (reg & JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK) ?
> +				true : false;
> +
> +	return output_address_error;
> +}
> +
> +int e5010_hw_enable_picture_done_irq(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INTERRUPT_MASK_OFFSET,
> +				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK,
> +				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT,
> +				       enable);
> +	return ret;
> +}
> +
> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CLK_CONTROL_OFFSET,
> +				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK,
> +				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT,
> +				       enable);
> +	return ret;
> +}
> +
> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CLK_CONTROL_OFFSET,
> +				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK,
> +				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT, 0);
> +	return ret;
> +}
> +
> +int e5010_hw_enable_crc_check(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CRC_CTRL_OFFSET,
> +				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK,
> +				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT, enable);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_source_to_memory(void __iomem *core_base, u32 set)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT, set);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_luma_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       INPUT_LUMA_BASE_OFFSET,
> +				       INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK, 0, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_chroma_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       INPUT_CHROMA_BASE_OFFSET,
> +				       INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK, 0, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_output_base_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_OUTPUT_BASE_OFFSET,
> +				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK,
> +				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_horizontal_size(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_IMAGE_SIZE_OFFSET,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_vertical_size(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_IMAGE_SIZE_OFFSET,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_luma_stride(void __iomem *core_base, u32 bytesperline)
> +{
> +	int ret;
> +	u32 val = bytesperline / 64;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL1_OFFSET,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_chroma_stride(void __iomem *core_base, u32 bytesperline)
> +{
> +	int ret;
> +	u32 val = bytesperline / 64;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL1_OFFSET,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_subsampling(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_chroma_order(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +void e5010_hw_set_output_max_size(void __iomem *core_base, u32 val)
> +{
> +	write_reg_field(core_base, JASPER_OUTPUT_MAX_SIZE_OFFSET,
> +			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK,
> +			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT,
> +			val);
> +}
> +
> +int e5010_hw_set_qpvalue(void __iomem *core_base, u32 offset, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base, offset, 0xffffffff, 0, val);
> +	return ret;
> +}
> +
> +void e5010_hw_clear_output_error(void __iomem *core_base, u32 clear)
> +{
> +	/* Make sure interrupts are clear */
> +	write_reg_field(core_base, JASPER_INTERRUPT_CLEAR_OFFSET,
> +			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK,
> +			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT, clear);
> +}
> +
> +void e5010_hw_clear_picture_done(void __iomem *core_base, u32 clear)
> +{
> +	write_reg_field(core_base,
> +			JASPER_INTERRUPT_CLEAR_OFFSET,
> +			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK,
> +			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT, clear);
> +}
> +
> +int e5010_hw_get_output_size(void __iomem *core_base)
> +{
> +	return readl(core_base + JASPER_OUTPUT_SIZE_OFFSET);
> +}
> +
> +void e5010_hw_encode_start(void __iomem *core_base, u32 start)
> +{
> +	write_reg_field(core_base, JASPER_CORE_CTRL_OFFSET,
> +			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK,
> +			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT, start);
> +}
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
> new file mode 100644
> index 000000000000..781d353c3226
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_JPEG_ENC_HW_H
> +#define _E5010_JPEG_ENC_HW_H
> +
> +#include "e5010-core-regs.h"
> +#include "e5010-mmu-regs.h"
> +
> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_picture_done_irq(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_crc_check(void __iomem *core_offset, u32 enable);
> +int e5010_hw_set_input_source_to_memory(void __iomem *core_offset, u32 set);
> +int e5010_hw_set_input_luma_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_input_chroma_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_output_base_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_get_output_size(void __iomem *core_offset);
> +int e5010_hw_set_horizontal_size(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_vertical_size(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_luma_stride(void __iomem *core_offset, u32 bytesperline);
> +int e5010_hw_set_chroma_stride(void __iomem *core_offset, u32 bytesperline);
> +int e5010_hw_set_input_subsampling(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_chroma_order(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_qpvalue(void __iomem *core_offset, u32 offset, u32 value);
> +void e5010_reset(struct device *dev, void __iomem *core_offset, void __iomem *mmu_offset);
> +void e5010_hw_set_output_max_size(void __iomem *core_offset, u32 val);
> +void e5010_hw_clear_picture_done(void __iomem *core_offset, u32 clear);
> +void e5010_hw_encode_start(void __iomem *core_offset, u32 start);
> +void e5010_hw_clear_output_error(void __iomem *core_offset, u32 clear);
> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable);
> +bool e5010_hw_pic_done_irq(void __iomem *core_base);
> +bool e5010_hw_output_address_irq(void __iomem *core_base);
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> new file mode 100644
> index 000000000000..bf40ba9014e1
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -0,0 +1,1678 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * TODO: Add MMU and memory tiling support
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/ioctl.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/err.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/interrupt.h>
> +#include <linux/clk.h>
> +#include <media/v4l2-common.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> +#include <media/v4l2-ioctl.h>
> +#include <media/v4l2-mem2mem.h>
> +#include <media/videobuf2-v4l2.h>
> +#include <media/videobuf2-dma-contig.h>
> +#include "e5010-jpeg-enc.h"
> +#include "e5010-jpeg-enc-hw.h"
> +
> +/* forward declarations */
> +static const struct of_device_id e5010_of_match[];
> +
> +static const struct v4l2_file_operations e5010_fops;
> +
> +static const struct v4l2_ioctl_ops e5010_ioctl_ops;
> +
> +static const struct vb2_ops e5010_video_ops;
> +
> +static const struct v4l2_m2m_ops e5010_m2m_ops;
> +
> +static struct e5010_fmt e5010_formats[] = {
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV12,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV12M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV21,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV21M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV16,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV16M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV61,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV61M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_JPEG,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.subsampling = 0,
> +		.chroma_order = 0,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 16,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +};
> +
> +/* Luma and chroma qp table to acheive 50% compression quality
> + * This is as per example in Annex K.1 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 luma[64] = {
> +	16, 11, 10, 16, 24, 40, 51, 61,
> +	12, 12, 14, 19, 26, 58, 60, 55,
> +	14, 13, 16, 24, 40, 57, 69, 56,
> +	14, 17, 22, 29, 51, 87, 80, 62,
> +	18, 22, 37, 56, 68, 109, 103, 77,
> +	24, 35, 55, 64, 81, 104, 113, 92,
> +	49, 64, 78, 87, 103, 121, 120, 101,
> +	72, 92, 95, 98, 112, 100, 103, 99
> +};
> +
> +static const u8 chroma[64] = {
> +	17, 18, 24, 47, 99, 99, 99, 99,
> +	18, 21, 26, 66, 99, 99, 99, 99,
> +	24, 26, 56, 99, 99, 99, 99, 99,
> +	47, 66, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99
> +};
> +
> +/* Zigzag scan pattern */
> +static const u8 zigzag[64] = {
> +	0,   1,  8, 16,  9,  2,  3, 10,
> +	17, 24, 32, 25, 18, 11,  4,  5,
> +	12, 19, 26, 33, 40, 48, 41, 34,
> +	27, 20, 13,  6,  7, 14, 21, 28,
> +	35, 42, 49, 56, 57, 50, 43, 36,
> +	29, 22, 15, 23, 30, 37, 44, 51,
> +	58, 59, 52, 45, 38, 31, 39, 46,
> +	53, 60, 61, 54, 47, 55, 62, 63
> +};

These 3 are duplicates of those in drivers/media/platform/verisilicon/hantro_jpeg.c

We should eventually do something about it.

> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the luminance DC coefficient differences.
> + * The table represents Table K.3 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_luma_dc[] = {
> +	0x00, 0x00, 0x01, 0x05, 0x01, 0x01, 0x01, 0x01, 0x01,
> +	0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the luminance AC coefficients.
> + * The table represents Table K.5 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_luma_ac[] = {
> +	0x10, 0x00, 0x02, 0x01, 0x03, 0x03, 0x02, 0x04, 0x03,
> +	0x05, 0x05, 0x04, 0x04, 0x00, 0x00, 0x01, 0x7D,
> +	0x01, 0x02, 0x03, 0x00, 0x04, 0x11, 0x05, 0x12, 0x21, 0x31, 0x41, 0x06, 0x13, 0x51, 0x61,
> +	0x07, 0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xA1, 0x08, 0x23, 0x42, 0xB1, 0xC1, 0x15, 0x52,
> +	0xD1, 0xF0, 0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0A, 0x16, 0x17, 0x18, 0x19, 0x1A, 0x25,
> +	0x26, 0x27, 0x28, 0x29, 0x2A, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44, 0x45,
> +	0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63, 0x64,
> +	0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A, 0x83,
> +	0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99,
> +	0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4, 0xB5, 0xB6,
> +	0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA, 0xD2, 0xD3,
> +	0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE1, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7, 0xE8,
> +	0xE9, 0xEA, 0xF1, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the chrominance DC coefficient differences.
> + * The table represents Table K.4 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_chroma_dc[] = {
> +	0x01, 0x00, 0x03, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
> +	0x01, 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the chrominance AC coefficients.
> + * The table represents Table K.6 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_chroma_ac[] = {
> +	0x11, 0x00, 0x02, 0x01, 0x02, 0x04, 0x04, 0x03, 0x04,
> +	0x07, 0x05, 0x04, 0x04, 0x00, 0x01, 0x02, 0x77,
> +	0x00, 0x01, 0x02, 0x03, 0x11, 0x04, 0x05, 0x21, 0x31, 0x06, 0x12, 0x41, 0x51, 0x07, 0x61,
> +	0x71, 0x13, 0x22, 0x32, 0x81, 0x08, 0x14, 0x42, 0x91, 0xA1, 0xB1, 0xC1, 0x09, 0x23, 0x33,
> +	0x52, 0xF0, 0x15, 0x62, 0x72, 0xD1, 0x0A, 0x16, 0x24, 0x34, 0xE1, 0x25, 0xF1, 0x17, 0x18,
> +	0x19, 0x1A, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44,
> +	0x45, 0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63,
> +	0x64, 0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A,
> +	0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97,
> +	0x98, 0x99, 0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4,
> +	0xB5, 0xB6, 0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA,
> +	0xD2, 0xD3, 0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7,
> +	0xE8, 0xE9, 0xEA, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
> +};
> +

These 4 are suspiciously similar, too, to those find in the verisilicon driver.

It seems some jpeg helpers library is in order.

> +static unsigned int debug;
> +module_param(debug, uint, 0644);
> +MODULE_PARM_DESC(debug, "debug level");
> +
> +#define dprintk(dev, lvl, fmt, arg...) \
> +	v4l2_dbg(lvl, debug, &(dev)->v4l2_dev, "%s: " fmt, __func__, ## arg)
> +
> +static const struct v4l2_event e5010_eos_event = {
> +	.type = V4L2_EVENT_EOS
> +};
> +
> +static const char *type_name(enum v4l2_buf_type type)
> +{
> +	switch (type) {
> +	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> +		return "Output";
> +	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
> +		return "Capture";
> +	default:
> +		return "Invalid";
> +	}
> +}
> +
> +static struct e5010_q_data *get_queue(struct e5010_context *ctx, enum v4l2_buf_type type)
> +{
> +	switch (type) {
> +	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> +		return &ctx->out_queue;
> +	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
> +		return &ctx->cap_queue;
> +	default:
> +		return ERR_PTR(-EINVAL);
> +	}
> +
> +	return ERR_PTR(-EINVAL);
> +}
> +
> +static void calculate_qp_tables(struct e5010_context *ctx)
> +{
> +	long long luminosity, contrast;
> +	int quality, i;
> +
> +	quality = 50 - ctx->quality;
> +
> +	luminosity = LUMINOSITY * quality / 50;
> +	contrast = CONTRAST * quality / 50;
> +
> +	if (quality > 0) {
> +		luminosity *= INCREASE;
> +		contrast *= INCREASE;
> +	}
> +
> +	for (i = 0; i < 64; i++) {

Is 64 maybe an ARRAY_SIZE() of something relevant?

> +		long long delta = chroma[i] * contrast + luminosity;
> +		int val = (int)(chroma[i] + delta);
> +
> +		clamp(val, 1, 255);
> +		ctx->chroma_qp[i] = quality == -50 ? 1 : val;
> +
> +		delta = luma[i] * contrast + luminosity;
> +		val = (int)(luma[i] + delta);
> +		clamp(val, 1, 255);
> +		ctx->luma_qp[i] = quality == -50 ? 1 : val;
> +	}
> +
> +	ctx->update_qp = true;
> +}
> +
> +static int update_qp_tables(struct e5010_context *ctx)
> +{
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	int i, ret = 0;
> +	u32 lvalue, cvalue;
> +
> +	lvalue = 0;
> +	cvalue = 0;
> +
> +	for (i = 0; i < QP_TABLE_SIZE; i++) {
> +		lvalue |= ctx->luma_qp[i] << (8 * (i % 4));
> +		cvalue |= ctx->chroma_qp[i] << (8 * (i % 4));
> +		if (i % 4 == 3) {
> +			ret |= e5010_hw_set_qpvalue(e5010->core_base,
> +							JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET
> +							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
> +							lvalue);
> +			ret |= e5010_hw_set_qpvalue(e5010->core_base,
> +							JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET
> +							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
> +							cvalue);
> +			lvalue = 0;
> +			cvalue = 0;
> +		}
> +	}
> +
> +	return ret;
> +}
> +
> +static int e5010_set_input_subsampling(void __iomem *core_base, int subsampling)
> +{
> +	switch (subsampling) {
> +	case V4L2_JPEG_CHROMA_SUBSAMPLING_420:
> +		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_420);
> +	case V4L2_JPEG_CHROMA_SUBSAMPLING_422:
> +		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_422);
> +	default:
> +		return -EINVAL;
> +	};
> +}
> +
> +static int e5010_querycap(struct file *file, void *priv, struct v4l2_capability *cap)
> +{
> +	strscpy(cap->driver, E5010_MODULE_NAME, sizeof(cap->driver));
> +	strscpy(cap->card, E5010_MODULE_NAME, sizeof(cap->card));
> +	snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", E5010_MODULE_NAME);
> +	cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING;
> +	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
> +
> +	return 0;
> +}
> +
> +static struct e5010_fmt *find_format(struct v4l2_format *f)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
> +		if (e5010_formats[i].fourcc == f->fmt.pix_mp.pixelformat &&
> +		    e5010_formats[i].type == f->type)
> +			return &e5010_formats[i];
> +	}
> +
> +	return NULL;
> +}
> +
> +static int e5010_enum_fmt(struct file *file, void *priv, struct v4l2_fmtdesc *f)
> +{
> +	int i, index = 0;
> +	struct e5010_fmt *fmt = NULL;
> +	struct e5010_context *ctx = file->private_data;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "ENUMFMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
> +		if (e5010_formats[i].type == f->type) {
> +			if (index == f->index) {
> +				fmt = &e5010_formats[i];
> +				break;
> +			}
> +			index++;
> +		}
> +	}
> +
> +	if (!fmt)
> +		return -EINVAL;
> +
> +	f->pixelformat = fmt->fourcc;
> +	return 0;
> +}
> +
> +static int e5010_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +	int i;
> +	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	queue = get_queue(ctx, f->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	pix_mp->flags = 0;
> +	pix_mp->field = V4L2_FIELD_NONE;
> +	pix_mp->pixelformat = queue->fmt->fourcc;
> +	pix_mp->width = queue->width_adjusted;
> +	pix_mp->height = queue->height_adjusted;
> +	pix_mp->num_planes = queue->fmt->num_planes;
> +
> +	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
> +		if (!pix_mp->colorspace)
> +			pix_mp->colorspace = V4L2_COLORSPACE_SRGB;
> +
> +		for (i = 0; i < queue->fmt->num_planes; i++) {
> +			plane_fmt[i].sizeimage = queue->sizeimage[i];
> +			plane_fmt[i].bytesperline = queue->bytesperline[i];
> +		}
> +
> +	} else {
> +		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		plane_fmt[0].bytesperline = 0;
> +		plane_fmt[0].sizeimage = queue->sizeimage[0];
> +	}
> +	pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +	pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +	pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +
> +	return 0;
> +}
> +
> +static int e5010_jpeg_try_fmt(struct v4l2_format *f, struct e5010_context *ctx)
> +{
> +	struct e5010_fmt *fmt;
> +	struct e5010_q_data *queue;
> +	int i;
> +	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	fmt = find_format(f);
> +	if (!fmt) {
> +		if (V4L2_TYPE_IS_OUTPUT(f->type))
> +			pix_mp->pixelformat = V4L2_PIX_FMT_NV12;
> +		else
> +			pix_mp->pixelformat = V4L2_PIX_FMT_JPEG;
> +		fmt = find_format(f);
> +		if (!fmt)
> +			return -EINVAL;
> +	}
> +
> +	queue = get_queue(ctx, f->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	queue->fmt = fmt;
> +	queue->width = pix_mp->width;
> +	queue->height = pix_mp->height;
> +
> +	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
> +		if (!pix_mp->colorspace)
> +			pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		if (!pix_mp->ycbcr_enc)
> +			pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +		if (!pix_mp->quantization)
> +			pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +		if (!pix_mp->xfer_func)
> +			pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +
> +		v4l2_apply_frmsize_constraints(&pix_mp->width,
> +					       &pix_mp->height,
> +					       &fmt->frmsize);
> +
> +		v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
> +				    pix_mp->width, pix_mp->height);
> +
> +		for (i = 0; i < fmt->num_planes; i++) {
> +			queue->bytesperline[i] = plane_fmt[i].bytesperline;
> +			queue->sizeimage[i] = plane_fmt[i].sizeimage;
> +		}
> +	} else {
> +		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +		pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +		pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +		memset(plane_fmt[0].reserved, 0, sizeof(plane_fmt[0].reserved));
> +		v4l2_apply_frmsize_constraints(&pix_mp->width,
> +					       &pix_mp->height,
> +					       &fmt->frmsize);
> +		queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
> +		queue->sizeimage[0] += HEADER_SIZE;
> +		queue->sizeimage[1] = 0;
> +		queue->bytesperline[0] = 0;
> +		queue->bytesperline[1] = 0;
> +		plane_fmt[0].sizeimage = queue->sizeimage[0];
> +		plane_fmt[0].bytesperline = 0;
> +	}
> +	pix_mp->flags = 0;
> +	pix_mp->field = V4L2_FIELD_NONE;
> +	pix_mp->pixelformat = fmt->fourcc;
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +	pix_mp->num_planes = fmt->num_planes;
> +	memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
> +
> +	dprintk(ctx->e5010, 2,
> +		"ctx: 0x%p: format type %s:, wxh: %dx%d (plane0 : %d bytes, plane1 : %d bytes),fmt: %c%c%c%c\n",
> +		ctx, type_name(f->type), queue->width_adjusted, queue->height_adjusted,
> +		queue->sizeimage[0], queue->sizeimage[1],
> +		(queue->fmt->fourcc & 0xff),
> +		(queue->fmt->fourcc >>  8) & 0xff,
> +		(queue->fmt->fourcc >> 16) & 0xff,
> +		(queue->fmt->fourcc >> 24) & 0xff);
> +
> +	return 0;
> +}
> +
> +static int e5010_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +
> +	return e5010_jpeg_try_fmt(f, ctx);
> +}
> +
> +static int e5010_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct vb2_queue *vq;
> +
> +	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
> +	if (!vq)
> +		return -EINVAL;
> +
> +	if (vb2_is_busy(vq)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "queue busy\n");
> +		return -EBUSY;
> +	}
> +
> +	return e5010_jpeg_try_fmt(f, ctx);
> +}
> +
> +static int e5010_enum_framesizes(struct file *file, void *priv, struct v4l2_frmsizeenum *fsize)
> +{
> +	struct v4l2_format f;
> +	struct e5010_fmt *fmt;
> +
> +	if (fsize->index != 0)
> +		return -EINVAL;
> +
> +	f.fmt.pix_mp.pixelformat = fsize->pixel_format;
> +	if (f.fmt.pix_mp.pixelformat ==  V4L2_PIX_FMT_JPEG)
> +		f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	else
> +		f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +
> +	fmt = find_format(&f);
> +	if (!fmt)
> +		return -EINVAL;
> +
> +	fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> +	fsize->stepwise = fmt->frmsize;
> +	fsize->reserved[0] = 0;
> +	fsize->reserved[1] = 0;
> +
> +	return 0;
> +}
> +
> +static int e5010_g_selection(struct file *file, void *fh, struct v4l2_selection *s)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +
> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> +		return -EINVAL;
> +
> +	queue = get_queue(ctx, s->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	switch (s->target) {
> +	case V4L2_SEL_TGT_CROP_DEFAULT:
> +	case V4L2_SEL_TGT_CROP_BOUNDS:
> +		s->r.left = 0;
> +		s->r.top = 0;
> +		s->r.width = queue->width;
> +		s->r.height = queue->height;
> +		break;
> +	case V4L2_SEL_TGT_CROP:
> +		s->r = queue->crop;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +
> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> +		return -EINVAL;
> +
> +	queue = get_queue(ctx, s->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	queue->crop.left = 0;
> +	queue->crop.top = 0;
> +	queue->crop.width = s->r.width;
> +	queue->crop.height = s->r.height;
> +
> +	return 0;
> +}
> +
> +static int e5010_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subscription *sub)
> +{
> +	switch (sub->type) {
> +	case V4L2_EVENT_EOS:
> +		return v4l2_event_subscribe(fh, sub, 0, NULL);
> +	case V4L2_EVENT_CTRL:
> +		return v4l2_ctrl_subscribe_event(fh, sub);
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
> +{
> +	struct e5010_context *ctx = priv;
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	int ret = 0;
> +
> +	/* src_vq */
> +	memset(src_vq, 0, sizeof(*src_vq));
> +	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
> +	src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
> +	src_vq->drv_priv = ctx;
> +	src_vq->buf_struct_size = sizeof(struct e5010_buffer);
> +	src_vq->ops = &e5010_video_ops;
> +	src_vq->mem_ops = &vb2_dma_contig_memops;
> +	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +	src_vq->lock = &e5010->mutex;
> +	src_vq->dev = e5010->v4l2_dev.dev;
> +
> +	ret = vb2_queue_init(src_vq);
> +	if (ret)
> +		return ret;
> +
> +	/* dst_vq */
> +	memset(dst_vq, 0, sizeof(*dst_vq));
> +	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
> +	dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
> +	dst_vq->drv_priv = ctx;
> +	dst_vq->buf_struct_size = sizeof(struct e5010_buffer);
> +	dst_vq->ops = &e5010_video_ops;
> +	dst_vq->mem_ops = &vb2_dma_contig_memops;
> +	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +	dst_vq->lock = &e5010->mutex;
> +	dst_vq->dev = e5010->v4l2_dev.dev;
> +
> +	ret = vb2_queue_init(dst_vq);
> +	if (ret) {
> +		vb2_queue_release(src_vq);
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_s_ctrl(struct v4l2_ctrl *ctrl)
> +{
> +	struct e5010_context *ctx =
> +		container_of(ctrl->handler, struct e5010_context, ctrl_handler);
> +
> +	switch (ctrl->id) {
> +	case V4L2_CID_JPEG_COMPRESSION_QUALITY:
> +		ctx->quality = ctrl->val;
> +		calculate_qp_tables(ctx);
> +		break;
> +	default:
> +		v4l2_err(&ctx->e5010->v4l2_dev, "Invalid control, id = %d, val = %d\n",
> +			 ctrl->id, ctrl->val);
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct v4l2_ctrl_ops e5010_ctrl_ops = {
> +	.s_ctrl = e5010_s_ctrl,
> +};
> +
> +static void e5010_encode_ctrls(struct e5010_context *ctx)
> +{
> +	v4l2_ctrl_new_std(&ctx->ctrl_handler, &e5010_ctrl_ops,
> +			  V4L2_CID_JPEG_COMPRESSION_QUALITY, 1, 100, 1, 75);
> +}
> +
> +static int e5010_ctrls_setup(struct e5010_context *ctx)
> +{
> +	int err;
> +
> +	v4l2_ctrl_handler_init(&ctx->ctrl_handler, 1);
> +
> +	e5010_encode_ctrls(ctx);
> +
> +	if (ctx->ctrl_handler.error) {
> +		err = ctx->ctrl_handler.error;
> +		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +
> +		return err;
> +	}
> +
> +	err = v4l2_ctrl_handler_setup(&ctx->ctrl_handler);
> +	if (err)
> +		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +
> +	return err;
> +}
> +
> +static void e5010_jpeg_set_default_params(struct e5010_context *ctx)
> +{
> +	struct e5010_q_data *queue;
> +	struct v4l2_format f;
> +	struct e5010_fmt *fmt;
> +	struct v4l2_pix_format_mplane *pix_mp = &f.fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +	int i = 0;
> +
> +	f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12;
> +	fmt = find_format(&f);
> +	queue = &ctx->out_queue;
> +	queue->fmt = fmt;
> +	queue->width = DEFAULT_WIDTH;
> +	queue->height = DEFAULT_HEIGHT;
> +	v4l2_apply_frmsize_constraints(&pix_mp->width,
> +				       &pix_mp->height,
> +				       &fmt->frmsize);
> +	v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
> +			    pix_mp->width, pix_mp->height);
> +	for (i = 0; i < fmt->num_planes; i++) {
> +		queue->bytesperline[i] = plane_fmt[i].bytesperline;
> +		queue->sizeimage[i] = plane_fmt[i].sizeimage;
> +	}
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +	queue->format_set = false;
> +	queue->streaming = false;
> +
> +	f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_JPEG;
> +	fmt = find_format(&f);
> +	queue = &ctx->cap_queue;
> +	queue->fmt = fmt;
> +	queue->width = DEFAULT_WIDTH;
> +	queue->height = DEFAULT_HEIGHT;
> +	v4l2_apply_frmsize_constraints(&pix_mp->width,
> +				       &pix_mp->height,
> +				       &fmt->frmsize);
> +	queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
> +	queue->sizeimage[0] += HEADER_SIZE;
> +	queue->sizeimage[1] = 0;
> +	queue->bytesperline[0] = 0;
> +	queue->bytesperline[1] = 0;
> +	queue->format_set = false;
> +	queue->streaming = false;
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +}
> +
> +static int e5010_open(struct file *file)
> +{
> +	struct e5010_dev *e5010 = video_drvdata(file);
> +	struct video_device *vdev = video_devdata(file);
> +	struct e5010_context *ctx;
> +	int ret = 0;
> +
> +	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return -ENOMEM;
> +
> +	if (mutex_lock_interruptible(&e5010->mutex)) {
> +		ret = -ERESTARTSYS;
> +		goto free;
> +	}
> +
> +	v4l2_fh_init(&ctx->fh, vdev);
> +	file->private_data = ctx;
> +	v4l2_fh_add(&ctx->fh);
> +
> +	ctx->e5010 = e5010;
> +	ctx->fh.m2m_ctx = v4l2_m2m_ctx_init(e5010->m2m_dev, ctx, queue_init);
> +	if (IS_ERR(ctx->fh.m2m_ctx)) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to init m2m ctx\n");
> +		ret = PTR_ERR(ctx->fh.m2m_ctx);
> +		goto exit;
> +	}
> +
> +	ret = e5010_ctrls_setup(ctx);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to setup e5010 jpeg controls\n");
> +		goto err_ctrls_setup;
> +	}
> +	ctx->fh.ctrl_handler = &ctx->ctrl_handler;
> +
> +	e5010_jpeg_set_default_params(ctx);
> +
> +	dprintk(e5010, 1, "Created instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
> +
> +	mutex_unlock(&e5010->mutex);
> +	return 0;
> +
> +err_ctrls_setup:
> +	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
> +exit:
> +	v4l2_fh_del(&ctx->fh);
> +	v4l2_fh_exit(&ctx->fh);
> +	mutex_unlock(&e5010->mutex);
> +free:
> +	kfree(ctx);
> +	return ret;
> +}
> +
> +static int e5010_release(struct file *file)
> +{
> +	struct e5010_dev *e5010 = video_drvdata(file);
> +	struct e5010_context *ctx = file->private_data;
> +
> +	dprintk(e5010, 1, "Releasing instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
> +	mutex_lock(&e5010->mutex);
> +	v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
> +	v4l2_fh_del(&ctx->fh);
> +	v4l2_fh_exit(&ctx->fh);
> +	kfree(ctx);
> +	mutex_unlock(&e5010->mutex);
> +
> +	return 0;
> +}
> +
> +static struct video_device e5010_videodev = {
> +	.name = E5010_MODULE_NAME,
> +	.fops = &e5010_fops,
> +	.ioctl_ops = &e5010_ioctl_ops,
> +	.minor = -1,
> +	.release = video_device_release_empty,
> +	.vfl_dir = VFL_DIR_M2M,
> +	.device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING,
> +};
> +
> +static void header_write(struct e5010_context *ctx, u8 *addr, unsigned int *offset,
> +			 unsigned int no_bytes, unsigned long bits)
> +{
> +	u8 *w_addr = addr + *offset;
> +	int i;
> +
> +	if ((*offset + no_bytes) > HEADER_SIZE) {
> +		v4l2_warn(&ctx->e5010->v4l2_dev, "%s: %s: %d: Problem writing header. %d > HEADER_SIZE %d\n",
> +			  __FILE__, __func__, __LINE__, *offset + no_bytes, HEADER_SIZE);
> +		return;
> +	}
> +
> +	for (i = no_bytes - 1; i >= 0; i--)
> +		*(w_addr++) = ((u8 *)&bits)[i];
> +
> +	*offset += no_bytes;
> +}
> +
> +static void encode_marker_segment(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +	int i;
> +
> +	header_write(ctx, buffer, offset, 2, START_OF_IMAGE);
> +	header_write(ctx, buffer, offset, 2, DQT_MARKER);

These markers have already been defined somewhere else (i.e. not in this
driver). Why not factor that out and reuse?

Regards,

Andrzej

> +	header_write(ctx, buffer, offset, 3, LQPQ << 4);
> +	for (i = 0; i < PELS_IN_BLOCK; i++)
> +		header_write(ctx, buffer, offset, 1, ctx->luma_qp[zigzag[i]]);
> +
> +	header_write(ctx, buffer, offset, 2, DQT_MARKER);
> +	header_write(ctx, buffer, offset, 3, (LQPQ << 4) | 1);
> +	for (i = 0; i < PELS_IN_BLOCK; i++)
> +		header_write(ctx, buffer, offset, 1, ctx->chroma_qp[zigzag[i]]);
> +
> +	/* Huffman tables */
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_DC);
> +	for (i = 0 ; i < (LH_DC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_luma_dc[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_AC);
> +	for (i = 0 ; i < (LH_AC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_luma_ac[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_DC);
> +	for (i = 0 ; i < (LH_DC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_chroma_dc[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_AC);
> +	for (i = 0 ; i < (LH_AC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_chroma_ac[i]);
> +}
> +
> +static void encode_frame_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +
> +	header_write(ctx, buffer, offset, 2, SOF_BASELINE_DCT);
> +	header_write(ctx, buffer, offset, 2, 8 + (3 * UC_NUM_COMP));
> +	header_write(ctx, buffer, offset, 1, PRECISION);
> +	header_write(ctx, buffer, offset, 2, ctx->out_queue.height);
> +	header_write(ctx, buffer, offset, 2, ctx->out_queue.width);
> +	header_write(ctx, buffer, offset, 1, UC_NUM_COMP);
> +
> +	/* Luma details */
> +	header_write(ctx, buffer, offset, 1, 1);
> +	if (ctx->out_queue.fmt->subsampling == V4L2_JPEG_CHROMA_SUBSAMPLING_422)
> +		header_write(ctx, buffer, offset, 1,
> +			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_422));
> +	else
> +		header_write(ctx, buffer, offset, 1,
> +			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_420));
> +	header_write(ctx, buffer, offset, 1, 0);
> +	/* Chroma details */
> +	header_write(ctx, buffer, offset, 1, 2);
> +	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
> +	header_write(ctx, buffer, offset, 1, 1);
> +	header_write(ctx, buffer, offset, 1, 3);
> +	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
> +	header_write(ctx, buffer, offset, 1, 1);
> +
> +	header_write(ctx, buffer, offset, 1, 0xFF);
> +}
> +
> +static void jpg_encode_sos_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +	int i;
> +
> +	header_write(ctx, buffer, offset, 2, START_OF_SCAN);
> +	header_write(ctx, buffer, offset, 2, 6 + (COMPONENTS_IN_SCAN << 1));
> +	header_write(ctx, buffer, offset, 1, COMPONENTS_IN_SCAN);
> +
> +	for (i = 0; i < COMPONENTS_IN_SCAN; i++) {
> +		header_write(ctx, buffer, offset, 1, i + 1);
> +		if (i == 0)
> +			header_write(ctx, buffer, offset, 1, 0);
> +		else
> +			header_write(ctx, buffer, offset, 1, 17);
> +	}
> +
> +	header_write(ctx, buffer, offset, 1, 0);
> +	header_write(ctx, buffer, offset, 1, 63);
> +	header_write(ctx, buffer, offset, 1, 0);
> +}
> +
> +static void write_header(struct e5010_context *ctx, void *addr)
> +{
> +	unsigned int offset = 0;
> +
> +	encode_marker_segment(ctx, addr, &offset);
> +	encode_frame_header(ctx, addr, &offset);
> +	jpg_encode_sos_header(ctx, addr, &offset);
> +}
> +
> +static irqreturn_t e5010_irq(int irq, void *data)
> +{
> +	struct e5010_dev *e5010 = data;
> +	struct e5010_context *ctx;
> +	int output_size;
> +	struct vb2_v4l2_buffer *src_buf, *dst_buf;
> +	bool pic_done, out_addr_err;
> +
> +	spin_lock(&e5010->hw_lock);
> +	pic_done = e5010_hw_pic_done_irq(e5010->core_base);
> +	out_addr_err = e5010_hw_output_address_irq(e5010->core_base);
> +
> +	if (!pic_done && !out_addr_err) {
> +		spin_unlock(&e5010->hw_lock);
> +		return IRQ_NONE;
> +	}
> +
> +	ctx = v4l2_m2m_get_curr_priv(e5010->m2m_dev);
> +	if (WARN_ON(!ctx))
> +		goto job_unlock;
> +
> +	dst_buf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
> +	src_buf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
> +	if (!dst_buf || !src_buf) {
> +		v4l2_err(&e5010->v4l2_dev, "ctx: 0x%p No source or destination buffer\n", ctx);
> +		goto job_unlock;
> +	}
> +
> +	if (out_addr_err) {
> +		e5010_hw_clear_output_error(e5010->core_base, 1);
> +		v4l2_warn(&e5010->v4l2_dev,
> +			  "ctx: 0x%p Output bitstream size exceeded max size\n", ctx);
> +		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
> +		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, dst_buf->planes[0].length);
> +		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR);
> +		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
> +			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
> +			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
> +			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
> +		}
> +	}
> +
> +	if (pic_done) {
> +		e5010_hw_clear_picture_done(e5010->core_base, 1);
> +		dprintk(e5010, 3, "ctx: 0x%p Got output bitstream of size %d bytes\n",
> +			ctx, readl(e5010->core_base + JASPER_OUTPUT_SIZE_OFFSET));
> +
> +		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
> +			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
> +			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
> +			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
> +		}
> +		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE);
> +		output_size = e5010_hw_get_output_size(e5010->core_base);
> +		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, output_size + HEADER_SIZE);
> +		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE);
> +		dprintk(e5010, 3,
> +			"ctx: 0x%p frame done for dst_buf->sequence: %d src_buf->sequence: %d\n",
> +			ctx, dst_buf->sequence, src_buf->sequence);
> +	}
> +
> +	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
> +	dprintk(e5010, 3, "ctx: 0x%p Finish job\n", ctx);
> +
> +job_unlock:
> +	spin_unlock(&e5010->hw_lock);
> +	return IRQ_HANDLED;
> +}
> +
> +static int e5010_init_device(struct e5010_dev *e5010)
> +{
> +	int ret = 0;
> +
> +	/*TODO: Set MMU in bypass mode until support for the same is added in driver*/
> +	e5010_hw_bypass_mmu(e5010->mmu_base, 1);
> +
> +	if (e5010_hw_enable_auto_clock_gating(e5010->core_base, 1))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to enable auto clock gating\n");
> +
> +	if (e5010_hw_enable_manual_clock_gating(e5010->core_base, 0))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to disable manual clock gating\n");
> +
> +	if (e5010_hw_enable_crc_check(e5010->core_base, 0))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to disable CRC check\n");
> +
> +	if (e5010_hw_enable_output_address_error_irq(e5010->core_base, 1))
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable Output Address Error interrupts\n");
> +
> +	ret = e5010_hw_set_input_source_to_memory(e5010->core_base, 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input source to memory\n");
> +		return ret;
> +	}
> +
> +	ret = e5010_hw_enable_picture_done_irq(e5010->core_base, 1);
> +	if (ret)
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable Picture Done interrupts\n");
> +
> +	return ret;
> +}
> +
> +static int e5010_probe(struct platform_device *pdev)
> +{
> +	struct e5010_dev *e5010;
> +	int irq, ret = 0;
> +
> +	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> +	if (ret)
> +		return dev_err_probe(e5010->dev, ret, "32-bit consistent DMA enable failed\n");
> +
> +	e5010 = devm_kzalloc(&pdev->dev, sizeof(*e5010), GFP_KERNEL);
> +	if (!e5010)
> +		return -ENOMEM;
> +
> +	platform_set_drvdata(pdev, e5010);
> +
> +	e5010->dev = &pdev->dev;
> +
> +	mutex_init(&e5010->mutex);
> +	spin_lock_init(&e5010->hw_lock);
> +
> +	e5010->vdev = &e5010_videodev;
> +	e5010->vdev->v4l2_dev = &e5010->v4l2_dev;
> +	e5010->vdev->lock = &e5010->mutex;
> +	e5010->vdev->queue = NULL;
> +	e5010->vdev->prio = NULL;
> +	e5010->vdev->dev_parent = NULL;
> +	e5010->vdev->minor = -1;
> +
> +	ret = v4l2_device_register(&pdev->dev, &e5010->v4l2_dev);
> +	if (ret)
> +		return dev_err_probe(e5010->dev, ret, "failed to register v4l2 device\n");
> +
> +	e5010->m2m_dev = v4l2_m2m_init(&e5010_m2m_ops);
> +	if (IS_ERR(e5010->m2m_dev)) {
> +		ret = PTR_ERR(e5010->m2m_dev);
> +		e5010->m2m_dev = NULL;
> +		dev_err_probe(e5010->dev, ret, "failed to init mem2mem device\n");
> +		goto fail_after_v4l2_register;
> +	}
> +
> +	video_set_drvdata(e5010->vdev, e5010);
> +
> +	ret = video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0);
> +	if (ret) {
> +		dev_err_probe(e5010->dev, ret, "failed to register video device\n");
> +		goto fail_after_v4l2_register;
> +	}
> +
> +	v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n",
> +		  e5010->vdev->num);
> +
> +	e5010->core_base = devm_platform_ioremap_resource_byname(pdev, "core");
> +	if (IS_ERR(e5010->core_base)) {
> +		ret = PTR_ERR(e5010->core_base);
> +		dev_err_probe(e5010->dev, ret, "Missing 'core' resources area\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu");
> +	if (IS_ERR(e5010->mmu_base)) {
> +		ret = PTR_ERR(e5010->mmu_base);
> +		dev_err_probe(e5010->dev, ret, "Missing 'mmu' resources area\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->last_context_run = NULL;
> +
> +	irq = platform_get_irq(pdev, 0);
> +	ret = devm_request_irq(e5010->dev, irq, e5010_irq, 0,
> +			       E5010_MODULE_NAME, e5010);
> +	if (ret) {
> +		dev_err_probe(e5010->dev, ret, "failed to register IRQ %d\n", irq);
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->clk = devm_clk_get(&pdev->dev, "core_clk");
> +	if (IS_ERR(e5010->clk)) {
> +		ret = PTR_ERR(e5010->clk);
> +		dev_err_probe(e5010->dev, ret, "failed to get clock\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	pm_runtime_enable(e5010->dev);
> +
> +	return 0;
> +
> +fail_after_video_register_device:
> +	v4l2_m2m_release(e5010->m2m_dev);
> +fail_after_v4l2_register:
> +	v4l2_device_unregister(&e5010->v4l2_dev);
> +	return ret;
> +}
> +
> +static int e5010_remove(struct platform_device *pdev)
> +{
> +	struct e5010_dev *e5010 = platform_get_drvdata(pdev);
> +
> +	pm_runtime_disable(e5010->dev);
> +	video_unregister_device(e5010->vdev);
> +	v4l2_m2m_release(e5010->m2m_dev);
> +	v4l2_device_unregister(&e5010->v4l2_dev);
> +
> +	return 0;
> +}
> +
> +static int e5010_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsigned int *nplanes,
> +			     unsigned int sizes[], struct device *alloc_devs[])
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vq);
> +	struct e5010_q_data *queue;
> +	int i;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(vq->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "queue setup with Invalid type: %d\n", vq->type);
> +		return -EINVAL;
> +	}
> +
> +	queue = get_queue(ctx, vq->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	if (*nplanes) {
> +		if (*nplanes != queue->fmt->num_planes)
> +			return -EINVAL;
> +		for (i = 0; i < *nplanes; i++) {
> +			if (sizes[i] < queue->sizeimage[i])
> +				return -EINVAL;
> +		}
> +		return 0;
> +	}
> +
> +	*nbuffers = max_t(unsigned int, *nbuffers, 1);
> +	*nplanes = queue->fmt->num_planes;
> +	for (i = 0; i < *nplanes; i++)
> +		sizes[i] = queue->sizeimage[i];
> +
> +	dprintk(ctx->e5010, 2,
> +		"ctx: 0x%p, type %s, buffer(s): %d, planes %d, plane1: bytes %d plane2: %d bytes\n",
> +		ctx, type_name(vq->type), *nbuffers, *nplanes, sizes[0], sizes[1]);
> +
> +	return 0;
> +}
> +
> +static void e5010_buf_finish(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	void *d_addr;
> +
> +	if (vb->state != VB2_BUF_STATE_DONE || V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
> +		return;
> +
> +	d_addr = vb2_plane_vaddr(vb, 0);
> +	write_header(ctx, d_addr);
> +}
> +
> +static int e5010_buf_out_validate(struct vb2_buffer *vb)
> +{
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +
> +	if (vbuf->field != V4L2_FIELD_NONE)
> +		dprintk(ctx->e5010, 1, "ctx: 0x%p, field isn't supported\n", ctx);
> +
> +	vbuf->field = V4L2_FIELD_NONE;
> +
> +	return 0;
> +}
> +
> +static int e5010_buf_prepare(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +	struct e5010_q_data *queue;
> +	int i;
> +
> +	vbuf->field = V4L2_FIELD_NONE;
> +
> +	queue = get_queue(ctx, vb->vb2_queue->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	for (i = 0; i < queue->fmt->num_planes; i++) {
> +		if (vb2_plane_size(vb, i) < (unsigned long)queue->sizeimage[i]) {
> +			v4l2_err(&ctx->e5010->v4l2_dev, "plane %d too small (%lu < %lu)", i,
> +				 vb2_plane_size(vb, i), (unsigned long)queue->sizeimage[i]);
> +
> +			return -EINVAL;
> +		}
> +	}
> +
> +	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type)) {
> +		vb2_set_plane_payload(vb, 0, 0);
> +		vb2_set_plane_payload(vb, 1, 0);
> +	}
> +
> +	return 0;
> +}
> +
> +static void e5010_buf_queue(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +
> +	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type) &&
> +	    vb2_is_streaming(vb->vb2_queue) &&
> +	    v4l2_m2m_dst_buf_is_last(ctx->fh.m2m_ctx)) {
> +		struct e5010_q_data *queue = get_queue(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
> +
> +		if (IS_ERR(queue))
> +			return;
> +
> +		vbuf->sequence = queue->sequence++;
> +		v4l2_m2m_last_buffer_done(ctx->fh.m2m_ctx, vbuf);
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +		return;
> +	}
> +
> +	v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
> +}
> +
> +static int e5010_encoder_cmd(struct file *file, void *priv,
> +			     struct v4l2_encoder_cmd *cmd)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	int ret;
> +	struct vb2_queue *cap_vq;
> +
> +	cap_vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
> +
> +	ret = v4l2_m2m_ioctl_try_encoder_cmd(file, &ctx->fh, cmd);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (!vb2_is_streaming(v4l2_m2m_get_src_vq(ctx->fh.m2m_ctx)) ||
> +	    !vb2_is_streaming(v4l2_m2m_get_dst_vq(ctx->fh.m2m_ctx)))
> +		return 0;
> +
> +	ret = v4l2_m2m_ioctl_encoder_cmd(file, &ctx->fh, cmd);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (cmd->cmd == V4L2_ENC_CMD_STOP &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +
> +	if (cmd->cmd == V4L2_ENC_CMD_START &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
> +		vb2_clear_last_buffer_dequeued(cap_vq);
> +
> +	return 0;
> +}
> +
> +static int e5010_start_streaming(struct vb2_queue *q, unsigned int count)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(q);
> +	int ret;
> +
> +	struct e5010_q_data *queue = get_queue(ctx, q->type);
> +
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +	queue->streaming = true;
> +	v4l2_m2m_update_start_streaming_state(ctx->fh.m2m_ctx, q);
> +	queue->sequence = 0;
> +
> +	ret = pm_runtime_resume_and_get(ctx->e5010->dev);
> +	if (ret < 0) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "failed to power up jpeg\n");
> +		return ret;
> +	}
> +
> +	ret = e5010_init_device(ctx->e5010);
> +	if (ret)
> +		v4l2_err(&ctx->e5010->v4l2_dev, "failed to Enable e5010 device\n");
> +
> +	return ret;
> +}
> +
> +static void e5010_stop_streaming(struct vb2_queue *q)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(q);
> +	struct vb2_v4l2_buffer *vbuf;
> +	struct e5010_q_data *queue;
> +
> +	queue = get_queue(ctx, q->type);
> +	if (IS_ERR(queue))
> +		return;
> +
> +	queue->streaming = false;
> +
> +	if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
> +		while ((vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx))) {
> +			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
> +				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
> +			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
> +		}
> +	} else {
> +		while ((vbuf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx))) {
> +			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
> +				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
> +			vb2_set_plane_payload(&vbuf->vb2_buf, 0, 0);
> +			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
> +		}
> +	}
> +
> +	if (V4L2_TYPE_IS_OUTPUT(q->type))
> +		v4l2_m2m_update_stop_streaming_state(ctx->fh.m2m_ctx, q);
> +
> +	if (V4L2_TYPE_IS_OUTPUT(q->type) &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx)) {
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +	}
> +
> +	pm_runtime_put_sync(ctx->e5010->dev);
> +}
> +
> +static void e5010_device_run(void *priv)
> +{
> +	struct e5010_context *ctx = priv;
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	struct vb2_v4l2_buffer *s_vb, *d_vb;
> +	u32 reg = 0;
> +	int ret = 0;
> +	unsigned long flags;
> +	int num_planes = ctx->out_queue.fmt->num_planes;
> +
> +	spin_lock_irqsave(&e5010->hw_lock, flags);
> +	s_vb = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
> +	WARN_ON(!s_vb);
> +	d_vb = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx);
> +	WARN_ON(!d_vb);
> +	if (!s_vb || !d_vb)
> +		goto no_ready_buf_err;
> +
> +	s_vb->sequence = ctx->out_queue.sequence++;
> +	d_vb->sequence = ctx->cap_queue.sequence++;
> +
> +	v4l2_m2m_buf_copy_metadata(s_vb, d_vb, false);
> +
> +	if (ctx != e5010->last_context_run || ctx->update_qp) {
> +		dprintk(e5010, 1, "ctx updated: 0x%p -> 0x%p, updating qp tables\n",
> +			e5010->last_context_run, ctx);
> +		ret = update_qp_tables(ctx);
> +	}
> +
> +	if (ret) {
> +		ctx->update_qp = true;
> +		v4l2_err(&e5010->v4l2_dev, "failed to update QP tables\n");
> +		goto device_busy_err;
> +	} else {
> +		e5010->last_context_run = ctx;
> +		ctx->update_qp = false;
> +	}
> +
> +	/* Set I/O Buffer addresses */
> +	reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0);
> +	ret = e5010_hw_set_input_luma_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input luma address\n");
> +		goto device_busy_err;
> +	}
> +
> +	if (num_planes == 1)
> +		reg += (ctx->out_queue.bytesperline[0]) * (ctx->out_queue.height);
> +	else
> +		reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 1);
> +
> +	dprintk(e5010, 3,
> +		"ctx: 0x%p, luma_addr: 0x%x, chroma_addr: 0x%x, out_addr: 0x%x\n",
> +		ctx, (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0), reg,
> +		(u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0));
> +
> +	dprintk(e5010, 3,
> +		"ctx: 0x%p, buf indices: src_index: %d, dst_index: %d\n",
> +		ctx, s_vb->vb2_buf.index, d_vb->vb2_buf.index);
> +
> +	ret = e5010_hw_set_input_chroma_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input chroma address\n");
> +		goto device_busy_err;
> +	}
> +
> +	reg = (u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0);
> +	reg += HEADER_SIZE;
> +	ret = e5010_hw_set_output_base_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set output size\n");
> +		goto device_busy_err;
> +	}
> +
> +	/* Set input settings */
> +	ret = e5010_hw_set_horizontal_size(e5010->core_base, ctx->out_queue.width - 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_vertical_size(e5010->core_base, ctx->out_queue.height - 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_luma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set luma stride\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_chroma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set chroma stride\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_set_input_subsampling(e5010->core_base, ctx->out_queue.fmt->subsampling);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input subsampling\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_chroma_order(e5010->core_base, ctx->out_queue.fmt->chroma_order);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set chroma order\n");
> +		goto device_busy_err;
> +	}
> +
> +	e5010_hw_set_output_max_size(e5010->core_base, d_vb->planes[0].length);
> +	e5010_hw_encode_start(e5010->core_base, 1);
> +
> +	spin_unlock_irqrestore(&e5010->hw_lock, flags);
> +
> +	return;
> +
> +device_busy_err:
> +	e5010_reset(e5010->dev, e5010->core_base, e5010->mmu_base);
> +
> +no_ready_buf_err:
> +	if (s_vb) {
> +		v4l2_m2m_src_buf_remove_by_buf(ctx->fh.m2m_ctx, s_vb);
> +		v4l2_m2m_buf_done(s_vb, VB2_BUF_STATE_ERROR);
> +	}
> +
> +	if (d_vb) {
> +		v4l2_m2m_dst_buf_remove_by_buf(ctx->fh.m2m_ctx, d_vb);
> +		/* Payload set to 1 since 0 payload can trigger EOS */
> +		vb2_set_plane_payload(&d_vb->vb2_buf, 0, 1);
> +		v4l2_m2m_buf_done(d_vb, VB2_BUF_STATE_ERROR);
> +	}
> +	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
> +	spin_unlock_irqrestore(&e5010->hw_lock, flags);
> +}
> +
> +#ifdef CONFIG_PM
> +static int e5010_runtime_resume(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = clk_prepare_enable(e5010->clk);
> +	if (ret < 0) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable clock\n");
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_runtime_suspend(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +
> +	clk_disable_unprepare(e5010->clk);
> +
> +	return 0;
> +}
> +#endif
> +
> +#ifdef CONFIG_PM_SLEEP
> +static int e5010_suspend(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +
> +	v4l2_m2m_suspend(e5010->m2m_dev);
> +
> +	return pm_runtime_force_suspend(dev);
> +}
> +
> +static int e5010_resume(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = pm_runtime_force_resume(dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	v4l2_m2m_resume(e5010->m2m_dev);
> +
> +	return ret;
> +}
> +#endif
> +
> +static const struct dev_pm_ops	e5010_pm_ops = {
> +	SET_RUNTIME_PM_OPS(e5010_runtime_suspend,
> +			   e5010_runtime_resume, NULL)
> +	SET_SYSTEM_SLEEP_PM_OPS(e5010_suspend, e5010_resume)
> +};
> +
> +static const struct v4l2_ioctl_ops e5010_ioctl_ops = {
> +	.vidioc_querycap = e5010_querycap,
> +
> +	.vidioc_enum_fmt_vid_cap = e5010_enum_fmt,
> +	.vidioc_g_fmt_vid_cap_mplane = e5010_g_fmt,
> +	.vidioc_try_fmt_vid_cap_mplane = e5010_try_fmt,
> +	.vidioc_s_fmt_vid_cap_mplane = e5010_s_fmt,
> +
> +	.vidioc_enum_fmt_vid_out = e5010_enum_fmt,
> +	.vidioc_g_fmt_vid_out_mplane = e5010_g_fmt,
> +	.vidioc_try_fmt_vid_out_mplane = e5010_try_fmt,
> +	.vidioc_s_fmt_vid_out_mplane = e5010_s_fmt,
> +
> +	.vidioc_g_selection = e5010_g_selection,
> +	.vidioc_s_selection = e5010_s_selection,
> +
> +	.vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
> +	.vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
> +	.vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
> +	.vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
> +	.vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
> +	.vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
> +	.vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
> +
> +	.vidioc_streamon = v4l2_m2m_ioctl_streamon,
> +	.vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
> +	.vidioc_log_status = v4l2_ctrl_log_status,
> +
> +	.vidioc_subscribe_event = e5010_subscribe_event,
> +	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> +	.vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
> +	.vidioc_encoder_cmd = e5010_encoder_cmd,
> +
> +	.vidioc_enum_framesizes = e5010_enum_framesizes,
> +};
> +
> +static const struct vb2_ops e5010_video_ops = {
> +	.queue_setup = e5010_queue_setup,
> +	.buf_queue = e5010_buf_queue,
> +	.buf_finish = e5010_buf_finish,
> +	.buf_prepare = e5010_buf_prepare,
> +	.buf_out_validate = e5010_buf_out_validate,
> +	.wait_prepare = vb2_ops_wait_prepare,
> +	.wait_finish = vb2_ops_wait_finish,
> +	.start_streaming = e5010_start_streaming,
> +	.stop_streaming = e5010_stop_streaming,
> +};
> +
> +static const struct v4l2_file_operations e5010_fops = {
> +	.owner = THIS_MODULE,
> +	.open = e5010_open,
> +	.release = e5010_release,
> +	.poll = v4l2_m2m_fop_poll,
> +	.unlocked_ioctl = video_ioctl2,
> +	.mmap = v4l2_m2m_fop_mmap,
> +};
> +
> +static const struct v4l2_m2m_ops e5010_m2m_ops = {
> +	.device_run = e5010_device_run,
> +};
> +
> +static const struct of_device_id e5010_of_match[] = {
> +	{.compatible = "img,e5010-jpeg-enc"},   { /* end */},
> +};
> +MODULE_DEVICE_TABLE(of, e5010_of_match);
> +
> +static struct platform_driver e5010_driver = {
> +	.probe = e5010_probe,
> +	.remove = e5010_remove,
> +	.driver = {
> +		.name = E5010_MODULE_NAME,
> +		.of_match_table = e5010_of_match,
> +		.pm = &e5010_pm_ops,
> +	},
> +};
> +module_platform_driver(e5010_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Imagination E5010 JPEG encoder driver");
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.h b/drivers/media/platform/imagination/e5010-jpeg-enc.h
> new file mode 100644
> index 000000000000..3a47b0327101
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.h
> @@ -0,0 +1,169 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-fh.h>
> +
> +#ifndef _E5010_JPEG_ENC_H
> +#define _E5010_JPEG_ENC_H
> +
> +#define MAX_PLANES			2
> +#define HEADER_SIZE			0x025E
> +#define MIN_DIMENSION			64
> +#define MAX_DIMENSION			8192
> +#define DEFAULT_WIDTH			640
> +#define DEFAULT_HEIGHT			480
> +#define E5010_MODULE_NAME		"e5010"
> +#define JPEG_MAX_BYTES_PER_PIXEL	2
> +
> +/* JPEG marker definitions */
> +#define START_OF_IMAGE			0xFFD8
> +#define SOF_BASELINE_DCT		0xFFC0
> +#define END_OF_IMAGE			0xFFD9
> +#define START_OF_SCAN			0xFFDA
> +
> +/* Definitions for the huffman table specification in the Marker segment */
> +#define DHT_MARKER			0xFFC4
> +#define LH_DC				0x001F
> +#define LH_AC				0x00B5
> +
> +/* Definitions for the quantization table specification in the Marker segment */
> +#define DQT_MARKER			0xFFDB
> +#define ACMAX				0x03FF
> +#define DCMAX				0x07FF
> +
> +/* Length and precision of the quantization table parameters */
> +#define LQPQ				0x00430
> +#define QMAX				255
> +
> +/* Misc JPEG header definitions */
> +#define UC_NUM_COMP			3
> +#define PRECISION			8
> +#define HORZ_SAMPLING_FACTOR		(2 << 4)
> +#define VERT_SAMPLING_FACTOR_422	1
> +#define VERT_SAMPLING_FACTOR_420	2
> +#define COMPONENTS_IN_SCAN		3
> +#define PELS_IN_BLOCK			64
> +
> +/* Used for Qp table generation */
> +#define LUMINOSITY			10
> +#define CONTRAST			1
> +#define INCREASE			2
> +#define QP_TABLE_SIZE			(8 * 8)
> +#define QP_TABLE_FIELD_OFFSET		0x04
> +
> +/*
> + * vb2 queue structure
> + * contains queue data information
> + *
> + * @fmt: format info
> + * @width: frame width
> + * @height: frame height
> + * @bytesperline: bytes per line in memory
> + * @size_image: image size in memory
> + */
> +struct e5010_q_data {
> +	struct e5010_fmt	*fmt;
> +	u32			width;
> +	u32			height;
> +	u32			width_adjusted;
> +	u32			height_adjusted;
> +	u32			sizeimage[MAX_PLANES];
> +	u32			bytesperline[MAX_PLANES];
> +	bool			format_set;
> +	bool			streaming;
> +	u32			sequence;
> +	struct v4l2_rect	crop;
> +};
> +
> +/*
> + * Driver device structure
> + * Holds all memory handles and global parameters
> + * Shared by all instances
> + */
> +struct e5010_dev {
> +	struct device *dev;
> +	struct v4l2_device	v4l2_dev;
> +	struct v4l2_m2m_dev	*m2m_dev;
> +	struct video_device	*vdev;
> +	void __iomem		*core_base;
> +	void __iomem		*mmu_base;
> +	struct clk		*clk;
> +	struct e5010_context	*last_context_run;
> +	/* Protect access to device data */
> +	struct mutex		mutex;
> +	/* Protect access to hardware*/
> +	spinlock_t		hw_lock;
> +};
> +
> +/*
> + * Driver context structure
> + * One of these exists for every m2m context
> + * Holds context specific data
> + */
> +struct e5010_context {
> +	struct v4l2_fh			fh;
> +	struct e5010_dev		*e5010;
> +	struct e5010_q_data		out_queue;
> +	struct e5010_q_data		cap_queue;
> +	int				quality;
> +	bool				update_qp;
> +	struct v4l2_ctrl_handler	ctrl_handler;
> +	u8				luma_qp[QP_TABLE_SIZE];
> +	u8				chroma_qp[QP_TABLE_SIZE];
> +};
> +
> +/*
> + * Buffer structure
> + * Contains info for all buffers
> + */
> +struct e5010_buffer {
> +	struct v4l2_m2m_buffer buffer;
> +};
> +
> +enum {
> +	CHROMA_ORDER_CB_CR = 0, //UV ordering
> +	CHROMA_ORDER_CR_CB = 1, //VU ordering
> +};
> +
> +enum {
> +	SUBSAMPLING_420 = 1,
> +	SUBSAMPLING_422 = 2,
> +};
> +
> +/*
> + * e5010 format structure
> + * contains format information
> + */
> +struct e5010_fmt {
> +	u32					fourcc;
> +	unsigned int				num_planes;
> +	unsigned int				type;
> +	u32					subsampling;
> +	u32					chroma_order;
> +	const struct v4l2_frmsize_stepwise	frmsize;
> +};
> +
> +/*
> + * struct e5010_ctrl - contains info for each supported v4l2 control
> + */
> +struct e5010_ctrl {
> +	unsigned int		cid;
> +	enum v4l2_ctrl_type	type;
> +	unsigned char		name[32];
> +	int			minimum;
> +	int			maximum;
> +	int			step;
> +	int			default_value;
> +	unsigned char		compound;
> +};
> +
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-mmu-regs.h b/drivers/media/platform/imagination/e5010-mmu-regs.h
> new file mode 100644
> index 000000000000..bfba06956cf2
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-mmu-regs.h
> @@ -0,0 +1,311 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_MMU_REGS_H
> +#define _E5010_MMU_REGS_H
> +
> +#define MMU_MMU_DIR_BASE_ADDR_OFFSET					(0x0020)
> +#define MMU_MMU_DIR_BASE_ADDR_STRIDE					(4)
> +#define MMU_MMU_DIR_BASE_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_TILE_CFG_OFFSET						(0x0040)
> +#define MMU_MMU_TILE_CFG_STRIDE						(4)
> +#define MMU_MMU_TILE_CFG_NO_ENTRIES					(4)
> +
> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_MASK			(0x00000010)
> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_SHIFT			(4)
> +
> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_MASK				(0x00000008)
> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_SHIFT				(3)
> +
> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_MASK				(0x00000007)
> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_SHIFT				(0)
> +
> +#define MMU_MMU_TILE_MIN_ADDR_OFFSET					(0x0050)
> +#define MMU_MMU_TILE_MIN_ADDR_STRIDE					(4)
> +#define MMU_MMU_TILE_MIN_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_TILE_MAX_ADDR_OFFSET					(0x0060)
> +#define MMU_MMU_TILE_MAX_ADDR_STRIDE					(4)
> +#define MMU_MMU_TILE_MAX_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_CONTROL0_OFFSET						(0x0000)
> +
> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_MASK				(0x00000001)
> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_SHIFT			(0)
> +
> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_MASK				(0x00000100)
> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_SHIFT				(8)
> +
> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_MASK			(0x00000200)
> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_SHIFT		(9)
> +
> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_MASK			(0x00001000)
> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_SHIFT			(12)
> +
> +#define MMU_MMU_CONTROL1_OFFSET						(0x0008)
> +
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_MASK					(0x00000008)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SHIFT				(3)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_NO_REPS				(4)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SIZE					(1)
> +
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_MASK				(0x00000800)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SHIFT				(11)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_NO_REPS				(4)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SIZE				(1)
> +
> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_MASK				(0x00010000)
> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_SHIFT				(16)
> +
> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_MASK			(0x00100000)
> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_SHIFT			(20)
> +
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_MASK				(0x01000000)
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_SHIFT				(24)
> +
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_MASK				(0x02000000)
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_SHIFT				(25)
> +
> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK				(0x10000000)
> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT				(28)
> +
> +#define MMU_MMU_BANK_INDEX_OFFSET					(0x0010)
> +
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_MASK				(0xC0000000)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SHIFT				(30)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_NO_REPS			(16)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SIZE				(2)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_OFFSET				(0x0018)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_MASK		(0x00008000)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SHIFT		(15)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_NO_REPS		(16)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SIZE		(1)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_MASK	(0x00010000)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_SHIFT	(16)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_OFFSET				(0x001C)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_MASK		(0x000003FF)
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_SHIFT		(0)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_MASK			(0x0FFF0000)
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_SHIFT		(16)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_OFFSET					(0x0070)
> +#define MMU_MMU_ADDRESS_CONTROL_TRUSTED					(IMG_TRUE)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK				(0x00000001)
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT			(0)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_MASK		(0x00000010)
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_SHIFT		(4)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_MASK		(0x00FF0000)
> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_SHIFT		(16)
> +
> +#define MMU_MMU_CONFIG0_OFFSET						(0x0080)
> +
> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_MASK				(0x0000000F)
> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_SHIFT				(0)
> +
> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_MASK			(0x000000F0)
> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_SHIFT			(4)
> +
> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_MASK			(0x00000700)
> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_SHIFT			(8)
> +
> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_MASK			(0x00001000)
> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_SHIFT			(12)
> +
> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_MASK				(0x00002000)
> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_SHIFT				(13)
> +
> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_MASK			(0x001F0000)
> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_SHIFT			(16)
> +
> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_MASK				(0x00200000)
> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_SHIFT				(21)
> +
> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_MASK				(0xFFC00000)
> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_SHIFT				(22)
> +
> +#define MMU_MMU_CONFIG1_OFFSET						(0x0084)
> +
> +#define MMU_MMU_CONFIG1_PAGE_SIZE_MASK					(0x0000000F)
> +#define MMU_MMU_CONFIG1_PAGE_SIZE_SHIFT					(0)
> +
> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_MASK				(0x0000FF00)
> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_SHIFT			(8)
> +
> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_MASK				(0x001F0000)
> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_SHIFT				(16)
> +
> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_MASK			(0x01000000)
> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_SHIFT			(24)
> +
> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_MASK			(0x02000000)
> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_SHIFT			(25)
> +
> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_MASK			(0x04000000)
> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_SHIFT			(26)
> +
> +#define MMU_MMU_STATUS0_OFFSET						(0x0088)
> +
> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_MASK				(0x00000001)
> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_SHIFT				(0)
> +
> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_MASK				(0xFFFFF000)
> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_SHIFT				(12)
> +
> +#define MMU_MMU_STATUS1_OFFSET						(0x008C)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_MASK				(0x0000FFFF)
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_SHIFT			(0)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_MASK				(0x000F0000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_SHIFT				(16)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_MASK				(0x03000000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_SHIFT				(24)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_MASK				(0x10000000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_SHIFT				(28)
> +
> +#define MMU_MMU_MEM_REQ_OFFSET						(0x0090)
> +
> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_MASK				(0x000003FF)
> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_SHIFT				(0)
> +
> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_MASK				(0x00001000)
> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_SHIFT				(12)
> +
> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_MASK				(0x00002000)
> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_SHIFT				(13)
> +
> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_MASK			(0x00004000)
> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_SHIFT			(14)
> +
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_MASK				(0x80000000)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SHIFT			(31)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_NO_REPS			(16)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SIZE				(1)
> +
> +#define MMU_MMU_FAULT_SELECT_OFFSET					(0x00A0)
> +
> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_MASK			(0x0000000F)
> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_SHIFT			(0)
> +
> +#define MMU_PROTOCOL_FAULT_OFFSET					(0x00A8)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_MASK			(0x00000001)
> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_SHIFT			(0)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_MASK				(0x00000010)
> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_SHIFT				(4)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_READ_MASK				(0x00000020)
> +#define MMU_PROTOCOL_FAULT_FAULT_READ_SHIFT				(5)
> +
> +#define MMU_TOTAL_READ_REQ_OFFSET					(0x0100)
> +
> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_MASK				(0xFFFFFFFF)
> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_SHIFT				(0)
> +
> +#define MMU_TOTAL_WRITE_REQ_OFFSET					(0x0104)
> +
> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_SHIFT			(0)
> +
> +#define MMU_READS_LESS_64_REQ_OFFSET					(0x0108)
> +
> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_SHIFT			(0)
> +
> +#define MMU_WRITES_LESS_64_REQ_OFFSET					(0x010C)
> +
> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_SHIFT			(0)
> +
> +#define MMU_EXT_CMD_STALL_OFFSET					(0x0120)
> +
> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_SHIFT				(0)
> +
> +#define MMU_WRITE_REQ_STALL_OFFSET					(0x0124)
> +
> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_MASK			(0xFFFFFFFF)
> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_SHIFT			(0)
> +
> +#define MMU_MMU_MISS_STALL_OFFSET					(0x0128)
> +
> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_SHIFT				(0)
> +
> +#define MMU_ADDRESS_STALL_OFFSET					(0x012C)
> +
> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_SHIFT				(0)
> +
> +#define MMU_TAG_STALL_OFFSET						(0x0130)
> +
> +#define MMU_TAG_STALL_TAG_STALL_MASK					(0xFFFFFFFF)
> +#define MMU_TAG_STALL_TAG_STALL_SHIFT					(0)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_OFFSET				(0x0140)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_MASK		(0x000003FF)
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_SHIFT		(0)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_MASK		(0xFFFF0000)
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_SHIFT		(16)
> +
> +#define MMU_AVERAGE_READ_LATENCY_OFFSET					(0x0144)
> +
> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_MASK		(0xFFFFFFFF)
> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_SHIFT		(0)
> +
> +#define MMU_STATISTICS_CONTROL_OFFSET					(0x0160)
> +
> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_MASK		(0x00000001)
> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_SHIFT		(0)
> +
> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_MASK			(0x00000002)
> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_SHIFT			(1)
> +
> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_MASK			(0x00000004)
> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_SHIFT			(2)
> +
> +#define MMU_MMU_VERSION_OFFSET						(0x01D0)
> +
> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_MASK				(0x00FF0000)
> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_SHIFT				(16)
> +
> +#define MMU_MMU_VERSION_MMU_MINOR_REV_MASK				(0x0000FF00)
> +#define MMU_MMU_VERSION_MMU_MINOR_REV_SHIFT				(8)
> +
> +#define MMU_MMU_VERSION_MMU_MAINT_REV_MASK				(0x000000FF)
> +#define MMU_MMU_VERSION_MMU_MAINT_REV_SHIFT				(0)
> +
> +#define MMU_BYTE_SIZE							(0x01D4)
> +
> +#endif


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/4] media: imagination: Add E5010 JPEG Encoder driver
  2023-08-22 10:27   ` Andrzej Pietrasiewicz
@ 2023-08-31 13:24     ` Devarsh Thakkar
  0 siblings, 0 replies; 11+ messages in thread
From: Devarsh Thakkar @ 2023-08-31 13:24 UTC (permalink / raw)
  To: Andrzej Pietrasiewicz, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, hverkuil-cisco, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

Hi Andrzej,

Thanks for the review.

On 22/08/23 15:57, Andrzej Pietrasiewicz wrote:
> Hi Devarsh,
> 
> W dniu 16.08.2023 o 17:22, Devarsh Thakkar pisze:
>> This adds support for stateful V4L2 M2M based driver
>> for Imagination E5010 JPEG Encoder [1] which supports baseline
>> encoding with two different quantization tables and compression
>> ratio as demanded.
>>
>> Support for both contiguous and non-contiguous YUV420 and YUV422
>> semiplanar formats is added along with alignment restrictions
>> as required by the hardware.
>>
>> System and runtime PM hooks are added in the driver along with v4l2
>> crop and selection API support.
>>
>> Minimum resolution supported is 64x64 and
>> Maximum resolution supported is 8192x8192.
>>
>> All v4l2-compliance tests are passing [2] :
>> v4l2-compliance -s -f -a  -d /dev/video0 -e /dev/video1
>>
>> Total for e5010 device /dev/video0: 70, Succeeded: 70, Failed: 0,
>> Warnings: 0
>> NOTE: video1 here is VIVID test pattern generator
>>
>> Also tests [3] were run manually to verify below driver features:
>>   - Runtime Power Management
>>   - Multi-instance JPEG Encoding
>>   - DMABUF import, export support
>>   - NV12, NV21, NV16, NV61 video format support
>>   - Compression quality S_CTRL
>>
>> Existing V4L2 M2M based JPEG drivers namely s5p-jpeg,
>> imx-jpeg and rcar_jpu were referred while making this.
>>
>> TODO:
>> Add MMU and memory tiling support
>>
>> [1]:  AM62A TRM (Section 7.6 is for JPEG Encoder)
>> Link: https://www.ti.com/lit/pdf/spruj16
>>
>> [2]: v4l2-compliance test :
>> Link: https://gist.github.com/devarsht/17348fc509fe375a630a798196edbb73
>>
>> [3]: E5010 JPEG Encoder Manual tests :
>>
>> Performance:
>> Link: https://gist.github.com/devarsht/ef5aba211aae45166681b8b4418d4e65
>>
>> Functionality:
>> Link: https://gist.github.com/devarsht/bfef1e3ead8e858b09cbf418aea753e8
>>
>> Compression Quality:
>> Link: https://gist.github.com/devarsht/345df9bf7157b4ca094293760e257451
>>
>> Multi Instance:
>> Link: https://gist.github.com/devarsht/4b4d734eeb9e0e616837c0836ddbc769
>>
>> Co-developed-by: David Huang <d-huang@ti.com>
>> Signed-off-by: David Huang <d-huang@ti.com>
>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
>> ---
>> V2:
>> No change
>>
>> V3:
>> - Correct license headers
>> - Use more generic name core instead of jasper for base registers
>> - Add Comment for forward declarations
>> - Simplify quantization table calculations
>> - Use v4l2_apply_frmsize_constraints for updating framesize and remove
>> unrequired functions
>> - Place TODO at top of file and in commit message too
>> - Use dev_err_probe helper in probe function
>> - Fix return value checking for failure scenarios in probe function
>> - Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
>> - Fix unexpected indentation
>> - Correct commit message
>> - Remove dependency on ARCH_K3 as driver is not specific to that
>>
>>   MAINTAINERS                                   |    2 +
>>   drivers/media/platform/Kconfig                |    1 +
>>   drivers/media/platform/Makefile               |    1 +
>>   drivers/media/platform/imagination/Kconfig    |   12 +
>>   drivers/media/platform/imagination/Makefile   |    3 +
>>   .../platform/imagination/e5010-core-regs.h    |  585 ++++++
>>   .../platform/imagination/e5010-jpeg-enc-hw.c  |  320 ++++
>>   .../platform/imagination/e5010-jpeg-enc-hw.h  |   42 +
>>   .../platform/imagination/e5010-jpeg-enc.c     | 1678 +++++++++++++++++
>>   .../platform/imagination/e5010-jpeg-enc.h     |  169 ++
>>   .../platform/imagination/e5010-mmu-regs.h     |  311 +++
>>   11 files changed, 3124 insertions(+)
>>   create mode 100644 drivers/media/platform/imagination/Kconfig
>>   create mode 100644 drivers/media/platform/imagination/Makefile
>>   create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
>>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
>>   create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
>>   create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9425ecf45df6..725a280a521b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -10208,8 +10208,10 @@ F:    drivers/auxdisplay/img-ascii-lcd.c
>>     IMGTEC JPEG ENCODER DRIVER
>>   M:    Devarsh Thakkar <devarsht@ti.com>
>> +L:    linux-media@vger.kernel.org
>>   S:    Supported
>>   F:    Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>> +F:    drivers/media/platform/imagination/e5010*
>>     IMGTEC IR DECODER DRIVER
>>   S:    Orphan
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index ee579916f874..72b4bedd47fb 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -69,6 +69,7 @@ source "drivers/media/platform/aspeed/Kconfig"
>>   source "drivers/media/platform/atmel/Kconfig"
>>   source "drivers/media/platform/cadence/Kconfig"
>>   source "drivers/media/platform/chips-media/Kconfig"
>> +source "drivers/media/platform/imagination/Kconfig"
>>   source "drivers/media/platform/intel/Kconfig"
>>   source "drivers/media/platform/marvell/Kconfig"
>>   source "drivers/media/platform/mediatek/Kconfig"
>> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
>> index 5453bb868e67..96db57cc9412 100644
>> --- a/drivers/media/platform/Makefile
>> +++ b/drivers/media/platform/Makefile
>> @@ -12,6 +12,7 @@ obj-y += aspeed/
>>   obj-y += atmel/
>>   obj-y += cadence/
>>   obj-y += chips-media/
>> +obj-y += imagination/
>>   obj-y += intel/
>>   obj-y += marvell/
>>   obj-y += mediatek/
>> diff --git a/drivers/media/platform/imagination/Kconfig
>> b/drivers/media/platform/imagination/Kconfig
>> new file mode 100644
>> index 000000000000..d8d79266ad5d
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/Kconfig
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +config VIDEO_E5010_JPEG_ENC
>> +    tristate "Imagination E5010 JPEG Encoder Driver"
>> +    depends on VIDEO_DEV
>> +    select VIDEOBUF2_DMA_CONTIG
>> +    select VIDEOBUF2_VMALLOC
>> +    select V4L2_MEM2MEM_DEV
>> +    help
>> +      This is a video4linux2 M2M driver for Imagination E5010 JPEG encoder,
>> +      which supports JPEG and MJPEG baseline encoding of YUV422 and YUV420
>> +      semiplanar video formats, with resolution ranging from 64x64 to 8K x 8K
>> +      pixels. The module will be named as e5010_jpeg_enc.
>> diff --git a/drivers/media/platform/imagination/Makefile
>> b/drivers/media/platform/imagination/Makefile
>> new file mode 100644
>> index 000000000000..d45b85b88575
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/Makefile
>> @@ -0,0 +1,3 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +e5010_jpeg_enc-objs := e5010-jpeg-enc-hw.o e5010-jpeg-enc.o
>> +obj-$(CONFIG_VIDEO_E5010_JPEG_ENC) += e5010_jpeg_enc.o
>> diff --git a/drivers/media/platform/imagination/e5010-core-regs.h
>> b/drivers/media/platform/imagination/e5010-core-regs.h
>> new file mode 100644
>> index 000000000000..aaec498fe83f
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-core-regs.h
>> @@ -0,0 +1,585 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#ifndef _E5010_CORE_REGS_H
>> +#define _E5010_CORE_REGS_H
>> +
>> +#define JASPER_CORE_ID_OFFSET                (0x0000)
>> +#define JASPER_CORE_ID_CR_GROUP_ID_MASK            (0xFF000000)
>> +#define JASPER_CORE_ID_CR_GROUP_ID_SHIFT        (24)
>> +#define JASPER_CORE_ID_CR_CORE_ID_MASK            (0x00FF0000)
>> +#define JASPER_CORE_ID_CR_CORE_ID_SHIFT            (16)
>> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_MASK        (0x0000FFF8)
>> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_SHIFT        (3)
>> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_MASK        (0x00000007)
>> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_SHIFT        (0)
>> +
>> +#define JASPER_CORE_REV_OFFSET                (0x0004)
>> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_MASK        (0xFF000000)
>> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_SHIFT    (24)
>> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_MASK    (0x00FF0000)
>> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_SHIFT    (16)
>> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_MASK    (0x0000FF00)
>> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_SHIFT    (8)
>> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_MASK    (0x000000FF)
>> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_SHIFT    (0)
>> +
>> +#define JASPER_INTERRUPT_MASK_OFFSET                    (0x0008)
>> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK   
>> (0x00000002)
>> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT    (1)
>> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK        (0x00000001)
>> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT        (0)
>> +
>> +#define JASPER_INTERRUPT_STATUS_OFFSET                    (0x000C)
>> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK   
>> (0x00000002)
>> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_SHIFT    (1)
>> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK        (0x00000001)
>> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_SHIFT        (0)
>> +
>> +#define JASPER_INTERRUPT_CLEAR_OFFSET                    (0x0010)
>> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK        (0x00000002)
>> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT        (1)
>> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK        (0x00000001)
>> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT        (0)
>> +
>> +#define JASPER_CLK_CONTROL_OFFSET                (0x0014)
>> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK    (0x00000002)
>> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT    (1)
>> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK    (0x00000001)
>> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT    (0)
>> +
>> +#define JASPER_CLK_STATUS_OFFSET            (0x0018)
>> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_MASK    (0x00000001)
>> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_SHIFT    (0)
>> +
>> +#define JASPER_RESET_OFFSET            (0x001C)
>> +#define JASPER_RESET_CR_SYS_RESET_MASK        (0x00000002)
>> +#define JASPER_RESET_CR_SYS_RESET_SHIFT        (1)
>> +#define JASPER_RESET_CR_CORE_RESET_MASK        (0x00000001)
>> +#define JASPER_RESET_CR_CORE_RESET_SHIFT    (0)
>> +
>> +#define JASPER_CORE_CTRL_OFFSET                (0x0020)
>> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK    (0x00000001)
>> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT    (0)
>> +
>> +#define JASPER_STATUS_OFFSET                (0x0024)
>> +#define JASPER_STATUS_CR_FLUSH_MODE_MASK        (0x00000002)
>> +#define JASPER_STATUS_CR_FLUSH_MODE_SHIFT        (1)
>> +#define JASPER_STATUS_CR_JASPER_BUSY_MASK        (0x00000001)
>> +#define JASPER_STATUS_CR_JASPER_BUSY_SHIFT        (0)
>> +
>> +#define JASPER_CRC_CLEAR_OFFSET                    (0x0028)
>> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_MASK        (0x00000001)
>> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_SHIFT        (0)
>> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_MASK            (0x00000002)
>> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_SHIFT            (1)
>> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_MASK            (0x00000004)
>> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_SHIFT            (2)
>> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_MASK        (0x00000008)
>> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_SHIFT        (3)
>> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_MASK    (0x00000010)
>> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_SHIFT    (4)
>> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_MASK    (0x00000020)
>> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_SHIFT    (5)
>> +
>> +#define JASPER_INPUT_CTRL0_OFFSET            (0x002C)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK    (0x01000000)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT    (24)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK    (0x00030000)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT    (16)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK        (0x00000004)
>> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT    (2)
>> +
>> +#define JASPER_INPUT_CTRL1_OFFSET            (0x0030)
>> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK    (0x1FC00000)
>> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT    (22)
>> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK    (0x00001FC0)
>> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT    (6)
>> +
>> +#define JASPER_MMU_CTRL_OFFSET                (0x0034)
>> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_MASK    (0x00000002)
>> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_SHIFT    (1)
>> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_MASK    (0x00000001)
>> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_SHIFT    (0)
>> +
>> +#define JASPER_IMAGE_SIZE_OFFSET                (0x0038)
>> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK        (0x1FFF0000)
>> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT        (16)
>> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK        (0x00001FFF)
>> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT    (0)
>> +
>> +#define INPUT_LUMA_BASE_OFFSET                (0x003C)
>> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK        (0xFFFFFFC0)
>> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_SHIFT    (6)
>> +
>> +#define INPUT_CHROMA_BASE_OFFSET            (0x0040)
>> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK    (0xFFFFFFC0)
>> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_SHIFT    (6)
>> +
>> +#define JASPER_OUTPUT_BASE_OFFSET        (0x0044)
>> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK    (0xFFFFFFFF)
>> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT    (0)
>> +
>> +#define JASPER_OUTPUT_SIZE_OFFSET            (0x0048)
>> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_MASK        (0xFFFFFFFF)
>> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_SHIFT        (0)
>> +#define JASPER_OUTPUT_MAX_SIZE_OFFSET            (0x004C)
>> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK    (0xFFFFFFFF)
>> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET                    (0x0050)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_SHIFT    (16)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_SHIFT    (0)
>> +#define JASPER_LUMA_QUANTIZATION_TABLE1_OFFSET                    (0x0054)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_SHIFT    (16)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_SHIFT    (0)
>> +#define JASPER_LUMA_QUANTIZATION_TABLE2_OFFSET                    (0x0058)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_SHIFT    (16)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_SHIFT    (0)
>> +#define JASPER_LUMA_QUANTIZATION_TABLE3_OFFSET                    (0x005C)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_SHIFT    (16)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_SHIFT    (0)
>> +#define JASPER_LUMA_QUANTIZATION_TABLE4_OFFSET                    (0x0060)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE5_OFFSET                    (0x0064)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_SHIFT    (16)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE6_OFFSET                    (0x0068)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_SHIFT    (8)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE7_OFFSET                    (0x006C)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE8_OFFSET                    (0x0070)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_SHIFT    (24)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE9_OFFSET                    (0x0074)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE10_OFFSET                    (0x0078)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE11_OFFSET                    (0x007C)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE12_OFFSET                    (0x0080)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE13_OFFSET                    (0x0084)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE14_OFFSET                    (0x0088)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_SHIFT    (0)
>> +
>> +#define JASPER_LUMA_QUANTIZATION_TABLE15_OFFSET                    (0x008C)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_MASK   
>> (0xFF000000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_SHIFT    (24)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_MASK   
>> (0x00FF0000)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_SHIFT    (16)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_MASK   
>> (0x0000FF00)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_SHIFT    (8)
>> +
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_MASK   
>> (0x000000FF)
>> +#define
>> JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET                (0x0090)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_OFFSET                    (0x0094)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_OFFSET                    (0x0098)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_OFFSET                    (0x009C)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_OFFSET                    (0x00A0)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_OFFSET                    (0x00A4)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_OFFSET                    (0x00A8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_OFFSET                    (0x00AC)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_OFFSET                    (0x00B0)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_OFFSET                    (0x00B4)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_SHIFT        (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_SHIFT        (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_SHIFT        (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_SHIFT        (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_OFFSET                    (0x00B8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_OFFSET                    (0x00BC)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_OFFSET                    (0x00C0)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_OFFSET                    (0x00C4)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_OFFSET                    (0x00C8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_SHIFT    (0)
>> +
>> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_OFFSET                    (0x00CC)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_MASK        (0xFF000000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_SHIFT   
>> (24)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_MASK        (0x00FF0000)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_SHIFT   
>> (16)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_MASK        (0x0000FF00)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_SHIFT    (8)
>> +
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_MASK        (0x000000FF)
>> +#define
>> JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_SHIFT    (0)
>> +
>> +#define JASPER_CRC_CTRL_OFFSET                (0x00D0)
>> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK        (0x00000001)
>> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT        (0)
>> +
>> +#define JASPER_FRONT_END_CRC_OFFSET                (0x00D4)
>> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_MASK    (0xFFFFFFFF)
>> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_SHIFT    (0)
>> +
>> +#define JASPER_DCT_CRC_OFFSET                (0x00D8)
>> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_MASK    (0xFFFFFFFF)
>> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_SHIFT    (0)
>> +
>> +#define JASPER_ZZ_CRC_OFFSET                (0x00DC)
>> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_MASK        (0xFFFFFFFF)
>> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_SHIFT    (0)
>> +
>> +#define JASPER_QUANT_CRC_OFFSET                (0x00E0)
>> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_MASK    (0xFFFFFFFF)
>> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_SHIFT    (0)
>> +
>> +#define JASPER_ENTROPY_ENCODER_CRC_OFFSET                (0x00E4)
>> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_MASK   
>> (0xFFFFFFFF)
>> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_SHIFT    (0)
>> +
>> +#define JASPER_PACKING_BUFFER_DATA_CRC_OFFSET                        (0x00E8)
>> +#define
>> JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_MASK       
>> (0xFFFFFFFF)
>> +#define
>> JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_SHIFT        (0)
>> +
>> +#define JASPER_PACKING_BUFFER_ADDR_CRC_OFFSET                        (0x00EC)
>> +#define
>> JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_MASK       
>> (0xFFFFFFFF)
>> +#define
>> JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_SHIFT        (0)
>> +
>> +#define JASPER_CORE_BYTE_SIZE    (0x00F0)
>> +
>> +#endif
>> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>> b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>> new file mode 100644
>> index 000000000000..237339789407
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>> @@ -0,0 +1,320 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#include <linux/io.h>
>> +#include <linux/iopoll.h>
>> +#include <linux/dev_printk.h>
>> +#include "e5010-jpeg-enc-hw.h"
>> +
>> +static void write_reg_field(void __iomem *base, unsigned int offset, u32 mask,
>> +                unsigned int shift, u32 value)
>> +{
>> +    u32 reg;
>> +
>> +    value <<= shift;
>> +    if (mask != 0xffffffff) {
>> +        reg = readl(base + offset);
>> +        value = (value & mask) | (reg & ~mask);
>> +    }
>> +    writel(value, (base + offset));
>> +}
>> +
>> +static int write_reg_field_not_busy(void __iomem *jasper_base, void __iomem
>> *wr_base,
>> +                    unsigned int offset, u32 mask, unsigned int shift,
>> +                    u32 value)
>> +{
>> +    int ret;
>> +    u32 val;
>> +
>> +    ret = readl_poll_timeout_atomic(jasper_base + JASPER_STATUS_OFFSET, val,
>> +                    (val & JASPER_STATUS_CR_JASPER_BUSY_MASK) == 0,
>> +                    2000, 50000);
>> +    if (ret)
>> +        return ret;
>> +
>> +    write_reg_field(wr_base, offset, mask, shift, value);
>> +
>> +    return 0;
>> +}
>> +
>> +void e5010_reset(struct device *dev, void __iomem *core_base, void __iomem
>> *mmu_base)
>> +{
>> +    int ret = 0;
>> +    u32 val;
>> +
>> +    write_reg_field(core_base, JASPER_RESET_OFFSET,
>> +            JASPER_RESET_CR_CORE_RESET_MASK,
>> +            JASPER_RESET_CR_CORE_RESET_SHIFT, 1);
>> +
>> +    write_reg_field(mmu_base, MMU_MMU_CONTROL1_OFFSET,
>> +            MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK,
>> +            MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT, 1);
>> +
>> +    ret = readl_poll_timeout_atomic(mmu_base + MMU_MMU_CONTROL1_OFFSET, val,
>> +                    (val & MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK) == 0,
>> +                    2000, 50000);
>> +    if (ret)
>> +        dev_warn(dev, "MMU soft reset timed out, forcing system soft
>> reset\n");
>> +
>> +    write_reg_field(core_base, JASPER_RESET_OFFSET,
>> +            JASPER_RESET_CR_SYS_RESET_MASK,
>> +            JASPER_RESET_CR_SYS_RESET_SHIFT, 1);
>> +}
>> +
>> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable)
>> +{
>> +    /* Bypass MMU */
>> +    write_reg_field(mmu_base,
>> +            MMU_MMU_ADDRESS_CONTROL_OFFSET,
>> +            MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK,
>> +            MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT,
>> +            enable);
>> +}
>> +
>> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_base, u32
>> enable)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INTERRUPT_MASK_OFFSET,
>> +                      
>> JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK,
>> +                      
>> JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT,
>> +                       enable);
>> +    return ret;
>> +}
>> +
>> +bool e5010_hw_pic_done_irq(void __iomem *core_base)
>> +{
>> +    u32 reg;
>> +    bool pic_done;
>> +
>> +    reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
>> +    pic_done = (reg & JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK) ?
>> true : false;
>> +
>> +    return pic_done;
>> +}
>> +
>> +bool e5010_hw_output_address_irq(void __iomem *core_base)
>> +{
>> +    u32 reg;
>> +    bool output_address_error;
>> +
>> +    reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
>> +    output_address_error = (reg &
>> JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK) ?
>> +                true : false;
>> +
>> +    return output_address_error;
>> +}
>> +
>> +int e5010_hw_enable_picture_done_irq(void __iomem *core_base, u32 enable)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INTERRUPT_MASK_OFFSET,
>> +                       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK,
>> +                       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT,
>> +                       enable);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_base, u32 enable)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_CLK_CONTROL_OFFSET,
>> +                       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK,
>> +                       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT,
>> +                       enable);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_base, u32 enable)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_CLK_CONTROL_OFFSET,
>> +                       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK,
>> +                       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT, 0);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_enable_crc_check(void __iomem *core_base, u32 enable)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_CRC_CTRL_OFFSET,
>> +                       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK,
>> +                       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT, enable);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_input_source_to_memory(void __iomem *core_base, u32 set)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INPUT_CTRL0_OFFSET,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT, set);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_input_luma_addr(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       INPUT_LUMA_BASE_OFFSET,
>> +                       INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK, 0, val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_input_chroma_addr(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       INPUT_CHROMA_BASE_OFFSET,
>> +                       INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK, 0, val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_output_base_addr(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_OUTPUT_BASE_OFFSET,
>> +                       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK,
>> +                       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT, val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_horizontal_size(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_IMAGE_SIZE_OFFSET,
>> +                       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK,
>> +                       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_vertical_size(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_IMAGE_SIZE_OFFSET,
>> +                       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK,
>> +                       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_luma_stride(void __iomem *core_base, u32 bytesperline)
>> +{
>> +    int ret;
>> +    u32 val = bytesperline / 64;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INPUT_CTRL1_OFFSET,
>> +                       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK,
>> +                       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_chroma_stride(void __iomem *core_base, u32 bytesperline)
>> +{
>> +    int ret;
>> +    u32 val = bytesperline / 64;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INPUT_CTRL1_OFFSET,
>> +                       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK,
>> +                       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_input_subsampling(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INPUT_CTRL0_OFFSET,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +int e5010_hw_set_chroma_order(void __iomem *core_base, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base,
>> +                       JASPER_INPUT_CTRL0_OFFSET,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK,
>> +                       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT,
>> +                       val);
>> +    return ret;
>> +}
>> +
>> +void e5010_hw_set_output_max_size(void __iomem *core_base, u32 val)
>> +{
>> +    write_reg_field(core_base, JASPER_OUTPUT_MAX_SIZE_OFFSET,
>> +            JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK,
>> +            JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT,
>> +            val);
>> +}
>> +
>> +int e5010_hw_set_qpvalue(void __iomem *core_base, u32 offset, u32 val)
>> +{
>> +    int ret;
>> +
>> +    ret = write_reg_field_not_busy(core_base, core_base, offset,
>> 0xffffffff, 0, val);
>> +    return ret;
>> +}
>> +
>> +void e5010_hw_clear_output_error(void __iomem *core_base, u32 clear)
>> +{
>> +    /* Make sure interrupts are clear */
>> +    write_reg_field(core_base, JASPER_INTERRUPT_CLEAR_OFFSET,
>> +            JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK,
>> +            JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT, clear);
>> +}
>> +
>> +void e5010_hw_clear_picture_done(void __iomem *core_base, u32 clear)
>> +{
>> +    write_reg_field(core_base,
>> +            JASPER_INTERRUPT_CLEAR_OFFSET,
>> +            JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK,
>> +            JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT, clear);
>> +}
>> +
>> +int e5010_hw_get_output_size(void __iomem *core_base)
>> +{
>> +    return readl(core_base + JASPER_OUTPUT_SIZE_OFFSET);
>> +}
>> +
>> +void e5010_hw_encode_start(void __iomem *core_base, u32 start)
>> +{
>> +    write_reg_field(core_base, JASPER_CORE_CTRL_OFFSET,
>> +            JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK,
>> +            JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT, start);
>> +}
>> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>> b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>> new file mode 100644
>> index 000000000000..781d353c3226
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>> @@ -0,0 +1,42 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#ifndef _E5010_JPEG_ENC_HW_H
>> +#define _E5010_JPEG_ENC_HW_H
>> +
>> +#include "e5010-core-regs.h"
>> +#include "e5010-mmu-regs.h"
>> +
>> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_offset, u32
>> enable);
>> +int e5010_hw_enable_picture_done_irq(void __iomem *core_offset, u32 enable);
>> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_offset, u32 enable);
>> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_offset, u32
>> enable);
>> +int e5010_hw_enable_crc_check(void __iomem *core_offset, u32 enable);
>> +int e5010_hw_set_input_source_to_memory(void __iomem *core_offset, u32 set);
>> +int e5010_hw_set_input_luma_addr(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_input_chroma_addr(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_output_base_addr(void __iomem *core_offset, u32 val);
>> +int e5010_hw_get_output_size(void __iomem *core_offset);
>> +int e5010_hw_set_horizontal_size(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_vertical_size(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_luma_stride(void __iomem *core_offset, u32 bytesperline);
>> +int e5010_hw_set_chroma_stride(void __iomem *core_offset, u32 bytesperline);
>> +int e5010_hw_set_input_subsampling(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_chroma_order(void __iomem *core_offset, u32 val);
>> +int e5010_hw_set_qpvalue(void __iomem *core_offset, u32 offset, u32 value);
>> +void e5010_reset(struct device *dev, void __iomem *core_offset, void
>> __iomem *mmu_offset);
>> +void e5010_hw_set_output_max_size(void __iomem *core_offset, u32 val);
>> +void e5010_hw_clear_picture_done(void __iomem *core_offset, u32 clear);
>> +void e5010_hw_encode_start(void __iomem *core_offset, u32 start);
>> +void e5010_hw_clear_output_error(void __iomem *core_offset, u32 clear);
>> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable);
>> +bool e5010_hw_pic_done_irq(void __iomem *core_base);
>> +bool e5010_hw_output_address_irq(void __iomem *core_base);
>> +#endif
>> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c
>> b/drivers/media/platform/imagination/e5010-jpeg-enc.c
>> new file mode 100644
>> index 000000000000..bf40ba9014e1
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
>> @@ -0,0 +1,1678 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * TODO: Add MMU and memory tiling support
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/of_device.h>
>> +#include <linux/ioctl.h>
>> +#include <linux/dma-mapping.h>
>> +#include <linux/err.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/clk.h>
>> +#include <media/v4l2-common.h>
>> +#include <media/v4l2-ctrls.h>
>> +#include <media/v4l2-device.h>
>> +#include <media/v4l2-event.h>
>> +#include <media/v4l2-ioctl.h>
>> +#include <media/v4l2-mem2mem.h>
>> +#include <media/videobuf2-v4l2.h>
>> +#include <media/videobuf2-dma-contig.h>
>> +#include "e5010-jpeg-enc.h"
>> +#include "e5010-jpeg-enc-hw.h"
>> +
>> +/* forward declarations */
>> +static const struct of_device_id e5010_of_match[];
>> +
>> +static const struct v4l2_file_operations e5010_fops;
>> +
>> +static const struct v4l2_ioctl_ops e5010_ioctl_ops;
>> +
>> +static const struct vb2_ops e5010_video_ops;
>> +
>> +static const struct v4l2_m2m_ops e5010_m2m_ops;
>> +
>> +static struct e5010_fmt e5010_formats[] = {
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV12,
>> +        .num_planes = 1,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
>> +        .chroma_order = CHROMA_ORDER_CB_CR,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV12M,
>> +        .num_planes = 2,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
>> +        .chroma_order = CHROMA_ORDER_CB_CR,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV21,
>> +        .num_planes = 1,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
>> +        .chroma_order = CHROMA_ORDER_CR_CB,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV21M,
>> +        .num_planes = 2,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
>> +        .chroma_order = CHROMA_ORDER_CR_CB,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV16,
>> +        .num_planes = 1,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
>> +        .chroma_order = CHROMA_ORDER_CB_CR,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV16M,
>> +        .num_planes = 2,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
>> +        .chroma_order = CHROMA_ORDER_CB_CR,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV61,
>> +        .num_planes = 1,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
>> +        .chroma_order = CHROMA_ORDER_CR_CB,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_NV61M,
>> +        .num_planes = 2,
>> +        .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> +        .subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
>> +        .chroma_order = CHROMA_ORDER_CR_CB,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +    {
>> +        .fourcc = V4L2_PIX_FMT_JPEG,
>> +        .num_planes = 1,
>> +        .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>> +        .subsampling = 0,
>> +        .chroma_order = 0,
>> +        .frmsize = { MIN_DIMENSION, MAX_DIMENSION, 16,
>> +                 MIN_DIMENSION, MAX_DIMENSION, 8 },
>> +    },
>> +};
>> +
>> +/* Luma and chroma qp table to acheive 50% compression quality
>> + * This is as per example in Annex K.1 of IS0/IEC 10918-1:1994(E)
>> + */
>> +static const u8 luma[64] = {
>> +    16, 11, 10, 16, 24, 40, 51, 61,
>> +    12, 12, 14, 19, 26, 58, 60, 55,
>> +    14, 13, 16, 24, 40, 57, 69, 56,
>> +    14, 17, 22, 29, 51, 87, 80, 62,
>> +    18, 22, 37, 56, 68, 109, 103, 77,
>> +    24, 35, 55, 64, 81, 104, 113, 92,
>> +    49, 64, 78, 87, 103, 121, 120, 101,
>> +    72, 92, 95, 98, 112, 100, 103, 99
>> +};
>> +
>> +static const u8 chroma[64] = {
>> +    17, 18, 24, 47, 99, 99, 99, 99,
>> +    18, 21, 26, 66, 99, 99, 99, 99,
>> +    24, 26, 56, 99, 99, 99, 99, 99,
>> +    47, 66, 99, 99, 99, 99, 99, 99,
>> +    99, 99, 99, 99, 99, 99, 99, 99,
>> +    99, 99, 99, 99, 99, 99, 99, 99,
>> +    99, 99, 99, 99, 99, 99, 99, 99,
>> +    99, 99, 99, 99, 99, 99, 99, 99
>> +};
>> +
>> +/* Zigzag scan pattern */
>> +static const u8 zigzag[64] = {
>> +    0,   1,  8, 16,  9,  2,  3, 10,
>> +    17, 24, 32, 25, 18, 11,  4,  5,
>> +    12, 19, 26, 33, 40, 48, 41, 34,
>> +    27, 20, 13,  6,  7, 14, 21, 28,
>> +    35, 42, 49, 56, 57, 50, 43, 36,
>> +    29, 22, 15, 23, 30, 37, 44, 51,
>> +    58, 59, 52, 45, 38, 31, 39, 46,
>> +    53, 60, 61, 54, 47, 55, 62, 63
>> +};
> 
> These 3 are duplicates of those in
> drivers/media/platform/verisilicon/hantro_jpeg.c
> 
> We should eventually do something about it.
> 

Agreed will move them to include/media/jpeg.h

>> +
>> +/*
>> + * Contains the data that needs to be sent in the marker segment of an
>> interchange format JPEG
>> + * stream or an abbreviated format table specification data stream.
>> + * Specifies the huffman table used for encoding the luminance DC
>> coefficient differences.
>> + * The table represents Table K.3 of IS0/IEC 10918-1:1994(E)
>> + */
>> +static const u8 marker_luma_dc[] = {
>> +    0x00, 0x00, 0x01, 0x05, 0x01, 0x01, 0x01, 0x01, 0x01,
>> +    0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>> +    0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
>> +};
>> +
>> +/*
>> + * Contains the data that needs to be sent in the marker segment of an
>> interchange format JPEG
>> + * stream or an abbreviated format table specification data stream.
>> + * Specifies the huffman table used for encoding the luminance AC
>> coefficients.
>> + * The table represents Table K.5 of IS0/IEC 10918-1:1994(E)
>> + */
>> +static const u8 marker_luma_ac[] = {
>> +    0x10, 0x00, 0x02, 0x01, 0x03, 0x03, 0x02, 0x04, 0x03,
>> +    0x05, 0x05, 0x04, 0x04, 0x00, 0x00, 0x01, 0x7D,
>> +    0x01, 0x02, 0x03, 0x00, 0x04, 0x11, 0x05, 0x12, 0x21, 0x31, 0x41, 0x06,
>> 0x13, 0x51, 0x61,
>> +    0x07, 0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xA1, 0x08, 0x23, 0x42, 0xB1,
>> 0xC1, 0x15, 0x52,
>> +    0xD1, 0xF0, 0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0A, 0x16, 0x17, 0x18,
>> 0x19, 0x1A, 0x25,
>> +    0x26, 0x27, 0x28, 0x29, 0x2A, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A,
>> 0x43, 0x44, 0x45,
>> +    0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59,
>> 0x5A, 0x63, 0x64,
>> +    0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78,
>> 0x79, 0x7A, 0x83,
>> +    0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96,
>> 0x97, 0x98, 0x99,
>> +    0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3,
>> 0xB4, 0xB5, 0xB6,
>> +    0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9,
>> 0xCA, 0xD2, 0xD3,
>> +    0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE1, 0xE2, 0xE3, 0xE4, 0xE5,
>> 0xE6, 0xE7, 0xE8,
>> +    0xE9, 0xEA, 0xF1, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
>> +};
>> +
>> +/*
>> + * Contains the data that needs to be sent in the marker segment of an
>> interchange format JPEG
>> + * stream or an abbreviated format table specification data stream.
>> + * Specifies the huffman table used for encoding the chrominance DC
>> coefficient differences.
>> + * The table represents Table K.4 of IS0/IEC 10918-1:1994(E)
>> + */
>> +static const u8 marker_chroma_dc[] = {
>> +    0x01, 0x00, 0x03, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
>> +    0x01, 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00,
>> +    0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
>> +};
>> +
>> +/*
>> + * Contains the data that needs to be sent in the marker segment of an
>> interchange format JPEG
>> + * stream or an abbreviated format table specification data stream.
>> + * Specifies the huffman table used for encoding the chrominance AC
>> coefficients.
>> + * The table represents Table K.6 of IS0/IEC 10918-1:1994(E)
>> + */
>> +static const u8 marker_chroma_ac[] = {
>> +    0x11, 0x00, 0x02, 0x01, 0x02, 0x04, 0x04, 0x03, 0x04,
>> +    0x07, 0x05, 0x04, 0x04, 0x00, 0x01, 0x02, 0x77,
>> +    0x00, 0x01, 0x02, 0x03, 0x11, 0x04, 0x05, 0x21, 0x31, 0x06, 0x12, 0x41,
>> 0x51, 0x07, 0x61,
>> +    0x71, 0x13, 0x22, 0x32, 0x81, 0x08, 0x14, 0x42, 0x91, 0xA1, 0xB1, 0xC1,
>> 0x09, 0x23, 0x33,
>> +    0x52, 0xF0, 0x15, 0x62, 0x72, 0xD1, 0x0A, 0x16, 0x24, 0x34, 0xE1, 0x25,
>> 0xF1, 0x17, 0x18,
>> +    0x19, 0x1A, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x35, 0x36, 0x37, 0x38, 0x39,
>> 0x3A, 0x43, 0x44,
>> +    0x45, 0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58,
>> 0x59, 0x5A, 0x63,
>> +    0x64, 0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77,
>> 0x78, 0x79, 0x7A,
>> +    0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94,
>> 0x95, 0x96, 0x97,
>> +    0x98, 0x99, 0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA,
>> 0xB2, 0xB3, 0xB4,
>> +    0xB5, 0xB6, 0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7,
>> 0xC8, 0xC9, 0xCA,
>> +    0xD2, 0xD3, 0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE2, 0xE3, 0xE4,
>> 0xE5, 0xE6, 0xE7,
>> +    0xE8, 0xE9, 0xEA, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
>> +};
>> +
> 
> These 4 are suspiciously similar, too, to those find in the verisilicon driver.
> 
> It seems some jpeg helpers library is in order.
> 

Yes I think it should be possible to have a jpeg helpers library or a common
file for preparing jpeg headers and I am open to look into it but would prefer
to track that as a separate patch and not in this series as I want to spend
some time to design it properly.

For now,  I was thinking if I can move all these byte arrays too to
include/media/jpeg.h and update it in V4 and then as a separate patch series
introduce the jpeg encoder helper module which export API to prepare JPEG helpers.

Kindly let me know your opinion.

Regards
Devarsh

>> +static unsigned int debug;
>> +module_param(debug, uint, 0644);
>> +MODULE_PARM_DESC(debug, "debug level");
>> +
>> +#define dprintk(dev, lvl, fmt, arg...) \
>> +    v4l2_dbg(lvl, debug, &(dev)->v4l2_dev, "%s: " fmt, __func__, ## arg)
>> +
>> +static const struct v4l2_event e5010_eos_event = {
>> +    .type = V4L2_EVENT_EOS
>> +};
>> +
>> +static const char *type_name(enum v4l2_buf_type type)
>> +{
>> +    switch (type) {
>> +    case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
>> +        return "Output";
>> +    case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
>> +        return "Capture";
>> +    default:
>> +        return "Invalid";
>> +    }
>> +}
>> +
>> +static struct e5010_q_data *get_queue(struct e5010_context *ctx, enum
>> v4l2_buf_type type)
>> +{
>> +    switch (type) {
>> +    case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
>> +        return &ctx->out_queue;
>> +    case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
>> +        return &ctx->cap_queue;
>> +    default:
>> +        return ERR_PTR(-EINVAL);
>> +    }
>> +
>> +    return ERR_PTR(-EINVAL);
>> +}
>> +
>> +static void calculate_qp_tables(struct e5010_context *ctx)
>> +{
>> +    long long luminosity, contrast;
>> +    int quality, i;
>> +
>> +    quality = 50 - ctx->quality;
>> +
>> +    luminosity = LUMINOSITY * quality / 50;
>> +    contrast = CONTRAST * quality / 50;
>> +
>> +    if (quality > 0) {
>> +        luminosity *= INCREASE;
>> +        contrast *= INCREASE;
>> +    }
>> +
>> +    for (i = 0; i < 64; i++) {
> 
> Is 64 maybe an ARRAY_SIZE() of something relevant?
> 

It's the size of both chroma and luma qp_tables, maybe I can have a macro
QP_TABLE_SIZE instead of using magic numbers.

>> +        long long delta = chroma[i] * contrast + luminosity;
>> +        int val = (int)(chroma[i] + delta);
>> +
>> +        clamp(val, 1, 255);
>> +        ctx->chroma_qp[i] = quality == -50 ? 1 : val;
>> +
>> +        delta = luma[i] * contrast + luminosity;
>> +        val = (int)(luma[i] + delta);
>> +        clamp(val, 1, 255);
>> +        ctx->luma_qp[i] = quality == -50 ? 1 : val;
>> +    }
>> +
>> +    ctx->update_qp = true;
>> +}
>> +
>> +static int update_qp_tables(struct e5010_context *ctx)
>> +{
>> +    struct e5010_dev *e5010 = ctx->e5010;
>> +    int i, ret = 0;
>> +    u32 lvalue, cvalue;
>> +
>> +    lvalue = 0;
>> +    cvalue = 0;
>> +
>> +    for (i = 0; i < QP_TABLE_SIZE; i++) {
>> +        lvalue |= ctx->luma_qp[i] << (8 * (i % 4));
>> +        cvalue |= ctx->chroma_qp[i] << (8 * (i % 4));
>> +        if (i % 4 == 3) {
>> +            ret |= e5010_hw_set_qpvalue(e5010->core_base,
>> +                            JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET
>> +                            + QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
>> +                            lvalue);
>> +            ret |= e5010_hw_set_qpvalue(e5010->core_base,
>> +                            JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET
>> +                            + QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
>> +                            cvalue);
>> +            lvalue = 0;
>> +            cvalue = 0;
>> +        }
>> +    }
>> +
>> +    return ret;
>> +}
>> +
>> +static int e5010_set_input_subsampling(void __iomem *core_base, int
>> subsampling)
>> +{
>> +    switch (subsampling) {
>> +    case V4L2_JPEG_CHROMA_SUBSAMPLING_420:
>> +        return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_420);
>> +    case V4L2_JPEG_CHROMA_SUBSAMPLING_422:
>> +        return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_422);
>> +    default:
>> +        return -EINVAL;
>> +    };
>> +}
>> +
>> +static int e5010_querycap(struct file *file, void *priv, struct
>> v4l2_capability *cap)
>> +{
>> +    strscpy(cap->driver, E5010_MODULE_NAME, sizeof(cap->driver));
>> +    strscpy(cap->card, E5010_MODULE_NAME, sizeof(cap->card));
>> +    snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
>> E5010_MODULE_NAME);
>> +    cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING;
>> +    cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
>> +
>> +    return 0;
>> +}
>> +
>> +static struct e5010_fmt *find_format(struct v4l2_format *f)
>> +{
>> +    int i;
>> +
>> +    for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
>> +        if (e5010_formats[i].fourcc == f->fmt.pix_mp.pixelformat &&
>> +            e5010_formats[i].type == f->type)
>> +            return &e5010_formats[i];
>> +    }
>> +
>> +    return NULL;
>> +}
>> +
>> +static int e5010_enum_fmt(struct file *file, void *priv, struct
>> v4l2_fmtdesc *f)
>> +{
>> +    int i, index = 0;
>> +    struct e5010_fmt *fmt = NULL;
>> +    struct e5010_context *ctx = file->private_data;
>> +
>> +    if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "ENUMFMT with Invalid type: %d\n",
>> f->type);
>> +        return -EINVAL;
>> +    }
>> +
>> +    for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
>> +        if (e5010_formats[i].type == f->type) {
>> +            if (index == f->index) {
>> +                fmt = &e5010_formats[i];
>> +                break;
>> +            }
>> +            index++;
>> +        }
>> +    }
>> +
>> +    if (!fmt)
>> +        return -EINVAL;
>> +
>> +    f->pixelformat = fmt->fourcc;
>> +    return 0;
>> +}
>> +
>> +static int e5010_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +    struct e5010_q_data *queue;
>> +    int i;
>> +    struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
>> +    struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
>> +
>> +    if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n",
>> f->type);
>> +        return -EINVAL;
>> +    }
>> +
>> +    queue = get_queue(ctx, f->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    pix_mp->flags = 0;
>> +    pix_mp->field = V4L2_FIELD_NONE;
>> +    pix_mp->pixelformat = queue->fmt->fourcc;
>> +    pix_mp->width = queue->width_adjusted;
>> +    pix_mp->height = queue->height_adjusted;
>> +    pix_mp->num_planes = queue->fmt->num_planes;
>> +
>> +    if (V4L2_TYPE_IS_OUTPUT(f->type)) {
>> +        if (!pix_mp->colorspace)
>> +            pix_mp->colorspace = V4L2_COLORSPACE_SRGB;
>> +
>> +        for (i = 0; i < queue->fmt->num_planes; i++) {
>> +            plane_fmt[i].sizeimage = queue->sizeimage[i];
>> +            plane_fmt[i].bytesperline = queue->bytesperline[i];
>> +        }
>> +
>> +    } else {
>> +        pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
>> +        plane_fmt[0].bytesperline = 0;
>> +        plane_fmt[0].sizeimage = queue->sizeimage[0];
>> +    }
>> +    pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
>> +    pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
>> +    pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_jpeg_try_fmt(struct v4l2_format *f, struct e5010_context
>> *ctx)
>> +{
>> +    struct e5010_fmt *fmt;
>> +    struct e5010_q_data *queue;
>> +    int i;
>> +    struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
>> +    struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
>> +
>> +    if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n",
>> f->type);
>> +        return -EINVAL;
>> +    }
>> +
>> +    fmt = find_format(f);
>> +    if (!fmt) {
>> +        if (V4L2_TYPE_IS_OUTPUT(f->type))
>> +            pix_mp->pixelformat = V4L2_PIX_FMT_NV12;
>> +        else
>> +            pix_mp->pixelformat = V4L2_PIX_FMT_JPEG;
>> +        fmt = find_format(f);
>> +        if (!fmt)
>> +            return -EINVAL;
>> +    }
>> +
>> +    queue = get_queue(ctx, f->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    queue->fmt = fmt;
>> +    queue->width = pix_mp->width;
>> +    queue->height = pix_mp->height;
>> +
>> +    if (V4L2_TYPE_IS_OUTPUT(f->type)) {
>> +        if (!pix_mp->colorspace)
>> +            pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
>> +        if (!pix_mp->ycbcr_enc)
>> +            pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
>> +        if (!pix_mp->quantization)
>> +            pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
>> +        if (!pix_mp->xfer_func)
>> +            pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
>> +
>> +        v4l2_apply_frmsize_constraints(&pix_mp->width,
>> +                           &pix_mp->height,
>> +                           &fmt->frmsize);
>> +
>> +        v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
>> +                    pix_mp->width, pix_mp->height);
>> +
>> +        for (i = 0; i < fmt->num_planes; i++) {
>> +            queue->bytesperline[i] = plane_fmt[i].bytesperline;
>> +            queue->sizeimage[i] = plane_fmt[i].sizeimage;
>> +        }
>> +    } else {
>> +        pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
>> +        pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
>> +        pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
>> +        pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
>> +        memset(plane_fmt[0].reserved, 0, sizeof(plane_fmt[0].reserved));
>> +        v4l2_apply_frmsize_constraints(&pix_mp->width,
>> +                           &pix_mp->height,
>> +                           &fmt->frmsize);
>> +        queue->sizeimage[0] = pix_mp->width * pix_mp->height *
>> JPEG_MAX_BYTES_PER_PIXEL;
>> +        queue->sizeimage[0] += HEADER_SIZE;
>> +        queue->sizeimage[1] = 0;
>> +        queue->bytesperline[0] = 0;
>> +        queue->bytesperline[1] = 0;
>> +        plane_fmt[0].sizeimage = queue->sizeimage[0];
>> +        plane_fmt[0].bytesperline = 0;
>> +    }
>> +    pix_mp->flags = 0;
>> +    pix_mp->field = V4L2_FIELD_NONE;
>> +    pix_mp->pixelformat = fmt->fourcc;
>> +    queue->width_adjusted = pix_mp->width;
>> +    queue->height_adjusted = pix_mp->height;
>> +    pix_mp->num_planes = fmt->num_planes;
>> +    memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
>> +
>> +    dprintk(ctx->e5010, 2,
>> +        "ctx: 0x%p: format type %s:, wxh: %dx%d (plane0 : %d bytes, plane1
>> : %d bytes),fmt: %c%c%c%c\n",
>> +        ctx, type_name(f->type), queue->width_adjusted,
>> queue->height_adjusted,
>> +        queue->sizeimage[0], queue->sizeimage[1],
>> +        (queue->fmt->fourcc & 0xff),
>> +        (queue->fmt->fourcc >>  8) & 0xff,
>> +        (queue->fmt->fourcc >> 16) & 0xff,
>> +        (queue->fmt->fourcc >> 24) & 0xff);
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +
>> +    return e5010_jpeg_try_fmt(f, ctx);
>> +}
>> +
>> +static int e5010_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +    struct vb2_queue *vq;
>> +
>> +    vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
>> +    if (!vq)
>> +        return -EINVAL;
>> +
>> +    if (vb2_is_busy(vq)) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "queue busy\n");
>> +        return -EBUSY;
>> +    }
>> +
>> +    return e5010_jpeg_try_fmt(f, ctx);
>> +}
>> +
>> +static int e5010_enum_framesizes(struct file *file, void *priv, struct
>> v4l2_frmsizeenum *fsize)
>> +{
>> +    struct v4l2_format f;
>> +    struct e5010_fmt *fmt;
>> +
>> +    if (fsize->index != 0)
>> +        return -EINVAL;
>> +
>> +    f.fmt.pix_mp.pixelformat = fsize->pixel_format;
>> +    if (f.fmt.pix_mp.pixelformat ==  V4L2_PIX_FMT_JPEG)
>> +        f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
>> +    else
>> +        f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
>> +
>> +    fmt = find_format(&f);
>> +    if (!fmt)
>> +        return -EINVAL;
>> +
>> +    fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
>> +    fsize->stepwise = fmt->frmsize;
>> +    fsize->reserved[0] = 0;
>> +    fsize->reserved[1] = 0;
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_g_selection(struct file *file, void *fh, struct
>> v4l2_selection *s)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +    struct e5010_q_data *queue;
>> +
>> +    if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>> +        return -EINVAL;
>> +
>> +    queue = get_queue(ctx, s->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    switch (s->target) {
>> +    case V4L2_SEL_TGT_CROP_DEFAULT:
>> +    case V4L2_SEL_TGT_CROP_BOUNDS:
>> +        s->r.left = 0;
>> +        s->r.top = 0;
>> +        s->r.width = queue->width;
>> +        s->r.height = queue->height;
>> +        break;
>> +    case V4L2_SEL_TGT_CROP:
>> +        s->r = queue->crop;
>> +        break;
>> +    default:
>> +        return -EINVAL;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_s_selection(struct file *file, void *fh, struct
>> v4l2_selection *s)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +    struct e5010_q_data *queue;
>> +
>> +    if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>> +        return -EINVAL;
>> +
>> +    queue = get_queue(ctx, s->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    queue->crop.left = 0;
>> +    queue->crop.top = 0;
>> +    queue->crop.width = s->r.width;
>> +    queue->crop.height = s->r.height;
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_subscribe_event(struct v4l2_fh *fh, const struct
>> v4l2_event_subscription *sub)
>> +{
>> +    switch (sub->type) {
>> +    case V4L2_EVENT_EOS:
>> +        return v4l2_event_subscribe(fh, sub, 0, NULL);
>> +    case V4L2_EVENT_CTRL:
>> +        return v4l2_ctrl_subscribe_event(fh, sub);
>> +    default:
>> +        return -EINVAL;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static int queue_init(void *priv, struct vb2_queue *src_vq, struct
>> vb2_queue *dst_vq)
>> +{
>> +    struct e5010_context *ctx = priv;
>> +    struct e5010_dev *e5010 = ctx->e5010;
>> +    int ret = 0;
>> +
>> +    /* src_vq */
>> +    memset(src_vq, 0, sizeof(*src_vq));
>> +    src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
>> +    src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
>> +    src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
>> +    src_vq->drv_priv = ctx;
>> +    src_vq->buf_struct_size = sizeof(struct e5010_buffer);
>> +    src_vq->ops = &e5010_video_ops;
>> +    src_vq->mem_ops = &vb2_dma_contig_memops;
>> +    src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
>> +    src_vq->lock = &e5010->mutex;
>> +    src_vq->dev = e5010->v4l2_dev.dev;
>> +
>> +    ret = vb2_queue_init(src_vq);
>> +    if (ret)
>> +        return ret;
>> +
>> +    /* dst_vq */
>> +    memset(dst_vq, 0, sizeof(*dst_vq));
>> +    dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
>> +    src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
>> +    dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
>> +    dst_vq->drv_priv = ctx;
>> +    dst_vq->buf_struct_size = sizeof(struct e5010_buffer);
>> +    dst_vq->ops = &e5010_video_ops;
>> +    dst_vq->mem_ops = &vb2_dma_contig_memops;
>> +    dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
>> +    dst_vq->lock = &e5010->mutex;
>> +    dst_vq->dev = e5010->v4l2_dev.dev;
>> +
>> +    ret = vb2_queue_init(dst_vq);
>> +    if (ret) {
>> +        vb2_queue_release(src_vq);
>> +        return ret;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_s_ctrl(struct v4l2_ctrl *ctrl)
>> +{
>> +    struct e5010_context *ctx =
>> +        container_of(ctrl->handler, struct e5010_context, ctrl_handler);
>> +
>> +    switch (ctrl->id) {
>> +    case V4L2_CID_JPEG_COMPRESSION_QUALITY:
>> +        ctx->quality = ctrl->val;
>> +        calculate_qp_tables(ctx);
>> +        break;
>> +    default:
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "Invalid control, id = %d, val =
>> %d\n",
>> +             ctrl->id, ctrl->val);
>> +        return -EINVAL;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static const struct v4l2_ctrl_ops e5010_ctrl_ops = {
>> +    .s_ctrl = e5010_s_ctrl,
>> +};
>> +
>> +static void e5010_encode_ctrls(struct e5010_context *ctx)
>> +{
>> +    v4l2_ctrl_new_std(&ctx->ctrl_handler, &e5010_ctrl_ops,
>> +              V4L2_CID_JPEG_COMPRESSION_QUALITY, 1, 100, 1, 75);
>> +}
>> +
>> +static int e5010_ctrls_setup(struct e5010_context *ctx)
>> +{
>> +    int err;
>> +
>> +    v4l2_ctrl_handler_init(&ctx->ctrl_handler, 1);
>> +
>> +    e5010_encode_ctrls(ctx);
>> +
>> +    if (ctx->ctrl_handler.error) {
>> +        err = ctx->ctrl_handler.error;
>> +        v4l2_ctrl_handler_free(&ctx->ctrl_handler);
>> +
>> +        return err;
>> +    }
>> +
>> +    err = v4l2_ctrl_handler_setup(&ctx->ctrl_handler);
>> +    if (err)
>> +        v4l2_ctrl_handler_free(&ctx->ctrl_handler);
>> +
>> +    return err;
>> +}
>> +
>> +static void e5010_jpeg_set_default_params(struct e5010_context *ctx)
>> +{
>> +    struct e5010_q_data *queue;
>> +    struct v4l2_format f;
>> +    struct e5010_fmt *fmt;
>> +    struct v4l2_pix_format_mplane *pix_mp = &f.fmt.pix_mp;
>> +    struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
>> +    int i = 0;
>> +
>> +    f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
>> +    f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12;
>> +    fmt = find_format(&f);
>> +    queue = &ctx->out_queue;
>> +    queue->fmt = fmt;
>> +    queue->width = DEFAULT_WIDTH;
>> +    queue->height = DEFAULT_HEIGHT;
>> +    v4l2_apply_frmsize_constraints(&pix_mp->width,
>> +                       &pix_mp->height,
>> +                       &fmt->frmsize);
>> +    v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
>> +                pix_mp->width, pix_mp->height);
>> +    for (i = 0; i < fmt->num_planes; i++) {
>> +        queue->bytesperline[i] = plane_fmt[i].bytesperline;
>> +        queue->sizeimage[i] = plane_fmt[i].sizeimage;
>> +    }
>> +    queue->width_adjusted = pix_mp->width;
>> +    queue->height_adjusted = pix_mp->height;
>> +    queue->format_set = false;
>> +    queue->streaming = false;
>> +
>> +    f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
>> +    f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_JPEG;
>> +    fmt = find_format(&f);
>> +    queue = &ctx->cap_queue;
>> +    queue->fmt = fmt;
>> +    queue->width = DEFAULT_WIDTH;
>> +    queue->height = DEFAULT_HEIGHT;
>> +    v4l2_apply_frmsize_constraints(&pix_mp->width,
>> +                       &pix_mp->height,
>> +                       &fmt->frmsize);
>> +    queue->sizeimage[0] = pix_mp->width * pix_mp->height *
>> JPEG_MAX_BYTES_PER_PIXEL;
>> +    queue->sizeimage[0] += HEADER_SIZE;
>> +    queue->sizeimage[1] = 0;
>> +    queue->bytesperline[0] = 0;
>> +    queue->bytesperline[1] = 0;
>> +    queue->format_set = false;
>> +    queue->streaming = false;
>> +    queue->width_adjusted = pix_mp->width;
>> +    queue->height_adjusted = pix_mp->height;
>> +}
>> +
>> +static int e5010_open(struct file *file)
>> +{
>> +    struct e5010_dev *e5010 = video_drvdata(file);
>> +    struct video_device *vdev = video_devdata(file);
>> +    struct e5010_context *ctx;
>> +    int ret = 0;
>> +
>> +    ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> +    if (!ctx)
>> +        return -ENOMEM;
>> +
>> +    if (mutex_lock_interruptible(&e5010->mutex)) {
>> +        ret = -ERESTARTSYS;
>> +        goto free;
>> +    }
>> +
>> +    v4l2_fh_init(&ctx->fh, vdev);
>> +    file->private_data = ctx;
>> +    v4l2_fh_add(&ctx->fh);
>> +
>> +    ctx->e5010 = e5010;
>> +    ctx->fh.m2m_ctx = v4l2_m2m_ctx_init(e5010->m2m_dev, ctx, queue_init);
>> +    if (IS_ERR(ctx->fh.m2m_ctx)) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to init m2m ctx\n");
>> +        ret = PTR_ERR(ctx->fh.m2m_ctx);
>> +        goto exit;
>> +    }
>> +
>> +    ret = e5010_ctrls_setup(ctx);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to setup e5010 jpeg controls\n");
>> +        goto err_ctrls_setup;
>> +    }
>> +    ctx->fh.ctrl_handler = &ctx->ctrl_handler;
>> +
>> +    e5010_jpeg_set_default_params(ctx);
>> +
>> +    dprintk(e5010, 1, "Created instance: 0x%p, m2m_ctx: 0x%p\n", ctx,
>> ctx->fh.m2m_ctx);
>> +
>> +    mutex_unlock(&e5010->mutex);
>> +    return 0;
>> +
>> +err_ctrls_setup:
>> +    v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
>> +exit:
>> +    v4l2_fh_del(&ctx->fh);
>> +    v4l2_fh_exit(&ctx->fh);
>> +    mutex_unlock(&e5010->mutex);
>> +free:
>> +    kfree(ctx);
>> +    return ret;
>> +}
>> +
>> +static int e5010_release(struct file *file)
>> +{
>> +    struct e5010_dev *e5010 = video_drvdata(file);
>> +    struct e5010_context *ctx = file->private_data;
>> +
>> +    dprintk(e5010, 1, "Releasing instance: 0x%p, m2m_ctx: 0x%p\n", ctx,
>> ctx->fh.m2m_ctx);
>> +    mutex_lock(&e5010->mutex);
>> +    v4l2_ctrl_handler_free(&ctx->ctrl_handler);
>> +    v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
>> +    v4l2_fh_del(&ctx->fh);
>> +    v4l2_fh_exit(&ctx->fh);
>> +    kfree(ctx);
>> +    mutex_unlock(&e5010->mutex);
>> +
>> +    return 0;
>> +}
>> +
>> +static struct video_device e5010_videodev = {
>> +    .name = E5010_MODULE_NAME,
>> +    .fops = &e5010_fops,
>> +    .ioctl_ops = &e5010_ioctl_ops,
>> +    .minor = -1,
>> +    .release = video_device_release_empty,
>> +    .vfl_dir = VFL_DIR_M2M,
>> +    .device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING,
>> +};
>> +
>> +static void header_write(struct e5010_context *ctx, u8 *addr, unsigned int
>> *offset,
>> +             unsigned int no_bytes, unsigned long bits)
>> +{
>> +    u8 *w_addr = addr + *offset;
>> +    int i;
>> +
>> +    if ((*offset + no_bytes) > HEADER_SIZE) {
>> +        v4l2_warn(&ctx->e5010->v4l2_dev, "%s: %s: %d: Problem writing
>> header. %d > HEADER_SIZE %d\n",
>> +              __FILE__, __func__, __LINE__, *offset + no_bytes, HEADER_SIZE);
>> +        return;
>> +    }
>> +
>> +    for (i = no_bytes - 1; i >= 0; i--)
>> +        *(w_addr++) = ((u8 *)&bits)[i];
>> +
>> +    *offset += no_bytes;
>> +}
>> +
>> +static void encode_marker_segment(struct e5010_context *ctx, void *addr,
>> unsigned int *offset)
>> +{
>> +    u8 *buffer = (u8 *)addr;
>> +    int i;
>> +
>> +    header_write(ctx, buffer, offset, 2, START_OF_IMAGE);
>> +    header_write(ctx, buffer, offset, 2, DQT_MARKER);
> 
> These markers have already been defined somewhere else (i.e. not in this
> driver). Why not factor that out and reuse?
> 

Agreed, I am thinking to put them in include/media/jpeg.h

> Regards,
> 
> Andrzej
> 
>> +    header_write(ctx, buffer, offset, 3, LQPQ << 4);
>> +    for (i = 0; i < PELS_IN_BLOCK; i++)
>> +        header_write(ctx, buffer, offset, 1, ctx->luma_qp[zigzag[i]]);
>> +
>> +    header_write(ctx, buffer, offset, 2, DQT_MARKER);
>> +    header_write(ctx, buffer, offset, 3, (LQPQ << 4) | 1);
>> +    for (i = 0; i < PELS_IN_BLOCK; i++)
>> +        header_write(ctx, buffer, offset, 1, ctx->chroma_qp[zigzag[i]]);
>> +
>> +    /* Huffman tables */
>> +    header_write(ctx, buffer, offset, 2, DHT_MARKER);
>> +    header_write(ctx, buffer, offset, 2, LH_DC);
>> +    for (i = 0 ; i < (LH_DC - 2); i++)
>> +        header_write(ctx, buffer, offset, 1, marker_luma_dc[i]);
>> +
>> +    header_write(ctx, buffer, offset, 2, DHT_MARKER);
>> +    header_write(ctx, buffer, offset, 2, LH_AC);
>> +    for (i = 0 ; i < (LH_AC - 2); i++)
>> +        header_write(ctx, buffer, offset, 1, marker_luma_ac[i]);
>> +
>> +    header_write(ctx, buffer, offset, 2, DHT_MARKER);
>> +    header_write(ctx, buffer, offset, 2, LH_DC);
>> +    for (i = 0 ; i < (LH_DC - 2); i++)
>> +        header_write(ctx, buffer, offset, 1, marker_chroma_dc[i]);
>> +
>> +    header_write(ctx, buffer, offset, 2, DHT_MARKER);
>> +    header_write(ctx, buffer, offset, 2, LH_AC);
>> +    for (i = 0 ; i < (LH_AC - 2); i++)
>> +        header_write(ctx, buffer, offset, 1, marker_chroma_ac[i]);
>> +}
>> +
>> +static void encode_frame_header(struct e5010_context *ctx, void *addr,
>> unsigned int *offset)
>> +{
>> +    u8 *buffer = (u8 *)addr;
>> +
>> +    header_write(ctx, buffer, offset, 2, SOF_BASELINE_DCT);
>> +    header_write(ctx, buffer, offset, 2, 8 + (3 * UC_NUM_COMP));
>> +    header_write(ctx, buffer, offset, 1, PRECISION);
>> +    header_write(ctx, buffer, offset, 2, ctx->out_queue.height);
>> +    header_write(ctx, buffer, offset, 2, ctx->out_queue.width);
>> +    header_write(ctx, buffer, offset, 1, UC_NUM_COMP);
>> +
>> +    /* Luma details */
>> +    header_write(ctx, buffer, offset, 1, 1);
>> +    if (ctx->out_queue.fmt->subsampling == V4L2_JPEG_CHROMA_SUBSAMPLING_422)
>> +        header_write(ctx, buffer, offset, 1,
>> +                 HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_422));
>> +    else
>> +        header_write(ctx, buffer, offset, 1,
>> +                 HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_420));
>> +    header_write(ctx, buffer, offset, 1, 0);
>> +    /* Chroma details */
>> +    header_write(ctx, buffer, offset, 1, 2);
>> +    header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
>> +    header_write(ctx, buffer, offset, 1, 1);
>> +    header_write(ctx, buffer, offset, 1, 3);
>> +    header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
>> +    header_write(ctx, buffer, offset, 1, 1);
>> +
>> +    header_write(ctx, buffer, offset, 1, 0xFF);
>> +}
>> +
>> +static void jpg_encode_sos_header(struct e5010_context *ctx, void *addr,
>> unsigned int *offset)
>> +{
>> +    u8 *buffer = (u8 *)addr;
>> +    int i;
>> +
>> +    header_write(ctx, buffer, offset, 2, START_OF_SCAN);
>> +    header_write(ctx, buffer, offset, 2, 6 + (COMPONENTS_IN_SCAN << 1));
>> +    header_write(ctx, buffer, offset, 1, COMPONENTS_IN_SCAN);
>> +
>> +    for (i = 0; i < COMPONENTS_IN_SCAN; i++) {
>> +        header_write(ctx, buffer, offset, 1, i + 1);
>> +        if (i == 0)
>> +            header_write(ctx, buffer, offset, 1, 0);
>> +        else
>> +            header_write(ctx, buffer, offset, 1, 17);
>> +    }
>> +
>> +    header_write(ctx, buffer, offset, 1, 0);
>> +    header_write(ctx, buffer, offset, 1, 63);
>> +    header_write(ctx, buffer, offset, 1, 0);
>> +}
>> +
>> +static void write_header(struct e5010_context *ctx, void *addr)
>> +{
>> +    unsigned int offset = 0;
>> +
>> +    encode_marker_segment(ctx, addr, &offset);
>> +    encode_frame_header(ctx, addr, &offset);
>> +    jpg_encode_sos_header(ctx, addr, &offset);
>> +}
>> +
>> +static irqreturn_t e5010_irq(int irq, void *data)
>> +{
>> +    struct e5010_dev *e5010 = data;
>> +    struct e5010_context *ctx;
>> +    int output_size;
>> +    struct vb2_v4l2_buffer *src_buf, *dst_buf;
>> +    bool pic_done, out_addr_err;
>> +
>> +    spin_lock(&e5010->hw_lock);
>> +    pic_done = e5010_hw_pic_done_irq(e5010->core_base);
>> +    out_addr_err = e5010_hw_output_address_irq(e5010->core_base);
>> +
>> +    if (!pic_done && !out_addr_err) {
>> +        spin_unlock(&e5010->hw_lock);
>> +        return IRQ_NONE;
>> +    }
>> +
>> +    ctx = v4l2_m2m_get_curr_priv(e5010->m2m_dev);
>> +    if (WARN_ON(!ctx))
>> +        goto job_unlock;
>> +
>> +    dst_buf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
>> +    src_buf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
>> +    if (!dst_buf || !src_buf) {
>> +        v4l2_err(&e5010->v4l2_dev, "ctx: 0x%p No source or destination
>> buffer\n", ctx);
>> +        goto job_unlock;
>> +    }
>> +
>> +    if (out_addr_err) {
>> +        e5010_hw_clear_output_error(e5010->core_base, 1);
>> +        v4l2_warn(&e5010->v4l2_dev,
>> +              "ctx: 0x%p Output bitstream size exceeded max size\n", ctx);
>> +        v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
>> +        vb2_set_plane_payload(&dst_buf->vb2_buf, 0,
>> dst_buf->planes[0].length);
>> +        v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR);
>> +        if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
>> +            dst_buf->flags |= V4L2_BUF_FLAG_LAST;
>> +            v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
>> +            v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
>> +            dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
>> +        }
>> +    }
>> +
>> +    if (pic_done) {
>> +        e5010_hw_clear_picture_done(e5010->core_base, 1);
>> +        dprintk(e5010, 3, "ctx: 0x%p Got output bitstream of size %d bytes\n",
>> +            ctx, readl(e5010->core_base + JASPER_OUTPUT_SIZE_OFFSET));
>> +
>> +        if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
>> +            dst_buf->flags |= V4L2_BUF_FLAG_LAST;
>> +            v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
>> +            v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
>> +            dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
>> +        }
>> +        v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE);
>> +        output_size = e5010_hw_get_output_size(e5010->core_base);
>> +        vb2_set_plane_payload(&dst_buf->vb2_buf, 0, output_size +
>> HEADER_SIZE);
>> +        v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE);
>> +        dprintk(e5010, 3,
>> +            "ctx: 0x%p frame done for dst_buf->sequence: %d
>> src_buf->sequence: %d\n",
>> +            ctx, dst_buf->sequence, src_buf->sequence);
>> +    }
>> +
>> +    v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
>> +    dprintk(e5010, 3, "ctx: 0x%p Finish job\n", ctx);
>> +
>> +job_unlock:
>> +    spin_unlock(&e5010->hw_lock);
>> +    return IRQ_HANDLED;
>> +}
>> +
>> +static int e5010_init_device(struct e5010_dev *e5010)
>> +{
>> +    int ret = 0;
>> +
>> +    /*TODO: Set MMU in bypass mode until support for the same is added in
>> driver*/
>> +    e5010_hw_bypass_mmu(e5010->mmu_base, 1);
>> +
>> +    if (e5010_hw_enable_auto_clock_gating(e5010->core_base, 1))
>> +        v4l2_warn(&e5010->v4l2_dev, "failed to enable auto clock gating\n");
>> +
>> +    if (e5010_hw_enable_manual_clock_gating(e5010->core_base, 0))
>> +        v4l2_warn(&e5010->v4l2_dev, "failed to disable manual clock
>> gating\n");
>> +
>> +    if (e5010_hw_enable_crc_check(e5010->core_base, 0))
>> +        v4l2_warn(&e5010->v4l2_dev, "failed to disable CRC check\n");
>> +
>> +    if (e5010_hw_enable_output_address_error_irq(e5010->core_base, 1))
>> +        v4l2_err(&e5010->v4l2_dev, "failed to enable Output Address Error
>> interrupts\n");
>> +
>> +    ret = e5010_hw_set_input_source_to_memory(e5010->core_base, 1);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input source to memory\n");
>> +        return ret;
>> +    }
>> +
>> +    ret = e5010_hw_enable_picture_done_irq(e5010->core_base, 1);
>> +    if (ret)
>> +        v4l2_err(&e5010->v4l2_dev, "failed to enable Picture Done
>> interrupts\n");
>> +
>> +    return ret;
>> +}
>> +
>> +static int e5010_probe(struct platform_device *pdev)
>> +{
>> +    struct e5010_dev *e5010;
>> +    int irq, ret = 0;
>> +
>> +    ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
>> +    if (ret)
>> +        return dev_err_probe(e5010->dev, ret, "32-bit consistent DMA enable
>> failed\n");
>> +
>> +    e5010 = devm_kzalloc(&pdev->dev, sizeof(*e5010), GFP_KERNEL);
>> +    if (!e5010)
>> +        return -ENOMEM;
>> +
>> +    platform_set_drvdata(pdev, e5010);
>> +
>> +    e5010->dev = &pdev->dev;
>> +
>> +    mutex_init(&e5010->mutex);
>> +    spin_lock_init(&e5010->hw_lock);
>> +
>> +    e5010->vdev = &e5010_videodev;
>> +    e5010->vdev->v4l2_dev = &e5010->v4l2_dev;
>> +    e5010->vdev->lock = &e5010->mutex;
>> +    e5010->vdev->queue = NULL;
>> +    e5010->vdev->prio = NULL;
>> +    e5010->vdev->dev_parent = NULL;
>> +    e5010->vdev->minor = -1;
>> +
>> +    ret = v4l2_device_register(&pdev->dev, &e5010->v4l2_dev);
>> +    if (ret)
>> +        return dev_err_probe(e5010->dev, ret, "failed to register v4l2
>> device\n");
>> +
>> +    e5010->m2m_dev = v4l2_m2m_init(&e5010_m2m_ops);
>> +    if (IS_ERR(e5010->m2m_dev)) {
>> +        ret = PTR_ERR(e5010->m2m_dev);
>> +        e5010->m2m_dev = NULL;
>> +        dev_err_probe(e5010->dev, ret, "failed to init mem2mem device\n");
>> +        goto fail_after_v4l2_register;
>> +    }
>> +
>> +    video_set_drvdata(e5010->vdev, e5010);
>> +
>> +    ret = video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0);
>> +    if (ret) {
>> +        dev_err_probe(e5010->dev, ret, "failed to register video device\n");
>> +        goto fail_after_v4l2_register;
>> +    }
>> +
>> +    v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n",
>> +          e5010->vdev->num);
>> +
>> +    e5010->core_base = devm_platform_ioremap_resource_byname(pdev, "core");
>> +    if (IS_ERR(e5010->core_base)) {
>> +        ret = PTR_ERR(e5010->core_base);
>> +        dev_err_probe(e5010->dev, ret, "Missing 'core' resources area\n");
>> +        goto fail_after_video_register_device;
>> +    }
>> +
>> +    e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu");
>> +    if (IS_ERR(e5010->mmu_base)) {
>> +        ret = PTR_ERR(e5010->mmu_base);
>> +        dev_err_probe(e5010->dev, ret, "Missing 'mmu' resources area\n");
>> +        goto fail_after_video_register_device;
>> +    }
>> +
>> +    e5010->last_context_run = NULL;
>> +
>> +    irq = platform_get_irq(pdev, 0);
>> +    ret = devm_request_irq(e5010->dev, irq, e5010_irq, 0,
>> +                   E5010_MODULE_NAME, e5010);
>> +    if (ret) {
>> +        dev_err_probe(e5010->dev, ret, "failed to register IRQ %d\n", irq);
>> +        goto fail_after_video_register_device;
>> +    }
>> +
>> +    e5010->clk = devm_clk_get(&pdev->dev, "core_clk");
>> +    if (IS_ERR(e5010->clk)) {
>> +        ret = PTR_ERR(e5010->clk);
>> +        dev_err_probe(e5010->dev, ret, "failed to get clock\n");
>> +        goto fail_after_video_register_device;
>> +    }
>> +
>> +    pm_runtime_enable(e5010->dev);
>> +
>> +    return 0;
>> +
>> +fail_after_video_register_device:
>> +    v4l2_m2m_release(e5010->m2m_dev);
>> +fail_after_v4l2_register:
>> +    v4l2_device_unregister(&e5010->v4l2_dev);
>> +    return ret;
>> +}
>> +
>> +static int e5010_remove(struct platform_device *pdev)
>> +{
>> +    struct e5010_dev *e5010 = platform_get_drvdata(pdev);
>> +
>> +    pm_runtime_disable(e5010->dev);
>> +    video_unregister_device(e5010->vdev);
>> +    v4l2_m2m_release(e5010->m2m_dev);
>> +    v4l2_device_unregister(&e5010->v4l2_dev);
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers,
>> unsigned int *nplanes,
>> +                 unsigned int sizes[], struct device *alloc_devs[])
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(vq);
>> +    struct e5010_q_data *queue;
>> +    int i;
>> +
>> +    if (!V4L2_TYPE_IS_MULTIPLANAR(vq->type)) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "queue setup with Invalid type:
>> %d\n", vq->type);
>> +        return -EINVAL;
>> +    }
>> +
>> +    queue = get_queue(ctx, vq->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    if (*nplanes) {
>> +        if (*nplanes != queue->fmt->num_planes)
>> +            return -EINVAL;
>> +        for (i = 0; i < *nplanes; i++) {
>> +            if (sizes[i] < queue->sizeimage[i])
>> +                return -EINVAL;
>> +        }
>> +        return 0;
>> +    }
>> +
>> +    *nbuffers = max_t(unsigned int, *nbuffers, 1);
>> +    *nplanes = queue->fmt->num_planes;
>> +    for (i = 0; i < *nplanes; i++)
>> +        sizes[i] = queue->sizeimage[i];
>> +
>> +    dprintk(ctx->e5010, 2,
>> +        "ctx: 0x%p, type %s, buffer(s): %d, planes %d, plane1: bytes %d
>> plane2: %d bytes\n",
>> +        ctx, type_name(vq->type), *nbuffers, *nplanes, sizes[0], sizes[1]);
>> +
>> +    return 0;
>> +}
>> +
>> +static void e5010_buf_finish(struct vb2_buffer *vb)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
>> +    void *d_addr;
>> +
>> +    if (vb->state != VB2_BUF_STATE_DONE ||
>> V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
>> +        return;
>> +
>> +    d_addr = vb2_plane_vaddr(vb, 0);
>> +    write_header(ctx, d_addr);
>> +}
>> +
>> +static int e5010_buf_out_validate(struct vb2_buffer *vb)
>> +{
>> +    struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
>> +    struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
>> +
>> +    if (vbuf->field != V4L2_FIELD_NONE)
>> +        dprintk(ctx->e5010, 1, "ctx: 0x%p, field isn't supported\n", ctx);
>> +
>> +    vbuf->field = V4L2_FIELD_NONE;
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_buf_prepare(struct vb2_buffer *vb)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
>> +    struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
>> +    struct e5010_q_data *queue;
>> +    int i;
>> +
>> +    vbuf->field = V4L2_FIELD_NONE;
>> +
>> +    queue = get_queue(ctx, vb->vb2_queue->type);
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +
>> +    for (i = 0; i < queue->fmt->num_planes; i++) {
>> +        if (vb2_plane_size(vb, i) < (unsigned long)queue->sizeimage[i]) {
>> +            v4l2_err(&ctx->e5010->v4l2_dev, "plane %d too small (%lu <
>> %lu)", i,
>> +                 vb2_plane_size(vb, i), (unsigned long)queue->sizeimage[i]);
>> +
>> +            return -EINVAL;
>> +        }
>> +    }
>> +
>> +    if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type)) {
>> +        vb2_set_plane_payload(vb, 0, 0);
>> +        vb2_set_plane_payload(vb, 1, 0);
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static void e5010_buf_queue(struct vb2_buffer *vb)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
>> +    struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
>> +
>> +    if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type) &&
>> +        vb2_is_streaming(vb->vb2_queue) &&
>> +        v4l2_m2m_dst_buf_is_last(ctx->fh.m2m_ctx)) {
>> +        struct e5010_q_data *queue = get_queue(ctx,
>> V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
>> +
>> +        if (IS_ERR(queue))
>> +            return;
>> +
>> +        vbuf->sequence = queue->sequence++;
>> +        v4l2_m2m_last_buffer_done(ctx->fh.m2m_ctx, vbuf);
>> +        v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
>> +        return;
>> +    }
>> +
>> +    v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
>> +}
>> +
>> +static int e5010_encoder_cmd(struct file *file, void *priv,
>> +                 struct v4l2_encoder_cmd *cmd)
>> +{
>> +    struct e5010_context *ctx = file->private_data;
>> +    int ret;
>> +    struct vb2_queue *cap_vq;
>> +
>> +    cap_vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx,
>> V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
>> +
>> +    ret = v4l2_m2m_ioctl_try_encoder_cmd(file, &ctx->fh, cmd);
>> +    if (ret < 0)
>> +        return ret;
>> +
>> +    if (!vb2_is_streaming(v4l2_m2m_get_src_vq(ctx->fh.m2m_ctx)) ||
>> +        !vb2_is_streaming(v4l2_m2m_get_dst_vq(ctx->fh.m2m_ctx)))
>> +        return 0;
>> +
>> +    ret = v4l2_m2m_ioctl_encoder_cmd(file, &ctx->fh, cmd);
>> +    if (ret < 0)
>> +        return ret;
>> +
>> +    if (cmd->cmd == V4L2_ENC_CMD_STOP &&
>> +        v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
>> +        v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
>> +
>> +    if (cmd->cmd == V4L2_ENC_CMD_START &&
>> +        v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
>> +        vb2_clear_last_buffer_dequeued(cap_vq);
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_start_streaming(struct vb2_queue *q, unsigned int count)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(q);
>> +    int ret;
>> +
>> +    struct e5010_q_data *queue = get_queue(ctx, q->type);
>> +
>> +    if (IS_ERR(queue))
>> +        return PTR_ERR(queue);
>> +    queue->streaming = true;
>> +    v4l2_m2m_update_start_streaming_state(ctx->fh.m2m_ctx, q);
>> +    queue->sequence = 0;
>> +
>> +    ret = pm_runtime_resume_and_get(ctx->e5010->dev);
>> +    if (ret < 0) {
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "failed to power up jpeg\n");
>> +        return ret;
>> +    }
>> +
>> +    ret = e5010_init_device(ctx->e5010);
>> +    if (ret)
>> +        v4l2_err(&ctx->e5010->v4l2_dev, "failed to Enable e5010 device\n");
>> +
>> +    return ret;
>> +}
>> +
>> +static void e5010_stop_streaming(struct vb2_queue *q)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(q);
>> +    struct vb2_v4l2_buffer *vbuf;
>> +    struct e5010_q_data *queue;
>> +
>> +    queue = get_queue(ctx, q->type);
>> +    if (IS_ERR(queue))
>> +        return;
>> +
>> +    queue->streaming = false;
>> +
>> +    if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
>> +        while ((vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx))) {
>> +            dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
>> +                ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
>> +            v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
>> +        }
>> +    } else {
>> +        while ((vbuf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx))) {
>> +            dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
>> +                ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
>> +            vb2_set_plane_payload(&vbuf->vb2_buf, 0, 0);
>> +            v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
>> +        }
>> +    }
>> +
>> +    if (V4L2_TYPE_IS_OUTPUT(q->type))
>> +        v4l2_m2m_update_stop_streaming_state(ctx->fh.m2m_ctx, q);
>> +
>> +    if (V4L2_TYPE_IS_OUTPUT(q->type) &&
>> +        v4l2_m2m_has_stopped(ctx->fh.m2m_ctx)) {
>> +        v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
>> +    }
>> +
>> +    pm_runtime_put_sync(ctx->e5010->dev);
>> +}
>> +
>> +static void e5010_device_run(void *priv)
>> +{
>> +    struct e5010_context *ctx = priv;
>> +    struct e5010_dev *e5010 = ctx->e5010;
>> +    struct vb2_v4l2_buffer *s_vb, *d_vb;
>> +    u32 reg = 0;
>> +    int ret = 0;
>> +    unsigned long flags;
>> +    int num_planes = ctx->out_queue.fmt->num_planes;
>> +
>> +    spin_lock_irqsave(&e5010->hw_lock, flags);
>> +    s_vb = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
>> +    WARN_ON(!s_vb);
>> +    d_vb = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx);
>> +    WARN_ON(!d_vb);
>> +    if (!s_vb || !d_vb)
>> +        goto no_ready_buf_err;
>> +
>> +    s_vb->sequence = ctx->out_queue.sequence++;
>> +    d_vb->sequence = ctx->cap_queue.sequence++;
>> +
>> +    v4l2_m2m_buf_copy_metadata(s_vb, d_vb, false);
>> +
>> +    if (ctx != e5010->last_context_run || ctx->update_qp) {
>> +        dprintk(e5010, 1, "ctx updated: 0x%p -> 0x%p, updating qp tables\n",
>> +            e5010->last_context_run, ctx);
>> +        ret = update_qp_tables(ctx);
>> +    }
>> +
>> +    if (ret) {
>> +        ctx->update_qp = true;
>> +        v4l2_err(&e5010->v4l2_dev, "failed to update QP tables\n");
>> +        goto device_busy_err;
>> +    } else {
>> +        e5010->last_context_run = ctx;
>> +        ctx->update_qp = false;
>> +    }
>> +
>> +    /* Set I/O Buffer addresses */
>> +    reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0);
>> +    ret = e5010_hw_set_input_luma_addr(e5010->core_base, reg);
>> +    if (ret || !reg) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input luma address\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    if (num_planes == 1)
>> +        reg += (ctx->out_queue.bytesperline[0]) * (ctx->out_queue.height);
>> +    else
>> +        reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 1);
>> +
>> +    dprintk(e5010, 3,
>> +        "ctx: 0x%p, luma_addr: 0x%x, chroma_addr: 0x%x, out_addr: 0x%x\n",
>> +        ctx, (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0), reg,
>> +        (u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0));
>> +
>> +    dprintk(e5010, 3,
>> +        "ctx: 0x%p, buf indices: src_index: %d, dst_index: %d\n",
>> +        ctx, s_vb->vb2_buf.index, d_vb->vb2_buf.index);
>> +
>> +    ret = e5010_hw_set_input_chroma_addr(e5010->core_base, reg);
>> +    if (ret || !reg) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input chroma address\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    reg = (u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0);
>> +    reg += HEADER_SIZE;
>> +    ret = e5010_hw_set_output_base_addr(e5010->core_base, reg);
>> +    if (ret || !reg) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set output size\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    /* Set input settings */
>> +    ret = e5010_hw_set_horizontal_size(e5010->core_base,
>> ctx->out_queue.width - 1);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    ret = e5010_hw_set_vertical_size(e5010->core_base,
>> ctx->out_queue.height - 1);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    ret = e5010_hw_set_luma_stride(e5010->core_base,
>> ctx->out_queue.bytesperline[0]);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set luma stride\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    ret = e5010_hw_set_chroma_stride(e5010->core_base,
>> ctx->out_queue.bytesperline[0]);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set chroma stride\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    ret = e5010_set_input_subsampling(e5010->core_base,
>> ctx->out_queue.fmt->subsampling);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set input subsampling\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    ret = e5010_hw_set_chroma_order(e5010->core_base,
>> ctx->out_queue.fmt->chroma_order);
>> +    if (ret) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to set chroma order\n");
>> +        goto device_busy_err;
>> +    }
>> +
>> +    e5010_hw_set_output_max_size(e5010->core_base, d_vb->planes[0].length);
>> +    e5010_hw_encode_start(e5010->core_base, 1);
>> +
>> +    spin_unlock_irqrestore(&e5010->hw_lock, flags);
>> +
>> +    return;
>> +
>> +device_busy_err:
>> +    e5010_reset(e5010->dev, e5010->core_base, e5010->mmu_base);
>> +
>> +no_ready_buf_err:
>> +    if (s_vb) {
>> +        v4l2_m2m_src_buf_remove_by_buf(ctx->fh.m2m_ctx, s_vb);
>> +        v4l2_m2m_buf_done(s_vb, VB2_BUF_STATE_ERROR);
>> +    }
>> +
>> +    if (d_vb) {
>> +        v4l2_m2m_dst_buf_remove_by_buf(ctx->fh.m2m_ctx, d_vb);
>> +        /* Payload set to 1 since 0 payload can trigger EOS */
>> +        vb2_set_plane_payload(&d_vb->vb2_buf, 0, 1);
>> +        v4l2_m2m_buf_done(d_vb, VB2_BUF_STATE_ERROR);
>> +    }
>> +    v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
>> +    spin_unlock_irqrestore(&e5010->hw_lock, flags);
>> +}
>> +
>> +#ifdef CONFIG_PM
>> +static int e5010_runtime_resume(struct device *dev)
>> +{
>> +    struct e5010_dev *e5010 = dev_get_drvdata(dev);
>> +    int ret;
>> +
>> +    ret = clk_prepare_enable(e5010->clk);
>> +    if (ret < 0) {
>> +        v4l2_err(&e5010->v4l2_dev, "failed to enable clock\n");
>> +        return ret;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>> +static int e5010_runtime_suspend(struct device *dev)
>> +{
>> +    struct e5010_dev *e5010 = dev_get_drvdata(dev);
>> +
>> +    clk_disable_unprepare(e5010->clk);
>> +
>> +    return 0;
>> +}
>> +#endif
>> +
>> +#ifdef CONFIG_PM_SLEEP
>> +static int e5010_suspend(struct device *dev)
>> +{
>> +    struct e5010_dev *e5010 = dev_get_drvdata(dev);
>> +
>> +    v4l2_m2m_suspend(e5010->m2m_dev);
>> +
>> +    return pm_runtime_force_suspend(dev);
>> +}
>> +
>> +static int e5010_resume(struct device *dev)
>> +{
>> +    struct e5010_dev *e5010 = dev_get_drvdata(dev);
>> +    int ret;
>> +
>> +    ret = pm_runtime_force_resume(dev);
>> +    if (ret < 0)
>> +        return ret;
>> +
>> +    v4l2_m2m_resume(e5010->m2m_dev);
>> +
>> +    return ret;
>> +}
>> +#endif
>> +
>> +static const struct dev_pm_ops    e5010_pm_ops = {
>> +    SET_RUNTIME_PM_OPS(e5010_runtime_suspend,
>> +               e5010_runtime_resume, NULL)
>> +    SET_SYSTEM_SLEEP_PM_OPS(e5010_suspend, e5010_resume)
>> +};
>> +
>> +static const struct v4l2_ioctl_ops e5010_ioctl_ops = {
>> +    .vidioc_querycap = e5010_querycap,
>> +
>> +    .vidioc_enum_fmt_vid_cap = e5010_enum_fmt,
>> +    .vidioc_g_fmt_vid_cap_mplane = e5010_g_fmt,
>> +    .vidioc_try_fmt_vid_cap_mplane = e5010_try_fmt,
>> +    .vidioc_s_fmt_vid_cap_mplane = e5010_s_fmt,
>> +
>> +    .vidioc_enum_fmt_vid_out = e5010_enum_fmt,
>> +    .vidioc_g_fmt_vid_out_mplane = e5010_g_fmt,
>> +    .vidioc_try_fmt_vid_out_mplane = e5010_try_fmt,
>> +    .vidioc_s_fmt_vid_out_mplane = e5010_s_fmt,
>> +
>> +    .vidioc_g_selection = e5010_g_selection,
>> +    .vidioc_s_selection = e5010_s_selection,
>> +
>> +    .vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
>> +    .vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
>> +    .vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
>> +    .vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
>> +    .vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
>> +    .vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
>> +    .vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
>> +
>> +    .vidioc_streamon = v4l2_m2m_ioctl_streamon,
>> +    .vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
>> +    .vidioc_log_status = v4l2_ctrl_log_status,
>> +
>> +    .vidioc_subscribe_event = e5010_subscribe_event,
>> +    .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
>> +    .vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
>> +    .vidioc_encoder_cmd = e5010_encoder_cmd,
>> +
>> +    .vidioc_enum_framesizes = e5010_enum_framesizes,
>> +};
>> +
>> +static const struct vb2_ops e5010_video_ops = {
>> +    .queue_setup = e5010_queue_setup,
>> +    .buf_queue = e5010_buf_queue,
>> +    .buf_finish = e5010_buf_finish,
>> +    .buf_prepare = e5010_buf_prepare,
>> +    .buf_out_validate = e5010_buf_out_validate,
>> +    .wait_prepare = vb2_ops_wait_prepare,
>> +    .wait_finish = vb2_ops_wait_finish,
>> +    .start_streaming = e5010_start_streaming,
>> +    .stop_streaming = e5010_stop_streaming,
>> +};
>> +
>> +static const struct v4l2_file_operations e5010_fops = {
>> +    .owner = THIS_MODULE,
>> +    .open = e5010_open,
>> +    .release = e5010_release,
>> +    .poll = v4l2_m2m_fop_poll,
>> +    .unlocked_ioctl = video_ioctl2,
>> +    .mmap = v4l2_m2m_fop_mmap,
>> +};
>> +
>> +static const struct v4l2_m2m_ops e5010_m2m_ops = {
>> +    .device_run = e5010_device_run,
>> +};
>> +
>> +static const struct of_device_id e5010_of_match[] = {
>> +    {.compatible = "img,e5010-jpeg-enc"},   { /* end */},
>> +};
>> +MODULE_DEVICE_TABLE(of, e5010_of_match);
>> +
>> +static struct platform_driver e5010_driver = {
>> +    .probe = e5010_probe,
>> +    .remove = e5010_remove,
>> +    .driver = {
>> +        .name = E5010_MODULE_NAME,
>> +        .of_match_table = e5010_of_match,
>> +        .pm = &e5010_pm_ops,
>> +    },
>> +};
>> +module_platform_driver(e5010_driver);
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("Imagination E5010 JPEG encoder driver");
>> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.h
>> b/drivers/media/platform/imagination/e5010-jpeg-enc.h
>> new file mode 100644
>> index 000000000000..3a47b0327101
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.h
>> @@ -0,0 +1,169 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#include <media/v4l2-ctrls.h>
>> +#include <media/v4l2-device.h>
>> +#include <media/v4l2-fh.h>
>> +
>> +#ifndef _E5010_JPEG_ENC_H
>> +#define _E5010_JPEG_ENC_H
>> +
>> +#define MAX_PLANES            2
>> +#define HEADER_SIZE            0x025E
>> +#define MIN_DIMENSION            64
>> +#define MAX_DIMENSION            8192
>> +#define DEFAULT_WIDTH            640
>> +#define DEFAULT_HEIGHT            480
>> +#define E5010_MODULE_NAME        "e5010"
>> +#define JPEG_MAX_BYTES_PER_PIXEL    2
>> +
>> +/* JPEG marker definitions */
>> +#define START_OF_IMAGE            0xFFD8
>> +#define SOF_BASELINE_DCT        0xFFC0
>> +#define END_OF_IMAGE            0xFFD9
>> +#define START_OF_SCAN            0xFFDA
>> +
>> +/* Definitions for the huffman table specification in the Marker segment */
>> +#define DHT_MARKER            0xFFC4
>> +#define LH_DC                0x001F
>> +#define LH_AC                0x00B5
>> +
>> +/* Definitions for the quantization table specification in the Marker
>> segment */
>> +#define DQT_MARKER            0xFFDB
>> +#define ACMAX                0x03FF
>> +#define DCMAX                0x07FF
>> +
>> +/* Length and precision of the quantization table parameters */
>> +#define LQPQ                0x00430
>> +#define QMAX                255
>> +
>> +/* Misc JPEG header definitions */
>> +#define UC_NUM_COMP            3
>> +#define PRECISION            8
>> +#define HORZ_SAMPLING_FACTOR        (2 << 4)
>> +#define VERT_SAMPLING_FACTOR_422    1
>> +#define VERT_SAMPLING_FACTOR_420    2
>> +#define COMPONENTS_IN_SCAN        3
>> +#define PELS_IN_BLOCK            64
>> +
>> +/* Used for Qp table generation */
>> +#define LUMINOSITY            10
>> +#define CONTRAST            1
>> +#define INCREASE            2
>> +#define QP_TABLE_SIZE            (8 * 8)
>> +#define QP_TABLE_FIELD_OFFSET        0x04
>> +
>> +/*
>> + * vb2 queue structure
>> + * contains queue data information
>> + *
>> + * @fmt: format info
>> + * @width: frame width
>> + * @height: frame height
>> + * @bytesperline: bytes per line in memory
>> + * @size_image: image size in memory
>> + */
>> +struct e5010_q_data {
>> +    struct e5010_fmt    *fmt;
>> +    u32            width;
>> +    u32            height;
>> +    u32            width_adjusted;
>> +    u32            height_adjusted;
>> +    u32            sizeimage[MAX_PLANES];
>> +    u32            bytesperline[MAX_PLANES];
>> +    bool            format_set;
>> +    bool            streaming;
>> +    u32            sequence;
>> +    struct v4l2_rect    crop;
>> +};
>> +
>> +/*
>> + * Driver device structure
>> + * Holds all memory handles and global parameters
>> + * Shared by all instances
>> + */
>> +struct e5010_dev {
>> +    struct device *dev;
>> +    struct v4l2_device    v4l2_dev;
>> +    struct v4l2_m2m_dev    *m2m_dev;
>> +    struct video_device    *vdev;
>> +    void __iomem        *core_base;
>> +    void __iomem        *mmu_base;
>> +    struct clk        *clk;
>> +    struct e5010_context    *last_context_run;
>> +    /* Protect access to device data */
>> +    struct mutex        mutex;
>> +    /* Protect access to hardware*/
>> +    spinlock_t        hw_lock;
>> +};
>> +
>> +/*
>> + * Driver context structure
>> + * One of these exists for every m2m context
>> + * Holds context specific data
>> + */
>> +struct e5010_context {
>> +    struct v4l2_fh            fh;
>> +    struct e5010_dev        *e5010;
>> +    struct e5010_q_data        out_queue;
>> +    struct e5010_q_data        cap_queue;
>> +    int                quality;
>> +    bool                update_qp;
>> +    struct v4l2_ctrl_handler    ctrl_handler;
>> +    u8                luma_qp[QP_TABLE_SIZE];
>> +    u8                chroma_qp[QP_TABLE_SIZE];
>> +};
>> +
>> +/*
>> + * Buffer structure
>> + * Contains info for all buffers
>> + */
>> +struct e5010_buffer {
>> +    struct v4l2_m2m_buffer buffer;
>> +};
>> +
>> +enum {
>> +    CHROMA_ORDER_CB_CR = 0, //UV ordering
>> +    CHROMA_ORDER_CR_CB = 1, //VU ordering
>> +};
>> +
>> +enum {
>> +    SUBSAMPLING_420 = 1,
>> +    SUBSAMPLING_422 = 2,
>> +};
>> +
>> +/*
>> + * e5010 format structure
>> + * contains format information
>> + */
>> +struct e5010_fmt {
>> +    u32                    fourcc;
>> +    unsigned int                num_planes;
>> +    unsigned int                type;
>> +    u32                    subsampling;
>> +    u32                    chroma_order;
>> +    const struct v4l2_frmsize_stepwise    frmsize;
>> +};
>> +
>> +/*
>> + * struct e5010_ctrl - contains info for each supported v4l2 control
>> + */
>> +struct e5010_ctrl {
>> +    unsigned int        cid;
>> +    enum v4l2_ctrl_type    type;
>> +    unsigned char        name[32];
>> +    int            minimum;
>> +    int            maximum;
>> +    int            step;
>> +    int            default_value;
>> +    unsigned char        compound;
>> +};
>> +
>> +#endif
>> diff --git a/drivers/media/platform/imagination/e5010-mmu-regs.h
>> b/drivers/media/platform/imagination/e5010-mmu-regs.h
>> new file mode 100644
>> index 000000000000..bfba06956cf2
>> --- /dev/null
>> +++ b/drivers/media/platform/imagination/e5010-mmu-regs.h
>> @@ -0,0 +1,311 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Imagination E5010 JPEG Encoder driver.
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *
>> + * Author: David Huang <d-huang@ti.com>
>> + * Author: Devarsh Thakkar <devarsht@ti.com>
>> + */
>> +
>> +#ifndef _E5010_MMU_REGS_H
>> +#define _E5010_MMU_REGS_H
>> +
>> +#define MMU_MMU_DIR_BASE_ADDR_OFFSET                    (0x0020)
>> +#define MMU_MMU_DIR_BASE_ADDR_STRIDE                    (4)
>> +#define MMU_MMU_DIR_BASE_ADDR_NO_ENTRIES                (4)
>> +
>> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_MASK            (0xFFFFFFFF)
>> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_SHIFT            (0)
>> +
>> +#define MMU_MMU_TILE_CFG_OFFSET                        (0x0040)
>> +#define MMU_MMU_TILE_CFG_STRIDE                        (4)
>> +#define MMU_MMU_TILE_CFG_NO_ENTRIES                    (4)
>> +
>> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_MASK            (0x00000010)
>> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_SHIFT            (4)
>> +
>> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_MASK                (0x00000008)
>> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_SHIFT                (3)
>> +
>> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_MASK                (0x00000007)
>> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_SHIFT                (0)
>> +
>> +#define MMU_MMU_TILE_MIN_ADDR_OFFSET                    (0x0050)
>> +#define MMU_MMU_TILE_MIN_ADDR_STRIDE                    (4)
>> +#define MMU_MMU_TILE_MIN_ADDR_NO_ENTRIES                (4)
>> +
>> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_MASK            (0xFFFFFFFF)
>> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_SHIFT            (0)
>> +
>> +#define MMU_MMU_TILE_MAX_ADDR_OFFSET                    (0x0060)
>> +#define MMU_MMU_TILE_MAX_ADDR_STRIDE                    (4)
>> +#define MMU_MMU_TILE_MAX_ADDR_NO_ENTRIES                (4)
>> +
>> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_MASK            (0xFFFFFFFF)
>> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_SHIFT            (0)
>> +
>> +#define MMU_MMU_CONTROL0_OFFSET                        (0x0000)
>> +
>> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_MASK                (0x00000001)
>> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_SHIFT            (0)
>> +
>> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_MASK                (0x00000100)
>> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_SHIFT                (8)
>> +
>> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_MASK           
>> (0x00000200)
>> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_SHIFT        (9)
>> +
>> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_MASK            (0x00001000)
>> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_SHIFT            (12)
>> +
>> +#define MMU_MMU_CONTROL1_OFFSET                        (0x0008)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_FLUSH_MASK                    (0x00000008)
>> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SHIFT                (3)
>> +#define MMU_MMU_CONTROL1_MMU_FLUSH_NO_REPS                (4)
>> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SIZE                    (1)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_INVALDC_MASK                (0x00000800)
>> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SHIFT                (11)
>> +#define MMU_MMU_CONTROL1_MMU_INVALDC_NO_REPS                (4)
>> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SIZE                (1)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_MASK                (0x00010000)
>> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_SHIFT                (16)
>> +
>> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_MASK            (0x00100000)
>> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_SHIFT            (20)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_MASK                (0x01000000)
>> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_SHIFT                (24)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_MASK                (0x02000000)
>> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_SHIFT                (25)
>> +
>> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK                (0x10000000)
>> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT                (28)
>> +
>> +#define MMU_MMU_BANK_INDEX_OFFSET                    (0x0010)
>> +
>> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_MASK                (0xC0000000)
>> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SHIFT                (30)
>> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_NO_REPS            (16)
>> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SIZE                (2)
>> +
>> +#define MMU_REQUEST_PRIORITY_ENABLE_OFFSET                (0x0018)
>> +
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_MASK       
>> (0x00008000)
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SHIFT        (15)
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_NO_REPS        (16)
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SIZE        (1)
>> +
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_MASK   
>> (0x00010000)
>> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_SHIFT    (16)
>> +
>> +#define MMU_REQUEST_LIMITED_THROUGHPUT_OFFSET                (0x001C)
>> +
>> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_MASK        (0x000003FF)
>> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_SHIFT        (0)
>> +
>> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_MASK           
>> (0x0FFF0000)
>> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_SHIFT        (16)
>> +
>> +#define MMU_MMU_ADDRESS_CONTROL_OFFSET                    (0x0070)
>> +#define MMU_MMU_ADDRESS_CONTROL_TRUSTED                    (IMG_TRUE)
>> +
>> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK                (0x00000001)
>> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT            (0)
>> +
>> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_MASK       
>> (0x00000010)
>> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_SHIFT        (4)
>> +
>> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_MASK        (0x00FF0000)
>> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_SHIFT        (16)
>> +
>> +#define MMU_MMU_CONFIG0_OFFSET                        (0x0080)
>> +
>> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_MASK                (0x0000000F)
>> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_SHIFT                (0)
>> +
>> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_MASK            (0x000000F0)
>> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_SHIFT            (4)
>> +
>> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_MASK            (0x00000700)
>> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_SHIFT            (8)
>> +
>> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_MASK            (0x00001000)
>> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_SHIFT            (12)
>> +
>> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_MASK                (0x00002000)
>> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_SHIFT                (13)
>> +
>> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_MASK            (0x001F0000)
>> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_SHIFT            (16)
>> +
>> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_MASK                (0x00200000)
>> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_SHIFT                (21)
>> +
>> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_MASK                (0xFFC00000)
>> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_SHIFT                (22)
>> +
>> +#define MMU_MMU_CONFIG1_OFFSET                        (0x0084)
>> +
>> +#define MMU_MMU_CONFIG1_PAGE_SIZE_MASK                    (0x0000000F)
>> +#define MMU_MMU_CONFIG1_PAGE_SIZE_SHIFT                    (0)
>> +
>> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_MASK                (0x0000FF00)
>> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_SHIFT            (8)
>> +
>> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_MASK                (0x001F0000)
>> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_SHIFT                (16)
>> +
>> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_MASK            (0x01000000)
>> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_SHIFT            (24)
>> +
>> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_MASK            (0x02000000)
>> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_SHIFT            (25)
>> +
>> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_MASK            (0x04000000)
>> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_SHIFT            (26)
>> +
>> +#define MMU_MMU_STATUS0_OFFSET                        (0x0088)
>> +
>> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_MASK                (0x00000001)
>> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_SHIFT                (0)
>> +
>> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_MASK                (0xFFFFF000)
>> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_SHIFT                (12)
>> +
>> +#define MMU_MMU_STATUS1_OFFSET                        (0x008C)
>> +
>> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_MASK                (0x0000FFFF)
>> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_SHIFT            (0)
>> +
>> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_MASK                (0x000F0000)
>> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_SHIFT                (16)
>> +
>> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_MASK                (0x03000000)
>> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_SHIFT                (24)
>> +
>> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_MASK                (0x10000000)
>> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_SHIFT                (28)
>> +
>> +#define MMU_MMU_MEM_REQ_OFFSET                        (0x0090)
>> +
>> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_MASK                (0x000003FF)
>> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_SHIFT                (0)
>> +
>> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_MASK                (0x00001000)
>> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_SHIFT                (12)
>> +
>> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_MASK                (0x00002000)
>> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_SHIFT                (13)
>> +
>> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_MASK            (0x00004000)
>> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_SHIFT            (14)
>> +
>> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_MASK                (0x80000000)
>> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SHIFT            (31)
>> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_NO_REPS            (16)
>> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SIZE                (1)
>> +
>> +#define MMU_MMU_FAULT_SELECT_OFFSET                    (0x00A0)
>> +
>> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_MASK            (0x0000000F)
>> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_SHIFT            (0)
>> +
>> +#define MMU_PROTOCOL_FAULT_OFFSET                    (0x00A8)
>> +
>> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_MASK            (0x00000001)
>> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_SHIFT            (0)
>> +
>> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_MASK                (0x00000010)
>> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_SHIFT                (4)
>> +
>> +#define MMU_PROTOCOL_FAULT_FAULT_READ_MASK                (0x00000020)
>> +#define MMU_PROTOCOL_FAULT_FAULT_READ_SHIFT                (5)
>> +
>> +#define MMU_TOTAL_READ_REQ_OFFSET                    (0x0100)
>> +
>> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_MASK                (0xFFFFFFFF)
>> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_SHIFT                (0)
>> +
>> +#define MMU_TOTAL_WRITE_REQ_OFFSET                    (0x0104)
>> +
>> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_MASK            (0xFFFFFFFF)
>> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_SHIFT            (0)
>> +
>> +#define MMU_READS_LESS_64_REQ_OFFSET                    (0x0108)
>> +
>> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_MASK            (0xFFFFFFFF)
>> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_SHIFT            (0)
>> +
>> +#define MMU_WRITES_LESS_64_REQ_OFFSET                    (0x010C)
>> +
>> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_MASK            (0xFFFFFFFF)
>> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_SHIFT            (0)
>> +
>> +#define MMU_EXT_CMD_STALL_OFFSET                    (0x0120)
>> +
>> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_MASK                (0xFFFFFFFF)
>> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_SHIFT                (0)
>> +
>> +#define MMU_WRITE_REQ_STALL_OFFSET                    (0x0124)
>> +
>> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_MASK            (0xFFFFFFFF)
>> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_SHIFT            (0)
>> +
>> +#define MMU_MMU_MISS_STALL_OFFSET                    (0x0128)
>> +
>> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_MASK                (0xFFFFFFFF)
>> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_SHIFT                (0)
>> +
>> +#define MMU_ADDRESS_STALL_OFFSET                    (0x012C)
>> +
>> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_MASK                (0xFFFFFFFF)
>> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_SHIFT                (0)
>> +
>> +#define MMU_TAG_STALL_OFFSET                        (0x0130)
>> +
>> +#define MMU_TAG_STALL_TAG_STALL_MASK                    (0xFFFFFFFF)
>> +#define MMU_TAG_STALL_TAG_STALL_SHIFT                    (0)
>> +
>> +#define MMU_PEAK_READ_OUTSTANDING_OFFSET                (0x0140)
>> +
>> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_MASK       
>> (0x000003FF)
>> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_SHIFT        (0)
>> +
>> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_MASK        (0xFFFF0000)
>> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_SHIFT        (16)
>> +
>> +#define MMU_AVERAGE_READ_LATENCY_OFFSET                    (0x0144)
>> +
>> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_MASK        (0xFFFFFFFF)
>> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_SHIFT        (0)
>> +
>> +#define MMU_STATISTICS_CONTROL_OFFSET                    (0x0160)
>> +
>> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_MASK        (0x00000001)
>> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_SHIFT        (0)
>> +
>> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_MASK            (0x00000002)
>> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_SHIFT            (1)
>> +
>> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_MASK            (0x00000004)
>> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_SHIFT            (2)
>> +
>> +#define MMU_MMU_VERSION_OFFSET                        (0x01D0)
>> +
>> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_MASK                (0x00FF0000)
>> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_SHIFT                (16)
>> +
>> +#define MMU_MMU_VERSION_MMU_MINOR_REV_MASK                (0x0000FF00)
>> +#define MMU_MMU_VERSION_MMU_MINOR_REV_SHIFT                (8)
>> +
>> +#define MMU_MMU_VERSION_MMU_MAINT_REV_MASK                (0x000000FF)
>> +#define MMU_MMU_VERSION_MMU_MAINT_REV_SHIFT                (0)
>> +
>> +#define MMU_BYTE_SIZE                            (0x01D4)
>> +
>> +#endif
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/4] media: imagination: Add E5010 JPEG Encoder driver
  2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
  2023-08-22 10:27   ` Andrzej Pietrasiewicz
@ 2023-09-06 12:38   ` Hans Verkuil
  1 sibling, 0 replies; 11+ messages in thread
From: Hans Verkuil @ 2023-09-06 12:38 UTC (permalink / raw)
  To: Devarsh Thakkar, mchehab, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, linux-media, devicetree, linux-kernel
  Cc: laurent.pinchart, eugen.hristev, ezequiel, u.kleine-koenig,
	sakari.ailus, praneeth, nm, vigneshr, a-bhatia1, j-luthra,
	b-brnich, detheridge, p-mantena, vijayp

On 16/08/2023 17:22, Devarsh Thakkar wrote:
> This adds support for stateful V4L2 M2M based driver
> for Imagination E5010 JPEG Encoder [1] which supports baseline
> encoding with two different quantization tables and compression
> ratio as demanded.
> 
> Support for both contiguous and non-contiguous YUV420 and YUV422
> semiplanar formats is added along with alignment restrictions
> as required by the hardware.
> 
> System and runtime PM hooks are added in the driver along with v4l2
> crop and selection API support.
> 
> Minimum resolution supported is 64x64 and
> Maximum resolution supported is 8192x8192.
> 
> All v4l2-compliance tests are passing [2] :
> v4l2-compliance -s -f -a  -d /dev/video0 -e /dev/video1
> 
> Total for e5010 device /dev/video0: 70, Succeeded: 70, Failed: 0,
> Warnings: 0
> NOTE: video1 here is VIVID test pattern generator
> 
> Also tests [3] were run manually to verify below driver features:
>  - Runtime Power Management
>  - Multi-instance JPEG Encoding
>  - DMABUF import, export support
>  - NV12, NV21, NV16, NV61 video format support
>  - Compression quality S_CTRL
> 
> Existing V4L2 M2M based JPEG drivers namely s5p-jpeg,
> imx-jpeg and rcar_jpu were referred while making this.
> 
> TODO:
> Add MMU and memory tiling support
> 
> [1]:  AM62A TRM (Section 7.6 is for JPEG Encoder)
> Link: https://www.ti.com/lit/pdf/spruj16
> 
> [2]: v4l2-compliance test :
> Link: https://gist.github.com/devarsht/17348fc509fe375a630a798196edbb73
> 
> [3]: E5010 JPEG Encoder Manual tests :
> 
> Performance:
> Link: https://gist.github.com/devarsht/ef5aba211aae45166681b8b4418d4e65
> 
> Functionality:
> Link: https://gist.github.com/devarsht/bfef1e3ead8e858b09cbf418aea753e8
> 
> Compression Quality:
> Link: https://gist.github.com/devarsht/345df9bf7157b4ca094293760e257451
> 
> Multi Instance:
> Link: https://gist.github.com/devarsht/4b4d734eeb9e0e616837c0836ddbc769
> 
> Co-developed-by: David Huang <d-huang@ti.com>
> Signed-off-by: David Huang <d-huang@ti.com>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> V2:
> No change
> 
> V3:
> - Correct license headers
> - Use more generic name core instead of jasper for base registers
> - Add Comment for forward declarations
> - Simplify quantization table calculations
> - Use v4l2_apply_frmsize_constraints for updating framesize and remove unrequired functions
> - Place TODO at top of file and in commit message too
> - Use dev_err_probe helper in probe function
> - Fix return value checking for failure scenarios in probe function
> - Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
> - Fix unexpected indentation
> - Correct commit message
> - Remove dependency on ARCH_K3 as driver is not specific to that
> 
>  MAINTAINERS                                   |    2 +
>  drivers/media/platform/Kconfig                |    1 +
>  drivers/media/platform/Makefile               |    1 +
>  drivers/media/platform/imagination/Kconfig    |   12 +
>  drivers/media/platform/imagination/Makefile   |    3 +
>  .../platform/imagination/e5010-core-regs.h    |  585 ++++++
>  .../platform/imagination/e5010-jpeg-enc-hw.c  |  320 ++++
>  .../platform/imagination/e5010-jpeg-enc-hw.h  |   42 +
>  .../platform/imagination/e5010-jpeg-enc.c     | 1678 +++++++++++++++++
>  .../platform/imagination/e5010-jpeg-enc.h     |  169 ++
>  .../platform/imagination/e5010-mmu-regs.h     |  311 +++
>  11 files changed, 3124 insertions(+)
>  create mode 100644 drivers/media/platform/imagination/Kconfig
>  create mode 100644 drivers/media/platform/imagination/Makefile
>  create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
>  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
>  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
>  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
>  create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
>  create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9425ecf45df6..725a280a521b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10208,8 +10208,10 @@ F:	drivers/auxdisplay/img-ascii-lcd.c
>  
>  IMGTEC JPEG ENCODER DRIVER
>  M:	Devarsh Thakkar <devarsht@ti.com>
> +L:	linux-media@vger.kernel.org
>  S:	Supported
>  F:	Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
> +F:	drivers/media/platform/imagination/e5010*
>  
>  IMGTEC IR DECODER DRIVER
>  S:	Orphan
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index ee579916f874..72b4bedd47fb 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -69,6 +69,7 @@ source "drivers/media/platform/aspeed/Kconfig"
>  source "drivers/media/platform/atmel/Kconfig"
>  source "drivers/media/platform/cadence/Kconfig"
>  source "drivers/media/platform/chips-media/Kconfig"
> +source "drivers/media/platform/imagination/Kconfig"
>  source "drivers/media/platform/intel/Kconfig"
>  source "drivers/media/platform/marvell/Kconfig"
>  source "drivers/media/platform/mediatek/Kconfig"
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index 5453bb868e67..96db57cc9412 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -12,6 +12,7 @@ obj-y += aspeed/
>  obj-y += atmel/
>  obj-y += cadence/
>  obj-y += chips-media/
> +obj-y += imagination/
>  obj-y += intel/
>  obj-y += marvell/
>  obj-y += mediatek/
> diff --git a/drivers/media/platform/imagination/Kconfig b/drivers/media/platform/imagination/Kconfig
> new file mode 100644
> index 000000000000..d8d79266ad5d
> --- /dev/null
> +++ b/drivers/media/platform/imagination/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config VIDEO_E5010_JPEG_ENC
> +	tristate "Imagination E5010 JPEG Encoder Driver"
> +	depends on VIDEO_DEV
> +	select VIDEOBUF2_DMA_CONTIG
> +	select VIDEOBUF2_VMALLOC
> +	select V4L2_MEM2MEM_DEV
> +	help
> +	  This is a video4linux2 M2M driver for Imagination E5010 JPEG encoder,
> +	  which supports JPEG and MJPEG baseline encoding of YUV422 and YUV420
> +	  semiplanar video formats, with resolution ranging from 64x64 to 8K x 8K
> +	  pixels. The module will be named as e5010_jpeg_enc.
> diff --git a/drivers/media/platform/imagination/Makefile b/drivers/media/platform/imagination/Makefile
> new file mode 100644
> index 000000000000..d45b85b88575
> --- /dev/null
> +++ b/drivers/media/platform/imagination/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +e5010_jpeg_enc-objs := e5010-jpeg-enc-hw.o e5010-jpeg-enc.o
> +obj-$(CONFIG_VIDEO_E5010_JPEG_ENC) += e5010_jpeg_enc.o
> diff --git a/drivers/media/platform/imagination/e5010-core-regs.h b/drivers/media/platform/imagination/e5010-core-regs.h
> new file mode 100644
> index 000000000000..aaec498fe83f
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-core-regs.h
> @@ -0,0 +1,585 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_CORE_REGS_H
> +#define _E5010_CORE_REGS_H
> +
> +#define JASPER_CORE_ID_OFFSET				(0x0000)
> +#define JASPER_CORE_ID_CR_GROUP_ID_MASK			(0xFF000000)
> +#define JASPER_CORE_ID_CR_GROUP_ID_SHIFT		(24)
> +#define JASPER_CORE_ID_CR_CORE_ID_MASK			(0x00FF0000)
> +#define JASPER_CORE_ID_CR_CORE_ID_SHIFT			(16)
> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_MASK		(0x0000FFF8)
> +#define JASPER_CORE_ID_CR_UNIQUE_NUM_SHIFT		(3)
> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_MASK		(0x00000007)
> +#define JASPER_CORE_ID_CR_PELS_PER_CYCLE_SHIFT		(0)
> +
> +#define JASPER_CORE_REV_OFFSET				(0x0004)
> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_MASK		(0xFF000000)
> +#define JASPER_CORE_REV_CR_JASPER_DESIGNER_SHIFT	(24)
> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_MASK	(0x00FF0000)
> +#define JASPER_CORE_REV_CR_JASPER_MAJOR_REV_SHIFT	(16)
> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_MASK	(0x0000FF00)
> +#define JASPER_CORE_REV_CR_JASPER_MINOR_REV_SHIFT	(8)
> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_MASK	(0x000000FF)
> +#define JASPER_CORE_REV_CR_JASPER_MAINT_REV_SHIFT	(0)
> +
> +#define JASPER_INTERRUPT_MASK_OFFSET					(0x0008)
> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK	(0x00000002)
> +#define JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT	(1)
> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT		(0)
> +
> +#define JASPER_INTERRUPT_STATUS_OFFSET					(0x000C)
> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK	(0x00000002)
> +#define JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_SHIFT	(1)
> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_SHIFT		(0)
> +
> +#define JASPER_INTERRUPT_CLEAR_OFFSET					(0x0010)
> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK		(0x00000002)
> +#define JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT		(1)
> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK		(0x00000001)
> +#define JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT		(0)
> +
> +#define JASPER_CLK_CONTROL_OFFSET				(0x0014)
> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK	(0x00000002)
> +#define JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT	(1)
> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK	(0x00000001)
> +#define JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT	(0)
> +
> +#define JASPER_CLK_STATUS_OFFSET			(0x0018)
> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_MASK	(0x00000001)
> +#define JASPER_CLK_STATUS_CR_JASPER_CLKG_STATUS_SHIFT	(0)
> +
> +#define JASPER_RESET_OFFSET			(0x001C)
> +#define JASPER_RESET_CR_SYS_RESET_MASK		(0x00000002)
> +#define JASPER_RESET_CR_SYS_RESET_SHIFT		(1)
> +#define JASPER_RESET_CR_CORE_RESET_MASK		(0x00000001)
> +#define JASPER_RESET_CR_CORE_RESET_SHIFT	(0)
> +
> +#define JASPER_CORE_CTRL_OFFSET				(0x0020)
> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK	(0x00000001)
> +#define JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT	(0)
> +
> +#define JASPER_STATUS_OFFSET				(0x0024)
> +#define JASPER_STATUS_CR_FLUSH_MODE_MASK		(0x00000002)
> +#define JASPER_STATUS_CR_FLUSH_MODE_SHIFT		(1)
> +#define JASPER_STATUS_CR_JASPER_BUSY_MASK		(0x00000001)
> +#define JASPER_STATUS_CR_JASPER_BUSY_SHIFT		(0)
> +
> +#define JASPER_CRC_CLEAR_OFFSET					(0x0028)
> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_MASK		(0x00000001)
> +#define JASPER_CRC_CLEAR_CR_FRONT_END_CRC_CLEAR_SHIFT		(0)
> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_MASK			(0x00000002)
> +#define JASPER_CRC_CLEAR_CR_DCT_CRC_CLEAR_SHIFT			(1)
> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_MASK			(0x00000004)
> +#define JASPER_CRC_CLEAR_CR_ZZ_CRC_CLEAR_SHIFT			(2)
> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_MASK		(0x00000008)
> +#define JASPER_CRC_CLEAR_CR_QUANT_CRC_CLEAR_SHIFT		(3)
> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_MASK	(0x00000010)
> +#define JASPER_CRC_CLEAR_CR_ENTROPY_ENCODER_CRC_CLEAR_SHIFT	(4)
> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_MASK	(0x00000020)
> +#define JASPER_CRC_CLEAR_CR_PACKING_BUFFER_CRC_CLEAR_SHIFT	(5)
> +
> +#define JASPER_INPUT_CTRL0_OFFSET			(0x002C)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK	(0x01000000)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT	(24)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK	(0x00030000)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT	(16)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK		(0x00000004)
> +#define JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT	(2)
> +
> +#define JASPER_INPUT_CTRL1_OFFSET			(0x0030)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK	(0x1FC00000)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT	(22)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK	(0x00001FC0)
> +#define JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT	(6)
> +
> +#define JASPER_MMU_CTRL_OFFSET				(0x0034)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_MASK	(0x00000002)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_SCHEME_SHIFT	(1)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_MASK	(0x00000001)
> +#define JASPER_MMU_CTRL_CR_JASPER_TILING_ENABLE_SHIFT	(0)
> +
> +#define JASPER_IMAGE_SIZE_OFFSET				(0x0038)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK		(0x1FFF0000)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT		(16)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK		(0x00001FFF)
> +#define JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT	(0)
> +
> +#define INPUT_LUMA_BASE_OFFSET				(0x003C)
> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK		(0xFFFFFFC0)
> +#define INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_SHIFT	(6)
> +
> +#define INPUT_CHROMA_BASE_OFFSET			(0x0040)
> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK	(0xFFFFFFC0)
> +#define INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_SHIFT	(6)
> +
> +#define JASPER_OUTPUT_BASE_OFFSET		(0x0044)
> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK	(0xFFFFFFFF)
> +#define JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT	(0)
> +
> +#define JASPER_OUTPUT_SIZE_OFFSET			(0x0048)
> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_MASK		(0xFFFFFFFF)
> +#define JASPER_OUTPUT_SIZE_CR_OUTPUT_SIZE_SHIFT		(0)
> +#define JASPER_OUTPUT_MAX_SIZE_OFFSET			(0x004C)
> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK	(0xFFFFFFFF)
> +#define JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET					(0x0050)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_03_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_02_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_01_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE0_CR_LUMA_QUANTIZATION_TABLE_00_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_OFFSET					(0x0054)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_07_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_06_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_05_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE1_CR_LUMA_QUANTIZATION_TABLE_04_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_OFFSET					(0x0058)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_13_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_12_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_11_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE2_CR_LUMA_QUANTIZATION_TABLE_10_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_OFFSET					(0x005C)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_17_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_16_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_15_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE3_CR_LUMA_QUANTIZATION_TABLE_14_SHIFT	(0)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_OFFSET					(0x0060)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_21_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE4_CR_LUMA_QUANTIZATION_TABLE_20_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_OFFSET					(0x0064)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_27_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_26_SHIFT	(16)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_25_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE5_CR_LUMA_QUANTIZATION_TABLE_24_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_OFFSET					(0x0068)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_33_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_32_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_31_SHIFT	(8)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE6_CR_LUMA_QUANTIZATION_TABLE_30_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_OFFSET					(0x006C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_37_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_36_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_35_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE7_CR_LUMA_QUANTIZATION_TABLE_34_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_OFFSET					(0x0070)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_43_SHIFT	(24)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_42_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_41_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE8_CR_LUMA_QUANTIZATION_TABLE_40_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_OFFSET					(0x0074)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_47_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_46_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_45_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE9_CR_LUMA_QUANTIZATION_TABLE_44_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_OFFSET					(0x0078)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_53_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_52_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_51_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE10_CR_LUMA_QUANTIZATION_TABLE_50_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_OFFSET					(0x007C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_57_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_56_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_55_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE11_CR_LUMA_QUANTIZATION_TABLE_54_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_OFFSET					(0x0080)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_63_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_62_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_61_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE12_CR_LUMA_QUANTIZATION_TABLE_60_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_OFFSET					(0x0084)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_67_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_66_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_65_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE13_CR_LUMA_QUANTIZATION_TABLE_64_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_OFFSET					(0x0088)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_73_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_72_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_71_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE14_CR_LUMA_QUANTIZATION_TABLE_70_SHIFT	(0)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_OFFSET					(0x008C)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_MASK	(0xFF000000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_77_SHIFT	(24)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_MASK	(0x00FF0000)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_76_SHIFT	(16)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_MASK	(0x0000FF00)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_75_SHIFT	(8)
> +
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_MASK	(0x000000FF)
> +#define JASPER_LUMA_QUANTIZATION_TABLE15_CR_LUMA_QUANTIZATION_TABLE_74_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET				(0x0090)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_03_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_02_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_01_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE0_CR_CHROMA_QUANTIZATION_TABLE_00_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_OFFSET					(0x0094)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_07_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_06_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_05_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE1_CR_CHROMA_QUANTIZATION_TABLE_04_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_OFFSET					(0x0098)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_13_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_12_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_11_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE2_CR_CHROMA_QUANTIZATION_TABLE_10_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_OFFSET					(0x009C)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_17_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_16_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_15_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE3_CR_CHROMA_QUANTIZATION_TABLE_14_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_OFFSET					(0x00A0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_23_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_22_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_21_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE4_CR_CHROMA_QUANTIZATION_TABLE_20_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_OFFSET					(0x00A4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_27_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_26_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_25_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE5_CR_CHROMA_QUANTIZATION_TABLE_24_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_OFFSET					(0x00A8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_33_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_32_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_31_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE6_CR_CHROMA_QUANTIZATION_TABLE_30_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_OFFSET					(0x00AC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_37_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_36_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_35_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE7_CR_CHROMA_QUANTIZATION_TABLE_34_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_OFFSET					(0x00B0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_43_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_42_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_41_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE8_CR_CHROMA_QUANTIZATION_TABLE_40_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_OFFSET					(0x00B4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_47_SHIFT		(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_46_SHIFT		(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_45_SHIFT		(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE9_CR_CHROMA_QUANTIZATION_TABLE_44_SHIFT		(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_OFFSET					(0x00B8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_53_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_52_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_51_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE10_CR_CHROMA_QUANTIZATION_TABLE_50_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_OFFSET					(0x00BC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_57_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_56_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_55_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE11_CR_CHROMA_QUANTIZATION_TABLE_54_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_OFFSET					(0x00C0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_63_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_62_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_61_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE12_CR_CHROMA_QUANTIZATION_TABLE_60_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_OFFSET					(0x00C4)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_67_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_66_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_65_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE13_CR_CHROMA_QUANTIZATION_TABLE_64_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_OFFSET					(0x00C8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_73_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_72_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_71_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE14_CR_CHROMA_QUANTIZATION_TABLE_70_SHIFT	(0)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_OFFSET					(0x00CC)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_MASK		(0xFF000000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_77_SHIFT	(24)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_MASK		(0x00FF0000)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_76_SHIFT	(16)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_MASK		(0x0000FF00)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_75_SHIFT	(8)
> +
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_MASK		(0x000000FF)
> +#define JASPER_CHROMA_QUANTIZATION_TABLE15_CR_CHROMA_QUANTIZATION_TABLE_74_SHIFT	(0)
> +
> +#define JASPER_CRC_CTRL_OFFSET				(0x00D0)
> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK		(0x00000001)
> +#define JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT		(0)
> +
> +#define JASPER_FRONT_END_CRC_OFFSET				(0x00D4)
> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_FRONT_END_CRC_CR_JASPER_FRONT_END_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_DCT_CRC_OFFSET				(0x00D8)
> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_DCT_CRC_CR_JASPER_DCT_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_ZZ_CRC_OFFSET				(0x00DC)
> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_MASK		(0xFFFFFFFF)
> +#define JASPER_ZZ_CRC_CR_JASPER_ZZ_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_QUANT_CRC_OFFSET				(0x00E0)
> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_QUANT_CRC_CR_JASPER_QUANT_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_ENTROPY_ENCODER_CRC_OFFSET				(0x00E4)
> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_MASK	(0xFFFFFFFF)
> +#define JASPER_ENTROPY_ENCODER_CRC_CR_JASPER_ENTROPY_CRC_OUT_SHIFT	(0)
> +
> +#define JASPER_PACKING_BUFFER_DATA_CRC_OFFSET						(0x00E8)
> +#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_MASK		(0xFFFFFFFF)
> +#define JASPER_PACKING_BUFFER_DATA_CRC_CR_JASPER_PACKING_DATA_CRC_OUT_SHIFT		(0)
> +
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_OFFSET						(0x00EC)
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_MASK		(0xFFFFFFFF)
> +#define JASPER_PACKING_BUFFER_ADDR_CRC_CR_JASPER_PACKING_ADDR_OUT_CRC_SHIFT		(0)
> +
> +#define JASPER_CORE_BYTE_SIZE	(0x00F0)
> +
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
> new file mode 100644
> index 000000000000..237339789407
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
> @@ -0,0 +1,320 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <linux/io.h>
> +#include <linux/iopoll.h>
> +#include <linux/dev_printk.h>
> +#include "e5010-jpeg-enc-hw.h"
> +
> +static void write_reg_field(void __iomem *base, unsigned int offset, u32 mask,
> +			    unsigned int shift, u32 value)
> +{
> +	u32 reg;
> +
> +	value <<= shift;
> +	if (mask != 0xffffffff) {
> +		reg = readl(base + offset);
> +		value = (value & mask) | (reg & ~mask);
> +	}
> +	writel(value, (base + offset));
> +}
> +
> +static int write_reg_field_not_busy(void __iomem *jasper_base, void __iomem *wr_base,
> +				    unsigned int offset, u32 mask, unsigned int shift,
> +				    u32 value)
> +{
> +	int ret;
> +	u32 val;
> +
> +	ret = readl_poll_timeout_atomic(jasper_base + JASPER_STATUS_OFFSET, val,
> +					(val & JASPER_STATUS_CR_JASPER_BUSY_MASK) == 0,
> +					2000, 50000);
> +	if (ret)
> +		return ret;
> +
> +	write_reg_field(wr_base, offset, mask, shift, value);
> +
> +	return 0;
> +}
> +
> +void e5010_reset(struct device *dev, void __iomem *core_base, void __iomem *mmu_base)
> +{
> +	int ret = 0;
> +	u32 val;
> +
> +	write_reg_field(core_base, JASPER_RESET_OFFSET,
> +			JASPER_RESET_CR_CORE_RESET_MASK,
> +			JASPER_RESET_CR_CORE_RESET_SHIFT, 1);
> +
> +	write_reg_field(mmu_base, MMU_MMU_CONTROL1_OFFSET,
> +			MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK,
> +			MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT, 1);
> +
> +	ret = readl_poll_timeout_atomic(mmu_base + MMU_MMU_CONTROL1_OFFSET, val,
> +					(val & MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK) == 0,
> +					2000, 50000);
> +	if (ret)
> +		dev_warn(dev, "MMU soft reset timed out, forcing system soft reset\n");
> +
> +	write_reg_field(core_base, JASPER_RESET_OFFSET,
> +			JASPER_RESET_CR_SYS_RESET_MASK,
> +			JASPER_RESET_CR_SYS_RESET_SHIFT, 1);
> +}
> +
> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable)
> +{
> +	/* Bypass MMU */
> +	write_reg_field(mmu_base,
> +			MMU_MMU_ADDRESS_CONTROL_OFFSET,
> +			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK,
> +			MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT,
> +			enable);
> +}
> +
> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INTERRUPT_MASK_OFFSET,
> +				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_MASK,
> +				       JASPER_INTERRUPT_MASK_CR_OUTPUT_ADDRESS_ERROR_ENABLE_SHIFT,
> +				       enable);
> +	return ret;

You can just do:

	return write_reg_field_not_busy(...

> +}
> +
> +bool e5010_hw_pic_done_irq(void __iomem *core_base)
> +{
> +	u32 reg;
> +	bool pic_done;
> +
> +	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
> +	pic_done = (reg & JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK) ? true : false;

This can just be:

	return reg & JASPER_INTERRUPT_STATUS_CR_PICTURE_DONE_IRQ_MASK;

> +
> +	return pic_done;
> +}
> +
> +bool e5010_hw_output_address_irq(void __iomem *core_base)
> +{
> +	u32 reg;
> +	bool output_address_error;
> +
> +	reg = readl(core_base + JASPER_INTERRUPT_STATUS_OFFSET);
> +	output_address_error = (reg & JASPER_INTERRUPT_STATUS_CR_OUTPUT_ADDRESS_ERROR_IRQ_MASK) ?
> +				true : false;
> +
> +	return output_address_error;

Same here.

> +}
> +
> +int e5010_hw_enable_picture_done_irq(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INTERRUPT_MASK_OFFSET,
> +				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_MASK,
> +				       JASPER_INTERRUPT_MASK_CR_PICTURE_DONE_ENABLE_SHIFT,
> +				       enable);

Just use return write_reg_field_not_busy(), same in the similar instances below.

> +	return ret;
> +}
> +
> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CLK_CONTROL_OFFSET,
> +				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_MASK,
> +				       JASPER_CLK_CONTROL_CR_JASPER_AUTO_CLKG_ENABLE_SHIFT,
> +				       enable);
> +	return ret;
> +}
> +
> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CLK_CONTROL_OFFSET,
> +				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_MASK,
> +				       JASPER_CLK_CONTROL_CR_JASPER_MAN_CLKG_ENABLE_SHIFT, 0);
> +	return ret;
> +}
> +
> +int e5010_hw_enable_crc_check(void __iomem *core_base, u32 enable)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_CRC_CTRL_OFFSET,
> +				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_MASK,
> +				       JASPER_CRC_CTRL_JASPER_CRC_ENABLE_SHIFT, enable);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_source_to_memory(void __iomem *core_base, u32 set)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SOURCE_SHIFT, set);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_luma_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       INPUT_LUMA_BASE_OFFSET,
> +				       INPUT_LUMA_BASE_CR_INPUT_LUMA_BASE_MASK, 0, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_chroma_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       INPUT_CHROMA_BASE_OFFSET,
> +				       INPUT_CHROMA_BASE_CR_INPUT_CHROMA_BASE_MASK, 0, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_output_base_addr(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_OUTPUT_BASE_OFFSET,
> +				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_MASK,
> +				       JASPER_OUTPUT_BASE_CR_OUTPUT_BASE_SHIFT, val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_horizontal_size(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_IMAGE_SIZE_OFFSET,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_MASK,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_HORIZONTAL_SIZE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_vertical_size(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_IMAGE_SIZE_OFFSET,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_MASK,
> +				       JASPER_IMAGE_SIZE_CR_IMAGE_VERTICAL_SIZE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_luma_stride(void __iomem *core_base, u32 bytesperline)
> +{
> +	int ret;
> +	u32 val = bytesperline / 64;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL1_OFFSET,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_MASK,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_LUMA_STRIDE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_chroma_stride(void __iomem *core_base, u32 bytesperline)
> +{
> +	int ret;
> +	u32 val = bytesperline / 64;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL1_OFFSET,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_MASK,
> +				       JASPER_INPUT_CTRL1_CR_INPUT_CHROMA_STRIDE_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_input_subsampling(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_SUBSAMPLING_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +int e5010_hw_set_chroma_order(void __iomem *core_base, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base,
> +				       JASPER_INPUT_CTRL0_OFFSET,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_MASK,
> +				       JASPER_INPUT_CTRL0_CR_INPUT_CHROMA_ORDER_SHIFT,
> +				       val);
> +	return ret;
> +}
> +
> +void e5010_hw_set_output_max_size(void __iomem *core_base, u32 val)
> +{
> +	write_reg_field(core_base, JASPER_OUTPUT_MAX_SIZE_OFFSET,
> +			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_MASK,
> +			JASPER_OUTPUT_MAX_SIZE_CR_OUTPUT_MAX_SIZE_SHIFT,
> +			val);
> +}
> +
> +int e5010_hw_set_qpvalue(void __iomem *core_base, u32 offset, u32 val)
> +{
> +	int ret;
> +
> +	ret = write_reg_field_not_busy(core_base, core_base, offset, 0xffffffff, 0, val);
> +	return ret;
> +}
> +
> +void e5010_hw_clear_output_error(void __iomem *core_base, u32 clear)
> +{
> +	/* Make sure interrupts are clear */
> +	write_reg_field(core_base, JASPER_INTERRUPT_CLEAR_OFFSET,
> +			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_MASK,
> +			JASPER_INTERRUPT_CLEAR_CR_OUTPUT_ERROR_CLEAR_SHIFT, clear);
> +}
> +
> +void e5010_hw_clear_picture_done(void __iomem *core_base, u32 clear)
> +{
> +	write_reg_field(core_base,
> +			JASPER_INTERRUPT_CLEAR_OFFSET,
> +			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_MASK,
> +			JASPER_INTERRUPT_CLEAR_CR_PICTURE_DONE_CLEAR_SHIFT, clear);
> +}
> +
> +int e5010_hw_get_output_size(void __iomem *core_base)
> +{
> +	return readl(core_base + JASPER_OUTPUT_SIZE_OFFSET);
> +}
> +
> +void e5010_hw_encode_start(void __iomem *core_base, u32 start)
> +{
> +	write_reg_field(core_base, JASPER_CORE_CTRL_OFFSET,
> +			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_MASK,
> +			JASPER_CORE_CTRL_CR_JASPER_ENCODE_START_SHIFT, start);
> +}
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
> new file mode 100644
> index 000000000000..781d353c3226
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_JPEG_ENC_HW_H
> +#define _E5010_JPEG_ENC_HW_H
> +
> +#include "e5010-core-regs.h"
> +#include "e5010-mmu-regs.h"
> +
> +int e5010_hw_enable_output_address_error_irq(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_picture_done_irq(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_auto_clock_gating(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_manual_clock_gating(void __iomem *core_offset, u32 enable);
> +int e5010_hw_enable_crc_check(void __iomem *core_offset, u32 enable);
> +int e5010_hw_set_input_source_to_memory(void __iomem *core_offset, u32 set);
> +int e5010_hw_set_input_luma_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_input_chroma_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_output_base_addr(void __iomem *core_offset, u32 val);
> +int e5010_hw_get_output_size(void __iomem *core_offset);
> +int e5010_hw_set_horizontal_size(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_vertical_size(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_luma_stride(void __iomem *core_offset, u32 bytesperline);
> +int e5010_hw_set_chroma_stride(void __iomem *core_offset, u32 bytesperline);
> +int e5010_hw_set_input_subsampling(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_chroma_order(void __iomem *core_offset, u32 val);
> +int e5010_hw_set_qpvalue(void __iomem *core_offset, u32 offset, u32 value);
> +void e5010_reset(struct device *dev, void __iomem *core_offset, void __iomem *mmu_offset);
> +void e5010_hw_set_output_max_size(void __iomem *core_offset, u32 val);
> +void e5010_hw_clear_picture_done(void __iomem *core_offset, u32 clear);
> +void e5010_hw_encode_start(void __iomem *core_offset, u32 start);
> +void e5010_hw_clear_output_error(void __iomem *core_offset, u32 clear);
> +void e5010_hw_bypass_mmu(void __iomem *mmu_base, u32 enable);
> +bool e5010_hw_pic_done_irq(void __iomem *core_base);
> +bool e5010_hw_output_address_irq(void __iomem *core_base);
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> new file mode 100644
> index 000000000000..bf40ba9014e1
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -0,0 +1,1678 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * TODO: Add MMU and memory tiling support
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/ioctl.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/err.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/interrupt.h>
> +#include <linux/clk.h>
> +#include <media/v4l2-common.h>
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-event.h>
> +#include <media/v4l2-ioctl.h>
> +#include <media/v4l2-mem2mem.h>
> +#include <media/videobuf2-v4l2.h>
> +#include <media/videobuf2-dma-contig.h>
> +#include "e5010-jpeg-enc.h"
> +#include "e5010-jpeg-enc-hw.h"
> +
> +/* forward declarations */
> +static const struct of_device_id e5010_of_match[];
> +
> +static const struct v4l2_file_operations e5010_fops;
> +
> +static const struct v4l2_ioctl_ops e5010_ioctl_ops;
> +
> +static const struct vb2_ops e5010_video_ops;
> +
> +static const struct v4l2_m2m_ops e5010_m2m_ops;
> +
> +static struct e5010_fmt e5010_formats[] = {
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV12,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV12M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV21,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV21M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_420,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV16,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV16M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CB_CR,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV61,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_NV61M,
> +		.num_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> +		.subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_422,
> +		.chroma_order = CHROMA_ORDER_CR_CB,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 64,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +	{
> +		.fourcc = V4L2_PIX_FMT_JPEG,
> +		.num_planes = 1,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.subsampling = 0,
> +		.chroma_order = 0,
> +		.frmsize = { MIN_DIMENSION, MAX_DIMENSION, 16,
> +			     MIN_DIMENSION, MAX_DIMENSION, 8 },
> +	},
> +};
> +
> +/* Luma and chroma qp table to acheive 50% compression quality
> + * This is as per example in Annex K.1 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 luma[64] = {
> +	16, 11, 10, 16, 24, 40, 51, 61,
> +	12, 12, 14, 19, 26, 58, 60, 55,
> +	14, 13, 16, 24, 40, 57, 69, 56,
> +	14, 17, 22, 29, 51, 87, 80, 62,
> +	18, 22, 37, 56, 68, 109, 103, 77,
> +	24, 35, 55, 64, 81, 104, 113, 92,
> +	49, 64, 78, 87, 103, 121, 120, 101,
> +	72, 92, 95, 98, 112, 100, 103, 99
> +};
> +
> +static const u8 chroma[64] = {
> +	17, 18, 24, 47, 99, 99, 99, 99,
> +	18, 21, 26, 66, 99, 99, 99, 99,
> +	24, 26, 56, 99, 99, 99, 99, 99,
> +	47, 66, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99,
> +	99, 99, 99, 99, 99, 99, 99, 99
> +};
> +
> +/* Zigzag scan pattern */
> +static const u8 zigzag[64] = {
> +	0,   1,  8, 16,  9,  2,  3, 10,
> +	17, 24, 32, 25, 18, 11,  4,  5,
> +	12, 19, 26, 33, 40, 48, 41, 34,
> +	27, 20, 13,  6,  7, 14, 21, 28,
> +	35, 42, 49, 56, 57, 50, 43, 36,
> +	29, 22, 15, 23, 30, 37, 44, 51,
> +	58, 59, 52, 45, 38, 31, 39, 46,
> +	53, 60, 61, 54, 47, 55, 62, 63
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the luminance DC coefficient differences.
> + * The table represents Table K.3 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_luma_dc[] = {
> +	0x00, 0x00, 0x01, 0x05, 0x01, 0x01, 0x01, 0x01, 0x01,
> +	0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the luminance AC coefficients.
> + * The table represents Table K.5 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_luma_ac[] = {
> +	0x10, 0x00, 0x02, 0x01, 0x03, 0x03, 0x02, 0x04, 0x03,
> +	0x05, 0x05, 0x04, 0x04, 0x00, 0x00, 0x01, 0x7D,
> +	0x01, 0x02, 0x03, 0x00, 0x04, 0x11, 0x05, 0x12, 0x21, 0x31, 0x41, 0x06, 0x13, 0x51, 0x61,
> +	0x07, 0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xA1, 0x08, 0x23, 0x42, 0xB1, 0xC1, 0x15, 0x52,
> +	0xD1, 0xF0, 0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0A, 0x16, 0x17, 0x18, 0x19, 0x1A, 0x25,
> +	0x26, 0x27, 0x28, 0x29, 0x2A, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44, 0x45,
> +	0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63, 0x64,
> +	0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A, 0x83,
> +	0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99,
> +	0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4, 0xB5, 0xB6,
> +	0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA, 0xD2, 0xD3,
> +	0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE1, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7, 0xE8,
> +	0xE9, 0xEA, 0xF1, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the chrominance DC coefficient differences.
> + * The table represents Table K.4 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_chroma_dc[] = {
> +	0x01, 0x00, 0x03, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
> +	0x01, 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B
> +};
> +
> +/*
> + * Contains the data that needs to be sent in the marker segment of an interchange format JPEG
> + * stream or an abbreviated format table specification data stream.
> + * Specifies the huffman table used for encoding the chrominance AC coefficients.
> + * The table represents Table K.6 of IS0/IEC 10918-1:1994(E)
> + */
> +static const u8 marker_chroma_ac[] = {
> +	0x11, 0x00, 0x02, 0x01, 0x02, 0x04, 0x04, 0x03, 0x04,
> +	0x07, 0x05, 0x04, 0x04, 0x00, 0x01, 0x02, 0x77,
> +	0x00, 0x01, 0x02, 0x03, 0x11, 0x04, 0x05, 0x21, 0x31, 0x06, 0x12, 0x41, 0x51, 0x07, 0x61,
> +	0x71, 0x13, 0x22, 0x32, 0x81, 0x08, 0x14, 0x42, 0x91, 0xA1, 0xB1, 0xC1, 0x09, 0x23, 0x33,
> +	0x52, 0xF0, 0x15, 0x62, 0x72, 0xD1, 0x0A, 0x16, 0x24, 0x34, 0xE1, 0x25, 0xF1, 0x17, 0x18,
> +	0x19, 0x1A, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x43, 0x44,
> +	0x45, 0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63,
> +	0x64, 0x65, 0x66, 0x67, 0x68, 0x69, 0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A,
> +	0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97,
> +	0x98, 0x99, 0x9A, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4,
> +	0xB5, 0xB6, 0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA,
> +	0xD2, 0xD3, 0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE2, 0xE3, 0xE4, 0xE5, 0xE6, 0xE7,
> +	0xE8, 0xE9, 0xEA, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6, 0xF7, 0xF8, 0xF9, 0xFA
> +};
> +
> +static unsigned int debug;
> +module_param(debug, uint, 0644);
> +MODULE_PARM_DESC(debug, "debug level");
> +
> +#define dprintk(dev, lvl, fmt, arg...) \
> +	v4l2_dbg(lvl, debug, &(dev)->v4l2_dev, "%s: " fmt, __func__, ## arg)
> +
> +static const struct v4l2_event e5010_eos_event = {
> +	.type = V4L2_EVENT_EOS
> +};
> +
> +static const char *type_name(enum v4l2_buf_type type)
> +{
> +	switch (type) {
> +	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> +		return "Output";
> +	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
> +		return "Capture";
> +	default:
> +		return "Invalid";
> +	}
> +}
> +
> +static struct e5010_q_data *get_queue(struct e5010_context *ctx, enum v4l2_buf_type type)
> +{
> +	switch (type) {
> +	case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> +		return &ctx->out_queue;
> +	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
> +		return &ctx->cap_queue;
> +	default:
> +		return ERR_PTR(-EINVAL);
> +	}
> +
> +	return ERR_PTR(-EINVAL);

I haven't read through the whole patch yet, but almost certainly get_queue is
only ever called with V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE or V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE.

So just simplify this:

	if (type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
		return &ctx->out_queue;
	return &ctx->cap_queue;

Then the caller doesn't need to do any error checking, thus simplifying
the code further.

> +}
> +
> +static void calculate_qp_tables(struct e5010_context *ctx)
> +{
> +	long long luminosity, contrast;
> +	int quality, i;
> +
> +	quality = 50 - ctx->quality;
> +
> +	luminosity = LUMINOSITY * quality / 50;
> +	contrast = CONTRAST * quality / 50;
> +
> +	if (quality > 0) {
> +		luminosity *= INCREASE;
> +		contrast *= INCREASE;
> +	}
> +
> +	for (i = 0; i < 64; i++) {
> +		long long delta = chroma[i] * contrast + luminosity;
> +		int val = (int)(chroma[i] + delta);
> +
> +		clamp(val, 1, 255);
> +		ctx->chroma_qp[i] = quality == -50 ? 1 : val;
> +
> +		delta = luma[i] * contrast + luminosity;
> +		val = (int)(luma[i] + delta);
> +		clamp(val, 1, 255);
> +		ctx->luma_qp[i] = quality == -50 ? 1 : val;
> +	}
> +
> +	ctx->update_qp = true;
> +}
> +
> +static int update_qp_tables(struct e5010_context *ctx)
> +{
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	int i, ret = 0;
> +	u32 lvalue, cvalue;
> +
> +	lvalue = 0;
> +	cvalue = 0;
> +
> +	for (i = 0; i < QP_TABLE_SIZE; i++) {
> +		lvalue |= ctx->luma_qp[i] << (8 * (i % 4));
> +		cvalue |= ctx->chroma_qp[i] << (8 * (i % 4));
> +		if (i % 4 == 3) {
> +			ret |= e5010_hw_set_qpvalue(e5010->core_base,
> +							JASPER_LUMA_QUANTIZATION_TABLE0_OFFSET
> +							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
> +							lvalue);
> +			ret |= e5010_hw_set_qpvalue(e5010->core_base,
> +							JASPER_CHROMA_QUANTIZATION_TABLE0_OFFSET
> +							+ QP_TABLE_FIELD_OFFSET * ((i - 3) / 4),
> +							cvalue);
> +			lvalue = 0;
> +			cvalue = 0;
> +		}
> +	}
> +
> +	return ret;
> +}
> +
> +static int e5010_set_input_subsampling(void __iomem *core_base, int subsampling)
> +{
> +	switch (subsampling) {
> +	case V4L2_JPEG_CHROMA_SUBSAMPLING_420:
> +		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_420);
> +	case V4L2_JPEG_CHROMA_SUBSAMPLING_422:
> +		return e5010_hw_set_input_subsampling(core_base, SUBSAMPLING_422);
> +	default:
> +		return -EINVAL;
> +	};
> +}
> +
> +static int e5010_querycap(struct file *file, void *priv, struct v4l2_capability *cap)
> +{
> +	strscpy(cap->driver, E5010_MODULE_NAME, sizeof(cap->driver));
> +	strscpy(cap->card, E5010_MODULE_NAME, sizeof(cap->card));
> +	snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", E5010_MODULE_NAME);

bus_info is filled in automatically for platform devices, just drop this.

> +	cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING;
> +	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;

No need for these two lines, the v4l2 framework will use device_caps in struct video_device
to fill this in automatically.

> +
> +	return 0;
> +}
> +
> +static struct e5010_fmt *find_format(struct v4l2_format *f)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
> +		if (e5010_formats[i].fourcc == f->fmt.pix_mp.pixelformat &&
> +		    e5010_formats[i].type == f->type)
> +			return &e5010_formats[i];
> +	}
> +
> +	return NULL;
> +}
> +
> +static int e5010_enum_fmt(struct file *file, void *priv, struct v4l2_fmtdesc *f)
> +{
> +	int i, index = 0;
> +	struct e5010_fmt *fmt = NULL;
> +	struct e5010_context *ctx = file->private_data;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "ENUMFMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	for (i = 0; i < ARRAY_SIZE(e5010_formats); ++i) {
> +		if (e5010_formats[i].type == f->type) {
> +			if (index == f->index) {
> +				fmt = &e5010_formats[i];
> +				break;
> +			}
> +			index++;
> +		}
> +	}
> +
> +	if (!fmt)
> +		return -EINVAL;
> +
> +	f->pixelformat = fmt->fourcc;
> +	return 0;
> +}
> +
> +static int e5010_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +	int i;
> +	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {

This can't happen.

> +		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	queue = get_queue(ctx, f->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);

No need for error checks.

> +
> +	pix_mp->flags = 0;
> +	pix_mp->field = V4L2_FIELD_NONE;
> +	pix_mp->pixelformat = queue->fmt->fourcc;
> +	pix_mp->width = queue->width_adjusted;
> +	pix_mp->height = queue->height_adjusted;
> +	pix_mp->num_planes = queue->fmt->num_planes;
> +
> +	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
> +		if (!pix_mp->colorspace)
> +			pix_mp->colorspace = V4L2_COLORSPACE_SRGB;
> +
> +		for (i = 0; i < queue->fmt->num_planes; i++) {
> +			plane_fmt[i].sizeimage = queue->sizeimage[i];
> +			plane_fmt[i].bytesperline = queue->bytesperline[i];
> +		}
> +
> +	} else {
> +		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		plane_fmt[0].bytesperline = 0;
> +		plane_fmt[0].sizeimage = queue->sizeimage[0];
> +	}
> +	pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +	pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +	pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +
> +	return 0;
> +}
> +
> +static int e5010_jpeg_try_fmt(struct v4l2_format *f, struct e5010_context *ctx)
> +{
> +	struct e5010_fmt *fmt;
> +	struct e5010_q_data *queue;
> +	int i;
> +	struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(f->type)) {

This can't happen.

> +		v4l2_err(&ctx->e5010->v4l2_dev, "G_FMT with Invalid type: %d\n", f->type);
> +		return -EINVAL;
> +	}
> +
> +	fmt = find_format(f);
> +	if (!fmt) {
> +		if (V4L2_TYPE_IS_OUTPUT(f->type))
> +			pix_mp->pixelformat = V4L2_PIX_FMT_NV12;
> +		else
> +			pix_mp->pixelformat = V4L2_PIX_FMT_JPEG;
> +		fmt = find_format(f);
> +		if (!fmt)
> +			return -EINVAL;
> +	}
> +
> +	queue = get_queue(ctx, f->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	queue->fmt = fmt;
> +	queue->width = pix_mp->width;
> +	queue->height = pix_mp->height;

Hmm, this looks very much like the VIDIOC_TRY_FMT is actually updating
real values, instead of just 'trying' them.

I think this belongs in s_fmt below. Same for the other changes to
queue in this function.

> +
> +	if (V4L2_TYPE_IS_OUTPUT(f->type)) {
> +		if (!pix_mp->colorspace)
> +			pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		if (!pix_mp->ycbcr_enc)
> +			pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +		if (!pix_mp->quantization)
> +			pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +		if (!pix_mp->xfer_func)
> +			pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +
> +		v4l2_apply_frmsize_constraints(&pix_mp->width,
> +					       &pix_mp->height,
> +					       &fmt->frmsize);
> +
> +		v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
> +				    pix_mp->width, pix_mp->height);
> +
> +		for (i = 0; i < fmt->num_planes; i++) {
> +			queue->bytesperline[i] = plane_fmt[i].bytesperline;
> +			queue->sizeimage[i] = plane_fmt[i].sizeimage;
> +		}
> +	} else {
> +		pix_mp->colorspace = V4L2_COLORSPACE_JPEG;
> +		pix_mp->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +		pix_mp->quantization = V4L2_QUANTIZATION_DEFAULT;
> +		pix_mp->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +		memset(plane_fmt[0].reserved, 0, sizeof(plane_fmt[0].reserved));

No need for this, done by the v4l2 framework.

> +		v4l2_apply_frmsize_constraints(&pix_mp->width,
> +					       &pix_mp->height,
> +					       &fmt->frmsize);
> +		queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
> +		queue->sizeimage[0] += HEADER_SIZE;
> +		queue->sizeimage[1] = 0;
> +		queue->bytesperline[0] = 0;
> +		queue->bytesperline[1] = 0;
> +		plane_fmt[0].sizeimage = queue->sizeimage[0];
> +		plane_fmt[0].bytesperline = 0;
> +	}
> +	pix_mp->flags = 0;
> +	pix_mp->field = V4L2_FIELD_NONE;
> +	pix_mp->pixelformat = fmt->fourcc;
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +	pix_mp->num_planes = fmt->num_planes;
> +	memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));

Ditto.

> +
> +	dprintk(ctx->e5010, 2,
> +		"ctx: 0x%p: format type %s:, wxh: %dx%d (plane0 : %d bytes, plane1 : %d bytes),fmt: %c%c%c%c\n",
> +		ctx, type_name(f->type), queue->width_adjusted, queue->height_adjusted,
> +		queue->sizeimage[0], queue->sizeimage[1],
> +		(queue->fmt->fourcc & 0xff),
> +		(queue->fmt->fourcc >>  8) & 0xff,
> +		(queue->fmt->fourcc >> 16) & 0xff,
> +		(queue->fmt->fourcc >> 24) & 0xff);
> +
> +	return 0;
> +}
> +
> +static int e5010_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +
> +	return e5010_jpeg_try_fmt(f, ctx);
> +}
> +
> +static int e5010_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct vb2_queue *vq;
> +
> +	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
> +	if (!vq)
> +		return -EINVAL;
> +
> +	if (vb2_is_busy(vq)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "queue busy\n");
> +		return -EBUSY;
> +	}
> +
> +	return e5010_jpeg_try_fmt(f, ctx);

And here is where the actualy updates to e5010_q_data should take place, I think.
It certainly does not make sense that s_fmt is just the same as try_fmt. That
can really only happen if there is just a single hardcoded format, and that isn't
the case here.

> +}
> +
> +static int e5010_enum_framesizes(struct file *file, void *priv, struct v4l2_frmsizeenum *fsize)
> +{
> +	struct v4l2_format f;
> +	struct e5010_fmt *fmt;
> +
> +	if (fsize->index != 0)
> +		return -EINVAL;
> +
> +	f.fmt.pix_mp.pixelformat = fsize->pixel_format;
> +	if (f.fmt.pix_mp.pixelformat ==  V4L2_PIX_FMT_JPEG)
> +		f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	else
> +		f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +
> +	fmt = find_format(&f);
> +	if (!fmt)
> +		return -EINVAL;
> +
> +	fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> +	fsize->stepwise = fmt->frmsize;
> +	fsize->reserved[0] = 0;
> +	fsize->reserved[1] = 0;
> +
> +	return 0;
> +}
> +
> +static int e5010_g_selection(struct file *file, void *fh, struct v4l2_selection *s)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +
> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> +		return -EINVAL;
> +
> +	queue = get_queue(ctx, s->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	switch (s->target) {
> +	case V4L2_SEL_TGT_CROP_DEFAULT:
> +	case V4L2_SEL_TGT_CROP_BOUNDS:
> +		s->r.left = 0;
> +		s->r.top = 0;
> +		s->r.width = queue->width;
> +		s->r.height = queue->height;
> +		break;
> +	case V4L2_SEL_TGT_CROP:
> +		s->r = queue->crop;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	struct e5010_q_data *queue;
> +
> +	if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> +		return -EINVAL;
> +
> +	queue = get_queue(ctx, s->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	queue->crop.left = 0;
> +	queue->crop.top = 0;
> +	queue->crop.width = s->r.width;
> +	queue->crop.height = s->r.height;
> +
> +	return 0;
> +}
> +
> +static int e5010_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subscription *sub)
> +{
> +	switch (sub->type) {
> +	case V4L2_EVENT_EOS:
> +		return v4l2_event_subscribe(fh, sub, 0, NULL);
> +	case V4L2_EVENT_CTRL:
> +		return v4l2_ctrl_subscribe_event(fh, sub);
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
> +{
> +	struct e5010_context *ctx = priv;
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	int ret = 0;
> +
> +	/* src_vq */
> +	memset(src_vq, 0, sizeof(*src_vq));
> +	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;

Why is this needed? Either drop this or comment on why this is needed.

> +	src_vq->io_modes = VB2_MMAP | VB2_DMABUF;
> +	src_vq->drv_priv = ctx;
> +	src_vq->buf_struct_size = sizeof(struct e5010_buffer);
> +	src_vq->ops = &e5010_video_ops;
> +	src_vq->mem_ops = &vb2_dma_contig_memops;

This should already ensure contiguous buffers.

> +	src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +	src_vq->lock = &e5010->mutex;
> +	src_vq->dev = e5010->v4l2_dev.dev;
> +
> +	ret = vb2_queue_init(src_vq);
> +	if (ret)
> +		return ret;
> +
> +	/* dst_vq */
> +	memset(dst_vq, 0, sizeof(*dst_vq));
> +	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	src_vq->dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
> +	dst_vq->io_modes = VB2_MMAP | VB2_DMABUF;
> +	dst_vq->drv_priv = ctx;
> +	dst_vq->buf_struct_size = sizeof(struct e5010_buffer);
> +	dst_vq->ops = &e5010_video_ops;
> +	dst_vq->mem_ops = &vb2_dma_contig_memops;
> +	dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +	dst_vq->lock = &e5010->mutex;
> +	dst_vq->dev = e5010->v4l2_dev.dev;
> +
> +	ret = vb2_queue_init(dst_vq);
> +	if (ret) {
> +		vb2_queue_release(src_vq);
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_s_ctrl(struct v4l2_ctrl *ctrl)
> +{
> +	struct e5010_context *ctx =
> +		container_of(ctrl->handler, struct e5010_context, ctrl_handler);
> +
> +	switch (ctrl->id) {
> +	case V4L2_CID_JPEG_COMPRESSION_QUALITY:
> +		ctx->quality = ctrl->val;
> +		calculate_qp_tables(ctx);
> +		break;
> +	default:
> +		v4l2_err(&ctx->e5010->v4l2_dev, "Invalid control, id = %d, val = %d\n",
> +			 ctrl->id, ctrl->val);

This really can't happen, so I'd just drop this error message.

> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct v4l2_ctrl_ops e5010_ctrl_ops = {
> +	.s_ctrl = e5010_s_ctrl,
> +};
> +
> +static void e5010_encode_ctrls(struct e5010_context *ctx)
> +{
> +	v4l2_ctrl_new_std(&ctx->ctrl_handler, &e5010_ctrl_ops,
> +			  V4L2_CID_JPEG_COMPRESSION_QUALITY, 1, 100, 1, 75);
> +}
> +
> +static int e5010_ctrls_setup(struct e5010_context *ctx)
> +{
> +	int err;
> +
> +	v4l2_ctrl_handler_init(&ctx->ctrl_handler, 1);
> +
> +	e5010_encode_ctrls(ctx);
> +
> +	if (ctx->ctrl_handler.error) {
> +		err = ctx->ctrl_handler.error;
> +		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +
> +		return err;
> +	}
> +
> +	err = v4l2_ctrl_handler_setup(&ctx->ctrl_handler);
> +	if (err)
> +		v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +
> +	return err;
> +}
> +
> +static void e5010_jpeg_set_default_params(struct e5010_context *ctx)
> +{
> +	struct e5010_q_data *queue;
> +	struct v4l2_format f;
> +	struct e5010_fmt *fmt;
> +	struct v4l2_pix_format_mplane *pix_mp = &f.fmt.pix_mp;
> +	struct v4l2_plane_pix_format *plane_fmt = pix_mp->plane_fmt;
> +	int i = 0;
> +
> +	f.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> +	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_NV12;
> +	fmt = find_format(&f);
> +	queue = &ctx->out_queue;
> +	queue->fmt = fmt;
> +	queue->width = DEFAULT_WIDTH;
> +	queue->height = DEFAULT_HEIGHT;
> +	v4l2_apply_frmsize_constraints(&pix_mp->width,
> +				       &pix_mp->height,
> +				       &fmt->frmsize);
> +	v4l2_fill_pixfmt_mp(pix_mp, pix_mp->pixelformat,
> +			    pix_mp->width, pix_mp->height);
> +	for (i = 0; i < fmt->num_planes; i++) {
> +		queue->bytesperline[i] = plane_fmt[i].bytesperline;
> +		queue->sizeimage[i] = plane_fmt[i].sizeimage;
> +	}
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +	queue->format_set = false;
> +	queue->streaming = false;
> +
> +	f.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> +	f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_JPEG;
> +	fmt = find_format(&f);
> +	queue = &ctx->cap_queue;
> +	queue->fmt = fmt;
> +	queue->width = DEFAULT_WIDTH;
> +	queue->height = DEFAULT_HEIGHT;
> +	v4l2_apply_frmsize_constraints(&pix_mp->width,
> +				       &pix_mp->height,
> +				       &fmt->frmsize);
> +	queue->sizeimage[0] = pix_mp->width * pix_mp->height * JPEG_MAX_BYTES_PER_PIXEL;
> +	queue->sizeimage[0] += HEADER_SIZE;
> +	queue->sizeimage[1] = 0;
> +	queue->bytesperline[0] = 0;
> +	queue->bytesperline[1] = 0;
> +	queue->format_set = false;
> +	queue->streaming = false;
> +	queue->width_adjusted = pix_mp->width;
> +	queue->height_adjusted = pix_mp->height;
> +}
> +
> +static int e5010_open(struct file *file)
> +{
> +	struct e5010_dev *e5010 = video_drvdata(file);
> +	struct video_device *vdev = video_devdata(file);
> +	struct e5010_context *ctx;
> +	int ret = 0;
> +
> +	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return -ENOMEM;
> +
> +	if (mutex_lock_interruptible(&e5010->mutex)) {
> +		ret = -ERESTARTSYS;
> +		goto free;
> +	}
> +
> +	v4l2_fh_init(&ctx->fh, vdev);
> +	file->private_data = ctx;
> +	v4l2_fh_add(&ctx->fh);
> +
> +	ctx->e5010 = e5010;
> +	ctx->fh.m2m_ctx = v4l2_m2m_ctx_init(e5010->m2m_dev, ctx, queue_init);
> +	if (IS_ERR(ctx->fh.m2m_ctx)) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to init m2m ctx\n");
> +		ret = PTR_ERR(ctx->fh.m2m_ctx);
> +		goto exit;
> +	}
> +
> +	ret = e5010_ctrls_setup(ctx);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to setup e5010 jpeg controls\n");
> +		goto err_ctrls_setup;
> +	}
> +	ctx->fh.ctrl_handler = &ctx->ctrl_handler;
> +
> +	e5010_jpeg_set_default_params(ctx);
> +
> +	dprintk(e5010, 1, "Created instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
> +
> +	mutex_unlock(&e5010->mutex);
> +	return 0;
> +
> +err_ctrls_setup:
> +	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
> +exit:
> +	v4l2_fh_del(&ctx->fh);
> +	v4l2_fh_exit(&ctx->fh);
> +	mutex_unlock(&e5010->mutex);
> +free:
> +	kfree(ctx);
> +	return ret;
> +}
> +
> +static int e5010_release(struct file *file)
> +{
> +	struct e5010_dev *e5010 = video_drvdata(file);
> +	struct e5010_context *ctx = file->private_data;
> +
> +	dprintk(e5010, 1, "Releasing instance: 0x%p, m2m_ctx: 0x%p\n", ctx, ctx->fh.m2m_ctx);
> +	mutex_lock(&e5010->mutex);
> +	v4l2_ctrl_handler_free(&ctx->ctrl_handler);
> +	v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
> +	v4l2_fh_del(&ctx->fh);
> +	v4l2_fh_exit(&ctx->fh);
> +	kfree(ctx);
> +	mutex_unlock(&e5010->mutex);
> +
> +	return 0;
> +}
> +
> +static struct video_device e5010_videodev = {
> +	.name = E5010_MODULE_NAME,
> +	.fops = &e5010_fops,
> +	.ioctl_ops = &e5010_ioctl_ops,
> +	.minor = -1,
> +	.release = video_device_release_empty,
> +	.vfl_dir = VFL_DIR_M2M,
> +	.device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING,
> +};
> +
> +static void header_write(struct e5010_context *ctx, u8 *addr, unsigned int *offset,
> +			 unsigned int no_bytes, unsigned long bits)
> +{
> +	u8 *w_addr = addr + *offset;
> +	int i;
> +
> +	if ((*offset + no_bytes) > HEADER_SIZE) {
> +		v4l2_warn(&ctx->e5010->v4l2_dev, "%s: %s: %d: Problem writing header. %d > HEADER_SIZE %d\n",
> +			  __FILE__, __func__, __LINE__, *offset + no_bytes, HEADER_SIZE);
> +		return;
> +	}
> +
> +	for (i = no_bytes - 1; i >= 0; i--)
> +		*(w_addr++) = ((u8 *)&bits)[i];
> +
> +	*offset += no_bytes;
> +}
> +
> +static void encode_marker_segment(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +	int i;
> +
> +	header_write(ctx, buffer, offset, 2, START_OF_IMAGE);
> +	header_write(ctx, buffer, offset, 2, DQT_MARKER);
> +	header_write(ctx, buffer, offset, 3, LQPQ << 4);
> +	for (i = 0; i < PELS_IN_BLOCK; i++)
> +		header_write(ctx, buffer, offset, 1, ctx->luma_qp[zigzag[i]]);
> +
> +	header_write(ctx, buffer, offset, 2, DQT_MARKER);
> +	header_write(ctx, buffer, offset, 3, (LQPQ << 4) | 1);
> +	for (i = 0; i < PELS_IN_BLOCK; i++)
> +		header_write(ctx, buffer, offset, 1, ctx->chroma_qp[zigzag[i]]);
> +
> +	/* Huffman tables */
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_DC);
> +	for (i = 0 ; i < (LH_DC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_luma_dc[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_AC);
> +	for (i = 0 ; i < (LH_AC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_luma_ac[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_DC);
> +	for (i = 0 ; i < (LH_DC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_chroma_dc[i]);
> +
> +	header_write(ctx, buffer, offset, 2, DHT_MARKER);
> +	header_write(ctx, buffer, offset, 2, LH_AC);
> +	for (i = 0 ; i < (LH_AC - 2); i++)
> +		header_write(ctx, buffer, offset, 1, marker_chroma_ac[i]);
> +}
> +
> +static void encode_frame_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +
> +	header_write(ctx, buffer, offset, 2, SOF_BASELINE_DCT);
> +	header_write(ctx, buffer, offset, 2, 8 + (3 * UC_NUM_COMP));
> +	header_write(ctx, buffer, offset, 1, PRECISION);
> +	header_write(ctx, buffer, offset, 2, ctx->out_queue.height);
> +	header_write(ctx, buffer, offset, 2, ctx->out_queue.width);
> +	header_write(ctx, buffer, offset, 1, UC_NUM_COMP);
> +
> +	/* Luma details */
> +	header_write(ctx, buffer, offset, 1, 1);
> +	if (ctx->out_queue.fmt->subsampling == V4L2_JPEG_CHROMA_SUBSAMPLING_422)
> +		header_write(ctx, buffer, offset, 1,
> +			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_422));
> +	else
> +		header_write(ctx, buffer, offset, 1,
> +			     HORZ_SAMPLING_FACTOR | (VERT_SAMPLING_FACTOR_420));
> +	header_write(ctx, buffer, offset, 1, 0);
> +	/* Chroma details */
> +	header_write(ctx, buffer, offset, 1, 2);
> +	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
> +	header_write(ctx, buffer, offset, 1, 1);
> +	header_write(ctx, buffer, offset, 1, 3);
> +	header_write(ctx, buffer, offset, 1, (HORZ_SAMPLING_FACTOR >> 1) | 1);
> +	header_write(ctx, buffer, offset, 1, 1);
> +
> +	header_write(ctx, buffer, offset, 1, 0xFF);
> +}
> +
> +static void jpg_encode_sos_header(struct e5010_context *ctx, void *addr, unsigned int *offset)
> +{
> +	u8 *buffer = (u8 *)addr;
> +	int i;
> +
> +	header_write(ctx, buffer, offset, 2, START_OF_SCAN);
> +	header_write(ctx, buffer, offset, 2, 6 + (COMPONENTS_IN_SCAN << 1));
> +	header_write(ctx, buffer, offset, 1, COMPONENTS_IN_SCAN);
> +
> +	for (i = 0; i < COMPONENTS_IN_SCAN; i++) {
> +		header_write(ctx, buffer, offset, 1, i + 1);
> +		if (i == 0)
> +			header_write(ctx, buffer, offset, 1, 0);
> +		else
> +			header_write(ctx, buffer, offset, 1, 17);
> +	}
> +
> +	header_write(ctx, buffer, offset, 1, 0);
> +	header_write(ctx, buffer, offset, 1, 63);
> +	header_write(ctx, buffer, offset, 1, 0);
> +}
> +
> +static void write_header(struct e5010_context *ctx, void *addr)
> +{
> +	unsigned int offset = 0;
> +
> +	encode_marker_segment(ctx, addr, &offset);
> +	encode_frame_header(ctx, addr, &offset);
> +	jpg_encode_sos_header(ctx, addr, &offset);
> +}
> +
> +static irqreturn_t e5010_irq(int irq, void *data)
> +{
> +	struct e5010_dev *e5010 = data;
> +	struct e5010_context *ctx;
> +	int output_size;
> +	struct vb2_v4l2_buffer *src_buf, *dst_buf;
> +	bool pic_done, out_addr_err;
> +
> +	spin_lock(&e5010->hw_lock);
> +	pic_done = e5010_hw_pic_done_irq(e5010->core_base);
> +	out_addr_err = e5010_hw_output_address_irq(e5010->core_base);
> +
> +	if (!pic_done && !out_addr_err) {
> +		spin_unlock(&e5010->hw_lock);
> +		return IRQ_NONE;
> +	}
> +
> +	ctx = v4l2_m2m_get_curr_priv(e5010->m2m_dev);
> +	if (WARN_ON(!ctx))
> +		goto job_unlock;
> +
> +	dst_buf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
> +	src_buf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
> +	if (!dst_buf || !src_buf) {
> +		v4l2_err(&e5010->v4l2_dev, "ctx: 0x%p No source or destination buffer\n", ctx);
> +		goto job_unlock;
> +	}
> +
> +	if (out_addr_err) {
> +		e5010_hw_clear_output_error(e5010->core_base, 1);
> +		v4l2_warn(&e5010->v4l2_dev,
> +			  "ctx: 0x%p Output bitstream size exceeded max size\n", ctx);
> +		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR);
> +		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, dst_buf->planes[0].length);
> +		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR);
> +		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
> +			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
> +			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
> +			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
> +		}
> +	}
> +
> +	if (pic_done) {
> +		e5010_hw_clear_picture_done(e5010->core_base, 1);
> +		dprintk(e5010, 3, "ctx: 0x%p Got output bitstream of size %d bytes\n",
> +			ctx, readl(e5010->core_base + JASPER_OUTPUT_SIZE_OFFSET));
> +
> +		if (v4l2_m2m_is_last_draining_src_buf(ctx->fh.m2m_ctx, src_buf)) {
> +			dst_buf->flags |= V4L2_BUF_FLAG_LAST;
> +			v4l2_m2m_mark_stopped(ctx->fh.m2m_ctx);
> +			v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +			dprintk(e5010, 2, "ctx: 0x%p Sending EOS\n", ctx);
> +		}
> +		v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE);
> +		output_size = e5010_hw_get_output_size(e5010->core_base);
> +		vb2_set_plane_payload(&dst_buf->vb2_buf, 0, output_size + HEADER_SIZE);
> +		v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE);
> +		dprintk(e5010, 3,
> +			"ctx: 0x%p frame done for dst_buf->sequence: %d src_buf->sequence: %d\n",
> +			ctx, dst_buf->sequence, src_buf->sequence);
> +	}
> +
> +	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
> +	dprintk(e5010, 3, "ctx: 0x%p Finish job\n", ctx);
> +
> +job_unlock:
> +	spin_unlock(&e5010->hw_lock);
> +	return IRQ_HANDLED;
> +}
> +
> +static int e5010_init_device(struct e5010_dev *e5010)
> +{
> +	int ret = 0;
> +
> +	/*TODO: Set MMU in bypass mode until support for the same is added in driver*/
> +	e5010_hw_bypass_mmu(e5010->mmu_base, 1);
> +
> +	if (e5010_hw_enable_auto_clock_gating(e5010->core_base, 1))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to enable auto clock gating\n");
> +
> +	if (e5010_hw_enable_manual_clock_gating(e5010->core_base, 0))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to disable manual clock gating\n");
> +
> +	if (e5010_hw_enable_crc_check(e5010->core_base, 0))
> +		v4l2_warn(&e5010->v4l2_dev, "failed to disable CRC check\n");
> +
> +	if (e5010_hw_enable_output_address_error_irq(e5010->core_base, 1))
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable Output Address Error interrupts\n");
> +
> +	ret = e5010_hw_set_input_source_to_memory(e5010->core_base, 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input source to memory\n");
> +		return ret;
> +	}
> +
> +	ret = e5010_hw_enable_picture_done_irq(e5010->core_base, 1);
> +	if (ret)
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable Picture Done interrupts\n");
> +
> +	return ret;
> +}
> +
> +static int e5010_probe(struct platform_device *pdev)
> +{
> +	struct e5010_dev *e5010;
> +	int irq, ret = 0;
> +
> +	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> +	if (ret)
> +		return dev_err_probe(e5010->dev, ret, "32-bit consistent DMA enable failed\n");
> +
> +	e5010 = devm_kzalloc(&pdev->dev, sizeof(*e5010), GFP_KERNEL);
> +	if (!e5010)
> +		return -ENOMEM;
> +
> +	platform_set_drvdata(pdev, e5010);
> +
> +	e5010->dev = &pdev->dev;
> +
> +	mutex_init(&e5010->mutex);
> +	spin_lock_init(&e5010->hw_lock);
> +
> +	e5010->vdev = &e5010_videodev;

Ew, you are modifying a global struct.

Just embed video_device in struct e5010_dev do:

	e5010->vdev = e5010_videodev;

> +	e5010->vdev->v4l2_dev = &e5010->v4l2_dev;
> +	e5010->vdev->lock = &e5010->mutex;
> +	e5010->vdev->queue = NULL;
> +	e5010->vdev->prio = NULL;
> +	e5010->vdev->dev_parent = NULL;

Drop these three NULL assignments: these fields are already NULL.

> +	e5010->vdev->minor = -1;
> +
> +	ret = v4l2_device_register(&pdev->dev, &e5010->v4l2_dev);
> +	if (ret)
> +		return dev_err_probe(e5010->dev, ret, "failed to register v4l2 device\n");
> +
> +	e5010->m2m_dev = v4l2_m2m_init(&e5010_m2m_ops);
> +	if (IS_ERR(e5010->m2m_dev)) {
> +		ret = PTR_ERR(e5010->m2m_dev);
> +		e5010->m2m_dev = NULL;
> +		dev_err_probe(e5010->dev, ret, "failed to init mem2mem device\n");
> +		goto fail_after_v4l2_register;
> +	}
> +
> +	video_set_drvdata(e5010->vdev, e5010);
> +
> +	ret = video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0);

This must be done last. As soon as you register the video device it can be
used, so registering the video device should only be done once everything
else is set up correctly.

> +	if (ret) {
> +		dev_err_probe(e5010->dev, ret, "failed to register video device\n");
> +		goto fail_after_v4l2_register;
> +	}
> +
> +	v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n",
> +		  e5010->vdev->num);
> +
> +	e5010->core_base = devm_platform_ioremap_resource_byname(pdev, "core");
> +	if (IS_ERR(e5010->core_base)) {
> +		ret = PTR_ERR(e5010->core_base);
> +		dev_err_probe(e5010->dev, ret, "Missing 'core' resources area\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu");
> +	if (IS_ERR(e5010->mmu_base)) {
> +		ret = PTR_ERR(e5010->mmu_base);
> +		dev_err_probe(e5010->dev, ret, "Missing 'mmu' resources area\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->last_context_run = NULL;
> +
> +	irq = platform_get_irq(pdev, 0);
> +	ret = devm_request_irq(e5010->dev, irq, e5010_irq, 0,
> +			       E5010_MODULE_NAME, e5010);
> +	if (ret) {
> +		dev_err_probe(e5010->dev, ret, "failed to register IRQ %d\n", irq);
> +		goto fail_after_video_register_device;
> +	}
> +
> +	e5010->clk = devm_clk_get(&pdev->dev, "core_clk");
> +	if (IS_ERR(e5010->clk)) {
> +		ret = PTR_ERR(e5010->clk);
> +		dev_err_probe(e5010->dev, ret, "failed to get clock\n");
> +		goto fail_after_video_register_device;
> +	}
> +
> +	pm_runtime_enable(e5010->dev);

This is where you can safely register the video device.

> +
> +	return 0;
> +
> +fail_after_video_register_device:
> +	v4l2_m2m_release(e5010->m2m_dev);
> +fail_after_v4l2_register:
> +	v4l2_device_unregister(&e5010->v4l2_dev);
> +	return ret;
> +}
> +
> +static int e5010_remove(struct platform_device *pdev)
> +{
> +	struct e5010_dev *e5010 = platform_get_drvdata(pdev);
> +
> +	pm_runtime_disable(e5010->dev);
> +	video_unregister_device(e5010->vdev);
> +	v4l2_m2m_release(e5010->m2m_dev);
> +	v4l2_device_unregister(&e5010->v4l2_dev);
> +
> +	return 0;
> +}
> +
> +static int e5010_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsigned int *nplanes,
> +			     unsigned int sizes[], struct device *alloc_devs[])
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vq);
> +	struct e5010_q_data *queue;
> +	int i;
> +
> +	if (!V4L2_TYPE_IS_MULTIPLANAR(vq->type)) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "queue setup with Invalid type: %d\n", vq->type);
> +		return -EINVAL;
> +	}

Can't happen.

> +
> +	queue = get_queue(ctx, vq->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);

Can never be an error as mentioned in my get_queue comment.

> +
> +	if (*nplanes) {
> +		if (*nplanes != queue->fmt->num_planes)
> +			return -EINVAL;
> +		for (i = 0; i < *nplanes; i++) {
> +			if (sizes[i] < queue->sizeimage[i])
> +				return -EINVAL;
> +		}
> +		return 0;
> +	}
> +
> +	*nbuffers = max_t(unsigned int, *nbuffers, 1);

Drop this, *nbuffers is never 0.

> +	*nplanes = queue->fmt->num_planes;
> +	for (i = 0; i < *nplanes; i++)
> +		sizes[i] = queue->sizeimage[i];
> +
> +	dprintk(ctx->e5010, 2,
> +		"ctx: 0x%p, type %s, buffer(s): %d, planes %d, plane1: bytes %d plane2: %d bytes\n",
> +		ctx, type_name(vq->type), *nbuffers, *nplanes, sizes[0], sizes[1]);
> +
> +	return 0;
> +}
> +
> +static void e5010_buf_finish(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	void *d_addr;
> +
> +	if (vb->state != VB2_BUF_STATE_DONE || V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
> +		return;
> +
> +	d_addr = vb2_plane_vaddr(vb, 0);
> +	write_header(ctx, d_addr);
> +}
> +
> +static int e5010_buf_out_validate(struct vb2_buffer *vb)
> +{
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +
> +	if (vbuf->field != V4L2_FIELD_NONE)
> +		dprintk(ctx->e5010, 1, "ctx: 0x%p, field isn't supported\n", ctx);
> +
> +	vbuf->field = V4L2_FIELD_NONE;
> +
> +	return 0;
> +}
> +
> +static int e5010_buf_prepare(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +	struct e5010_q_data *queue;
> +	int i;
> +
> +	vbuf->field = V4L2_FIELD_NONE;
> +
> +	queue = get_queue(ctx, vb->vb2_queue->type);
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +
> +	for (i = 0; i < queue->fmt->num_planes; i++) {
> +		if (vb2_plane_size(vb, i) < (unsigned long)queue->sizeimage[i]) {
> +			v4l2_err(&ctx->e5010->v4l2_dev, "plane %d too small (%lu < %lu)", i,
> +				 vb2_plane_size(vb, i), (unsigned long)queue->sizeimage[i]);
> +
> +			return -EINVAL;
> +		}
> +	}
> +
> +	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type)) {
> +		vb2_set_plane_payload(vb, 0, 0);
> +		vb2_set_plane_payload(vb, 1, 0);
> +	}
> +
> +	return 0;
> +}
> +
> +static void e5010_buf_queue(struct vb2_buffer *vb)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(vb->vb2_queue);
> +	struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> +
> +	if (V4L2_TYPE_IS_CAPTURE(vb->vb2_queue->type) &&
> +	    vb2_is_streaming(vb->vb2_queue) &&
> +	    v4l2_m2m_dst_buf_is_last(ctx->fh.m2m_ctx)) {
> +		struct e5010_q_data *queue = get_queue(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
> +
> +		if (IS_ERR(queue))
> +			return;
> +
> +		vbuf->sequence = queue->sequence++;
> +		v4l2_m2m_last_buffer_done(ctx->fh.m2m_ctx, vbuf);
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +		return;
> +	}
> +
> +	v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
> +}
> +
> +static int e5010_encoder_cmd(struct file *file, void *priv,
> +			     struct v4l2_encoder_cmd *cmd)
> +{
> +	struct e5010_context *ctx = file->private_data;
> +	int ret;
> +	struct vb2_queue *cap_vq;
> +
> +	cap_vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
> +
> +	ret = v4l2_m2m_ioctl_try_encoder_cmd(file, &ctx->fh, cmd);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (!vb2_is_streaming(v4l2_m2m_get_src_vq(ctx->fh.m2m_ctx)) ||
> +	    !vb2_is_streaming(v4l2_m2m_get_dst_vq(ctx->fh.m2m_ctx)))
> +		return 0;
> +
> +	ret = v4l2_m2m_ioctl_encoder_cmd(file, &ctx->fh, cmd);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (cmd->cmd == V4L2_ENC_CMD_STOP &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +
> +	if (cmd->cmd == V4L2_ENC_CMD_START &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx))
> +		vb2_clear_last_buffer_dequeued(cap_vq);
> +
> +	return 0;
> +}
> +
> +static int e5010_start_streaming(struct vb2_queue *q, unsigned int count)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(q);
> +	int ret;
> +
> +	struct e5010_q_data *queue = get_queue(ctx, q->type);
> +
> +	if (IS_ERR(queue))
> +		return PTR_ERR(queue);
> +	queue->streaming = true;
> +	v4l2_m2m_update_start_streaming_state(ctx->fh.m2m_ctx, q);
> +	queue->sequence = 0;
> +
> +	ret = pm_runtime_resume_and_get(ctx->e5010->dev);
> +	if (ret < 0) {
> +		v4l2_err(&ctx->e5010->v4l2_dev, "failed to power up jpeg\n");
> +		return ret;

If start_streaming fails, then it must return all queued buffers to
state VB2_BUF_STATE_QUEUED.

> +	}
> +
> +	ret = e5010_init_device(ctx->e5010);
> +	if (ret)
> +		v4l2_err(&ctx->e5010->v4l2_dev, "failed to Enable e5010 device\n");
> +
> +	return ret;
> +}
> +
> +static void e5010_stop_streaming(struct vb2_queue *q)
> +{
> +	struct e5010_context *ctx = vb2_get_drv_priv(q);
> +	struct vb2_v4l2_buffer *vbuf;
> +	struct e5010_q_data *queue;
> +
> +	queue = get_queue(ctx, q->type);
> +	if (IS_ERR(queue))
> +		return;
> +
> +	queue->streaming = false;
> +
> +	if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
> +		while ((vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx))) {
> +			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
> +				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
> +			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
> +		}
> +	} else {
> +		while ((vbuf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx))) {
> +			dprintk(ctx->e5010, 2, "ctx: 0x%p, buf type %s | index %d\n",
> +				ctx, type_name(vbuf->vb2_buf.type), vbuf->vb2_buf.index);
> +			vb2_set_plane_payload(&vbuf->vb2_buf, 0, 0);
> +			v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR);
> +		}
> +	}
> +
> +	if (V4L2_TYPE_IS_OUTPUT(q->type))
> +		v4l2_m2m_update_stop_streaming_state(ctx->fh.m2m_ctx, q);
> +
> +	if (V4L2_TYPE_IS_OUTPUT(q->type) &&
> +	    v4l2_m2m_has_stopped(ctx->fh.m2m_ctx)) {
> +		v4l2_event_queue_fh(&ctx->fh, &e5010_eos_event);
> +	}
> +
> +	pm_runtime_put_sync(ctx->e5010->dev);
> +}
> +
> +static void e5010_device_run(void *priv)
> +{
> +	struct e5010_context *ctx = priv;
> +	struct e5010_dev *e5010 = ctx->e5010;
> +	struct vb2_v4l2_buffer *s_vb, *d_vb;
> +	u32 reg = 0;
> +	int ret = 0;
> +	unsigned long flags;
> +	int num_planes = ctx->out_queue.fmt->num_planes;
> +
> +	spin_lock_irqsave(&e5010->hw_lock, flags);
> +	s_vb = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
> +	WARN_ON(!s_vb);
> +	d_vb = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx);
> +	WARN_ON(!d_vb);
> +	if (!s_vb || !d_vb)
> +		goto no_ready_buf_err;
> +
> +	s_vb->sequence = ctx->out_queue.sequence++;
> +	d_vb->sequence = ctx->cap_queue.sequence++;
> +
> +	v4l2_m2m_buf_copy_metadata(s_vb, d_vb, false);
> +
> +	if (ctx != e5010->last_context_run || ctx->update_qp) {
> +		dprintk(e5010, 1, "ctx updated: 0x%p -> 0x%p, updating qp tables\n",
> +			e5010->last_context_run, ctx);
> +		ret = update_qp_tables(ctx);
> +	}
> +
> +	if (ret) {
> +		ctx->update_qp = true;
> +		v4l2_err(&e5010->v4l2_dev, "failed to update QP tables\n");
> +		goto device_busy_err;
> +	} else {
> +		e5010->last_context_run = ctx;
> +		ctx->update_qp = false;
> +	}
> +
> +	/* Set I/O Buffer addresses */
> +	reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0);
> +	ret = e5010_hw_set_input_luma_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input luma address\n");
> +		goto device_busy_err;
> +	}
> +
> +	if (num_planes == 1)
> +		reg += (ctx->out_queue.bytesperline[0]) * (ctx->out_queue.height);
> +	else
> +		reg = (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 1);
> +
> +	dprintk(e5010, 3,
> +		"ctx: 0x%p, luma_addr: 0x%x, chroma_addr: 0x%x, out_addr: 0x%x\n",
> +		ctx, (u32)vb2_dma_contig_plane_dma_addr(&s_vb->vb2_buf, 0), reg,
> +		(u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0));
> +
> +	dprintk(e5010, 3,
> +		"ctx: 0x%p, buf indices: src_index: %d, dst_index: %d\n",
> +		ctx, s_vb->vb2_buf.index, d_vb->vb2_buf.index);
> +
> +	ret = e5010_hw_set_input_chroma_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input chroma address\n");
> +		goto device_busy_err;
> +	}
> +
> +	reg = (u32)vb2_dma_contig_plane_dma_addr(&d_vb->vb2_buf, 0);
> +	reg += HEADER_SIZE;
> +	ret = e5010_hw_set_output_base_addr(e5010->core_base, reg);
> +	if (ret || !reg) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set output size\n");
> +		goto device_busy_err;
> +	}
> +
> +	/* Set input settings */
> +	ret = e5010_hw_set_horizontal_size(e5010->core_base, ctx->out_queue.width - 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_vertical_size(e5010->core_base, ctx->out_queue.height - 1);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input width\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_luma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set luma stride\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_chroma_stride(e5010->core_base, ctx->out_queue.bytesperline[0]);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set chroma stride\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_set_input_subsampling(e5010->core_base, ctx->out_queue.fmt->subsampling);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set input subsampling\n");
> +		goto device_busy_err;
> +	}
> +
> +	ret = e5010_hw_set_chroma_order(e5010->core_base, ctx->out_queue.fmt->chroma_order);
> +	if (ret) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to set chroma order\n");
> +		goto device_busy_err;
> +	}
> +
> +	e5010_hw_set_output_max_size(e5010->core_base, d_vb->planes[0].length);
> +	e5010_hw_encode_start(e5010->core_base, 1);
> +
> +	spin_unlock_irqrestore(&e5010->hw_lock, flags);
> +
> +	return;
> +
> +device_busy_err:
> +	e5010_reset(e5010->dev, e5010->core_base, e5010->mmu_base);
> +
> +no_ready_buf_err:
> +	if (s_vb) {
> +		v4l2_m2m_src_buf_remove_by_buf(ctx->fh.m2m_ctx, s_vb);
> +		v4l2_m2m_buf_done(s_vb, VB2_BUF_STATE_ERROR);
> +	}
> +
> +	if (d_vb) {
> +		v4l2_m2m_dst_buf_remove_by_buf(ctx->fh.m2m_ctx, d_vb);
> +		/* Payload set to 1 since 0 payload can trigger EOS */
> +		vb2_set_plane_payload(&d_vb->vb2_buf, 0, 1);
> +		v4l2_m2m_buf_done(d_vb, VB2_BUF_STATE_ERROR);
> +	}
> +	v4l2_m2m_job_finish(e5010->m2m_dev, ctx->fh.m2m_ctx);
> +	spin_unlock_irqrestore(&e5010->hw_lock, flags);
> +}
> +
> +#ifdef CONFIG_PM
> +static int e5010_runtime_resume(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = clk_prepare_enable(e5010->clk);
> +	if (ret < 0) {
> +		v4l2_err(&e5010->v4l2_dev, "failed to enable clock\n");
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
> +static int e5010_runtime_suspend(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +
> +	clk_disable_unprepare(e5010->clk);
> +
> +	return 0;
> +}
> +#endif
> +
> +#ifdef CONFIG_PM_SLEEP
> +static int e5010_suspend(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +
> +	v4l2_m2m_suspend(e5010->m2m_dev);
> +
> +	return pm_runtime_force_suspend(dev);
> +}
> +
> +static int e5010_resume(struct device *dev)
> +{
> +	struct e5010_dev *e5010 = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = pm_runtime_force_resume(dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	v4l2_m2m_resume(e5010->m2m_dev);
> +
> +	return ret;
> +}
> +#endif
> +
> +static const struct dev_pm_ops	e5010_pm_ops = {
> +	SET_RUNTIME_PM_OPS(e5010_runtime_suspend,
> +			   e5010_runtime_resume, NULL)
> +	SET_SYSTEM_SLEEP_PM_OPS(e5010_suspend, e5010_resume)
> +};
> +
> +static const struct v4l2_ioctl_ops e5010_ioctl_ops = {
> +	.vidioc_querycap = e5010_querycap,
> +
> +	.vidioc_enum_fmt_vid_cap = e5010_enum_fmt,
> +	.vidioc_g_fmt_vid_cap_mplane = e5010_g_fmt,
> +	.vidioc_try_fmt_vid_cap_mplane = e5010_try_fmt,
> +	.vidioc_s_fmt_vid_cap_mplane = e5010_s_fmt,
> +
> +	.vidioc_enum_fmt_vid_out = e5010_enum_fmt,
> +	.vidioc_g_fmt_vid_out_mplane = e5010_g_fmt,
> +	.vidioc_try_fmt_vid_out_mplane = e5010_try_fmt,
> +	.vidioc_s_fmt_vid_out_mplane = e5010_s_fmt,
> +
> +	.vidioc_g_selection = e5010_g_selection,
> +	.vidioc_s_selection = e5010_s_selection,
> +
> +	.vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
> +	.vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
> +	.vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
> +	.vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
> +	.vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
> +	.vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
> +	.vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
> +
> +	.vidioc_streamon = v4l2_m2m_ioctl_streamon,
> +	.vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
> +	.vidioc_log_status = v4l2_ctrl_log_status,
> +
> +	.vidioc_subscribe_event = e5010_subscribe_event,
> +	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> +	.vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
> +	.vidioc_encoder_cmd = e5010_encoder_cmd,
> +
> +	.vidioc_enum_framesizes = e5010_enum_framesizes,
> +};
> +
> +static const struct vb2_ops e5010_video_ops = {
> +	.queue_setup = e5010_queue_setup,
> +	.buf_queue = e5010_buf_queue,
> +	.buf_finish = e5010_buf_finish,
> +	.buf_prepare = e5010_buf_prepare,
> +	.buf_out_validate = e5010_buf_out_validate,
> +	.wait_prepare = vb2_ops_wait_prepare,
> +	.wait_finish = vb2_ops_wait_finish,
> +	.start_streaming = e5010_start_streaming,
> +	.stop_streaming = e5010_stop_streaming,
> +};
> +
> +static const struct v4l2_file_operations e5010_fops = {
> +	.owner = THIS_MODULE,
> +	.open = e5010_open,
> +	.release = e5010_release,
> +	.poll = v4l2_m2m_fop_poll,
> +	.unlocked_ioctl = video_ioctl2,
> +	.mmap = v4l2_m2m_fop_mmap,
> +};
> +
> +static const struct v4l2_m2m_ops e5010_m2m_ops = {
> +	.device_run = e5010_device_run,
> +};
> +
> +static const struct of_device_id e5010_of_match[] = {
> +	{.compatible = "img,e5010-jpeg-enc"},   { /* end */},
> +};
> +MODULE_DEVICE_TABLE(of, e5010_of_match);
> +
> +static struct platform_driver e5010_driver = {
> +	.probe = e5010_probe,
> +	.remove = e5010_remove,
> +	.driver = {
> +		.name = E5010_MODULE_NAME,
> +		.of_match_table = e5010_of_match,
> +		.pm = &e5010_pm_ops,
> +	},
> +};
> +module_platform_driver(e5010_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Imagination E5010 JPEG encoder driver");
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.h b/drivers/media/platform/imagination/e5010-jpeg-enc.h
> new file mode 100644
> index 000000000000..3a47b0327101
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.h
> @@ -0,0 +1,169 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-fh.h>
> +
> +#ifndef _E5010_JPEG_ENC_H
> +#define _E5010_JPEG_ENC_H
> +
> +#define MAX_PLANES			2
> +#define HEADER_SIZE			0x025E
> +#define MIN_DIMENSION			64
> +#define MAX_DIMENSION			8192
> +#define DEFAULT_WIDTH			640
> +#define DEFAULT_HEIGHT			480
> +#define E5010_MODULE_NAME		"e5010"
> +#define JPEG_MAX_BYTES_PER_PIXEL	2
> +
> +/* JPEG marker definitions */
> +#define START_OF_IMAGE			0xFFD8
> +#define SOF_BASELINE_DCT		0xFFC0
> +#define END_OF_IMAGE			0xFFD9
> +#define START_OF_SCAN			0xFFDA
> +
> +/* Definitions for the huffman table specification in the Marker segment */
> +#define DHT_MARKER			0xFFC4
> +#define LH_DC				0x001F
> +#define LH_AC				0x00B5
> +
> +/* Definitions for the quantization table specification in the Marker segment */
> +#define DQT_MARKER			0xFFDB
> +#define ACMAX				0x03FF
> +#define DCMAX				0x07FF
> +
> +/* Length and precision of the quantization table parameters */
> +#define LQPQ				0x00430
> +#define QMAX				255
> +
> +/* Misc JPEG header definitions */
> +#define UC_NUM_COMP			3
> +#define PRECISION			8
> +#define HORZ_SAMPLING_FACTOR		(2 << 4)
> +#define VERT_SAMPLING_FACTOR_422	1
> +#define VERT_SAMPLING_FACTOR_420	2
> +#define COMPONENTS_IN_SCAN		3
> +#define PELS_IN_BLOCK			64
> +
> +/* Used for Qp table generation */
> +#define LUMINOSITY			10
> +#define CONTRAST			1
> +#define INCREASE			2
> +#define QP_TABLE_SIZE			(8 * 8)
> +#define QP_TABLE_FIELD_OFFSET		0x04
> +
> +/*
> + * vb2 queue structure
> + * contains queue data information
> + *
> + * @fmt: format info
> + * @width: frame width
> + * @height: frame height
> + * @bytesperline: bytes per line in memory
> + * @size_image: image size in memory
> + */
> +struct e5010_q_data {
> +	struct e5010_fmt	*fmt;
> +	u32			width;
> +	u32			height;
> +	u32			width_adjusted;
> +	u32			height_adjusted;
> +	u32			sizeimage[MAX_PLANES];
> +	u32			bytesperline[MAX_PLANES];
> +	bool			format_set;
> +	bool			streaming;
> +	u32			sequence;
> +	struct v4l2_rect	crop;
> +};
> +
> +/*
> + * Driver device structure
> + * Holds all memory handles and global parameters
> + * Shared by all instances
> + */
> +struct e5010_dev {
> +	struct device *dev;
> +	struct v4l2_device	v4l2_dev;
> +	struct v4l2_m2m_dev	*m2m_dev;
> +	struct video_device	*vdev;
> +	void __iomem		*core_base;
> +	void __iomem		*mmu_base;
> +	struct clk		*clk;
> +	struct e5010_context	*last_context_run;
> +	/* Protect access to device data */
> +	struct mutex		mutex;
> +	/* Protect access to hardware*/
> +	spinlock_t		hw_lock;
> +};
> +
> +/*
> + * Driver context structure
> + * One of these exists for every m2m context
> + * Holds context specific data
> + */
> +struct e5010_context {
> +	struct v4l2_fh			fh;
> +	struct e5010_dev		*e5010;
> +	struct e5010_q_data		out_queue;
> +	struct e5010_q_data		cap_queue;
> +	int				quality;
> +	bool				update_qp;
> +	struct v4l2_ctrl_handler	ctrl_handler;
> +	u8				luma_qp[QP_TABLE_SIZE];
> +	u8				chroma_qp[QP_TABLE_SIZE];
> +};
> +
> +/*
> + * Buffer structure
> + * Contains info for all buffers
> + */
> +struct e5010_buffer {
> +	struct v4l2_m2m_buffer buffer;
> +};
> +
> +enum {
> +	CHROMA_ORDER_CB_CR = 0, //UV ordering
> +	CHROMA_ORDER_CR_CB = 1, //VU ordering
> +};
> +
> +enum {
> +	SUBSAMPLING_420 = 1,
> +	SUBSAMPLING_422 = 2,
> +};
> +
> +/*
> + * e5010 format structure
> + * contains format information
> + */
> +struct e5010_fmt {
> +	u32					fourcc;
> +	unsigned int				num_planes;
> +	unsigned int				type;
> +	u32					subsampling;
> +	u32					chroma_order;
> +	const struct v4l2_frmsize_stepwise	frmsize;
> +};
> +
> +/*
> + * struct e5010_ctrl - contains info for each supported v4l2 control
> + */
> +struct e5010_ctrl {
> +	unsigned int		cid;
> +	enum v4l2_ctrl_type	type;
> +	unsigned char		name[32];
> +	int			minimum;
> +	int			maximum;
> +	int			step;
> +	int			default_value;
> +	unsigned char		compound;
> +};
> +
> +#endif
> diff --git a/drivers/media/platform/imagination/e5010-mmu-regs.h b/drivers/media/platform/imagination/e5010-mmu-regs.h
> new file mode 100644
> index 000000000000..bfba06956cf2
> --- /dev/null
> +++ b/drivers/media/platform/imagination/e5010-mmu-regs.h
> @@ -0,0 +1,311 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Imagination E5010 JPEG Encoder driver.
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + * Author: David Huang <d-huang@ti.com>
> + * Author: Devarsh Thakkar <devarsht@ti.com>
> + */
> +
> +#ifndef _E5010_MMU_REGS_H
> +#define _E5010_MMU_REGS_H
> +
> +#define MMU_MMU_DIR_BASE_ADDR_OFFSET					(0x0020)
> +#define MMU_MMU_DIR_BASE_ADDR_STRIDE					(4)
> +#define MMU_MMU_DIR_BASE_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_DIR_BASE_ADDR_MMU_DIR_BASE_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_TILE_CFG_OFFSET						(0x0040)
> +#define MMU_MMU_TILE_CFG_STRIDE						(4)
> +#define MMU_MMU_TILE_CFG_NO_ENTRIES					(4)
> +
> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_MASK			(0x00000010)
> +#define MMU_MMU_TILE_CFG_TILE_128INTERLEAVE_SHIFT			(4)
> +
> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_MASK				(0x00000008)
> +#define MMU_MMU_TILE_CFG_TILE_ENABLE_SHIFT				(3)
> +
> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_MASK				(0x00000007)
> +#define MMU_MMU_TILE_CFG_TILE_STRIDE_SHIFT				(0)
> +
> +#define MMU_MMU_TILE_MIN_ADDR_OFFSET					(0x0050)
> +#define MMU_MMU_TILE_MIN_ADDR_STRIDE					(4)
> +#define MMU_MMU_TILE_MIN_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_TILE_MIN_ADDR_TILE_MIN_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_TILE_MAX_ADDR_OFFSET					(0x0060)
> +#define MMU_MMU_TILE_MAX_ADDR_STRIDE					(4)
> +#define MMU_MMU_TILE_MAX_ADDR_NO_ENTRIES				(4)
> +
> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_MASK			(0xFFFFFFFF)
> +#define MMU_MMU_TILE_MAX_ADDR_TILE_MAX_ADDR_SHIFT			(0)
> +
> +#define MMU_MMU_CONTROL0_OFFSET						(0x0000)
> +
> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_MASK				(0x00000001)
> +#define MMU_MMU_CONTROL0_MMU_TILING_SCHEME_SHIFT			(0)
> +
> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_MASK				(0x00000100)
> +#define MMU_MMU_CONTROL0_MMU_CACHE_POLICY_SHIFT				(8)
> +
> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_MASK			(0x00000200)
> +#define MMU_MMU_CONTROL0_FORCE_CACHE_POLICY_BYPASS_SHIFT		(9)
> +
> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_MASK			(0x00001000)
> +#define MMU_MMU_CONTROL0_STALL_ON_PROTOCOL_FAULT_SHIFT			(12)
> +
> +#define MMU_MMU_CONTROL1_OFFSET						(0x0008)
> +
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_MASK					(0x00000008)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SHIFT				(3)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_NO_REPS				(4)
> +#define MMU_MMU_CONTROL1_MMU_FLUSH_SIZE					(1)
> +
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_MASK				(0x00000800)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SHIFT				(11)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_NO_REPS				(4)
> +#define MMU_MMU_CONTROL1_MMU_INVALDC_SIZE				(1)
> +
> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_MASK				(0x00010000)
> +#define MMU_MMU_CONTROL1_MMU_FAULT_CLEAR_SHIFT				(16)
> +
> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_MASK			(0x00100000)
> +#define MMU_MMU_CONTROL1_PROTOCOL_FAULT_CLEAR_SHIFT			(20)
> +
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_MASK				(0x01000000)
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_SET_SHIFT				(24)
> +
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_MASK				(0x02000000)
> +#define MMU_MMU_CONTROL1_MMU_PAUSE_CLEAR_SHIFT				(25)
> +
> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_MASK				(0x10000000)
> +#define MMU_MMU_CONTROL1_MMU_SOFT_RESET_SHIFT				(28)
> +
> +#define MMU_MMU_BANK_INDEX_OFFSET					(0x0010)
> +
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_MASK				(0xC0000000)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SHIFT				(30)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_NO_REPS			(16)
> +#define MMU_MMU_BANK_INDEX_MMU_BANK_INDEX_SIZE				(2)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_OFFSET				(0x0018)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_MASK		(0x00008000)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SHIFT		(15)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_NO_REPS		(16)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_PRIORITY_ENABLE_SIZE		(1)
> +
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_MASK	(0x00010000)
> +#define MMU_REQUEST_PRIORITY_ENABLE_CMD_MMU_PRIORITY_ENABLE_SHIFT	(16)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_OFFSET				(0x001C)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_MASK		(0x000003FF)
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_LIMITED_WORDS_SHIFT		(0)
> +
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_MASK			(0x0FFF0000)
> +#define MMU_REQUEST_LIMITED_THROUGHPUT_REQUEST_GAP_SHIFT		(16)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_OFFSET					(0x0070)
> +#define MMU_MMU_ADDRESS_CONTROL_TRUSTED					(IMG_TRUE)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_MASK				(0x00000001)
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_BYPASS_SHIFT			(0)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_MASK		(0x00000010)
> +#define MMU_MMU_ADDRESS_CONTROL_MMU_ENABLE_EXT_ADDRESSING_SHIFT		(4)
> +
> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_MASK		(0x00FF0000)
> +#define MMU_MMU_ADDRESS_CONTROL_UPPER_ADDRESS_FIXED_SHIFT		(16)
> +
> +#define MMU_MMU_CONFIG0_OFFSET						(0x0080)
> +
> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_MASK				(0x0000000F)
> +#define MMU_MMU_CONFIG0_NUM_REQUESTORS_SHIFT				(0)
> +
> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_MASK			(0x000000F0)
> +#define MMU_MMU_CONFIG0_EXTENDED_ADDR_RANGE_SHIFT			(4)
> +
> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_MASK			(0x00000700)
> +#define MMU_MMU_CONFIG0_GROUP_OVERRIDE_SIZE_SHIFT			(8)
> +
> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_MASK			(0x00001000)
> +#define MMU_MMU_CONFIG0_ADDR_COHERENCY_SUPPORTED_SHIFT			(12)
> +
> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_MASK				(0x00002000)
> +#define MMU_MMU_CONFIG0_MMU_SUPPORTED_SHIFT				(13)
> +
> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_MASK			(0x001F0000)
> +#define MMU_MMU_CONFIG0_TILE_ADDR_GRANULARITY_SHIFT			(16)
> +
> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_MASK				(0x00200000)
> +#define MMU_MMU_CONFIG0_NO_READ_REORDER_SHIFT				(21)
> +
> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_MASK				(0xFFC00000)
> +#define MMU_MMU_CONFIG0_TAGS_SUPPORTED_SHIFT				(22)
> +
> +#define MMU_MMU_CONFIG1_OFFSET						(0x0084)
> +
> +#define MMU_MMU_CONFIG1_PAGE_SIZE_MASK					(0x0000000F)
> +#define MMU_MMU_CONFIG1_PAGE_SIZE_SHIFT					(0)
> +
> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_MASK				(0x0000FF00)
> +#define MMU_MMU_CONFIG1_PAGE_CACHE_ENTRIES_SHIFT			(8)
> +
> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_MASK				(0x001F0000)
> +#define MMU_MMU_CONFIG1_DIR_CACHE_ENTRIES_SHIFT				(16)
> +
> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_MASK			(0x01000000)
> +#define MMU_MMU_CONFIG1_BANDWIDTH_COUNT_SUPPORTED_SHIFT			(24)
> +
> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_MASK			(0x02000000)
> +#define MMU_MMU_CONFIG1_STALL_COUNT_SUPPORTED_SHIFT			(25)
> +
> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_MASK			(0x04000000)
> +#define MMU_MMU_CONFIG1_LATENCY_COUNT_SUPPORTED_SHIFT			(26)
> +
> +#define MMU_MMU_STATUS0_OFFSET						(0x0088)
> +
> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_MASK				(0x00000001)
> +#define MMU_MMU_STATUS0_MMU_PF_N_RW_SHIFT				(0)
> +
> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_MASK				(0xFFFFF000)
> +#define MMU_MMU_STATUS0_MMU_FAULT_ADDR_SHIFT				(12)
> +
> +#define MMU_MMU_STATUS1_OFFSET						(0x008C)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_MASK				(0x0000FFFF)
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_STAT_SHIFT			(0)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_MASK				(0x000F0000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_REQ_ID_SHIFT				(16)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_MASK				(0x03000000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_INDEX_SHIFT				(24)
> +
> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_MASK				(0x10000000)
> +#define MMU_MMU_STATUS1_MMU_FAULT_RNW_SHIFT				(28)
> +
> +#define MMU_MMU_MEM_REQ_OFFSET						(0x0090)
> +
> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_MASK				(0x000003FF)
> +#define MMU_MMU_MEM_REQ_TAG_OUTSTANDING_SHIFT				(0)
> +
> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_MASK				(0x00001000)
> +#define MMU_MMU_MEM_REQ_EXT_WRRESP_FAULT_SHIFT				(12)
> +
> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_MASK				(0x00002000)
> +#define MMU_MMU_MEM_REQ_EXT_RDRESP_FAULT_SHIFT				(13)
> +
> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_MASK			(0x00004000)
> +#define MMU_MMU_MEM_REQ_EXT_READ_BURST_FAULT_SHIFT			(14)
> +
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_MASK				(0x80000000)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SHIFT			(31)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_NO_REPS			(16)
> +#define MMU_MMU_MEM_REQ_INT_PROTOCOL_FAULT_SIZE				(1)
> +
> +#define MMU_MMU_FAULT_SELECT_OFFSET					(0x00A0)
> +
> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_MASK			(0x0000000F)
> +#define MMU_MMU_FAULT_SELECT_MMU_FAULT_SELECT_SHIFT			(0)
> +
> +#define MMU_PROTOCOL_FAULT_OFFSET					(0x00A8)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_MASK			(0x00000001)
> +#define MMU_PROTOCOL_FAULT_FAULT_PAGE_BREAK_SHIFT			(0)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_MASK				(0x00000010)
> +#define MMU_PROTOCOL_FAULT_FAULT_WRITE_SHIFT				(4)
> +
> +#define MMU_PROTOCOL_FAULT_FAULT_READ_MASK				(0x00000020)
> +#define MMU_PROTOCOL_FAULT_FAULT_READ_SHIFT				(5)
> +
> +#define MMU_TOTAL_READ_REQ_OFFSET					(0x0100)
> +
> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_MASK				(0xFFFFFFFF)
> +#define MMU_TOTAL_READ_REQ_TOTAL_READ_REQ_SHIFT				(0)
> +
> +#define MMU_TOTAL_WRITE_REQ_OFFSET					(0x0104)
> +
> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_TOTAL_WRITE_REQ_TOTAL_WRITE_REQ_SHIFT			(0)
> +
> +#define MMU_READS_LESS_64_REQ_OFFSET					(0x0108)
> +
> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_READS_LESS_64_REQ_READS_LESS_64_REQ_SHIFT			(0)
> +
> +#define MMU_WRITES_LESS_64_REQ_OFFSET					(0x010C)
> +
> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_MASK			(0xFFFFFFFF)
> +#define MMU_WRITES_LESS_64_REQ_WRITES_LESS_64_REQ_SHIFT			(0)
> +
> +#define MMU_EXT_CMD_STALL_OFFSET					(0x0120)
> +
> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_EXT_CMD_STALL_EXT_CMD_STALL_SHIFT				(0)
> +
> +#define MMU_WRITE_REQ_STALL_OFFSET					(0x0124)
> +
> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_MASK			(0xFFFFFFFF)
> +#define MMU_WRITE_REQ_STALL_WRITE_REQ_STALL_SHIFT			(0)
> +
> +#define MMU_MMU_MISS_STALL_OFFSET					(0x0128)
> +
> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_MMU_MISS_STALL_MMU_MISS_STALL_SHIFT				(0)
> +
> +#define MMU_ADDRESS_STALL_OFFSET					(0x012C)
> +
> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_MASK				(0xFFFFFFFF)
> +#define MMU_ADDRESS_STALL_ADDRESS_STALL_SHIFT				(0)
> +
> +#define MMU_TAG_STALL_OFFSET						(0x0130)
> +
> +#define MMU_TAG_STALL_TAG_STALL_MASK					(0xFFFFFFFF)
> +#define MMU_TAG_STALL_TAG_STALL_SHIFT					(0)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_OFFSET				(0x0140)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_MASK		(0x000003FF)
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_TAG_OUTSTANDING_SHIFT		(0)
> +
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_MASK		(0xFFFF0000)
> +#define MMU_PEAK_READ_OUTSTANDING_PEAK_READ_LATENCY_SHIFT		(16)
> +
> +#define MMU_AVERAGE_READ_LATENCY_OFFSET					(0x0144)
> +
> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_MASK		(0xFFFFFFFF)
> +#define MMU_AVERAGE_READ_LATENCY_AVERAGE_READ_LATENCY_SHIFT		(0)
> +
> +#define MMU_STATISTICS_CONTROL_OFFSET					(0x0160)
> +
> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_MASK		(0x00000001)
> +#define MMU_STATISTICS_CONTROL_BANDWIDTH_STATS_INIT_SHIFT		(0)
> +
> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_MASK			(0x00000002)
> +#define MMU_STATISTICS_CONTROL_STALL_STATS_INIT_SHIFT			(1)
> +
> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_MASK			(0x00000004)
> +#define MMU_STATISTICS_CONTROL_LATENCY_STATS_INIT_SHIFT			(2)
> +
> +#define MMU_MMU_VERSION_OFFSET						(0x01D0)
> +
> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_MASK				(0x00FF0000)
> +#define MMU_MMU_VERSION_MMU_MAJOR_REV_SHIFT				(16)
> +
> +#define MMU_MMU_VERSION_MMU_MINOR_REV_MASK				(0x0000FF00)
> +#define MMU_MMU_VERSION_MMU_MINOR_REV_SHIFT				(8)
> +
> +#define MMU_MMU_VERSION_MMU_MAINT_REV_MASK				(0x000000FF)
> +#define MMU_MMU_VERSION_MMU_MAINT_REV_SHIFT				(0)
> +
> +#define MMU_BYTE_SIZE							(0x01D4)
> +
> +#endif

Regards,

	Hans

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-09-06 12:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
2023-08-19 14:00   ` Krzysztof Kozlowski
2023-08-20 16:46     ` Devarsh Thakkar
2023-08-20 20:25       ` Krzysztof Kozlowski
2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
2023-08-22 10:27   ` Andrzej Pietrasiewicz
2023-08-31 13:24     ` Devarsh Thakkar
2023-09-06 12:38   ` Hans Verkuil
2023-08-16 15:22 ` [DONOTMERGE PATCH v3 3/4] arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder Devarsh Thakkar
2023-08-16 15:22 ` [DONOTMERGE PATCH v3 4/4] arm64: defconfig: Enable " Devarsh Thakkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).