* [PATCH][next] media: i2c: st-vgxy61: remove redundant initialization of pointer mode
@ 2024-02-05 22:05 Colin Ian King
2024-02-09 8:55 ` Benjamin Mugnier
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-05 22:05 UTC (permalink / raw)
To: Benjamin Mugnier, Sylvain Petinot, Sakari Ailus,
Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
The pointer mode is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.
Cleans up clang scan build warning:
drivers/media/i2c/st-vgxy61.c:632:33: warning: Value stored to 'mode'
during its initialization is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/media/i2c/st-vgxy61.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c
index 2d64466d7ecf..b9e7c57027b1 100644
--- a/drivers/media/i2c/st-vgxy61.c
+++ b/drivers/media/i2c/st-vgxy61.c
@@ -629,7 +629,7 @@ static int vgxy61_try_fmt_internal(struct v4l2_subdev *sd,
const struct vgxy61_mode_info **new_mode)
{
struct vgxy61_dev *sensor = to_vgxy61_dev(sd);
- const struct vgxy61_mode_info *mode = sensor->sensor_modes;
+ const struct vgxy61_mode_info *mode;
unsigned int index;
for (index = 0; index < ARRAY_SIZE(vgxy61_supported_codes); index++) {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] media: i2c: st-vgxy61: remove redundant initialization of pointer mode
2024-02-05 22:05 [PATCH][next] media: i2c: st-vgxy61: remove redundant initialization of pointer mode Colin Ian King
@ 2024-02-09 8:55 ` Benjamin Mugnier
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Mugnier @ 2024-02-09 8:55 UTC (permalink / raw)
To: Colin Ian King, Sylvain Petinot, Sakari Ailus,
Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
Hi Colin,
Thank you for your patch.
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
On 2/5/24 23:05, Colin Ian King wrote:
> The pointer mode is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/media/i2c/st-vgxy61.c:632:33: warning: Value stored to 'mode'
> during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/media/i2c/st-vgxy61.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c
> index 2d64466d7ecf..b9e7c57027b1 100644
> --- a/drivers/media/i2c/st-vgxy61.c
> +++ b/drivers/media/i2c/st-vgxy61.c
> @@ -629,7 +629,7 @@ static int vgxy61_try_fmt_internal(struct v4l2_subdev *sd,
> const struct vgxy61_mode_info **new_mode)
> {
> struct vgxy61_dev *sensor = to_vgxy61_dev(sd);
> - const struct vgxy61_mode_info *mode = sensor->sensor_modes;
> + const struct vgxy61_mode_info *mode;
> unsigned int index;
>
> for (index = 0; index < ARRAY_SIZE(vgxy61_supported_codes); index++) {
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-05 22:05 [PATCH][next] media: i2c: st-vgxy61: remove redundant initialization of pointer mode Colin Ian King
2024-02-09 8:55 ` Benjamin Mugnier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).