[PATCH v1 0/2] media: rockchip: rga: Add rk3568 support

[PATCH v1 0/2] media: rockchip: rga: Add rk3568 support

[Jianfeng Liu]

The RGA2 on the Rockchip rk3588 is the same core as the RGA2 on the
Rockchip rk3288 and rk3568.

This series adds the necessary device tree binding and node in the device
tree to enable the RGA2 on the Rockchip rk3588.

Tested on rock5b with gstreamer command:
gst-launch-1.0 videotestsrc ! video/x-raw,format=BGRx ! v4l2convert ! xvimagesink

Jianfeng Liu (2):
  dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga
  arm64: dts: rockchip: Add RGA2 support to rk3588

 .../devicetree/bindings/media/rockchip-rga.yaml       |  1 +
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi             | 11 +++++++++++
 2 files changed, 12 insertions(+)

-- 
2.34.1

[PATCH v1 1/2] dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga

[Jianfeng Liu]

Add a new compatible for the rk3588 Rockchip SoC, which also features an
RGA, which is called RGA2 in the TRM Part2. It is the same core as used
on the rk3288 and rk3568, which documents the same RGA2.

Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
---
 Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
index ea2342222..ac17cda65 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
@@ -24,6 +24,7 @@ properties:
           - enum:
               - rockchip,rk3228-rga
               - rockchip,rk3568-rga
+              - rockchip,rk3588-rga
           - const: rockchip,rk3288-rga
 
   reg:
-- 
2.34.1

Re: [PATCH v1 1/2] dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Fri, Mar 22, 2024 at 01:29:14PM +0800, Jianfeng Liu wrote:
> Add a new compatible for the rk3588 Rockchip SoC, which also features an
> RGA, which is called RGA2 in the TRM Part2. It is the same core as used
> on the rk3288 and rk3568, which documents the same RGA2.
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v1 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588

[Jianfeng Liu]

RK3588 also features a RGA2 block. Add the necessary device tree
node.

Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 87b83c87b..8f130177b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -387,6 +387,17 @@ psci {
 		method = "smc";
 	};
 
+	rga: rga@fdb80000 {
+		compatible = "rockchip,rk3588-rga", "rockchip,rk3288-rga";
+		reg = <0x0 0xfdb80000 0x0 0x180>;
+		interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru ACLK_RGA2>, <&cru HCLK_RGA2>, <&cru CLK_RGA2_CORE>;
+		clock-names = "aclk", "hclk", "sclk";
+		resets = <&cru SRST_RGA2_CORE>, <&cru SRST_A_RGA2>, <&cru SRST_H_RGA2>;
+		reset-names = "core", "axi", "ahb";
+		power-domains = <&power RK3588_PD_VDPU>;
+	};
+
 	spll: clock-0 {
 		compatible = "fixed-clock";
 		clock-frequency = <702000000>;
-- 
2.34.1

Re: [PATCH v1 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588

[Jianfeng Liu]

This node is not sorted by bus-address, and anthoer patch adding hantro g1
with addreess fdb50000 is not merged. I will send v2 after that patch is
merged.

Jianfeng

Re: [PATCH v1 0/2] media: rockchip: rga: Add rk3568 support

[Jianfeng Liu]

I am really sorry guys, this patch is for rk3588, I wrote a wrong title.
Do I need to send a v2 patch just changing title of the cover letter?

Regards,
Jianfeng