[PATCH v2] ths7303: Declare as static a private function

[PATCH v2] ths7303: Declare as static a private function

[Ricardo Ribalda Delgado]

git grep shows that the function is only called from ths7303.c

Fix this build warning:

CC      drivers/media/i2c/ths7303.o
drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for  ‘ths7303_setval’ [-Wmissing-prototypes]
   int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
        ^

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v2: Comment by Laurent Pinchart
Align parameters

 drivers/media/i2c/ths7303.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
index 42276d9..ed9ae88 100644
--- a/drivers/media/i2c/ths7303.c
+++ b/drivers/media/i2c/ths7303.c
@@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg, u8 val)
 }
 
 /* following function is used to set ths7303 */
-int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
+static int ths7303_setval(struct v4l2_subdev *sd,
+			  enum ths7303_filter_mode mode)
 {
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
 	struct ths7303_state *state = to_state(sd);
-- 
1.8.4.rc3

Re: [PATCH v2] ths7303: Declare as static a private function

[Laurent Pinchart]

Hi Ricardo,

Thank you for the patch.

On Wednesday 06 November 2013 15:40:18 Ricardo Ribalda Delgado wrote:
> git grep shows that the function is only called from ths7303.c
> 
> Fix this build warning:
> 
> CC      drivers/media/i2c/ths7303.o
> drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for 
> ‘ths7303_setval’ [-Wmissing-prototypes] int ths7303_setval(struct
> v4l2_subdev *sd, enum ths7303_filter_mode mode) ^
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Confirmed :-)

> ---
> v2: Comment by Laurent Pinchart
> Align parameters
> 
>  drivers/media/i2c/ths7303.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
> index 42276d9..ed9ae88 100644
> --- a/drivers/media/i2c/ths7303.c
> +++ b/drivers/media/i2c/ths7303.c
> @@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg,
> u8 val) }
> 
>  /* following function is used to set ths7303 */
> -int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
> +static int ths7303_setval(struct v4l2_subdev *sd,
> +			  enum ths7303_filter_mode mode)
>  {
>  	struct i2c_client *client = v4l2_get_subdevdata(sd);
>  	struct ths7303_state *state = to_state(sd);
-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] ths7303: Declare as static a private function

[Prabhakar Lad]

Hi Ricardo,

Thanks for the patch.

On Wed, Nov 6, 2013 at 8:10 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> git grep shows that the function is only called from ths7303.c
>
> Fix this build warning:
>
> CC      drivers/media/i2c/ths7303.o
> drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for  ‘ths7303_setval’ [-Wmissing-prototypes]
>    int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
>         ^
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Regards,
--Prabhakar Lad