* [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
@ 2023-11-08 6:42 Heiner Kallweit
2023-11-23 20:59 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2023-11-08 6:42 UTC (permalink / raw)
To: Sylwester Nawrocki, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Alim Akhtar
Cc: linux-media, linux-arm-kernel, linux-samsung-soc, linux-i2c
This I2C bus is used by the firmware only and it seems I2C_CLASS_SPD
device auto-detection has never been used. So we can safely remove it.
That's one further step towards removing I2C_CLASS_SPD completely.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
index bef6e9b4a..44363c424 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
@@ -57,7 +57,6 @@ static int fimc_is_i2c_probe(struct platform_device *pdev)
strscpy(i2c_adap->name, "exynos4x12-isp-i2c", sizeof(i2c_adap->name));
i2c_adap->owner = THIS_MODULE;
i2c_adap->algo = &fimc_is_i2c_algorithm;
- i2c_adap->class = I2C_CLASS_SPD;
platform_set_drvdata(pdev, isp_i2c);
pm_runtime_enable(&pdev->dev);
--
2.42.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
2023-11-08 6:42 [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support Heiner Kallweit
@ 2023-11-23 20:59 ` Wolfram Sang
2023-11-23 21:37 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2023-11-23 20:59 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Sylwester Nawrocki, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Alim Akhtar, linux-media, linux-arm-kernel, linux-samsung-soc,
linux-i2c
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Wed, Nov 08, 2023 at 07:42:37AM +0100, Heiner Kallweit wrote:
> This I2C bus is used by the firmware only and it seems I2C_CLASS_SPD
> device auto-detection has never been used. So we can safely remove it.
> That's one further step towards removing I2C_CLASS_SPD completely.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
As I want to apply this cleanup early in the cycle, could we have an ack
for me to modify this subsystem via I2C, please?
> ---
> drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> index bef6e9b4a..44363c424 100644
> --- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> @@ -57,7 +57,6 @@ static int fimc_is_i2c_probe(struct platform_device *pdev)
> strscpy(i2c_adap->name, "exynos4x12-isp-i2c", sizeof(i2c_adap->name));
> i2c_adap->owner = THIS_MODULE;
> i2c_adap->algo = &fimc_is_i2c_algorithm;
> - i2c_adap->class = I2C_CLASS_SPD;
>
> platform_set_drvdata(pdev, isp_i2c);
> pm_runtime_enable(&pdev->dev);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
2023-11-23 20:59 ` Wolfram Sang
@ 2023-11-23 21:37 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2023-11-23 21:37 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Alim Akhtar, linux-samsung-soc, Sylwester Nawrocki,
linux-arm-kernel, Krzysztof Kozlowski, linux-media,
Mauro Carvalho Chehab
On 23.11.2023 21:59, Wolfram Sang wrote:
> On Wed, Nov 08, 2023 at 07:42:37AM +0100, Heiner Kallweit wrote:
>> This I2C bus is used by the firmware only and it seems I2C_CLASS_SPD
>> device auto-detection has never been used. So we can safely remove it.
>> That's one further step towards removing I2C_CLASS_SPD completely.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> As I want to apply this cleanup early in the cycle, could we have an ack
> for me to modify this subsystem via I2C, please?
>
Today I received the following, patch has been applied via the
linux-media tree already.
[git:media_stage/master] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
Author: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed Nov 8 07:42:37 2023 +0100
This I2C bus is used by the firmware only and it seems I2C_CLASS_SPD
device auto-detection has never been used. So we can safely remove it.
That's one further step towards removing I2C_CLASS_SPD completely.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>> ---
>> drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
>> index bef6e9b4a..44363c424 100644
>> --- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
>> +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
>> @@ -57,7 +57,6 @@ static int fimc_is_i2c_probe(struct platform_device *pdev)
>> strscpy(i2c_adap->name, "exynos4x12-isp-i2c", sizeof(i2c_adap->name));
>> i2c_adap->owner = THIS_MODULE;
>> i2c_adap->algo = &fimc_is_i2c_algorithm;
>> - i2c_adap->class = I2C_CLASS_SPD;
>>
>> platform_set_drvdata(pdev, isp_i2c);
>> pm_runtime_enable(&pdev->dev);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-23 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 6:42 [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support Heiner Kallweit
2023-11-23 20:59 ` Wolfram Sang
2023-11-23 21:37 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).