* [PATCH] [media] cx88-dvb: Changed tuner associated with board Hauppauge HVR-4000 from TUNER_PHILIPS_FMD1216ME_MK3 to TUNER_PHILIPS_FMD1216MEX_MK3
@ 2015-12-29 16:26 José David Moreno Juárez
2016-01-25 17:09 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: José David Moreno Juárez @ 2015-12-29 16:26 UTC (permalink / raw)
To: linux-media
The correct tuner for the board Hauppauge HVR-4000 seems to be FMD1216MEX MK3
instead of FMD1216ME MK3. The tuner is identified as such by tveeprom:
Dec 28 23:01:15 [kernel] tveeprom 8-0050: tuner model is Philips
FMD1216MEX (idx 133, type 78)
This patch fixes a longstanding warning message issued by tuner-simple:
Dec 28 23:01:15 [kernel] tuner-simple 8-0061: couldn't set type to 63.
Using 78 (Philips FMD1216MEX MK3 Hybrid Tuner) instead
It has been successfully tested against kernel 4.1.12.
Signed-off-by: José David Moreno Juárez <jose.david@morenojuarez.nom.es>
---
drivers/media/pci/cx88/cx88-dvb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-dvb.c b/drivers/media/pci/cx88/cx88-
dvb.c
index afb2075..ac2ad00 100644
--- a/drivers/media/pci/cx88/cx88-dvb.c
+++ b/drivers/media/pci/cx88/cx88-dvb.c
@@ -1474,7 +1474,7 @@ static int dvb_register(struct cx8802_dev *dev)
if (!dvb_attach(simple_tuner_attach,
fe1->dvb.frontend,
&dev->core->i2c_adap,
- 0x61, TUNER_PHILIPS_FMD1216ME_MK3))
+ 0x61, TUNER_PHILIPS_FMD1216MEX_MK3))
goto frontend_detach;
}
break;
--
2.4.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] cx88-dvb: Changed tuner associated with board Hauppauge HVR-4000 from TUNER_PHILIPS_FMD1216ME_MK3 to TUNER_PHILIPS_FMD1216MEX_MK3
2015-12-29 16:26 [PATCH] [media] cx88-dvb: Changed tuner associated with board Hauppauge HVR-4000 from TUNER_PHILIPS_FMD1216ME_MK3 to TUNER_PHILIPS_FMD1216MEX_MK3 José David Moreno Juárez
@ 2016-01-25 17:09 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2016-01-25 17:09 UTC (permalink / raw)
To: José David Moreno Juárez; +Cc: linux-media
Em Tue, 29 Dec 2015 17:26:41 +0100
José David Moreno Juárez <jose.david@morenojuarez.nom.es> escreveu:
> The correct tuner for the board Hauppauge HVR-4000 seems to be FMD1216MEX MK3
> instead of FMD1216ME MK3. The tuner is identified as such by tveeprom:
> Dec 28 23:01:15 [kernel] tveeprom 8-0050: tuner model is Philips
> FMD1216MEX (idx 133, type 78)
>
> This patch fixes a longstanding warning message issued by tuner-simple:
> Dec 28 23:01:15 [kernel] tuner-simple 8-0061: couldn't set type to 63.
> Using 78 (Philips FMD1216MEX MK3 Hybrid Tuner) instead
>
> It has been successfully tested against kernel 4.1.12.
>
>
>
> Signed-off-by: José David Moreno Juárez <jose.david@morenojuarez.nom.es>
> ---
> drivers/media/pci/cx88/cx88-dvb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/cx88/cx88-dvb.c b/drivers/media/pci/cx88/cx88-
> dvb.c
> index afb2075..ac2ad00 100644
> --- a/drivers/media/pci/cx88/cx88-dvb.c
> +++ b/drivers/media/pci/cx88/cx88-dvb.c
> @@ -1474,7 +1474,7 @@ static int dvb_register(struct cx8802_dev *dev)
> if (!dvb_attach(simple_tuner_attach,
> fe1->dvb.frontend,
> &dev->core->i2c_adap,
> - 0x61, TUNER_PHILIPS_FMD1216ME_MK3))
> + 0x61, TUNER_PHILIPS_FMD1216MEX_MK3))
This will likely break for other Hauppauge devices that use the other
tuner model. The best would be, instead, to use the value returned
by tveeprom here, instead of hardcoding it.
> goto frontend_detach;
> }
> break;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-25 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-29 16:26 [PATCH] [media] cx88-dvb: Changed tuner associated with board Hauppauge HVR-4000 from TUNER_PHILIPS_FMD1216ME_MK3 to TUNER_PHILIPS_FMD1216MEX_MK3 José David Moreno Juárez
2016-01-25 17:09 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).