* [PATCH] cec-follower: create analog channel frequencies
@ 2019-09-16 18:38 Jiunn Chang
2019-09-17 8:34 ` Hans Verkuil
2019-09-17 9:13 ` [PATCH v2] " Jiunn Chang
0 siblings, 2 replies; 6+ messages in thread
From: Jiunn Chang @ 2019-09-16 18:38 UTC (permalink / raw)
To: linux-media, linux-kernel-mentees; +Cc: hverkuil
This frequency table will allow proper testing of tuner control. There
are three frequencies per analog broadcast type and broadcast system, so
tuner increment and decrement can be tested.
Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
---
utils/cec-follower/cec-tuner.cpp | 77 ++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
index 5e794d71..e0d58e6c 100644
--- a/utils/cec-follower/cec-tuner.cpp
+++ b/utils/cec-follower/cec-tuner.cpp
@@ -7,6 +7,83 @@
#include "cec-follower.h"
+/*
+ * This table contains analog television channel frequencies in KHz. There are
+ * a total of three frequencies per analog broadcast type and broadcast system.
+ *
+ * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
+ * broadcast types and broadcast systems.
+ *
+ * The table is indexed by [ana_bcast_type][bcast_system][i].
+ *
+ */
+static unsigned int analog_freqs_khz[3][9][3] =
+{
+ // cable
+ {
+ // pal-bg
+ {471250, 479250, 487250},
+ // secam-lq
+ {615250, 623250, 631250},
+ // pal-m
+ {501250, 507250, 513250},
+ // ntsc-m
+ {519250, 525250, 531250},
+ // pal-i
+ {45750, 53750, 61750},
+ // secam-dk
+ {759250, 767250, 775250},
+ // secam-bg
+ {495250, 503250, 511250},
+ // secam-l
+ {639250, 647250, 655250},
+ // pal-dk
+ {783250, 791250, 799250}
+ },
+ // satellite
+ {
+ // pal-bg
+ {519250, 527250, 535250},
+ // secam-lq
+ {663250, 671250, 679250},
+ // pal-m
+ {537250, 543250, 549250},
+ // ntsc-m
+ {555250, 561250, 567250},
+ // pal-i
+ {175250, 183250, 191250},
+ // secam-dk
+ {807250, 815250, 823250},
+ // secam-bg
+ {543250, 551250, 559250},
+ // secam-l
+ {687250, 695250, 703250},
+ // pal-dk
+ {831250, 839250, 847250}
+ },
+ // terrestrial
+ {
+ // pal-bg
+ {567250, 575250, 583250},
+ // secam-lq
+ {711250, 719250, 727250},
+ // pal-m
+ {573250, 579250, 585250},
+ // ntsc-m
+ {591250, 597250, 603250},
+ // pal-i
+ {199250, 207250, 215250},
+ // secam-dk
+ {145250, 153250, 161250},
+ // secam-bg
+ {591250, 599250, 607250},
+ // secam-l
+ {735250, 743250, 751250},
+ // pal-dk
+ {169250, 177250, 185250}
+ }
+};
+
void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me)
{
switch (msg.msg[1]) {
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cec-follower: create analog channel frequencies
2019-09-16 18:38 [PATCH] cec-follower: create analog channel frequencies Jiunn Chang
@ 2019-09-17 8:34 ` Hans Verkuil
2019-09-17 9:13 ` [PATCH v2] " Jiunn Chang
1 sibling, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-09-17 8:34 UTC (permalink / raw)
To: Jiunn Chang, linux-media, linux-kernel-mentees
On 9/16/19 8:38 PM, Jiunn Chang wrote:
> This frequency table will allow proper testing of tuner control. There
> are three frequencies per analog broadcast type and broadcast system, so
> tuner increment and decrement can be tested.
>
> Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
> ---
> utils/cec-follower/cec-tuner.cpp | 77 ++++++++++++++++++++++++++++++++
> 1 file changed, 77 insertions(+)
>
> diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
> index 5e794d71..e0d58e6c 100644
> --- a/utils/cec-follower/cec-tuner.cpp
> +++ b/utils/cec-follower/cec-tuner.cpp
> @@ -7,6 +7,83 @@
>
> #include "cec-follower.h"
>
> +/*
> + * This table contains analog television channel frequencies in KHz. There are
> + * a total of three frequencies per analog broadcast type and broadcast system.
> + *
> + * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
> + * broadcast types and broadcast systems.
> + *
> + * The table is indexed by [ana_bcast_type][bcast_system][i].
> + *
No need for this empty comment line.
These frequencies are based on data from a wikipedia page, right?
It's useful to add a link to that page in this comment.
> + */
> +static unsigned int analog_freqs_khz[3][9][3] =
> +{
> + // cable
> + {
> + // pal-bg
> + {471250, 479250, 487250},
Add a space after { and before } in this table.
> + // secam-lq
> + {615250, 623250, 631250},
> + // pal-m
> + {501250, 507250, 513250},
> + // ntsc-m
> + {519250, 525250, 531250},
> + // pal-i
> + {45750, 53750, 61750},
> + // secam-dk
> + {759250, 767250, 775250},
> + // secam-bg
> + {495250, 503250, 511250},
> + // secam-l
> + {639250, 647250, 655250},
> + // pal-dk
> + {783250, 791250, 799250}
> + },
> + // satellite
> + {
> + // pal-bg
> + {519250, 527250, 535250},
> + // secam-lq
> + {663250, 671250, 679250},
> + // pal-m
> + {537250, 543250, 549250},
> + // ntsc-m
> + {555250, 561250, 567250},
> + // pal-i
> + {175250, 183250, 191250},
> + // secam-dk
> + {807250, 815250, 823250},
> + // secam-bg
> + {543250, 551250, 559250},
> + // secam-l
> + {687250, 695250, 703250},
> + // pal-dk
> + {831250, 839250, 847250}
> + },
> + // terrestrial
> + {
> + // pal-bg
> + {567250, 575250, 583250},
> + // secam-lq
> + {711250, 719250, 727250},
> + // pal-m
> + {573250, 579250, 585250},
> + // ntsc-m
> + {591250, 597250, 603250},
> + // pal-i
> + {199250, 207250, 215250},
> + // secam-dk
> + {145250, 153250, 161250},
> + // secam-bg
> + {591250, 599250, 607250},
> + // secam-l
> + {735250, 743250, 751250},
> + // pal-dk
> + {169250, 177250, 185250}
> + }
> +};
> +
> void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me)
> {
> switch (msg.msg[1]) {
>
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] cec-follower: create analog channel frequencies
2019-09-16 18:38 [PATCH] cec-follower: create analog channel frequencies Jiunn Chang
2019-09-17 8:34 ` Hans Verkuil
@ 2019-09-17 9:13 ` Jiunn Chang
2019-09-17 9:20 ` Hans Verkuil
2019-09-19 2:53 ` [PATCH v3] " Jiunn Chang
1 sibling, 2 replies; 6+ messages in thread
From: Jiunn Chang @ 2019-09-17 9:13 UTC (permalink / raw)
To: linux-media, linux-kernel-mentees; +Cc: hverkuil
This frequency table will allow proper testing of tuner control. There
are three frequencies per analog broadcast type and broadcast system, so
tuner increment and decrement can be tested.
Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
---
Changes since v1:
- Add Wikipedia link for analog channel frequencies
- Add spaces between { and }
>8---------------------------------------------------------------------------8<
utils/cec-follower/cec-tuner.cpp | 80 ++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
index 5e794d71..912adcb9 100644
--- a/utils/cec-follower/cec-tuner.cpp
+++ b/utils/cec-follower/cec-tuner.cpp
@@ -7,6 +7,86 @@
#include "cec-follower.h"
+/*
+ * This table contains analog television channel frequencies in KHz. There are
+ * a total of three frequencies per analog broadcast type and broadcast system.
+ *
+ * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
+ * broadcast types and broadcast systems.
+ *
+ * The table is indexed by [ana_bcast_type][bcast_system][i].
+ *
+ * Analog channel frequencies are from Wikipedia:
+ *
+ * https://en.wikipedia.org/wiki/Television_channel_frequencies
+ */
+static unsigned int analog_freqs_khz[3][9][3] =
+{
+ // cable
+ {
+ // pal-bg
+ { 471250, 479250, 487250 },
+ // secam-lq
+ { 615250, 623250, 631250 },
+ // pal-m
+ { 501250, 507250, 513250 },
+ // ntsc-m
+ { 519250, 525250, 531250 },
+ // pal-i
+ { 45750, 53750, 61750 },
+ // secam-dk
+ { 759250, 767250, 775250 },
+ // secam-bg
+ { 495250, 503250, 511250 },
+ // secam-l
+ { 639250, 647250, 655250 },
+ // pal-dk
+ { 783250, 791250, 799250 }
+ },
+ // satellite
+ {
+ // pal-bg
+ { 519250, 527250, 535250 },
+ // secam-lq
+ { 663250, 671250, 679250 },
+ // pal-m
+ { 537250, 543250, 549250 },
+ // ntsc-m
+ { 555250, 561250, 567250 },
+ // pal-i
+ { 175250, 183250, 191250 },
+ // secam-dk
+ { 807250, 815250, 823250 },
+ // secam-bg
+ { 543250, 551250, 559250 },
+ // secam-l
+ { 687250, 695250, 703250 },
+ // pal-dk
+ { 831250, 839250, 847250 }
+ },
+ // terrestrial
+ {
+ // pal-bg
+ { 567250, 575250, 583250 },
+ // secam-lq
+ { 711250, 719250, 727250 },
+ // pal-m
+ { 573250, 579250, 585250 },
+ // ntsc-m
+ { 591250, 597250, 603250 },
+ // pal-i
+ { 199250, 207250, 215250 },
+ // secam-dk
+ { 145250, 153250, 161250 },
+ // secam-bg
+ { 591250, 599250, 607250 },
+ // secam-l
+ { 735250, 743250, 751250 },
+ // pal-dk
+ { 169250, 177250, 185250 }
+ }
+};
+
void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me)
{
switch (msg.msg[1]) {
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] cec-follower: create analog channel frequencies
2019-09-17 9:13 ` [PATCH v2] " Jiunn Chang
@ 2019-09-17 9:20 ` Hans Verkuil
2019-09-19 2:53 ` [PATCH v3] " Jiunn Chang
1 sibling, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-09-17 9:20 UTC (permalink / raw)
To: Jiunn Chang, linux-media, linux-kernel-mentees
On 9/17/19 11:13 AM, Jiunn Chang wrote:
> This frequency table will allow proper testing of tuner control. There
> are three frequencies per analog broadcast type and broadcast system, so
> tuner increment and decrement can be tested.
>
> Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
> ---
>
> Changes since v1:
> - Add Wikipedia link for analog channel frequencies
> - Add spaces between { and }
>
>> 8---------------------------------------------------------------------------8<
For future reference: just use --- instead of this line.
The patch looks good, I'll wait for the next patch that will use this before
merging this patch (otherwise I'd be merging dead code!).
Regards,
Hans
>
> utils/cec-follower/cec-tuner.cpp | 80 ++++++++++++++++++++++++++++++++
> 1 file changed, 80 insertions(+)
>
> diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
> index 5e794d71..912adcb9 100644
> --- a/utils/cec-follower/cec-tuner.cpp
> +++ b/utils/cec-follower/cec-tuner.cpp
> @@ -7,6 +7,86 @@
>
> #include "cec-follower.h"
>
> +/*
> + * This table contains analog television channel frequencies in KHz. There are
> + * a total of three frequencies per analog broadcast type and broadcast system.
> + *
> + * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
> + * broadcast types and broadcast systems.
> + *
> + * The table is indexed by [ana_bcast_type][bcast_system][i].
> + *
> + * Analog channel frequencies are from Wikipedia:
> + *
> + * https://en.wikipedia.org/wiki/Television_channel_frequencies
> + */
> +static unsigned int analog_freqs_khz[3][9][3] =
> +{
> + // cable
> + {
> + // pal-bg
> + { 471250, 479250, 487250 },
> + // secam-lq
> + { 615250, 623250, 631250 },
> + // pal-m
> + { 501250, 507250, 513250 },
> + // ntsc-m
> + { 519250, 525250, 531250 },
> + // pal-i
> + { 45750, 53750, 61750 },
> + // secam-dk
> + { 759250, 767250, 775250 },
> + // secam-bg
> + { 495250, 503250, 511250 },
> + // secam-l
> + { 639250, 647250, 655250 },
> + // pal-dk
> + { 783250, 791250, 799250 }
> + },
> + // satellite
> + {
> + // pal-bg
> + { 519250, 527250, 535250 },
> + // secam-lq
> + { 663250, 671250, 679250 },
> + // pal-m
> + { 537250, 543250, 549250 },
> + // ntsc-m
> + { 555250, 561250, 567250 },
> + // pal-i
> + { 175250, 183250, 191250 },
> + // secam-dk
> + { 807250, 815250, 823250 },
> + // secam-bg
> + { 543250, 551250, 559250 },
> + // secam-l
> + { 687250, 695250, 703250 },
> + // pal-dk
> + { 831250, 839250, 847250 }
> + },
> + // terrestrial
> + {
> + // pal-bg
> + { 567250, 575250, 583250 },
> + // secam-lq
> + { 711250, 719250, 727250 },
> + // pal-m
> + { 573250, 579250, 585250 },
> + // ntsc-m
> + { 591250, 597250, 603250 },
> + // pal-i
> + { 199250, 207250, 215250 },
> + // secam-dk
> + { 145250, 153250, 161250 },
> + // secam-bg
> + { 591250, 599250, 607250 },
> + // secam-l
> + { 735250, 743250, 751250 },
> + // pal-dk
> + { 169250, 177250, 185250 }
> + }
> +};
> +
> void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me)
> {
> switch (msg.msg[1]) {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] cec-follower: create analog channel frequencies
2019-09-17 9:13 ` [PATCH v2] " Jiunn Chang
2019-09-17 9:20 ` Hans Verkuil
@ 2019-09-19 2:53 ` Jiunn Chang
2019-09-19 17:47 ` [PATCH v4] " Jiunn Chang
1 sibling, 1 reply; 6+ messages in thread
From: Jiunn Chang @ 2019-09-19 2:53 UTC (permalink / raw)
To: linux-media, linux-kernel-mentees; +Cc: hverkuil
This frequency table will allow proper testing of tuner control. There
are three frequencies per analog broadcast type and broadcast system, so
tuner increment and decrement can be tested.
Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
---
Changes since v1:
- Add Wikipedia link for analog channel frequencies
- Add spaces between { and }
Changes since v2:
- Refactor lines numbers since a fix patch was needed for cec-tuner.cpp
---
utils/cec-follower/cec-tuner.cpp | 80 ++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
index bb727ae7..2303e6bb 100644
--- a/utils/cec-follower/cec-tuner.cpp
+++ b/utils/cec-follower/cec-tuner.cpp
@@ -7,6 +7,86 @@
#include "cec-follower.h"
+/*
+ * This table contains analog television channel frequencies in KHz. There are
+ * a total of three frequencies per analog broadcast type and broadcast system.
+ *
+ * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
+ * broadcast types and broadcast systems.
+ *
+ * The table is indexed by [ana_bcast_type][bcast_system][i].
+ *
+ * Analog channel frequencies are from Wikipedia:
+ *
+ * https://en.wikipedia.org/wiki/Television_channel_frequencies
+ */
+static unsigned int analog_freqs_khz[3][9][3] =
+{
+ // cable
+ {
+ // pal-bg
+ { 471250, 479250, 487250 },
+ // secam-lq
+ { 615250, 623250, 631250 },
+ // pal-m
+ { 501250, 507250, 513250 },
+ // ntsc-m
+ { 519250, 525250, 531250 },
+ // pal-i
+ { 45750, 53750, 61750 },
+ // secam-dk
+ { 759250, 767250, 775250 },
+ // secam-bg
+ { 495250, 503250, 511250 },
+ // secam-l
+ { 639250, 647250, 655250 },
+ // pal-dk
+ { 783250, 791250, 799250 }
+ },
+ // satellite
+ {
+ // pal-bg
+ { 519250, 527250, 535250 },
+ // secam-lq
+ { 663250, 671250, 679250 },
+ // pal-m
+ { 537250, 543250, 549250 },
+ // ntsc-m
+ { 555250, 561250, 567250 },
+ // pal-i
+ { 175250, 183250, 191250 },
+ // secam-dk
+ { 807250, 815250, 823250 },
+ // secam-bg
+ { 543250, 551250, 559250 },
+ // secam-l
+ { 687250, 695250, 703250 },
+ // pal-dk
+ { 831250, 839250, 847250 }
+ },
+ // terrestrial
+ {
+ // pal-bg
+ { 567250, 575250, 583250 },
+ // secam-lq
+ { 711250, 719250, 727250 },
+ // pal-m
+ { 573250, 579250, 585250 },
+ // ntsc-m
+ { 591250, 597250, 603250 },
+ // pal-i
+ { 199250, 207250, 215250 },
+ // secam-dk
+ { 145250, 153250, 161250 },
+ // secam-bg
+ { 591250, 599250, 607250 },
+ // secam-l
+ { 735250, 743250, 751250 },
+ // pal-dk
+ { 169250, 177250, 185250 }
+ }
+};
+
static void reply_feature_abort(struct node *node, struct cec_msg *msg, __u8 reason = CEC_OP_ABORT_UNRECOGNIZED_OP)
{
unsigned la = cec_msg_initiator(msg);
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4] cec-follower: create analog channel frequencies
2019-09-19 2:53 ` [PATCH v3] " Jiunn Chang
@ 2019-09-19 17:47 ` Jiunn Chang
0 siblings, 0 replies; 6+ messages in thread
From: Jiunn Chang @ 2019-09-19 17:47 UTC (permalink / raw)
To: linux-media, linux-kernel-mentees; +Cc: hverkuil
This frequency table will allow proper testing of tuner control. There
are three frequencies per analog broadcast type and broadcast system, so
tuner increment and decrement can be tested.
Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
---
Changes made since v1:
- Add Wikipedia link for analog channel frequencies
- Add spaces between { and }
Changes made since v2:
- Add reply_feature_abort() to cec-tuner.cpp
- Refactor lines numbers since a fix patch was needed for cec-tuner.cpp
Changes made since v3:
- Remove reply_feature_abort() from cec-tuner.cpp
- Add macro for NUM_ANALOG_FREQS
- Refactor lines numbers since a fix patch was needed for cec-tuner.cpp
---
utils/cec-follower/cec-tuner.cpp | 82 ++++++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tuner.cpp
index a1e349bd..bdeda342 100644
--- a/utils/cec-follower/cec-tuner.cpp
+++ b/utils/cec-follower/cec-tuner.cpp
@@ -7,6 +7,88 @@
#include "cec-follower.h"
+#define NUM_ANALOG_FREQS 3
+
+/*
+ * This table contains analog television channel frequencies in KHz. There are
+ * a total of three frequencies per analog broadcast type and broadcast system.
+ *
+ * CEC 17 and CEC Table 31 of the 1.4 specification lists the available analog
+ * broadcast types and broadcast systems.
+ *
+ * The table is indexed by [ana_bcast_type][bcast_system][NUM_ANALOG_FREQS].
+ *
+ * Analog channel frequencies are from Wikipedia:
+ *
+ * https://en.wikipedia.org/wiki/Television_channel_frequencies
+ */
+static unsigned int analog_freqs_khz[3][9][NUM_ANALOG_FREQS] =
+{
+ // cable
+ {
+ // pal-bg
+ { 471250, 479250, 487250 },
+ // secam-lq
+ { 615250, 623250, 631250 },
+ // pal-m
+ { 501250, 507250, 513250 },
+ // ntsc-m
+ { 519250, 525250, 531250 },
+ // pal-i
+ { 45750, 53750, 61750 },
+ // secam-dk
+ { 759250, 767250, 775250 },
+ // secam-bg
+ { 495250, 503250, 511250 },
+ // secam-l
+ { 639250, 647250, 655250 },
+ // pal-dk
+ { 783250, 791250, 799250 }
+ },
+ // satellite
+ {
+ // pal-bg
+ { 519250, 527250, 535250 },
+ // secam-lq
+ { 663250, 671250, 679250 },
+ // pal-m
+ { 537250, 543250, 549250 },
+ // ntsc-m
+ { 555250, 561250, 567250 },
+ // pal-i
+ { 175250, 183250, 191250 },
+ // secam-dk
+ { 807250, 815250, 823250 },
+ // secam-bg
+ { 543250, 551250, 559250 },
+ // secam-l
+ { 687250, 695250, 703250 },
+ // pal-dk
+ { 831250, 839250, 847250 }
+ },
+ // terrestrial
+ {
+ // pal-bg
+ { 567250, 575250, 583250 },
+ // secam-lq
+ { 711250, 719250, 727250 },
+ // pal-m
+ { 573250, 579250, 585250 },
+ // ntsc-m
+ { 591250, 597250, 603250 },
+ // pal-i
+ { 199250, 207250, 215250 },
+ // secam-dk
+ { 145250, 153250, 161250 },
+ // secam-bg
+ { 591250, 599250, 607250 },
+ // secam-l
+ { 735250, 743250, 751250 },
+ // pal-dk
+ { 169250, 177250, 185250 }
+ }
+};
+
void process_tuner_record_timer_msgs(struct node *node, struct cec_msg &msg, unsigned me)
{
bool is_bcast = cec_msg_is_broadcast(&msg);
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-19 17:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-16 18:38 [PATCH] cec-follower: create analog channel frequencies Jiunn Chang
2019-09-17 8:34 ` Hans Verkuil
2019-09-17 9:13 ` [PATCH v2] " Jiunn Chang
2019-09-17 9:20 ` Hans Verkuil
2019-09-19 2:53 ` [PATCH v3] " Jiunn Chang
2019-09-19 17:47 ` [PATCH v4] " Jiunn Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).