From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: linux-media@vger.kernel.org
Cc: Oliver Endriss <o.endriss@gmx.de>, Ralph Metzler <rjkm@metzlerbros.de>
Subject: Re: [PATCH 0/5] Driver support for cards based on Digital Devices bridge (ddbridge)
Date: Fri, 15 Jul 2011 09:40:35 -0300 [thread overview]
Message-ID: <4E203543.6090905@redhat.com> (raw)
In-Reply-To: <201107150721.25744@orion.escape-edv.de>
Em 15-07-2011 02:21, Oliver Endriss escreveu:
> On Friday 15 July 2011 06:18:27 Mauro Carvalho Chehab wrote:
>> Em 14-07-2011 20:45, Oliver Endriss escreveu:
>>> - DVB-T tuning does not work anymore.
>>
>> The enclosed patch should fix the issue. It were due to a wrong goto error
>> replacements that happened at the changeset that were fixing the error
>> propagation logic. Sorry for that.
>>
>> Please test.
>
> Done. DVB-T works again. Thanks.
Thanks for reporting the issue and testing the fix!
> @all
> Could someone please test DVB-C?
>
>> [media] drxk: Fix a bug at some switches that broke DVB-T
>>
>> The error propagation changeset c23bf4402 broke the DVB-T
>> code, as it wrongly replaced some break with goto error.
>> Fix the broken logic.
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
>> index a0e2ff5..217796d 100644
>> --- a/drivers/media/dvb/frontends/drxk_hard.c
>> +++ b/drivers/media/dvb/frontends/drxk_hard.c
>> @@ -3451,13 +3451,13 @@ static int DVBTCtrlSetEchoThreshold(struct drxk_state *state,
>> data |= ((echoThres->threshold <<
>> OFDM_SC_RA_RAM_ECHO_THRES_2K__B)
>> & (OFDM_SC_RA_RAM_ECHO_THRES_2K__M));
>> - goto error;
>> + break;
>> case DRX_FFTMODE_8K:
>> data &= ~OFDM_SC_RA_RAM_ECHO_THRES_8K__M;
>> data |= ((echoThres->threshold <<
>> OFDM_SC_RA_RAM_ECHO_THRES_8K__B)
>> & (OFDM_SC_RA_RAM_ECHO_THRES_8K__M));
>> - goto error;
>> + break;
>> default:
>> return -EINVAL;
>> goto error;
> ^^^^^^^^^^^
> Hm, this 'goto' should be removed.
True. I've just added a small trivial patch removing this goto, and a break after
a return.
Thanks!
Mauro
next prev parent reply other threads:[~2011-07-15 12:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 21:21 [PATCH 0/5] Driver support for cards based on Digital Devices bridge (ddbridge) Oliver Endriss
2011-07-03 21:23 ` PATCH 1/5] ddbridge: Initial check-in Oliver Endriss
2011-07-03 21:24 ` [PATCH 2/5] ddbridge: Codingstyle fixes Oliver Endriss
2011-07-03 21:25 ` [PATCH 3/5] ddbridge: Allow compiling of the driver Oliver Endriss
2011-07-03 21:26 ` [PATCH 4/5] cxd2099: Fix compilation of ngene/ddbridge for DVB_CXD2099=n Oliver Endriss
2011-07-04 10:14 ` Bjørn Mork
2011-07-03 21:27 ` [PATCH 5/5] cxd2099: Update Kconfig description (ddbridge support) Oliver Endriss
2011-07-04 0:06 ` Walter Van Eetvelt
2011-07-03 22:27 ` [PATCH 0/5] Driver support for cards based on Digital Devices bridge (ddbridge) Mauro Carvalho Chehab
2011-07-03 23:24 ` Oliver Endriss
2011-07-04 0:17 ` Mauro Carvalho Chehab
2011-07-14 23:45 ` Oliver Endriss
2011-07-15 0:47 ` Mauro Carvalho Chehab
2011-07-15 2:11 ` Oliver Endriss
2011-07-15 4:01 ` Mauro Carvalho Chehab
2011-07-15 3:56 ` Mauro Carvalho Chehab
2011-07-15 5:17 ` Oliver Endriss
2011-07-15 8:26 ` Ralph Metzler
2011-07-15 13:25 ` Mauro Carvalho Chehab
2011-07-15 17:01 ` Andreas Oberritter
2011-07-15 17:34 ` Mauro Carvalho Chehab
2011-07-15 23:41 ` Antti Palosaari
2011-07-16 12:25 ` Mauro Carvalho Chehab
2011-07-16 14:16 ` Antti Palosaari
2011-07-16 14:54 ` Mauro Carvalho Chehab
2011-07-16 15:40 ` Andreas Oberritter
2011-07-16 15:44 ` Antti Palosaari
2011-07-16 15:53 ` Andreas Oberritter
2011-07-16 15:59 ` Antti Palosaari
2011-07-16 16:37 ` Rémi Denis-Courmont
2011-07-17 2:51 ` Andreas Oberritter
2011-07-17 7:51 ` Rémi Denis-Courmont
2011-07-17 0:56 ` Mauro Carvalho Chehab
2011-07-17 3:02 ` Andreas Oberritter
2011-07-17 3:59 ` Mauro Carvalho Chehab
2011-07-17 7:39 ` Rémi Denis-Courmont
2011-07-17 8:01 ` Mauro Carvalho Chehab
2011-07-17 1:07 ` Mauro Carvalho Chehab
2011-07-16 15:40 ` Oliver Endriss
2011-11-03 7:49 ` Steffen Barszus
2011-11-03 17:24 ` Lars Hanisch
2011-07-15 4:18 ` Mauro Carvalho Chehab
2011-07-15 5:21 ` Oliver Endriss
2011-07-15 12:40 ` Mauro Carvalho Chehab [this message]
2011-07-17 11:44 ` Oliver Endriss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E203543.6090905@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=o.endriss@gmx.de \
--cc=rjkm@metzlerbros.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).