From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Xia Jiang <xia.jiang@mediatek.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rick Chang <rick.chang@mediatek.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
srv_heupstream@mediatek.com, senozhatsky@chromium.org,
mojahsu@chromium.org, drinkcat@chromium.org,
maoguang.meng@mediatek.com, sj.huang@mediatek.com
Subject: Re: [PATCH v8 08/14] media: platform: Change case for improving code quality
Date: Mon, 11 May 2020 10:37:50 +0200 [thread overview]
Message-ID: <4b8cc41e-5171-0d48-f588-96e4212ab22c@xs4all.nl> (raw)
In-Reply-To: <20200403094033.8288-9-xia.jiang@mediatek.com>
On 03/04/2020 11:40, Xia Jiang wrote:
> Change register offset hex numberals from upercase to lowercase.
Typos:
numberals -> numerals
upercase -> uppercase
Regards,
Hans
>
> Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
> ---
> v8: no changes
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h
> index 94db04e9cdb6..2945da842dfa 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_reg.h
> @@ -20,29 +20,29 @@
> #define BIT_INQST_MASK_ALLIRQ 0x37
>
> #define JPGDEC_REG_RESET 0x0090
> -#define JPGDEC_REG_BRZ_FACTOR 0x00F8
> -#define JPGDEC_REG_DU_NUM 0x00FC
> +#define JPGDEC_REG_BRZ_FACTOR 0x00f8
> +#define JPGDEC_REG_DU_NUM 0x00fc
> #define JPGDEC_REG_DEST_ADDR0_Y 0x0140
> #define JPGDEC_REG_DEST_ADDR0_U 0x0144
> #define JPGDEC_REG_DEST_ADDR0_V 0x0148
> -#define JPGDEC_REG_DEST_ADDR1_Y 0x014C
> +#define JPGDEC_REG_DEST_ADDR1_Y 0x014c
> #define JPGDEC_REG_DEST_ADDR1_U 0x0150
> #define JPGDEC_REG_DEST_ADDR1_V 0x0154
> #define JPGDEC_REG_STRIDE_Y 0x0158
> -#define JPGDEC_REG_STRIDE_UV 0x015C
> +#define JPGDEC_REG_STRIDE_UV 0x015c
> #define JPGDEC_REG_IMG_STRIDE_Y 0x0160
> #define JPGDEC_REG_IMG_STRIDE_UV 0x0164
> -#define JPGDEC_REG_WDMA_CTRL 0x016C
> +#define JPGDEC_REG_WDMA_CTRL 0x016c
> #define JPGDEC_REG_PAUSE_MCU_NUM 0x0170
> -#define JPGDEC_REG_OPERATION_MODE 0x017C
> +#define JPGDEC_REG_OPERATION_MODE 0x017c
> #define JPGDEC_REG_FILE_ADDR 0x0200
> -#define JPGDEC_REG_COMP_ID 0x020C
> +#define JPGDEC_REG_COMP_ID 0x020c
> #define JPGDEC_REG_TOTAL_MCU_NUM 0x0210
> #define JPGDEC_REG_COMP0_DATA_UNIT_NUM 0x0224
> -#define JPGDEC_REG_DU_CTRL 0x023C
> +#define JPGDEC_REG_DU_CTRL 0x023c
> #define JPGDEC_REG_TRIG 0x0240
> #define JPGDEC_REG_FILE_BRP 0x0248
> -#define JPGDEC_REG_FILE_TOTAL_SIZE 0x024C
> +#define JPGDEC_REG_FILE_TOTAL_SIZE 0x024c
> #define JPGDEC_REG_QT_ID 0x0270
> #define JPGDEC_REG_INTERRUPT_STATUS 0x0274
> #define JPGDEC_REG_STATUS 0x0278
>
next prev parent reply other threads:[~2020-05-11 8:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:40 [PATCH v8 00/14] Add support for mt2701 JPEG ENC support Xia Jiang
2020-04-03 9:40 ` [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-05-21 13:45 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 02/14] media: platform: Improve queue set up " Xia Jiang
2020-05-21 13:46 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 03/14] media: platform: Improve getting and requesting irq " Xia Jiang
2020-05-21 13:47 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-05-11 8:39 ` Hans Verkuil
2020-05-21 13:59 ` Tomasz Figa
2020-06-05 6:02 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 05/14] media: platform: Improve power on and power off flow Xia Jiang
2020-05-21 15:22 ` Tomasz Figa
2020-06-05 6:03 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Xia Jiang
2020-05-21 15:32 ` Tomasz Figa
2020-05-27 1:52 ` Xia Jiang
2020-05-27 14:46 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 07/14] media: platform: Use kernel native functions for improving code quality Xia Jiang
2020-05-21 15:41 ` Tomasz Figa
2020-06-05 6:41 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 08/14] media: platform: Change case " Xia Jiang
2020-05-11 8:37 ` Hans Verkuil [this message]
2020-06-05 8:04 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 09/14] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-05-21 15:44 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 10/14] media: platform: Delete redundant code for improving code quality Xia Jiang
2020-05-21 15:49 ` Tomasz Figa
2020-06-05 6:41 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 11/14] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-05-21 16:00 ` Tomasz Figa
2020-06-18 3:40 ` Xia Jiang
2020-06-18 12:34 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 12/14] arm: dts: Add jpeg enc device tree node Xia Jiang
2020-04-07 3:52 ` Yingjoe Chen
2020-04-03 9:40 ` [PATCH v8 13/14] media: platform: Rename jpeg dec file name Xia Jiang
2020-05-21 16:02 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 14/14] media: platform: Add jpeg dec/enc feature Xia Jiang
2020-05-11 9:04 ` Hans Verkuil
2020-05-21 16:08 ` Tomasz Figa
2020-06-05 8:07 ` Xia Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8cc41e-5171-0d48-f588-96e4212ab22c@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mojahsu@chromium.org \
--cc=rick.chang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).