From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Xia Jiang <xia.jiang@mediatek.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rick Chang <rick.chang@mediatek.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
srv_heupstream@mediatek.com, senozhatsky@chromium.org,
mojahsu@chromium.org, drinkcat@chromium.org,
maoguang.meng@mediatek.com, sj.huang@mediatek.com
Subject: Re: [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value
Date: Mon, 11 May 2020 10:39:02 +0200 [thread overview]
Message-ID: <c4b04c02-b04c-5e83-d3bc-4d9a78df013b@xs4all.nl> (raw)
In-Reply-To: <20200403094033.8288-5-xia.jiang@mediatek.com>
On 03/04/2020 11:40, Xia Jiang wrote:
> Change device node number from 3 to -1 because that the driver will
> also support jpeg encoder.
>
> Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index e2a1d850813b..a536fa95b3d6 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1154,7 +1154,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
> jpeg->dec_vdev->device_caps = V4L2_CAP_STREAMING |
> V4L2_CAP_VIDEO_M2M_MPLANE;
>
> - ret = video_register_device(jpeg->dec_vdev, VFL_TYPE_GRABBER, 3);
> + ret = video_register_device(jpeg->dec_vdev, VFL_TYPE_GRABBER, -1);
VFL_TYPE_GRABBER was renamed to VFL_TYPE_VIDEO.
It looks like this patch series is not on top of the media_tree repo master branch.
Please make sure your patch series is on top of that.
Regards,
Hans
> if (ret) {
> v4l2_err(&jpeg->v4l2_dev, "Failed to register video device\n");
> goto err_dec_vdev_register;
>
next prev parent reply other threads:[~2020-05-11 8:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:40 [PATCH v8 00/14] Add support for mt2701 JPEG ENC support Xia Jiang
2020-04-03 9:40 ` [PATCH v8 01/14] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-05-21 13:45 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 02/14] media: platform: Improve queue set up " Xia Jiang
2020-05-21 13:46 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 03/14] media: platform: Improve getting and requesting irq " Xia Jiang
2020-05-21 13:47 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-05-11 8:39 ` Hans Verkuil [this message]
2020-05-21 13:59 ` Tomasz Figa
2020-06-05 6:02 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 05/14] media: platform: Improve power on and power off flow Xia Jiang
2020-05-21 15:22 ` Tomasz Figa
2020-06-05 6:03 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 06/14] media: platform: Improve the implementation of the system PM ops Xia Jiang
2020-05-21 15:32 ` Tomasz Figa
2020-05-27 1:52 ` Xia Jiang
2020-05-27 14:46 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 07/14] media: platform: Use kernel native functions for improving code quality Xia Jiang
2020-05-21 15:41 ` Tomasz Figa
2020-06-05 6:41 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 08/14] media: platform: Change case " Xia Jiang
2020-05-11 8:37 ` Hans Verkuil
2020-06-05 8:04 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 09/14] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-05-21 15:44 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 10/14] media: platform: Delete redundant code for improving code quality Xia Jiang
2020-05-21 15:49 ` Tomasz Figa
2020-06-05 6:41 ` Xia Jiang
2020-04-03 9:40 ` [PATCH v8 11/14] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-05-21 16:00 ` Tomasz Figa
2020-06-18 3:40 ` Xia Jiang
2020-06-18 12:34 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 12/14] arm: dts: Add jpeg enc device tree node Xia Jiang
2020-04-07 3:52 ` Yingjoe Chen
2020-04-03 9:40 ` [PATCH v8 13/14] media: platform: Rename jpeg dec file name Xia Jiang
2020-05-21 16:02 ` Tomasz Figa
2020-04-03 9:40 ` [PATCH v8 14/14] media: platform: Add jpeg dec/enc feature Xia Jiang
2020-05-11 9:04 ` Hans Verkuil
2020-05-21 16:08 ` Tomasz Figa
2020-06-05 8:07 ` Xia Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b04c02-b04c-5e83-d3bc-4d9a78df013b@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mojahsu@chromium.org \
--cc=rick.chang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).