* [PATCH] videobuf2-core: remove duplicated code
@ 2014-05-21 9:48 Victor Lambret
2014-05-21 10:36 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Victor Lambret @ 2014-05-21 9:48 UTC (permalink / raw)
To: Pawel Osciak, Marek Szyprowski, Kyungmin Park,
Mauro Carvalho Chehab, linux-media, linux-kernel
Cc: Victor Lambret
Remove duplicated test of buffer presence at streamon
Signed-off-by: Victor Lambret <victor.lambret.ext@parrot.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index f9059bb..b731b66 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2067,10 +2067,6 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
return -EINVAL;
}
- if (!q->num_buffers) {
- dprintk(1, "streamon: no buffers have been allocated\n");
- return -EINVAL;
- }
if (q->num_buffers < q->min_buffers_needed) {
dprintk(1, "streamon: need at least %u allocated buffers\n",
q->min_buffers_needed);
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] videobuf2-core: remove duplicated code
2014-05-21 9:48 [PATCH] videobuf2-core: remove duplicated code Victor Lambret
@ 2014-05-21 10:36 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2014-05-21 10:36 UTC (permalink / raw)
To: Victor Lambret, Pawel Osciak, Kyungmin Park,
Mauro Carvalho Chehab, linux-media, linux-kernel
Hello,
On 2014-05-21 11:48, Victor Lambret wrote:
> Remove duplicated test of buffer presence at streamon
>
> Signed-off-by: Victor Lambret <victor.lambret.ext@parrot.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index f9059bb..b731b66 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -2067,10 +2067,6 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
> return -EINVAL;
> }
>
> - if (!q->num_buffers) {
> - dprintk(1, "streamon: no buffers have been allocated\n");
> - return -EINVAL;
> - }
> if (q->num_buffers < q->min_buffers_needed) {
> dprintk(1, "streamon: need at least %u allocated buffers\n",
> q->min_buffers_needed);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-21 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-21 9:48 [PATCH] videobuf2-core: remove duplicated code Victor Lambret
2014-05-21 10:36 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).