linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Compiler warning from drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’
@ 2015-06-24  3:05 Shuah Khan
  2015-07-14 22:54 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2015-06-24  3:05 UTC (permalink / raw)
  To: Mauro Carvalho Chehab (m.chehab@samsung.com)
  Cc: Linux Media Mailing List, Shuah Khan

Hi Mauro,

I am seeing the following warning from au0828 - linux_media
media_controller branch:

drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’:
drivers/media/usb/au0828/au0828-video.c:679:6: warning: ‘entity’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
   if (sink == entity)
      ^
drivers/media/usb/au0828/au0828-video.c:644:24: note: ‘entity’ was
declared here
  struct media_entity  *entity, *source;
                        ^

This looks real to me, but don't know what entity should have been
initialized to.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Compiler warning from drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’
  2015-06-24  3:05 Compiler warning from drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’ Shuah Khan
@ 2015-07-14 22:54 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2015-07-14 22:54 UTC (permalink / raw)
  To: Mauro Carvalho Chehab (m.chehab@samsung.com); +Cc: Linux Media Mailing List

On 06/23/2015 09:05 PM, Shuah Khan wrote:
> Hi Mauro,
> 
> I am seeing the following warning from au0828 - linux_media
> media_controller branch:
> 
> drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’:
> drivers/media/usb/au0828/au0828-video.c:679:6: warning: ‘entity’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>    if (sink == entity)
>       ^
> drivers/media/usb/au0828/au0828-video.c:644:24: note: ‘entity’ was
> declared here
>   struct media_entity  *entity, *source;
>                         ^
> 
> This looks real to me, but don't know what entity should have been
> initialized to.
> 

Hi Mauro,

I don't your patch that fixes this issue in the media-controller branch.
Are you planning to get that in?

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-14 22:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24  3:05 Compiler warning from drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’ Shuah Khan
2015-07-14 22:54 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).