Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

[Sergei Shtylyov]

Hello.

On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote:

> This is an automatic generated email to let you know that the following patch were queued at the
> http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
>
> Subject: [media] rcar_vin: call g_std() instead of querystd()
> Author:  Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date:    Thu Sep 3 20:18:05 2015 -0300
>
> Hans Verkuil says: "The only place querystd can be called  is in the QUERYSTD
> ioctl, all other ioctls should use the last set standard." So call the g_std()
> subdevice method instead of querystd() in the driver's set_fmt() method.
>
> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

    Note that merging this patch without the 2 patches preceding it in the the 
series will break the frame capture.

MBR, Sergei

Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

[Guennadi Liakhovetski]

On Sat, 26 Sep 2015, Sergei Shtylyov wrote:

> Hello.
> 
> On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote:
> 
> > This is an automatic generated email to let you know that the following
> > patch were queued at the
> > http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
> > 
> > Subject: [media] rcar_vin: call g_std() instead of querystd()
> > Author:  Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Date:    Thu Sep 3 20:18:05 2015 -0300
> > 
> > Hans Verkuil says: "The only place querystd can be called  is in the
> > QUERYSTD
> > ioctl, all other ioctls should use the last set standard." So call the
> > g_std()
> > subdevice method instead of querystd() in the driver's set_fmt() method.
> > 
> > Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> 
>    Note that merging this patch without the 2 patches preceding it in the the
> series will break the frame capture.

Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them, 
but I guess I should have read patch 0/3, on which I was indeed CC'ed and 
just have acked this patch instead of pushing it... Mauro, I guess the 
only two possibilities to fix this now is to also push the other two 
patches or to revert this one. Sorry about this.

Thanks
Guennadi

Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

[Mauro Carvalho Chehab]

Em Sun, 27 Sep 2015 21:23:29 +0200
Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:

> On Sat, 26 Sep 2015, Sergei Shtylyov wrote:
> 
> > Hello.
> > 
> > On 09/25/2015 11:32 PM, Mauro Carvalho Chehab wrote:
> > 
> > > This is an automatic generated email to let you know that the following
> > > patch were queued at the
> > > http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
> > > 
> > > Subject: [media] rcar_vin: call g_std() instead of querystd()
> > > Author:  Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > Date:    Thu Sep 3 20:18:05 2015 -0300
> > > 
> > > Hans Verkuil says: "The only place querystd can be called  is in the
> > > QUERYSTD
> > > ioctl, all other ioctls should use the last set standard." So call the
> > > g_std()
> > > subdevice method instead of querystd() in the driver's set_fmt() method.
> > > 
> > > Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > 
> >    Note that merging this patch without the 2 patches preceding it in the the
> > series will break the frame capture.
> 
> Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them, 
> but I guess I should have read patch 0/3, on which I was indeed CC'ed and 
> just have acked this patch instead of pushing it... Mauro, I guess the 
> only two possibilities to fix this now is to also push the other two 
> patches or to revert this one. Sorry about this.

Well, if the other two patches are OK, then send me a pull request,
and I'll merge them.

> 
> Thanks
> Guennadi

Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

[Sergei Shtylyov]

Hello.

On 9/27/2015 11:08 PM, Mauro Carvalho Chehab wrote:

>>>> This is an automatic generated email to let you know that the following
>>>> patch were queued at the
>>>> http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
>>>>
>>>> Subject: [media] rcar_vin: call g_std() instead of querystd()
>>>> Author:  Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Date:    Thu Sep 3 20:18:05 2015 -0300
>>>>
>>>> Hans Verkuil says: "The only place querystd can be called  is in the
>>>> QUERYSTD
>>>> ioctl, all other ioctls should use the last set standard." So call the
>>>> g_std()
>>>> subdevice method instead of querystd() in the driver's set_fmt() method.
>>>>
>>>> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>>>
>>>     Note that merging this patch without the 2 patches preceding it in the the
>>> series will break the frame capture.
>>
>> Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them,
>> but I guess I should have read patch 0/3, on which I was indeed CC'ed and
>> just have acked this patch instead of pushing it... Mauro, I guess the
>> only two possibilities to fix this now is to also push the other two
>> patches or to revert this one. Sorry about this.

> Well, if the other two patches are OK, then send me a pull request,
> and I'll merge them.

    The adv7180 patch was rejected by Hans. I'm still hoping Lars-Peter will 
look into removing the auto-detect feature from this driver.

MBR, Sergei