* [PATCH 1/1] staging: media: fix style problem
@ 2019-06-21 6:39 Aliasgar Surti
2019-06-25 7:17 ` Hans Verkuil
0 siblings, 1 reply; 7+ messages in thread
From: Aliasgar Surti @ 2019-06-21 6:39 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, hverkuil-cisco, linux-media,
devel, linux-kernel
Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
checkpatch reported "WARNING: line over 80 characters".
This patch fixes the warning for file soc_camera/soc_ov5642.c
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
drivers/staging/media/soc_camera/soc_ov5642.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_ov5642.c b/drivers/staging/media/soc_camera/soc_ov5642.c
index 94696d7..39ae24dc 100644
--- a/drivers/staging/media/soc_camera/soc_ov5642.c
+++ b/drivers/staging/media/soc_camera/soc_ov5642.c
@@ -687,7 +687,8 @@ static int reg_write16(struct i2c_client *client, u16 reg, u16 val16)
}
#ifdef CONFIG_VIDEO_ADV_DEBUG
-static int ov5642_get_register(struct v4l2_subdev *sd, struct v4l2_dbg_register *reg)
+static int ov5642_get_register(struct v4l2_subdev *sd,
+ struct v4l2_dbg_register *reg)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
int ret;
@@ -705,7 +706,8 @@ static int ov5642_get_register(struct v4l2_subdev *sd, struct v4l2_dbg_register
return ret;
}
-static int ov5642_set_register(struct v4l2_subdev *sd, const struct v4l2_dbg_register *reg)
+static int ov5642_set_register(struct v4l2_subdev *sd,
+ const struct v4l2_dbg_register *reg)
{
struct i2c_client *client = v4l2_get_subdevdata(sd);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: media: fix style problem
2019-06-21 6:39 [PATCH 1/1] staging: media: fix style problem Aliasgar Surti
@ 2019-06-25 7:17 ` Hans Verkuil
2019-06-25 13:22 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Hans Verkuil @ 2019-06-25 7:17 UTC (permalink / raw)
To: Aliasgar Surti, mchehab, gregkh, sakari.ailus, linux-media,
devel, linux-kernel
On 6/21/19 8:39 AM, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file soc_camera/soc_ov5642.c
FYI: we're not accepting patches for staging/media/soc_camera: these
are obsolete and broken drivers.
Regards,
Hans
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> drivers/staging/media/soc_camera/soc_ov5642.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/soc_camera/soc_ov5642.c b/drivers/staging/media/soc_camera/soc_ov5642.c
> index 94696d7..39ae24dc 100644
> --- a/drivers/staging/media/soc_camera/soc_ov5642.c
> +++ b/drivers/staging/media/soc_camera/soc_ov5642.c
> @@ -687,7 +687,8 @@ static int reg_write16(struct i2c_client *client, u16 reg, u16 val16)
> }
>
> #ifdef CONFIG_VIDEO_ADV_DEBUG
> -static int ov5642_get_register(struct v4l2_subdev *sd, struct v4l2_dbg_register *reg)
> +static int ov5642_get_register(struct v4l2_subdev *sd,
> + struct v4l2_dbg_register *reg)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> int ret;
> @@ -705,7 +706,8 @@ static int ov5642_get_register(struct v4l2_subdev *sd, struct v4l2_dbg_register
> return ret;
> }
>
> -static int ov5642_set_register(struct v4l2_subdev *sd, const struct v4l2_dbg_register *reg)
> +static int ov5642_set_register(struct v4l2_subdev *sd,
> + const struct v4l2_dbg_register *reg)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: media: fix style problem
2019-06-25 7:17 ` Hans Verkuil
@ 2019-06-25 13:22 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2019-06-25 13:22 UTC (permalink / raw)
To: Hans Verkuil, Aliasgar Surti, mchehab, gregkh, sakari.ailus,
linux-media, devel, linux-kernel
On Tue, 2019-06-25 at 09:17 +0200, Hans Verkuil wrote:
> On 6/21/19 8:39 AM, Aliasgar Surti wrote:
> > From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> >
> > checkpatch reported "WARNING: line over 80 characters".
> > This patch fixes the warning for file soc_camera/soc_ov5642.c
>
> FYI: we're not accepting patches for staging/media/soc_camera: these
> are obsolete and broken drivers.
Then mark the MAINTAINERS entry as Orphan / Obsolete
It's currently:
SOC-CAMERA V4L2 SUBSYSTEM
L: linux-media@vger.kernel.org
T: git git://linuxtv.org/media_tree.git
S: Orphan
F: include/media/soc_camera.h
F: drivers/staging/media/soc_camera/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] staging: media: fix style problem
@ 2019-06-20 5:31 Aliasgar Surti
2019-06-20 21:25 ` André Almeida
0 siblings, 1 reply; 7+ messages in thread
From: Aliasgar Surti @ 2019-06-20 5:31 UTC (permalink / raw)
To: linux-media, gregkh, linux-kernel; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
checkpatch reported "WARNING: line over 80 characters".
This patch fixes the warning for file davinci_vpfe/dm365_isif.c
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
index 46fd818..e9c8de1 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
@@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
#define DM365_ISIF_MAX_CLVSV 0x1fff
#define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
-static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
+static int
+isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
{
int err = -EINVAL;
@@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
return isif_validate_bclamp_params(¶ms->bclamp);
}
-static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
+static int isif_set_params(struct v4l2_subdev *sd,
+ const struct vpfe_isif_raw_config *params)
{
struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
int ret = -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: media: fix style problem
2019-06-20 5:31 Aliasgar Surti
@ 2019-06-20 21:25 ` André Almeida
0 siblings, 0 replies; 7+ messages in thread
From: André Almeida @ 2019-06-20 21:25 UTC (permalink / raw)
To: Aliasgar Surti, linux-media, gregkh, linux-kernel
Hello Alisgar,
On 6/20/19 2:31 AM, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file davinci_vpfe/dm365_isif.c
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> index 46fd818..e9c8de1 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> @@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
> #define DM365_ISIF_MAX_CLVSV 0x1fff
> #define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
>
> -static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> +static int
> +isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> {
> int err = -EINVAL;
>
> @@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
> return isif_validate_bclamp_params(¶ms->bclamp);
> }
>
> -static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
> +static int isif_set_params(struct v4l2_subdev *sd,
> + const struct vpfe_isif_raw_config *params)
> {
> struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
> int ret = -EINVAL;
When you resend a patch with some modifications you have done after
receiving some feedback, don't forget to increase the version of your
patch . One can do this by adding the `-v2` flag at `git format-patch`
command. It is also a good practice to changelog what modifications you
did bellow the `---` mark.
Have a look at this v3[1]. And please read "Revising your patches"[2]
for a complete documentation.
Good hacking!
André
[1] https://patchwork.kernel.org/patch/10999271/
[2] https://kernelnewbies.org/FirstKernelPatch
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] staging: media: fix style problem
@ 2019-06-20 5:02 Aliasgar Surti
2019-06-20 5:09 ` Nathan Chancellor
0 siblings, 1 reply; 7+ messages in thread
From: Aliasgar Surti @ 2019-06-20 5:02 UTC (permalink / raw)
To: linux-media, gregkh, linux-kernel; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
checkpatch reported "WARNING: line over 80 characters".
This patch fixes the warning for file davinci_vpfe/dm365_isif.c
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
index 46fd818..12bdf91 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
@@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
#define DM365_ISIF_MAX_CLVSV 0x1fff
#define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
-static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
+static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp
+ *bclamp)
{
int err = -EINVAL;
@@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
return isif_validate_bclamp_params(¶ms->bclamp);
}
-static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
+static int isif_set_params(struct v4l2_subdev *sd,
+ const struct vpfe_isif_raw_config *params)
{
struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
int ret = -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] staging: media: fix style problem
2019-06-20 5:02 Aliasgar Surti
@ 2019-06-20 5:09 ` Nathan Chancellor
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Chancellor @ 2019-06-20 5:09 UTC (permalink / raw)
To: Aliasgar Surti; +Cc: linux-media, gregkh, linux-kernel
On Thu, Jun 20, 2019 at 10:32:48AM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file davinci_vpfe/dm365_isif.c
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> index 46fd818..12bdf91 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> @@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
> #define DM365_ISIF_MAX_CLVSV 0x1fff
> #define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
>
> -static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> +static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp
> + *bclamp)
I think
static int
isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
is a better choice for this change.
Cheers,
Nathan
> {
> int err = -EINVAL;
>
> @@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
> return isif_validate_bclamp_params(¶ms->bclamp);
> }
>
> -static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
> +static int isif_set_params(struct v4l2_subdev *sd,
> + const struct vpfe_isif_raw_config *params)
> {
> struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
> int ret = -EINVAL;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-25 13:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 6:39 [PATCH 1/1] staging: media: fix style problem Aliasgar Surti
2019-06-25 7:17 ` Hans Verkuil
2019-06-25 13:22 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2019-06-20 5:31 Aliasgar Surti
2019-06-20 21:25 ` André Almeida
2019-06-20 5:02 Aliasgar Surti
2019-06-20 5:09 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).