* [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static
@ 2021-02-23 8:54 Jiapeng Chong
2021-02-23 9:18 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-23 8:54 UTC (permalink / raw)
To: christian.koenig
Cc: ray.huang, airlied, daniel, sumit.semwal, dri-devel,
linux-kernel, linux-media, linaro-mm-sig, Jiapeng Chong
Fix the following sparse warning:
drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol
'ttm_bo_glob_use_count' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index b65f4b1..107dd13 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -50,7 +50,7 @@
* ttm_global_mutex - protecting the global BO state
*/
DEFINE_MUTEX(ttm_global_mutex);
-unsigned ttm_bo_glob_use_count;
+static unsigned ttm_bo_glob_use_count;
struct ttm_bo_global ttm_bo_glob;
EXPORT_SYMBOL(ttm_bo_glob);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static
2021-02-23 8:54 [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static Jiapeng Chong
@ 2021-02-23 9:18 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2021-02-23 9:18 UTC (permalink / raw)
To: Jiapeng Chong
Cc: ray.huang, airlied, daniel, sumit.semwal, dri-devel,
linux-kernel, linux-media, linaro-mm-sig
Am 23.02.21 um 09:54 schrieb Jiapeng Chong:
> Fix the following sparse warning:
>
> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol
> 'ttm_bo_glob_use_count' was not declared. Should it be static?
IIRC we already have a patch for this on the mailing list and the mutex
can be static as well.
Christian.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b65f4b1..107dd13 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -50,7 +50,7 @@
> * ttm_global_mutex - protecting the global BO state
> */
> DEFINE_MUTEX(ttm_global_mutex);
> -unsigned ttm_bo_glob_use_count;
> +static unsigned ttm_bo_glob_use_count;
> struct ttm_bo_global ttm_bo_glob;
> EXPORT_SYMBOL(ttm_bo_glob);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-23 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 8:54 [PATCH] drm/ttm/ttm_bo: make ttm_bo_glob_use_count static Jiapeng Chong
2021-02-23 9:18 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).