[GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Hans Verkuil]

The following changes since commit ad71693f41aa60217eaf1c29afb49b3aa0a2db5d:

  media: mtk-vpu: load vpu firmware from the new location (2020-03-24 17:11:47 +0100)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.7n

for you to fetch changes up to 938b4f6cbbd7c7bd2236f4594ef37431c519f7a7:

  media: ti-vpe: cal: fix stop state timeout (2020-03-25 13:21:59 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Laurent Pinchart (14):
      media: imx: imx7-mipi-csis: Cleanup and fix subdev pad format handling
      media: imx: imx7-mipi-csis: Centralize initialization of pad formats
      media: imx: imx7-mipi-csis: Add missing RAW formats
      media: imx: imx7-mipi-csis: Expose correct YUV formats
      media: imx: imx7-mipi-csis: Fix MEDIA_BUS_FMT_UYVY8_2X8 data alignment
      media: imx: imx7-mipi-csis: Add MEDIA_BUS_FMT_UYVY10_2X10 support
      media: imx: imx7-mipi-csis: Rename data_alignment field to width
      media: imx: imx7-mipi-csis: Align image width based on format
      media: imx: imx7-mipi-csis: Never set MIPI_CSIS_ISPCFG_ALIGN_32BIT
      media: imx: imx7-mipi-csis: Align macro definitions
      media: imx: imx7-mipi-csis: Remove link setup on source pad
      media: imx: imx7-mipi-csis: Cleanup includes
      media: imx: imx7-mipi-csis: Don't use imx-media-utils helpers
      media: imx: imx7-mipi-csis: Implement the .enum_mbus_code() operation

Tomi Valkeinen (19):
      media: ti-vpe: cal: fix DMA memory corruption
      media: ti-vpe: cal: improve enable_irqs
      media: ti-vpe: cal: fix use of wrong macro
      media: ti-vpe: cal: use runtime_resume for errata handling
      media: ti-vpe: cal: drop cal_runtime_get/put
      media: ti-vpe: cal: catch error irqs and print errors
      media: ti-vpe: cal: print errors on timeouts
      media: ti-vpe: cal: simplify irq handling
      media: ti-vpe: cal: remove useless CAL_GEN_* macros
      media: ti-vpe: cal: remove useless IRQ defines
      media: ti-vpe: cal: use reg_write_field
      media: ti-vpe: cal: cleanup CIO power enable/disable
      media: ti-vpe: cal: fix dummy read to phy
      media: ti-vpe: cal: program number of lines properly
      media: ti-vpe: cal: set DMA max seg size
      media: ti-vpe: cal: move code to separate functions
      media: ti-vpe: cal: improve wait for CIO resetdone
      media: ti-vpe: cal: improve wait for stop-state
      media: ti-vpe: cal: fix stop state timeout

 drivers/media/platform/ti-vpe/cal.c        | 397 ++++++++++++++++++++++++++++++---------------------
 drivers/media/platform/ti-vpe/cal_regs.h   |  21 +--
 drivers/staging/media/imx/imx7-mipi-csis.c | 446 ++++++++++++++++++++++++++++++++++++----------------------
 3 files changed, 518 insertions(+), 346 deletions(-)

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes (#62535)

[Jenkins]

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/patch/62535/
Build log: https://builder.linuxtv.org/job/patchwork/43853/
Build time: 00:11:53
Link: https://lore.kernel.org/linux-media/64c740ae-3ebd-cec3-14f4-e65f2cb53af3@xs4all.nl

gpg: Signature made Wed 25 Mar 2020 01:50:37 PM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: 3 patches and/or PDF generation with issues, being 0 at build time

Error/warnings:


Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0020-media-ti-vpe-cal-catch-error-irqs-and-print-errors.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0020-media-ti-vpe-cal-catch-error-irqs-and-print-errors.patch
patches/0020-media-ti-vpe-cal-catch-error-irqs-and-print-errors.patch:79: WARNING: line over 80 characters
patches/0020-media-ti-vpe-cal-catch-error-irqs-and-print-errors.patch:82: WARNING: line over 80 characters

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0026-media-ti-vpe-cal-cleanup-CIO-power-enable-disable.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0026-media-ti-vpe-cal-cleanup-CIO-power-enable-disable.patch
patches/0026-media-ti-vpe-cal-cleanup-CIO-power-enable-disable.patch:40: WARNING: line over 80 characters
patches/0026-media-ti-vpe-cal-cleanup-CIO-power-enable-disable.patch:41: WARNING: line over 80 characters

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0029-media-ti-vpe-cal-set-DMA-max-seg-size.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0029-media-ti-vpe-cal-set-DMA-max-seg-size.patch
patches/0029-media-ti-vpe-cal-set-DMA-max-seg-size.patch:9: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Laurent Pinchart]

Hi Hans,

On Wed, Mar 25, 2020 at 02:51:55PM +0100, Hans Verkuil wrote:
> The following changes since commit ad71693f41aa60217eaf1c29afb49b3aa0a2db5d:
> 
>   media: mtk-vpu: load vpu firmware from the new location (2020-03-24 17:11:47 +0100)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.7n
> 
> for you to fetch changes up to 938b4f6cbbd7c7bd2236f4594ef37431c519f7a7:
> 
>   media: ti-vpe: cal: fix stop state timeout (2020-03-25 13:21:59 +0100)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Laurent Pinchart (14):
>       media: imx: imx7-mipi-csis: Cleanup and fix subdev pad format handling
>       media: imx: imx7-mipi-csis: Centralize initialization of pad formats
>       media: imx: imx7-mipi-csis: Add missing RAW formats
>       media: imx: imx7-mipi-csis: Expose correct YUV formats
>       media: imx: imx7-mipi-csis: Fix MEDIA_BUS_FMT_UYVY8_2X8 data alignment
>       media: imx: imx7-mipi-csis: Add MEDIA_BUS_FMT_UYVY10_2X10 support
>       media: imx: imx7-mipi-csis: Rename data_alignment field to width
>       media: imx: imx7-mipi-csis: Align image width based on format
>       media: imx: imx7-mipi-csis: Never set MIPI_CSIS_ISPCFG_ALIGN_32BIT
>       media: imx: imx7-mipi-csis: Align macro definitions
>       media: imx: imx7-mipi-csis: Remove link setup on source pad
>       media: imx: imx7-mipi-csis: Cleanup includes
>       media: imx: imx7-mipi-csis: Don't use imx-media-utils helpers
>       media: imx: imx7-mipi-csis: Implement the .enum_mbus_code() operation
> 
> Tomi Valkeinen (19):
>       media: ti-vpe: cal: fix DMA memory corruption
>       media: ti-vpe: cal: improve enable_irqs
>       media: ti-vpe: cal: fix use of wrong macro
>       media: ti-vpe: cal: use runtime_resume for errata handling
>       media: ti-vpe: cal: drop cal_runtime_get/put
>       media: ti-vpe: cal: catch error irqs and print errors
>       media: ti-vpe: cal: print errors on timeouts
>       media: ti-vpe: cal: simplify irq handling
>       media: ti-vpe: cal: remove useless CAL_GEN_* macros
>       media: ti-vpe: cal: remove useless IRQ defines
>       media: ti-vpe: cal: use reg_write_field
>       media: ti-vpe: cal: cleanup CIO power enable/disable
>       media: ti-vpe: cal: fix dummy read to phy
>       media: ti-vpe: cal: program number of lines properly
>       media: ti-vpe: cal: set DMA max seg size
>       media: ti-vpe: cal: move code to separate functions
>       media: ti-vpe: cal: improve wait for CIO resetdone
>       media: ti-vpe: cal: improve wait for stop-state
>       media: ti-vpe: cal: fix stop state timeout

Tomi has posted v3, is that what the pull request contains ?

>  drivers/media/platform/ti-vpe/cal.c        | 397 ++++++++++++++++++++++++++++++---------------------
>  drivers/media/platform/ti-vpe/cal_regs.h   |  21 +--
>  drivers/staging/media/imx/imx7-mipi-csis.c | 446 ++++++++++++++++++++++++++++++++++++----------------------
>  3 files changed, 518 insertions(+), 346 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Tomi Valkeinen]

On 25/03/2020 16:27, Laurent Pinchart wrote:

>> Tomi Valkeinen (19):
>>        media: ti-vpe: cal: fix DMA memory corruption
>>        media: ti-vpe: cal: improve enable_irqs
>>        media: ti-vpe: cal: fix use of wrong macro
>>        media: ti-vpe: cal: use runtime_resume for errata handling
>>        media: ti-vpe: cal: drop cal_runtime_get/put
>>        media: ti-vpe: cal: catch error irqs and print errors
>>        media: ti-vpe: cal: print errors on timeouts
>>        media: ti-vpe: cal: simplify irq handling
>>        media: ti-vpe: cal: remove useless CAL_GEN_* macros
>>        media: ti-vpe: cal: remove useless IRQ defines
>>        media: ti-vpe: cal: use reg_write_field
>>        media: ti-vpe: cal: cleanup CIO power enable/disable
>>        media: ti-vpe: cal: fix dummy read to phy
>>        media: ti-vpe: cal: program number of lines properly
>>        media: ti-vpe: cal: set DMA max seg size
>>        media: ti-vpe: cal: move code to separate functions
>>        media: ti-vpe: cal: improve wait for CIO resetdone
>>        media: ti-vpe: cal: improve wait for stop-state
>>        media: ti-vpe: cal: fix stop state timeout
> 
> Tomi has posted v3, is that what the pull request contains ?

Yes, looks like v3.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Hans Verkuil]

On 3/25/20 3:40 PM, Tomi Valkeinen wrote:
> On 25/03/2020 16:27, Laurent Pinchart wrote:
> 
>>> Tomi Valkeinen (19):
>>>        media: ti-vpe: cal: fix DMA memory corruption
>>>        media: ti-vpe: cal: improve enable_irqs
>>>        media: ti-vpe: cal: fix use of wrong macro
>>>        media: ti-vpe: cal: use runtime_resume for errata handling
>>>        media: ti-vpe: cal: drop cal_runtime_get/put
>>>        media: ti-vpe: cal: catch error irqs and print errors
>>>        media: ti-vpe: cal: print errors on timeouts
>>>        media: ti-vpe: cal: simplify irq handling
>>>        media: ti-vpe: cal: remove useless CAL_GEN_* macros
>>>        media: ti-vpe: cal: remove useless IRQ defines
>>>        media: ti-vpe: cal: use reg_write_field
>>>        media: ti-vpe: cal: cleanup CIO power enable/disable
>>>        media: ti-vpe: cal: fix dummy read to phy
>>>        media: ti-vpe: cal: program number of lines properly
>>>        media: ti-vpe: cal: set DMA max seg size
>>>        media: ti-vpe: cal: move code to separate functions
>>>        media: ti-vpe: cal: improve wait for CIO resetdone
>>>        media: ti-vpe: cal: improve wait for stop-state
>>>        media: ti-vpe: cal: fix stop state timeout
>>
>> Tomi has posted v3, is that what the pull request contains ?
> 
> Yes, looks like v3.

I was 15 minutes away from posting the PR with v2 when I saw v3 arrive :-)

So yes, this is with v3.

Regards,

	Hans

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Mauro Carvalho Chehab]

Em Wed, 25 Mar 2020 14:51:55 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> The following changes since commit ad71693f41aa60217eaf1c29afb49b3aa0a2db5d:
> 
>   media: mtk-vpu: load vpu firmware from the new location (2020-03-24 17:11:47 +0100)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.7n
> 
> for you to fetch changes up to 938b4f6cbbd7c7bd2236f4594ef37431c519f7a7:
> 
>   media: ti-vpe: cal: fix stop state timeout (2020-03-25 13:21:59 +0100)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Laurent Pinchart (14):
...

> Tomi Valkeinen (19):
...

>  drivers/media/platform/ti-vpe/cal.c        | 397 ++++++++++++++++++++++++++++++---------------------
>  drivers/media/platform/ti-vpe/cal_regs.h   |  21 +--
>  drivers/staging/media/imx/imx7-mipi-csis.c | 446 ++++++++++++++++++++++++++++++++++++----------------------
>  3 files changed, 518 insertions(+), 346 deletions(-)

That sounds too much for a late pull request. Any of the patches here
are fixing a regression? Otherwise, I'll likely postpone merging it
only after the merge window.

Thanks,
Mauro

Re: [GIT PULL FOR v5.7] ti-vpe/cal and imx7-mipi-csis cleanups/fixes

[Hans Verkuil]

On 3/25/20 5:06 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 25 Mar 2020 14:51:55 +0100
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
>> The following changes since commit ad71693f41aa60217eaf1c29afb49b3aa0a2db5d:
>>
>>   media: mtk-vpu: load vpu firmware from the new location (2020-03-24 17:11:47 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.7n
>>
>> for you to fetch changes up to 938b4f6cbbd7c7bd2236f4594ef37431c519f7a7:
>>
>>   media: ti-vpe: cal: fix stop state timeout (2020-03-25 13:21:59 +0100)
>>
>> ----------------------------------------------------------------
>> Tag branch
>>
>> ----------------------------------------------------------------
>> Laurent Pinchart (14):
> ...
> 
>> Tomi Valkeinen (19):
> ...
> 
>>  drivers/media/platform/ti-vpe/cal.c        | 397 ++++++++++++++++++++++++++++++---------------------
>>  drivers/media/platform/ti-vpe/cal_regs.h   |  21 +--
>>  drivers/staging/media/imx/imx7-mipi-csis.c | 446 ++++++++++++++++++++++++++++++++++++----------------------
>>  3 files changed, 518 insertions(+), 346 deletions(-)
> 
> That sounds too much for a late pull request. Any of the patches here
> are fixing a regression? Otherwise, I'll likely postpone merging it
> only after the merge window.

I expected that anyway :-)

I forgot to update the subject line to say 5.8, my fault.

Regards,

	Hans