* [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function
@ 2019-03-18 15:55 Sakari Ailus
2019-03-19 2:58 ` Bingbu Cao
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2019-03-18 15:55 UTC (permalink / raw)
To: linux-media; +Cc: rajmohan.mani, tfiga
Set the entity function for the four CSI-2 receiver sub-devices the driver
creates. This avoids a kernel warning from each as well.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
index 617fb2e944dc3..b76dff851f3d2 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
@@ -1601,6 +1601,7 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q)
subdev->owner = THIS_MODULE;
snprintf(subdev->name, sizeof(subdev->name),
CIO2_ENTITY_NAME " %td", q - cio2->queue);
+ subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
v4l2_set_subdevdata(subdev, cio2);
r = v4l2_device_register_subdev(&cio2->v4l2_dev, subdev);
if (r) {
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function
2019-03-18 15:55 [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function Sakari Ailus
@ 2019-03-19 2:58 ` Bingbu Cao
0 siblings, 0 replies; 2+ messages in thread
From: Bingbu Cao @ 2019-03-19 2:58 UTC (permalink / raw)
To: Sakari Ailus, linux-media; +Cc: rajmohan.mani, tfiga
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
On 3/18/19 11:55 PM, Sakari Ailus wrote:
> Set the entity function for the four CSI-2 receiver sub-devices the driver
> creates. This avoids a kernel warning from each as well.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 617fb2e944dc3..b76dff851f3d2 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1601,6 +1601,7 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q)
> subdev->owner = THIS_MODULE;
> snprintf(subdev->name, sizeof(subdev->name),
> CIO2_ENTITY_NAME " %td", q - cio2->queue);
> + subdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
> v4l2_set_subdevdata(subdev, cio2);
> r = v4l2_device_register_subdev(&cio2->v4l2_dev, subdev);
> if (r) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-19 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 15:55 [PATCH 1/1] ipu3-cio2: Set CSI-2 receiver sub-device entity function Sakari Ailus
2019-03-19 2:58 ` Bingbu Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).